Re: [Wireshark-dev] E212 Mobile network code is not caculated correctly?

2009-01-09 Thread Guy Harris
On Jan 8, 2009, at 10:32 PM, Pascal Quantin wrote: you are right and this was fixed in trunk by revision 24759 ( http://anonsvn.wireshark.org/viewvc?view=revrevision=24759 ). It also appears to be fixed in Wireshark 1.0.5 (and possibly some earlier 10.0.x releases); 1.0.0 isn't the current

[Wireshark-dev] E212 Mobile network code is not caculated correctly?

2009-01-08 Thread Zhang, Long (Roger)
Hi, I am developing based on Wireshark 1.0.0. I found the mnc in E212 may not be caculated correctly. The mnc for 3 digits is calculated as mnc += 10 * mnc + mnc3;. I think it should be mnc = 10 * mnc + mnc3;. From E212 spec, I did not find algorithm to calculate mnc, but I think += is not

Re: [Wireshark-dev] E212 Mobile network code is not caculated correctly?

2009-01-08 Thread Pascal Quantin
Hi, you are right and this was fixed in trunk by revision 24759 ( http://anonsvn.wireshark.org/viewvc?view=revrevision=24759 ). Regards, Pascal. 2009/1/9 Zhang, Long (Roger) zha...@alcatel-lucent.com: Hi, I am developing based on Wireshark 1.0.0. I found the mnc in E212 may not be