[Wireshark-dev] Possible bug in dissect_pipe_dcerpc() (packet-smb-pipe.c)

2012-07-27 Thread Pascal Quantin
Hi all, while working on fixing a few Clang warnings in packet-smb-pipe.c, I discovered that the hash_key variable in dissect_pipe_dcerpc() function is never used. According to the nice comment Guy put in revision above the variable assignment, I have the feeling that it is actually useful

Re: [Wireshark-dev] Possible bug in dissect_pipe_dcerpc() (packet-smb-pipe.c)

2012-07-27 Thread Evan Huus
On Fri, Jul 27, 2012 at 6:14 PM, Pascal Quantin pascal.quan...@gmail.com wrote: Hi all, while working on fixing a few Clang warnings in packet-smb-pipe.c, I discovered that the hash_key variable in dissect_pipe_dcerpc() function is never used. According to the nice comment Guy put in

Re: [Wireshark-dev] Possible bug in dissect_pipe_dcerpc() (packet-smb-pipe.c)

2012-07-27 Thread Pascal Quantin
2012/7/28 Evan Huus eapa...@gmail.com On Fri, Jul 27, 2012 at 6:14 PM, Pascal Quantin pascal.quan...@gmail.com wrote: Hi all, while working on fixing a few Clang warnings in packet-smb-pipe.c, I discovered that the hash_key variable in dissect_pipe_dcerpc() function is never used.