Re: [Wireshark-dev] proto_filter_names hash collision

2007-11-21 Thread Jaap Keuter
Hi, Sounds good to me. Thanx, Jaap Kukosa, Tomas wrote: Does it make sense to do all those sanity checks only if a special command-line flag is supplied to TShark, so that the checks are done as part of the build process, rather than being done every time you run Wireshark or TShark?

[Wireshark-dev] proto_filter_names hash collision

2007-11-20 Thread Kukosa, Tomas
It seems that we have reached critical number of protocols. I have met collision of built in p7 protoco with my private nu protocol. They both have the same g_str_hash() value. Does it make sence to create hash from the protocol filter name which has usually 2-4 characters? BTW the

Re: [Wireshark-dev] proto_filter_names hash collision

2007-11-20 Thread Guy Harris
Kukosa, Tomas wrote: It seems that we have reached critical number of protocols. I have met collision of built in p7 protoco with my private nu protocol. They both have the same g_str_hash() value. Does it make sence to create hash from the protocol filter name which has usually 2-4

Re: [Wireshark-dev] proto_filter_names hash collision

2007-11-20 Thread ronnie sahlberg
Instead of creating a hash and store it in a hashtable wouldnt it be better/faster to just store the names as the strings as is in a se-tree instead. That should be much faster. On Nov 21, 2007 8:13 AM, Guy Harris [EMAIL PROTECTED] wrote: Kukosa, Tomas wrote: It seems that we have reached

Re: [Wireshark-dev] proto_filter_names hash collision

2007-11-20 Thread ronnie sahlberg
or rather a pe-tree On Nov 21, 2007 9:45 AM, ronnie sahlberg [EMAIL PROTECTED] wrote: Instead of creating a hash and store it in a hashtable wouldnt it be better/faster to just store the names as the strings as is in a se-tree instead. That should be much faster. On Nov 21, 2007 8:13 AM,

Re: [Wireshark-dev] proto_filter_names hash collision

2007-11-20 Thread Jaap Keuter
Guy Harris wrote: Kukosa, Tomas wrote: It seems that we have reached critical number of protocols. I have met collision of built in p7 protoco with my private nu protocol. They both have the same g_str_hash() value. Does it make sence to create hash from the protocol filter name which