Re: [Wireshark-dev] Buildbot compile flags

2007-03-25 Thread Gerald Combs
Joerg Mayer wrote: On Thu, Mar 22, 2007 at 08:01:50PM -0700, Stephen Fisher wrote: On Thu, Mar 22, 2007 at 07:47:35PM -0700, Guy Harris wrote: The alternative is to compile with -std=c99 for the long long case, but do we really want to do that? I agree that -pedantic is a bit too much to

[Wireshark-dev] How to handle unreferenced local variables warning on DCE/RPC IDL generated c files?

2007-03-25 Thread Ulf Lamping
Hi List! I'm currently looking at the warnings that are triggered by the files generated by idl2eth files. An example would be (plugins/giop): packet-coseventcomm.c packet-coseventcomm.c(139) : warning C4101: 'be' : unreferenced local variable packet-coseventcomm.c(140) : warning C4101:

Re: [Wireshark-dev] [Wireshark-commits] rev 21185: /trunk/wiretap/ /trunk/wiretap/: mpeg.c

2007-03-25 Thread Luis Ontanon
This should put an end to the buildbot lamenting about files that are not being considered as mpeg files. However I'm certain I was way too conservative when choosing what's a MPEG file (I had just MP3s), please add more types if you are aware of them. On 3/25/07, [EMAIL PROTECTED] [EMAIL

[Wireshark-dev] OSB decode in wireshark

2007-03-25 Thread ronnie sahlberg
List, I have done some largish changes to the usb dissector to make it work again after the switch to DLT189. The dissector now decodes for example usm_memory_stick.pcap and other such traces properly. Please test and comment. I have also checked in USB support for conversations and hostlist

Re: [Wireshark-dev] [Wireshark-commits] rev 21191: /trunk/ /trunk/epan/dissectors/: Makefile.common packet-megaco.c /trunk/asn1/h248/: Makefile /trunk/plugins/megaco/: packet-megaco.c /trunk/plugins/:

2007-03-25 Thread Luis Ontanon
Some changes slipped through without me noticing: Good thing: changes to asn1/ranap, that were commited already with packet-ranap.[ch] Neutral thing: changes to makefiles of asn1/snmp and asn1/h248 to add a target to test compilation. No bad things Luis On 3/25/07, [EMAIL PROTECTED]

[Wireshark-dev] USBMON traces and packet-usb.c changes

2007-03-25 Thread ronnie sahlberg
First I think that it is not really feasible to change the DLT type again. Looking at traces from the current DLT189 and the updated (and now functional) usb dissector there are a few observations. The pseudoheader given to the dissector lacks several useful fields which would make life

[Wireshark-dev] [PATCH] USB: show unknown descriptors

2007-03-25 Thread Charles Lepple
This patch enables packet-usb.c to display all descriptors in the GET CONFIGURATION request, regardless of whether we know how to decode them. (All descriptors in that request share the same first two bytes.) It also adds the HID descriptor type (not the report descriptor, though - that is

Re: [Wireshark-dev] [Wireshark-commits] rev 21195: /trunk/ /trunk/: configure.in

2007-03-25 Thread Stephen Fisher
We probably want to add this to wiretap/configure.in also.. On Mon, Mar 26, 2007 at 12:32:15AM +, [EMAIL PROTECTED] wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=21195 User: morriss Date: 2007/03/26 12:32 AM Log: If we're using gcc, try to use

Re: [Wireshark-dev] [PATCH] USB: show unknown descriptors

2007-03-25 Thread ronnie sahlberg
Thanks Charles. Checked in. I have a big patch to the dissector I am going to try to merge piece by piece over the next few days. This will result in many smallish patches. Since you are also working on patches to packet-usb.c can I ask you to send small patches and frequently so that none

Re: [Wireshark-dev] [PATCH] USB: show unknown descriptors

2007-03-25 Thread Charles Lepple
On 3/25/07, ronnie sahlberg [EMAIL PROTECTED] wrote: I have a big patch to the dissector I am going to try to merge piece by piece over the next few days. This will result in many smallish patches. Since you are also working on patches to packet-usb.c can I ask you to send small patches

Re: [Wireshark-dev] [Wireshark-commits] rev 21195: /trunk/ /trunk/: configure.in

2007-03-25 Thread Jeff Morriss
Oops, forgot to do that, thanks for the reminder. (It's done now.) Stephen Fisher wrote: We probably want to add this to wiretap/configure.in also.. On Mon, Mar 26, 2007 at 12:32:15AM +, [EMAIL PROTECTED] wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=21195

Re: [Wireshark-dev] USBMON traces and packet-usb.c changes

2007-03-25 Thread Charles Lepple
On 3/25/07, Charles Lepple [EMAIL PROTECTED] wrote: On 3/25/07, ronnie sahlberg [EMAIL PROTECTED] wrote: Modulo changing the DLT value AGAIN the only three possibilities I see are: As far as I can tell, the code that creates pcap files with DLT 186 and 189 is still in CVS. For the swapped

Re: [Wireshark-dev] [PATCH] USB: show unknown descriptors

2007-03-25 Thread ronnie sahlberg
On 3/26/07, Charles Lepple [EMAIL PROTECTED] wrote: On 3/25/07, ronnie sahlberg The usb dissector is currently divided into two files packet-usb.c and packet-usb-masstorage.c My idea was to have packet-usb.c only contain the core part of the protocol (and maybe also the HUB stuff) while

[Wireshark-dev] RFC 2508 Dissector

2007-03-25 Thread Donald White
Between August and October of 2006, I submitted three patches for packet-ppp.c. These corrected problems I had encountered in researching a problem for my employer. This problem involved RFC 2508 protocol between two routers. In resolving this problem, I developed a partial RFC 2508

Re: [Wireshark-dev] [Wireshark-commits] rev 21195: /trunk/ /trunk/: configure.in

2007-03-25 Thread ronnie sahlberg
[EMAIL PROTECTED] trunk]$ echo yes | gcc -E -Wfoodeclaration-after-statement - # 1 yes [EMAIL PROTECTED] trunk]$ gcc -v Reading specs from /usr/lib/gcc-lib/i386-redhat-linux/2.96/specs gcc version 2.96 2731 (Red Hat Linux 7.1 2.96-81) [EMAIL PROTECTED] trunk]$ It appears it only looks at the

Re: [Wireshark-dev] [Wireshark-commits] rev 21195: /trunk/ /trunk/: configure.in

2007-03-25 Thread ronnie sahlberg
Dont worry. Ill rewrite it so that it tries to compile a real file. On 3/26/07, ronnie sahlberg [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] trunk]$ echo yes | gcc -E -Wfoodeclaration-after-statement - # 1 yes [EMAIL PROTECTED] trunk]$ gcc -v Reading specs from

Re: [Wireshark-dev] [Wireshark-commits] rev 21195: /trunk/ /trunk/: configure.in

2007-03-25 Thread Stephen Fisher
This add-on macro claims to do what you need: ax_cflags_gcc_option Check whether GCC supports the given option. http://autoconf-archive.cryp.to/ax_cflags_gcc_option.html On Mon, Mar 26, 2007 at 06:32:32AM +, ronnie sahlberg wrote: Dont worry. Ill rewrite it so that it tries to

Re: [Wireshark-dev] [Wireshark-commits] rev 21195: /trunk/ /trunk/: configure.in

2007-03-25 Thread ronnie sahlberg
I just checked in a different test for configure.in in trunk that works for me. Please review. On 3/26/07, Jeff Morriss [EMAIL PROTECTED] wrote: Hmmm, that's weird, it works for me. What version of GCC are you using? What does: echo yes | gcc -E -Wfoodeclaration-after-statement -