Re: [Wireshark-dev] Wireshark 1.8.1 crashes

2013-01-20 Thread Pascal Quantin
Le 20/01/2013 07:51, Danniel_zeng a écrit : Thank Evan Huus. I'v check those packet-ppp.cs and compare with the one in wireshark1.8.1,I find that the difference is the FIXED_LENGTH have been replayed by OPT_LEN_FIXED_LENGTH. I want to know where is FIXED_LENGTH or OPT_LEN_FIXED_LENGTH

Re: [Wireshark-dev] libgcrypt 1.5.0 compiler warnings

2013-02-21 Thread Pascal Quantin
2013/2/21 Martin Kaiser li...@kaiser.cx Dear all, this issue has been around for a long time. When we use libgcrypt 1.5.0, including gcrypt.h spills out lots of warnings about deprecated definitions, breaking compilation with -Werror. Steven Fisher asked about this on the libgcrypt list

Re: [Wireshark-dev] Simpifying exporting DLL symbols

2013-02-26 Thread Pascal Quantin
2013/2/26 Bálint Réczey bal...@balintreczey.hu Hi, I have created the attached patch to control symbol visibility using C defines instead of .def and .sym files. It is expected to work on every platform and every build system we support, but I did not want to commit it without discussing

Re: [Wireshark-dev] malformed packet

2013-02-28 Thread Pascal Quantin
2013/2/28 Hadriel Kaplan hkap...@acmepacket.com Wireshark's SIP dissector is throwing an error on the RAck header field method name. It shouldn't, because the message's header is correctly formed, but there's a bug in packet-sip.c: for case POS_RACK, when it goes to add the method name,

Re: [Wireshark-dev] Editcap link warnings

2013-03-05 Thread Pascal Quantin
2013/3/6 Christopher Maynard christopher.mayn...@gtech.com Bill Meier wmeier@... writes: Recent Windows 7 and Windows XP Buildbot builds have been giving locally defined symbol ... imported in ... warnings while linking editcap: (I get the same warnings on my system). Me too. Not

Re: [Wireshark-dev] Editcap link warnings

2013-03-07 Thread Pascal Quantin
2013/3/7 Gerald Combs ger...@wireshark.org This didn't work because prior includes (wsgetopt.h in editcap.c and privileges.h in capinfos.c) lock in the export behavior. I checked in your changes in r48170 along with a workaround to reset the export definitions. It's clunkier than I would like

Re: [Wireshark-dev] Warning on useless extended value strings?

2013-03-19 Thread Pascal Quantin
2013/3/19 Evan Huus eapa...@gmail.com Would anyone object to a g_warning if an extended value string has to fall back to linear search? It probably indicates either a typo in the value-string or somebody not understanding how extended value strings work. Didn't want to put this in without

Re: [Wireshark-dev] Possible misuse of match_strval_idx

2013-03-24 Thread Pascal Quantin
Le 24/03/2013 00:57, Evan Huus a écrit : On Sat, Mar 23, 2013 at 6:39 PM, Jaap Keuter jaap.keu...@xs4all.nl wrote: On 03/23/2013 10:07 PM, Evan Huus wrote: Am I correct in thinking that in packet-gsm_a_dtap.c around line 6432, if match_strval_idx doesn't find a match then we will access

Re: [Wireshark-dev] Access to source

2013-04-11 Thread Pascal Quantin
2013/4/11 Edwin Abraham edwin.abraha...@gmail.com I wanted to know where you guys maintain your source actively SVN or GIT? Hi Edwin, as stated in http://www.wireshark.org/develop.html, the main repository is using subversion and you can also find a git mirror if you prefer. Best regards,

Re: [Wireshark-dev] FW: [Wireshark-commits] buildbot failure in Wireshark 1.8 on Windows-7-x64

2013-04-24 Thread Pascal Quantin
Done in r49012. Regards, Pascal. 2013/4/24 Anders Broman anders.bro...@ericsson.com Hi, This patch was meant for 1.10, I made a mistake trying to check out 1.10 and got 1.8 instead I think. Could someone revert the change? I'm not able to until later this evening. Regards anders

Re: [Wireshark-dev] Wireshark - Dissector Bug for HSRP Version 2

2013-05-02 Thread Pascal Quantin
This is bug 8622 that was just fixed. Regards, Pascal. Le 2 mai 2013 à 17:01, Evan Huus eapa...@gmail.com a écrit : Looks like a wireshark bug off the top of my head. Please file a bug and specify which Wireshark version you're running. If possible, attach the capture file as that makes

Re: [Wireshark-dev] BIP / CAT-TP protocol support

2013-05-04 Thread Pascal Quantin
2013/5/3 Kunc Ondrej DC ondrej.k...@gemalto.com Hello Wireshark community! ** ** I need to decode BIP / CAT-TP protocol – and am desperately looking for any kind of either standalone SW or Wireshark plugin to read it – could you please advise if there such plugin or any way to decode

Re: [Wireshark-dev] WinPcap 4.1.3

2013-05-05 Thread Pascal Quantin
2013/5/4 Maxime Thépault-Denis max...@unite.re Hi, It seems Wireshark 1.8.6 is not compatible with Windows 8 x64 because WinPcap 4.1.2 provided don't know Windows 8. Also, I tried with the recent WinPcap 4.1.3 manually, and it works. Please, do you plan to include the new WinPcap 4.1.3

Re: [Wireshark-dev] Export PDU:s

2013-05-10 Thread Pascal Quantin
2013/5/5 Anders Broman a.bro...@bredband.net Hi, I have added a basic implementation making it possible to export higher level PDU:s to file using a USER_DLT. The basic implementation makes it possible to export SIP traffic to a new file adding some meta data before the actual SIP message.

Re: [Wireshark-dev] Export PDU:s

2013-05-12 Thread Pascal Quantin
2013/5/12 Anders Broman a.bro...@bredband.net Pascal Quantin skrev 2013-05-10 15:20: 2013/5/5 Anders Broman a.bro...@bredband.net Hi, I have added a basic implementation making it possible to export higher level PDU:s to file using a USER_DLT. The basic implementation makes it possible

Re: [Wireshark-dev] Export PDU:s

2013-05-12 Thread Pascal Quantin
2013/5/12 Anders Broman a.bro...@bredband.net Pascal Quantin skrev 2013-05-12 11:08: 2013/5/12 Anders Broman a.bro...@bredband.net Pascal Quantin skrev 2013-05-10 15:20: 2013/5/5 Anders Broman a.bro...@bredband.net Hi, I have added a basic implementation making it possible

Re: [Wireshark-dev] Tapping Behaviour [Was: Export PDU:s]

2013-05-12 Thread Pascal Quantin
2013/5/12 Evan Huus eapa...@gmail.com On Sun, May 12, 2013 at 8:58 AM, Anders Broman a.bro...@bredband.net wrote: Pascal Quantin skrev 2013-05-12 11:08: 2013/5/12 Anders Broman a.bro...@bredband.net Pascal Quantin skrev 2013-05-10 15:20: 2013/5/5 Anders Broman a.bro

Re: [Wireshark-dev] Tapping Behaviour [Was: Export PDU:s]

2013-05-12 Thread Pascal Quantin
2013/5/12 Anders Broman a.bro...@bredband.net Evan Huus skrev 2013-05-12 15:11: On Sun, May 12, 2013 at 8:58 AM, Anders Broman a.bro...@bredband.net wrote: Pascal Quantin skrev 2013-05-12 11:08: 2013/5/12 Anders Broman a.bro...@bredband.net Pascal Quantin skrev 2013-05-10 15:20: 2013

Re: [Wireshark-dev] Tapping Behaviour [Was: Export PDU:s]

2013-05-12 Thread Pascal Quantin
for malformed packets). On Sun, May 12, 2013 at 12:39 PM, Pascal Quantin pascal.quan...@gmail.com wrote: Hi Evan, I'm not sure I understood your proposal properly. The issue with bug 8321 was that the tap was never called (due to the exception) and the issue with bug 8610 was that context

Re: [Wireshark-dev] ASN1 now builds with cmake - open points

2013-05-12 Thread Pascal Quantin
2013/5/12 Joerg Mayer jma...@loplof.de I've finished adding the necessary code to generate the dissectors in the asn1 subdirectory. To build and copy a single dissector, just go into the subdirectory and type make. To regenerate and copy all dissectors, go into the asn1 directory and type

Re: [Wireshark-dev] [Wireshark-commits] rev 49410: /trunk/asn1/ /trunk/asn1/: CMakeLists.txt Makefile.am

2013-05-20 Thread Pascal Quantin
2013/5/20 Joerg Mayer jma...@loplof.de On Sat, May 18, 2013 at 05:48:51PM +, pas...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=49410 User: pascal Date: 2013/05/18 10:48 AM Log: Revert r49406: it's not ready for prime time yet

Re: [Wireshark-dev] GTPV2 packets in GPRS Tunneling protocol

2013-06-02 Thread Pascal Quantin
Le 02/06/2013 18:01, Manish Kumar a écrit : Hi All, I am a beginner to wireshark development. I want to add a small filter related to small information contained in GTPV2 packets. Can any one guide me how to go about this. Which one is the main file in the whole code through I can browse

Re: [Wireshark-dev] GTPV2 packets in GPRS Tunneling protocol

2013-06-02 Thread Pascal Quantin
definition. If you want to see how the gtpv2.imsi filter is added, search for hf_gtpv2_imsi definition (line 5423 in trunk) and usage (line 868). Pascal. Regards, Manish Kumar On Sun, Jun 2, 2013 at 10:56 PM, Pascal Quantin pascal.quan...@gmail.comwrote: Le 02/06/2013 18:01, Manish Kumar a écrit

Re: [Wireshark-dev] [Wireshark-commits] rev 50031: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-nbap.c packet-nbap.h

2013-06-19 Thread Pascal Quantin
2013/6/19 Joerg Mayer jma...@loplof.de On Wed, Jun 19, 2013 at 06:23:53AM +, pas...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=50031 User: pascal Date: 2013/06/18 11:23 PM Log: Regenerate dissector Directory:

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Windows-XP-x86

2013-06-22 Thread Pascal Quantin
) as the buildbot saw. On Fri, Jun 21, 2013 at 1:33 AM, Graham Bloice graham.blo...@trihedral.com wrote: OK for me also on XP x32, although I'm not sure how to feed in the seed from the failing test run. Graham On 20 June 2013 16:56, Pascal Quantin pascal.quan...@gmail.com wrote: Failed

Re: [Wireshark-dev] Building OpenFlow 1.0 dissector for Wireshark 1.10.0 on Ubuntu 13.04

2013-07-10 Thread Pascal Quantin
2013/7/10 Guy Harris g...@alum.mit.edu On Jul 10, 2013, at 2:18 PM, Phiho Hoang hohoang...@gmail.com wrote: Greetings, Wireshark 1.10.0 was built from source on Ubuntu 13.04, (with gcc 4.7.3) OpenFlow 1.0 dissector was also built from source using scons with this modification in

Re: [Wireshark-dev] long options again

2013-07-16 Thread Pascal Quantin
2013/7/15 Martin Kaiser li...@kaiser.cx Hi, this was discussed months ago, I also raised this briefly at Sharkfest - but I changed my mind since then. Guy Harris skrev 2013-04-09 00:32: On Apr 8, 2013, at 3:02 PM, Anders Broman a.bro...@bredband.net wrote: I think we have

Re: [Wireshark-dev] dissect_sip_tcp_heur()

2013-08-12 Thread Pascal Quantin
2013/8/10 Martin Kaiser li...@kaiser.cx I came across this while browsing through the coverity defects. gboolean first = TRUE; is never changed Does the following change make sense to those who are familiar with SIP? diff --git a/epan/dissectors/packet-sip.c b/epan/dissectors/packet-sip.c

Re: [Wireshark-dev] About hidden fields and generated fields ...

2013-08-13 Thread Pascal Quantin
2013/8/13 DbdM Tbt spin@gmail.com Good day to all. Please bear with me as I am still learning the ins and outs of formatting dissector output. I have come across a discussion about hidden fields and generated fields. http://www.wireshark.org/lists/wireshark-dev/201110/msg00257.html I

Re: [Wireshark-dev] [Wireshark-commits] rev 51395: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-rohc.c

2013-08-19 Thread Pascal Quantin
2013/8/17 Jakub Zawadzki darkjames...@darkjames.pl By the way from ROHC code: 2296 data = (guint8 *)ep_alloc(len); 2299 next_tvb = tvb_new_child_real_data(tvb, data, len, len); 2300 add_new_data_source(pinfo, next_tvb, Payload); It's very bad idea to use

Re: [Wireshark-dev] [Wireshark-commits] rev 51395: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-rohc.c

2013-08-19 Thread Pascal Quantin
Le 19 août 2013 à 13:24, Evan Huus eapa...@gmail.com a écrit : On 2013-08-19, at 6:42 AM, Pascal Quantin pascal.quan...@gmail.com wrote: 2013/8/17 Jakub Zawadzki darkjames...@darkjames.pl By the way from ROHC code: 2296 data = (guint8 *)ep_alloc(len); 2299

Re: [Wireshark-dev] [Wireshark-commits] rev 51395: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-rohc.c

2013-08-19 Thread Pascal Quantin
2013/8/19 Pascal Quantin pascal.quan...@gmail.com Le 19 août 2013 à 13:24, Evan Huus eapa...@gmail.com a écrit : On 2013-08-19, at 6:42 AM, Pascal Quantin pascal.quan...@gmail.com wrote: 2013/8/17 Jakub Zawadzki darkjames...@darkjames.pl By the way from ROHC code: 2296 data

Re: [Wireshark-dev] Polling for possible reasons why the 'filter name' does not work

2013-08-28 Thread Pascal Quantin
Hi, Gilbert is most probably right. When browsing really quickly the plugin code you indicated in your initial post, I cannot find a proto_tree_add_item(tree, proto_openflow, tvb, 0, -1, ENC_NA) call. Did you try to modify dissect_openflow() with something like this ? static gint ett_of = -1;

Re: [Wireshark-dev] reported_length -1

2013-09-07 Thread Pascal Quantin
2013/9/7 Martin Kaiser li...@kaiser.cx Dear all, I stumbled on tvb_new_subset(tvb, 10, (tvb_get_guint8(tvb, 1) - 2), (tvb_get_guint8(tvb, 1) - 2)); If tvb_get_guint8(tvb, 1)==0, we throw an exception because of backing_length - that makes sense. As for reported_length-1, it looks like

Re: [Wireshark-dev] wmem_strbuf_printf()

2013-09-15 Thread Pascal Quantin
Hi Martin, on my side while converting some dissectors to wmem, I replaced the ep_strbuf_printf by: - either a call to wmem_strbuf_append_printf directly if it was the first time the buffer was filled - or a combination of wmem_strbuf_truncate / wmem_strbuf_append_printf Regards, Pascal.

Re: [Wireshark-dev] Removal of Visual Studio solution and project files

2013-09-17 Thread Pascal Quantin
Hi Graham, definitely a +1 for me. Regards, Pascal. 2013/9/17 Graham Bloice graham.blo...@trihedral.com As the Visual Studio solutions are not really maintained I'd like to delete them to prevent users from being confused when they try them and they don't work. If the project to get

Re: [Wireshark-dev] Removal of Visual Studio solution and project files

2013-09-17 Thread Pascal Quantin
with that. -Original Message- From: Pascal Quantin pascal.quan...@gmail.com To: Developer support list for Wireshark wireshark-dev@wireshark.org Sent: Tue, Sep 17, 2013 9:12 am Subject: Re: [Wireshark-dev] Removal of Visual Studio solution and project files Hi Graham

Re: [Wireshark-dev] Gently migrating to Git + Gerrit

2013-09-20 Thread Pascal Quantin
2013/9/20 Gerald Combs ger...@wireshark.org If I understand correctly, the main difference between Chocolatey packages and NuGet packages from our perspective is that the former are installed in system-wide locations (primarily %ProgramFiles%) and the latter are installed in the local source

[Wireshark-dev] emem - wmem conversion status and next steps

2013-09-20 Thread Pascal Quantin
Hi all, the easy part of the conversion from emem to wmem memory should be almost complete now: dissectors and plugins use the new memory manager (with the exception of uat / initialization routines). Next, I was thinking about converting our helper functions found in epan module and the various

Re: [Wireshark-dev] emem - wmem conversion status and next steps

2013-09-21 Thread Pascal Quantin
not the important part ;) ). Would my proposal be an acceptable tradeoff instead? Cheers, Pascal. Le 21 sept. 2013 à 00:16, Evan Huus eapa...@gmail.com a écrit : On 2013-09-20, at 5:55 PM, Pascal Quantin pascal.quan...@gmail.com wrote: Hi all, the easy part of the conversion from emem to wmem memory

Re: [Wireshark-dev] emem - wmem conversion status and next steps

2013-09-22 Thread Pascal Quantin
2013/9/21 Evan Huus eapa...@gmail.com The move from emem to wmem is already breaking compatibility in a significant way (especially as we remove more and more emem functions completely), and the current trunk is probably a good place to break compatibility: it already contains the expert-info

Re: [Wireshark-dev] File-scope memory on subsequent passes

2013-09-30 Thread Pascal Quantin
2013/9/30 Evan Huus eapa...@gmail.com I recently found that there are some dissectors which allocate file-scope memory every time they dissect a packet (not just on the first pass, when the packet is unvisited). Can anybody think of a reason for this, or should it be considered a bug? I

Re: [Wireshark-dev] Getting a bug fix into release

2013-10-03 Thread Pascal Quantin
2013/10/3 David Richards d_m_richa...@comcast.net ** I don't know the process for deciding what gets included in a release build, but could someone look at including rev 50272 (fix for bug 8871)? Since the code is in there I'd rather not have to keep building my own version for the folks who

Re: [Wireshark-dev] Windows 8 Mobile Broadband interface model interface types

2013-10-07 Thread Pascal Quantin
2013/4/28 Roger Smith irieb...@me.com Windows 8 added support for MBIM devices/network interfaces. Unfortunately these MBIM interfaces are not showing up as a selectable interface in wireshark. Any idea on how to get this working? MBIM interfaces transport ip packets and are not wrapped

Re: [Wireshark-dev] [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h

2013-10-14 Thread Pascal Quantin
2013/10/14 didier dgauthe...@magic.fr Hi, Le dimanche 13 octobre 2013 à 16:43 -0400, Evan Huus a écrit : On Sun, Oct 13, 2013 at 3:54 AM, Jakub Zawadzki darkjames...@darkjames.pl wrote: About tvb_offset_exists() comment, compute_offset() is not returning exception when offset ==

Re: [Wireshark-dev] [Wireshark-commits] rev 53024: /trunk/image/ /trunk/image/: Makefile.nmake dumpcap.rc.in rawshark.rc.in tshark.rc.in wireshark.exe.manifest.in

2013-11-02 Thread Pascal Quantin
2013/11/2 Joerg Mayer jma...@loplof.de Hello Pascal, On Fri, Nov 01, 2013 at 05:02:40PM +, pas...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=53024 [...] Log: Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9298 : Update manifest

Re: [Wireshark-dev] [Wireshark-commits] rev 53024: /trunk/image/ /trunk/image/: Makefile.nmake dumpcap.rc.in rawshark.rc.in tshark.rc.in wireshark.exe.manifest.in

2013-11-03 Thread Pascal Quantin
2013/11/3 Joerg Mayer jma...@loplof.de On Sun, Nov 03, 2013 at 01:45:28AM +0100, Joerg Mayer wrote: Might be. Unfortunately my Windows test machine is offline for a possible but unlikely virus infection until our admins get back into office to do the checks on monday, so I have to guess

Re: [Wireshark-dev] Wireshark PIDL generated dissectors

2013-11-03 Thread Pascal Quantin
Hi, there is also a small issue spotted by checkAPIs.pl script (found in tools folder) leading to a failure of the buildbot: Error: the name for hf_frsrpc_frsrpc_FrsVerifyPromotionParent___ndr_guid_size (frsrpc.frsrpc_FrsVerifyPromotionParent.__ndr_guid_size) has leading space in

Re: [Wireshark-dev] Wireshark PIDL generated dissectors

2013-11-04 Thread Pascal Quantin
Hi, Le 4 nov. 2013 à 09:24, Matthieu Patou m...@samba.org a écrit : On 11/03/2013 11:37 AM, Pascal Quantin wrote: Hi, there is also a small issue spotted by checkAPIs.pl script (found in tools folder) leading to a failure of the buildbot: Error: the name

Re: [Wireshark-dev] Wireshark development setup Help

2013-11-11 Thread Pascal Quantin
Hi, html2text.py is most probably not compatible with Python 3.3 yet. I recommend to install Python 2.7 instead, that's what I use to build Wireshark myself. Regards, Pascal. Le 11 nov. 2013 à 20:07, Sreejith M M sreejith...@gmail.com a écrit : Thanks Graham I tried Visual Studio command

Re: [Wireshark-dev] Problem...

2013-11-17 Thread Pascal Quantin
2013/11/17 Herb Falk h...@sisconet.com h...@sisconet.com Here is what is in config.nmake: INSTALL_DIR=wireshark-gtk2 Here is the path and the file: C:\wireshark\wireshark-gtk2\share\glib-2.0\schemas\gschemas.compiled Hi, did you try to run c:\wireshark\wireshark-gtk2\wireshark.exe as Bill

Re: [Wireshark-dev] Windows build setup - Concept required

2013-12-05 Thread Pascal Quantin
2013/12/5 Gerald Combs ger...@wireshark.org 10) The setup process does not allow for the simultanous installation of gtk2 and gtk3 Does GTK3 work well enough on Windows to drop GTK2? This would simplify things quite a bit. Personally I find the GTK2 GUI much more polished than GTK3 on

Re: [Wireshark-dev] Windows build setup - Concept required

2013-12-05 Thread Pascal Quantin
2013/12/5 Christopher Maynard christopher.mayn...@gtech.com mmann78@... writes: +1 -Original Message- From: Pascal Quantin pascal.quan...@gmail.com To: Developer support list for Wireshark wireshark-dev@wireshark.org Sent: Thu, Dec 5, 2013 3:33 pm Subject: Re: [Wireshark

Re: [Wireshark-dev] RFC: new types for hfi-display (STR_ASCII, STR_UNICODE), drop proto_tree_add_unicode_string()

2013-12-08 Thread Pascal Quantin
2013/12/7 Jakub Zawadzki darkjames...@darkjames.pl Hi, I renamed base_display_e to field_display_e, and added new enums to field_display_e, but I wonder if it's correct approach. For FT_ABSOLUTE_TIME we're using seperate enum (absolute_time_display_e), so maybe FT_STRING* should also have

Re: [Wireshark-dev] Windows version info

2013-12-08 Thread Pascal Quantin
Hi Graham, Le 8 déc. 2013 à 22:56, Graham Bloice graham.blo...@trihedral.com a écrit : Compiling with VS2013, the GetVersionEx function is now reported as deprecated: E:\Wireshark\trunk\version_info.c(368): warning C4996: 'GetVersionExW': was declared deprecated

Re: [Wireshark-dev] Windows version info

2013-12-09 Thread Pascal Quantin
2013/12/9 Graham Bloice graham.blo...@trihedral.com On 8 December 2013 22:32, Pascal Quantin pascal.quan...@gmail.com wrote: Hi Graham, Le 8 déc. 2013 à 22:56, Graham Bloice graham.blo...@trihedral.com a écrit : Compiling with VS2013, the GetVersionEx function is now reported

Re: [Wireshark-dev] Mysterious Fuzz Failure

2013-12-11 Thread Pascal Quantin
2013/12/11 Evan Huus eapa...@gmail.com https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9406 Can anybody at all reproduce this one? Gerald, any thoughts on what fuzzbot-specific config might be causing this? Hi Evan, I failed to reproduce it both on Linux x64 and Windows.

Re: [Wireshark-dev] BCD Decoding

2013-12-17 Thread Pascal Quantin
Hi Even, in 3GPP world BCD encoding starts with the least significant nibble. That's why tvb_bcd_dig_to_wmwm_packet_str() behaves like this. Changing it to decode the most significant nibble first would break all the dissectors currently using this function. The stop condition for the most

Re: [Wireshark-dev] BCD Decoding

2013-12-17 Thread Pascal Quantin
Le 18 déc. 2013 à 00:55, Evan Huus eapa...@gmail.com a écrit : On Tue, Dec 17, 2013 at 6:13 PM, Pascal Quantin pascal.quan...@gmail.com wrote: Hi Even, in 3GPP world BCD encoding starts with the least significant nibble. That's why tvb_bcd_dig_to_wmwm_packet_str() behaves like

Re: [Wireshark-dev] BCD Decoding

2013-12-18 Thread Pascal Quantin
2013/12/18 Pascal Quantin pascal.quan...@gmail.com Le 18 déc. 2013 à 00:55, Evan Huus eapa...@gmail.com a écrit : On Tue, Dec 17, 2013 at 6:13 PM, Pascal Quantin pascal.quan...@gmail.com wrote: Hi Even, in 3GPP world BCD encoding starts with the least significant nibble. That's

Re: [Wireshark-dev] Should existing use of 'LL' and 'ULL' when specifying a constant be fixed ?

2013-12-18 Thread Pascal Quantin
2013/12/17 Bill Meier wme...@newsguy.com README.developer says: When specifying an integral constant that doesn't fit in 32 bits, don't use LL at the end of the constant - not all compilers use LL for that. Instead, put the constant in a call to the G_GINT64_CONSTANT() macro, e.g.

Re: [Wireshark-dev] Replacing g_iconv and different codesets

2013-12-20 Thread Pascal Quantin
Hi Michael, 2013/12/20 Michael Lum michael@starsolutions.com Is there a goal to remove g_iconv calls from Wireshark. I notice the GSM SMS dissector has been changed. I'm working on an ANSI SMS change but the replacement of g_iconv is not straight forward. I checked charsets.c/.h and

[Wireshark-dev] 3GPP 23.038 encoding and string length

2013-12-24 Thread Pascal Quantin
Hi all, r54428 introduced a ENC_3GPP_TS_23_038 encoding type so as to be able to use proto_tree_add_item directly instead of manually decoding the string with gsm_sms_char_7bit_unpack() / gsm_sms_chars_to_utf8() functions. While it is a very good idea (much more easier to use) it raises an

Re: [Wireshark-dev] 3GPP 23.038 encoding and string length

2013-12-24 Thread Pascal Quantin
2013/12/24 Guy Harris g...@alum.mit.edu On Dec 24, 2013, at 5:30 AM, mman...@netscape.net wrote: Isn't it simple enough to add a proto_tree_add_gsm_sms_item (or similar) API We already have tvbuff and proto_tree_ routines that take bit offsets and bit counts, so this may be another case

Re: [Wireshark-dev] 3GPP 23.038 encoding and string length

2013-12-24 Thread Pascal Quantin
2013/12/24 Guy Harris g...@alum.mit.edu On Dec 24, 2013, at 12:45 PM, Pascal Quantin pascal.quan...@gmail.com wrote: I would vote for proto_tree_add_gsm_7bits_item() as TS 23.038 talks about 8 bits data and UCS2 encoding also and defines this alphabet as GSM 7bit. We should not put SMS

Re: [Wireshark-dev] 3GPP 23.038 encoding and string length

2013-12-29 Thread Pascal Quantin
Hi, 2013/12/28 Guy Harris g...@alum.mit.edu On Dec 24, 2013, at 2:43 AM, Pascal Quantin pascal.quan...@gmail.com wrote: r54428 introduced a ENC_3GPP_TS_23_038 encoding type so as to be able to use proto_tree_add_item directly instead of manually decoding the string

Re: [Wireshark-dev] 3GPP 23.038 encoding and string length

2014-01-01 Thread Pascal Quantin
2013/12/29 Pascal Quantin pascal.quan...@gmail.com Hi 2013/12/28 Guy Harris g...@alum.mit.edu On Dec 24, 2013, at 2:43 AM, Pascal Quantin pascal.quan...@gmail.com wrote: r54428 introduced a ENC_3GPP_TS_23_038 encoding type so as to be able to use proto_tree_add_item directly instead

Re: [Wireshark-dev] Is it possible to update the version of gcrypt?

2014-01-07 Thread Pascal Quantin
Hi Martin, I tried myself to compile the libgpg-error 1.12 and libgcrypt 1.6.0 libraries using the mingw cross-compilation toolchain but I was not really successful (Wireshark does not start due to an issue with the exported symbols from libgpg-error-0.dll). The good news is that OpenSUSE now

Re: [Wireshark-dev] Win64 BuildBot down?

2014-01-12 Thread Pascal Quantin
Hi Tyson, numerous buildbots are down, as seen on http://buildbot.wireshark.org/trunk/waterfall I can build locally without any problem for win64. Pascal. 2014/1/12 Tyson Key tyson@gmail.com Hi list, It seems that there haven't been any more Win64 CI builds since the 9th... Please

Re: [Wireshark-dev] gtk.h not found when compiling Wireshark 1.10.2 on Fedora 19

2014-01-15 Thread Pascal Quantin
Hi John, did you install the GTK+ 2.X development package on your Fedora distribution? Google suggests that it can be installed with the following command line: yum install gtk2-devel Best regards, Pascal. 2014/1/15 John Powell jrp...@gmail.com Hi Everyone, I am trying to compile

Re: [Wireshark-dev] snow3g dissector in violation of GPLv2+

2014-01-15 Thread Pascal Quantin
2014/1/16 Joerg Mayer jma...@loplof.de commit b01a99c385bc80566cff9134f93b5d4680dd5a58 Author: Martin Mathieson martin.r.mathie...@googlemail.com Date: Tue Jan 14 11:09:47 2014 + Provide hook for calling EEA1 implementation (Snow3G). Implementation not supplied due to licensing

Re: [Wireshark-dev] Start-up help

2014-01-21 Thread Pascal Quantin
2014/1/21 Michael Oed michael@gmail.com Hi @ll, I'm new wireshark development. I would like to contribute some of my knowledge and time in this interesting project. I see in the buglist a, in my opinion, good starter bug (9672). How can I grab to tell the other developers the bug is in

Re: [Wireshark-dev] Start-up help

2014-01-21 Thread Pascal Quantin
2014/1/21 Michael Oed michael@gmail.com Hi Pascal, thanks for your answer. One other question, how can I change in Wireshark-Bugzilla the assigment? Might it be possible that I need extra permissions to do that? Thanks and best regards Mike Once you have created your Bugzilla

Re: [Wireshark-dev] Subversion to Git migration status

2014-01-29 Thread Pascal Quantin
2014-01-28 Gerald Combs ger...@wireshark.org The repository migration (Subversion to Git) is complete. Bill Meier wins the award for final SVN commit (r54990 / g58bb472). At this point the Wireshark subversion repository will no longer receive updates. Any new development must be done with

Re: [Wireshark-dev] Gerrit Topic Names

2014-01-30 Thread Pascal Quantin
+1: I find the hyphen much more more eye friendly than the slash. 2014-01-30 Anders Broman anders.bro...@ericsson.com Hi, I vote for - hyphens (bug-) Regards Anders -Original Message- From: wireshark-dev-boun...@wireshark.org [mailto: wireshark-dev-boun...@wireshark.org] On

[Wireshark-dev] Git and line endings

2014-02-03 Thread Pascal Quantin
Hi all, with subversion we were using the native eol-style property. Now that we moved to git, would it make sense to commit a .gitattributes file with text=auto to avoid any issue between Linux and Windows development boxes? I faced tonight an issue with asn2wrs.py that generated the ASN.1

Re: [Wireshark-dev] Git and line endings

2014-02-04 Thread Pascal Quantin
2014-02-04 Graham Bloice graham.blo...@trihedral.com: On 3 February 2014 22:50, Pascal Quantin pascal.quan...@gmail.com wrote: Hi all, with subversion we were using the native eol-style property. Now that we moved to git, would it make sense to commit a .gitattributes file with text=auto

Re: [Wireshark-dev] Git and line endings

2014-02-04 Thread Pascal Quantin
2014-02-04 Graham Bloice graham.blo...@trihedral.com: On 4 February 2014 11:18, Pascal Quantin pascal.quan...@gmail.com wrote: 2014-02-04 Graham Bloice graham.blo...@trihedral.com: On 3 February 2014 22:50, Pascal Quantin pascal.quan...@gmail.comwrote: Hi all, with subversion we were

Re: [Wireshark-dev] Git and line endings

2014-02-04 Thread Pascal Quantin
2014-02-04 Bálint Réczey bal...@balintreczey.hu: Hi, 2014-02-04 Pascal Quantin pascal.quan...@gmail.com: 2014-02-04 Graham Bloice graham.blo...@trihedral.com: On 4 February 2014 11:18, Pascal Quantin pascal.quan...@gmail.com wrote: 2014-02-04 Graham Bloice graham.blo

Re: [Wireshark-dev] Git and line endings

2014-02-04 Thread Pascal Quantin
2014-02-04 Bálint Réczey bal...@balintreczey.hu: OK, let's go with * text=auto and don't convert the files now. As Graham suggested wireshark.sln can stay CRLF, since it won't be ever used on other OS-es. After double checking the git documentation, it looks like the files will get

Re: [Wireshark-dev] error encountered during compilation on windows

2014-02-11 Thread Pascal Quantin
Hi, 2014-02-11 8:41 GMT+01:00 Rahul Rohit rahul.ro...@aricent.com: Hi, During the build of wireshark exe in windows machice(32 bit) we get the following errors. epan\except.h(97) : error C2054: expected '(' to follow 'WS_MSVC_NORETURN' epan\except.h(97) : error C2085:

Re: [Wireshark-dev] error encountered during compilation on windows

2014-02-11 Thread Pascal Quantin
2014-02-11 13:50 GMT+01:00 Rahul Rohit rahul.ro...@aricent.com: Hi, WS_MSVC_NORETURN is supposed to be defined as: #define WS_MSVC_NORETURN__declspec(noreturn) in the auto generated config.h file found at the root of your working copy. Do you confirm you have it defined in your

Re: [Wireshark-dev] error encountered during compilation on windows

2014-02-11 Thread Pascal Quantin
-dev-boun...@wireshark.org] *On Behalf Of *Pascal Quantin *Sent:* Tuesday, February 11, 2014 6:48 PM *To:* Developer support list for Wireshark *Subject:* Re: [Wireshark-dev] error encountered during compilation on windows 2014-02-11 13:50 GMT+01:00 Rahul Rohit rahul.ro...@aricent.com

Re: [Wireshark-dev] Automatically Expiring Old Gerrit Reviews

2014-02-12 Thread Pascal Quantin
2014-02-12 21:57 GMT+01:00 Evan Huus eapa...@gmail.com: Been poking around how other projects use Gerrit and discovered that openstack has a cron job which automatically expires old reviews [1]. Seems like it might be a good idea, and doesn't sound too hard to do. Abandoned/expired reviews

Re: [Wireshark-dev] Unable to recognise DTLS packets

2014-02-13 Thread Pascal Quantin
Hi, 2014-02-13 8:43 GMT+01:00 Tulika Bose tulika.b...@tcs.com: Hi Thanx a lot.I used the 'Decode as' option,and the DTLS header is getting parsed correctly.But it caused an issue,that for some some of the DTLS packets,the pprotocol field showed DTLSv1,while the other packets showed it as

Re: [Wireshark-dev] duplicate field names (was: displaying header field without filtering)

2014-02-20 Thread Pascal Quantin
Le 20 févr. 2014 19:55, Hadriel Kaplan hadriel.kap...@oracle.com a écrit : On Feb 19, 2014, at 7:03 PM, Evan Huus eapa...@gmail.com wrote: You can reuse a single spare field for all of these bytes, and they would only cause a single entry in the filter expression dialog. I suspect this

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Pascal Quantin
2014-02-25 22:57 GMT+01:00 Joerg Mayer jma...@loplof.de: On Tue, Feb 25, 2014 at 01:48:22PM -0500, Evan Huus wrote: On Tue, Feb 25, 2014 at 1:39 PM, Joerg Mayer jma...@loplof.de wrote: On Tue, Feb 25, 2014 at 10:09:43AM -0800, Gerald Combs wrote: I haven't found anything obvious in the

Re: [Wireshark-dev] Doubt related to rrc tables

2014-02-26 Thread Pascal Quantin
2014-02-26 8:59 GMT+01:00 Rahul Rohit rahul.ro...@aricent.com: Hi, Why don't we have rrc.proc.imsg tables like ranap.proc.imsg or nbap.proc.imsg tables ?? on what criteria this tables are defined ?? Hi, simply because RRC protocol has nothing to do with RANAP or NBAP protocols and

Re: [Wireshark-dev] Debugging Wireshark Disector

2014-02-26 Thread Pascal Quantin
Le 26 févr. 2014 19:03, Men Mamu meng@gmail.com a écrit : Hi, I'm working on a custom dissector on wireshark and some problems happened, I'd like to know what happened in the dissector, I am working windows XP OS. so please i need the steps to debug custom wireshark dissector. Does

Re: [Wireshark-dev] FW: [Wireshark-commits] master 579e7e1: Wireshark: Add option to choose format type of capture file

2014-03-06 Thread Pascal Quantin
Hi Anders, name is the string that appears in the file open dialog, allowing you to know which format you are selecting. Cheers, Pascal. 2014-03-06 15:53 GMT+01:00 Anders Broman anders.bro...@ericsson.com: Hi, This change broke a custom wiretap plugin I have which used

Re: [Wireshark-dev] Fix bug in GSM MAP, have problems with GIT

2014-03-08 Thread Pascal Quantin
Le 08/03/2014 09:45, Anders Broman a écrit : Hi, Could some one replace the file in asn1/gsm_map with this one, and regenerate the dissector? Omitting SubscriberData makes CONTENT OF fail and InsertSubscriberDataArg will not get all its tags Done:

Re: [Wireshark-dev] Packet counter in live tshark captures

2014-03-18 Thread Pascal Quantin
2014-03-18 0:24 GMT+01:00 Jan Larres j...@majutsushi.net: Hi, I am using tshark to do a live capture in a terminal. Unfortunately tshark occasionally prints out the current packet count on stderr, messing up the alignment of the summary lines and thus making them harder to read. I have

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-28 Thread Pascal Quantin
2014-03-28 16:02 GMT+01:00 Bálint Réczey bal...@balintreczey.hu: +1 The Debian packages use Lua since 1.10.2-2 without any problem. Cheers, Balint 2014-03-28 15:45 GMT+01:00 Nakayama Kenjiro nakayamakenj...@gmail.com: +1 On Fri, Mar 28, 2014 at 11:29 PM, Hadriel Kaplan

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-28 Thread Pascal Quantin
2014-03-28 16:34 GMT+01:00 Hadriel Kaplan hadriel.kap...@oracle.com: The bugs are listed here: http://www.lua.org/bugs.html 5.2.3 was only released this past December, but 5.2.2 has been out since 2012. What do you mean by we have a 5.2.1 library for Windows but not a 5.2.3 one? Do you

Re: [Wireshark-dev] Defect in reassembling TCP stream. Bug and Patch are available on Bugzilla.

2014-03-28 Thread Pascal Quantin
2014-03-28 16:06 GMT+01:00 Pavel Karneliuk pavel_karnel...@epam.com: Hello, At first, thank you all for Wireshark. It is amazing tool! I found a defect and register Bug 9936https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9936- epan/follow.c - Incorrect comparing a sequence number

Re: [Wireshark-dev] Defect in reassembling TCP stream. Bug and Patch are available on Bugzilla.

2014-03-28 Thread Pascal Quantin
Le 28 mars 2014 16:52, Pavel Karneliuk pavel_karnel...@epam.com a écrit : Hi Pascal, thank you for answer. I saw your commits to follow.c and I hoped for your reply. 450:if( newseq seq[idx] ) { I think - Yes. It compares sequence numbers. 459: if ( current-data_len new_pos ) { I am

Re: [Wireshark-dev] Can we move to Lua 5.2.3 only?

2014-03-29 Thread Pascal Quantin
2014-03-28 20:32 GMT+01:00 Hadriel Kaplan hadriel.kap...@oracle.com: On Mar 28, 2014, at 11:42 AM, Pascal Quantin pascal.quan...@gmail.com wrote: 2014-03-28 16:34 GMT+01:00 Hadriel Kaplan hadriel.kap...@oracle.com: The bugs are listed here: http://www.lua.org/bugs.html 5.2.3 was only

Re: [Wireshark-dev] how to use the wireshark source code to develop application?

2014-03-30 Thread Pascal Quantin
Le 30 mars 2014 08:58, 我想不无聊 237825...@qq.com a écrit : I want to store some information about packets and transmit among files,so i create a file in wireshark root directory,named performance.h: //performance.h #include glib.h typedef struct performance_s { gfloat time[100];

Re: [Wireshark-dev] 回复: how to use the wireshark source code to developapplication?

2014-03-30 Thread Pascal Quantin
of WS_VAR_IMPORT in the source code. Regards, Pascal. PS: there is no need to send multiple emails to the mailing list with the same question over and over. -- 原始邮件 -- *发件人:* Pascal Quantin;pascal.quan...@gmail.com; *发送时间:* 2014年3月30日(星期天) 下午5:06 *收件人

Re: [Wireshark-dev] 回复: 回复: how to use the wireshark source code to developapplication?

2014-03-30 Thread Pascal Quantin
and over. -- 原始邮件 -- 发件人: Pascal Quantin;pascal.quan...@gmail.com; 发送时间: 2014年3月30日(星期天) 下午5:06 收件人: Developer support list for Wiresharkwireshark-dev@wireshark.org; 主题: Re: [Wireshark-dev] how to use the wireshark source code to developapplication? Le 30 mars

<    1   2   3   4   5   6   7   8   9   >