Shaun Jackman wrote:
2, do you really need all these includes?
+#include arpa/inet.h
+#include errno.h
+#include math.h
+#include stdint.h
+#include stdlib.h
+#include string.h
+#include time.h
are all of these ones actually available on all platforms we support?
At one point each of
I have checked in the wiretap patch after doing the changes listed.
On 3/21/07, Shaun Jackman [EMAIL PROTECTED] wrote:
On 3/20/07, ronnie sahlberg [EMAIL PROTECTED] wrote:
1, shouldnt the defines MPA_MARSHAL_... really be called
MPA_UNMARSHAL_... instead?
Good point.
2, do you really
ronnie sahlberg wrote:
I have checked in the wiretap patch after doing the changes listed.
The win32 build on MSVC 6.0 fails with the following errors:
mpeg.c(47) : error C2065: 'off_t' : undeclared identifier
mpeg.c(47) : error C2146: syntax error : missing ';' before identifier
'offset'
Thanks.
I have added two headers to mpeg.h hoping that msvc will find the
missing definitions.
Please try latest svn
On 3/22/07, Graham Bloice [EMAIL PROTECTED] wrote:
ronnie sahlberg wrote:
I have checked in the wiretap patch after doing the changes listed.
The win32 build on MSVC
ronnie sahlberg wrote:
Thanks.
I have added two headers to mpeg.h hoping that msvc will find the
missing definitions.
Please try latest svn
It found the definitions but was still picky about some implicit casts.
Attached are the changes required to allow compilation without warnings.
Thanks.
Checked in.
On 3/22/07, Graham Bloice [EMAIL PROTECTED] wrote:
ronnie sahlberg wrote:
Thanks.
I have added two headers to mpeg.h hoping that msvc will find the
missing definitions.
Please try latest svn
It found the definitions but was still picky about some implicit
On 3/22/07, ronnie sahlberg [EMAIL PROTECTED] wrote:
I have checked in the wiretap patch after doing the changes listed.
Great! Thanks for doing the massaging necessary to check in the patch.
Cheers,
Shaun
___
Wireshark-dev mailing list
On 3/20/07, ronnie sahlberg [EMAIL PROTECTED] wrote:
1, shouldnt the defines MPA_MARSHAL_... really be called
MPA_UNMARSHAL_... instead?
Good point.
2, do you really need all these includes?
+#include arpa/inet.h
+#include errno.h
+#include math.h
+#include stdint.h
+#include stdlib.h
On 3/15/07, Jeff Morriss [EMAIL PROTECTED] wrote:
Actually the patch isn't attached ;-)
Grumble. =P
2007-03-15 Shaun Jackman [EMAIL PROTECTED]
* wiretap/Makefile.common (NONGENERATED_C_FILES): Add mpeg.c.
(NONGENERATED_HEADER_FILES): Add mpeg.h.
* wiretap/file_access.c
On 8/25/06, ronnie sahlberg [EMAIL PROTECTED] wrote:
Can you add the GPL boilerplate to some of the files that are missing it.
Done.
Why do you create a mpeg plugin directory?
To me it looks like an normal dissector generated by asn2wrs and as
such it is not a plugin. am i missing
Actually the patch isn't attached ;-)
Shaun Jackman wrote:
On 8/25/06, ronnie sahlberg [EMAIL PROTECTED] wrote:
Can you add the GPL boilerplate to some of the files that are missing it.
Done.
Why do you create a mpeg plugin directory?
To me it looks like an normal dissector generated by
11 matches
Mail list logo
