Re: [Wireshark-dev] Display IPv6 extension headers outside of the IPv6 subtree

2015-08-22 Thread João Valverde
I'm not so sure now that I've done some tests with short and long header chains, I think I'll drop it. Regards, João V. On 08/21/2015 06:04 PM, João Valverde wrote: I forgot to include: f) it would fix this[1] bug too. [1]https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9996 On 08/21

Re: [Wireshark-dev] Display IPv6 extension headers outside of the IPv6 subtree

2015-08-21 Thread João Valverde
I forgot to include: f) it would fix this[1] bug too. [1]https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9996 On 08/21/2015 05:45 PM, João Valverde wrote: Hi, I would like to propose a patch to remove IPv6 extension headers from the IPv6 subtree and display them as normal IP protocols

Re: [Wireshark-dev] Display IPv6 extension headers outside of the IPv6 subtree

2015-08-22 Thread João Valverde
On 08/22/2015 09:29 AM, Alexis La Goutte wrote: On Sat, Aug 22, 2015 at 8:10 AM, João Valverde joao.valve...@tecnico.ulisboa.pt mailto:joao.valve...@tecnico.ulisboa.pt wrote: I'm not so sure now that I've done some tests with short and long header chains, I think I'll drop it. Can

Re: [Wireshark-dev] Display IPv6 extension headers outside of the IPv6 subtree

2015-08-22 Thread João Valverde
On 08/22/2015 02:28 PM, João Valverde wrote: On 08/22/2015 09:29 AM, Alexis La Goutte wrote: On Sat, Aug 22, 2015 at 8:10 AM, João Valverde joao.valve...@tecnico.ulisboa.pt mailto:joao.valve...@tecnico.ulisboa.pt wrote: I'm not so sure now that I've done some tests with short

Re: [Wireshark-dev] Display IPv6 extension headers outside of the IPv6 subtree

2015-08-22 Thread João Valverde
On 08/21/2015 05:45 PM, João Valverde wrote: Hi, I would like to propose a patch to remove IPv6 extension headers from the IPv6 subtree and display them as normal IP protocols in the UI. Arguments for: a) The current behaviour really, really, (really) hurts legibility b) It would

Re: [Wireshark-dev] Display IPv6 extension headers outside of the IPv6 subtree

2015-08-22 Thread João Valverde
On 08/22/2015 02:58 PM, João Valverde wrote: On 08/22/2015 02:28 PM, João Valverde wrote: On 08/22/2015 09:29 AM, Alexis La Goutte wrote: On Sat, Aug 22, 2015 at 8:10 AM, João Valverde joao.valve...@tecnico.ulisboa.pt mailto:joao.valve...@tecnico.ulisboa.pt wrote: I'm not so sure

Re: [Wireshark-dev] GCC GTK3 Wireshark build warnings ?

2015-11-11 Thread João Valverde
On 11-11-2015 17:28, Bill Meier wrote: When building GTK3 Wireshark on my Fedora system (after not having done so for a while), I'm getting many warnings similar to the following: CC libgtkui_a-about_dlg.o In file included from /usr/include/gtk-3.0/gtk/gtk.h:263:0,

Re: [Wireshark-dev] Missing character in Qt GUI

2015-10-14 Thread João Valverde
On 10/14/2015 09:15 PM, Guy Harris wrote: On Oct 14, 2015, at 12:23 PM, Joerg Mayer > wrote: I currently have a missing character between source and destination port in the info column of udp and tcp. See attached screenshot. I suspect your font

Re: [Wireshark-dev] Do we still need/want -Wc++-compat?

2015-10-13 Thread João Valverde
GTK build breaks for 3.18 with Werror=c++-compat ('and' is a reserved C++ keyword). It should arguably be fixed upstream, I patched my GTK installation, but can this warning be removed? On 10/09/2015 06:47 PM, Evan Huus wrote: On Fri, Oct 9, 2015 at 1:40 PM, Guy Harris

[Wireshark-dev] Remove duplication for resolved addresses

2015-09-10 Thread João Valverde
Hi list, I proposed a change[1] to remove the duplication for resolved addresses (not necessarily using that code) in the UI: Src: 192.0.2.1, Dst: 192.0.2.2 Instead of: Src: 192.0.2.1 (192.0.2.1), Dst: 192.0.2.2 (192.0.2.2) This change (rightfully) raised concerns that it would break

Re: [Wireshark-dev] Wireshark "Decode As"

2015-09-15 Thread João Valverde
On 09/15/2015 11:55 PM, Pascal Quantin wrote: 2015-09-15 23:20 GMT+02:00 João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>>: > > > > On 09/15/2015 09:43 PM, Pascal Quantin wrote: >> >> >> &

Re: [Wireshark-dev] Wireshark "Decode As"

2015-09-15 Thread João Valverde
On 09/16/2015 12:19 AM, João Valverde wrote: On 09/15/2015 11:55 PM, Pascal Quantin wrote: 2015-09-15 23:20 GMT+02:00 João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>>: > > > > On 09/15/2015 09:43 PM, Pascal Quantin wro

Re: [Wireshark-dev] Wireshark "Decode As"

2015-09-15 Thread João Valverde
On 09/15/2015 07:38 PM, Pascal Quantin wrote: Hi João, Le 15 sept. 2015 4:41 PM, "João Valverde" <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>> a écrit : > > Hi, > > I'm trying to understand and troubleshoot some &quo

Re: [Wireshark-dev] Wireshark "Decode As"

2015-09-15 Thread João Valverde
On 09/15/2015 09:43 PM, Pascal Quantin wrote: 2015-09-15 22:39 GMT+02:00 João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>>: On 09/15/2015 09:05 PM, Pascal Quantin wrote: 2015-09-15 21:15 GMT+02:00 João Valverde

Re: [Wireshark-dev] Remove duplication for resolved addresses

2015-09-11 Thread João Valverde
On 09/10/2015 10:13 PM, João Valverde wrote: On 09/10/2015 09:51 PM, João Valverde wrote: On 09/10/2015 09:05 PM, Pascal Quantin wrote: Hi, 2015-09-10 13:50 GMT+02:00 João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>>: Hi

Re: [Wireshark-dev] Remove duplication for resolved addresses

2015-09-11 Thread João Valverde
On 09/11/2015 04:01 PM, João Valverde wrote: On 09/10/2015 10:13 PM, João Valverde wrote: On 09/10/2015 09:51 PM, João Valverde wrote: On 09/10/2015 09:05 PM, Pascal Quantin wrote: Hi, 2015-09-10 13:50 GMT+02:00 João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao

Re: [Wireshark-dev] Remove duplication for resolved addresses

2015-09-10 Thread João Valverde
On 09/10/2015 09:05 PM, Pascal Quantin wrote: Hi, 2015-09-10 13:50 GMT+02:00 João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>>: Hi list, I proposed a change[1] to remove the duplication for resolved addresses (not neces

Re: [Wireshark-dev] Remove duplication for resolved addresses

2015-09-10 Thread João Valverde
On 09/10/2015 09:51 PM, João Valverde wrote: On 09/10/2015 09:05 PM, Pascal Quantin wrote: Hi, 2015-09-10 13:50 GMT+02:00 João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>>: Hi list, I proposed a change[1] to remove the

[Wireshark-dev] Wireshark "Decode As"

2015-09-15 Thread João Valverde
Hi, I'm trying to understand and troubleshoot some "Decode As" issues. To give an example consider the packet: IPv6 | IPv6 | UDP Wouldn't the second IPv6 layer overwrite the Decode As protocol number for the first layer, giving: IPv6 (Decode IP protocol 17 As:) | IPv6 (Decode IP protocol

[Wireshark-dev] save_fragmented

2015-09-25 Thread João Valverde
Hi, What's the use case for save_fragmented? The documentation doesn't explain why it's there: https://www.wireshark.org/docs/wsdg_html_chunked/ChDissectReassemble.html The context leads me to think that save_fragmented is only relevant in this case because the example deals with a custom

Re: [Wireshark-dev] Editorconfig

2015-12-02 Thread João Valverde
On 02-12-2015 17:31, Gerald Combs wrote: Does anyone have any experience with EditorConfig (http://editorconfig.org/)? It seems like it would be useful for getting rid of our modeline boilerplate, at least in directories where formatting is consistent. Didn't know about EditorConfig but I

Re: [Wireshark-dev] Editorconfig

2015-12-02 Thread João Valverde
On 02-12-2015 18:41, João Valverde wrote: On 02-12-2015 17:31, Gerald Combs wrote: Does anyone have any experience with EditorConfig (http://editorconfig.org/)? It seems like it would be useful for getting rid of our modeline boilerplate, at least in directories where formatting

Re: [Wireshark-dev] ui/gtk/pixbuf-csource not linked in

2015-12-04 Thread João Valverde
On 05-12-2015 00:29, Simon Barber wrote: I'm building wireshark_gtk on MacOS 10.10 using cmake, with GTK2, and I'm not seeing pixbuf-csource being linked in. Here's the AR command: ar cru libgtkui.a libgtkui_a-about_dlg.o libgtkui_a-addr_resolution_dlg.o libgtkui_a-bytes_view.o

Re: [Wireshark-dev] ui/gtk/pixbuf-csource not linked in

2015-12-04 Thread João Valverde
) "_wsiconcap_32_pb_data", referenced from: _main_capture_callback in libgtkui.a(libgtkui_a-main.o) "_wsiconcap_48_pb_data", referenced from: _main_capture_callback in libgtkui.a(libgtkui_a-main.o) "_wsiconcap_64_pb_data", referenced from:

Re: [Wireshark-dev] ui/gtk/pixbuf-csource not linked in

2015-12-07 Thread João Valverde
On 07-12-2015 21:01, Simon Barber wrote: I don't see -DHAVE_GRESOURCE Making all in ui/gtk gcc -DHAVE_CONFIG_H -I. -I../.. -I../.. -I../../wiretap -DG_DISABLE_DEPRECATED -DG_DISABLE_SINGLE_INCLUDES -DGSEAL_ENABLE -DGTK_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_DEPRECATED

[Wireshark-dev] Qt and setlocale

2015-12-30 Thread João Valverde
Hi, Should Qt call setlocale? GTK does. https://code.wireshark.org/review/12944 Regards, João ___ Sent via:Wireshark-dev mailing list Archives:

Re: [Wireshark-dev] Setting up git for gerrit

2015-11-29 Thread João Valverde
On 29-11-2015 23:19, Paul Offord wrote: Hi, I’m trying to setup git so that I can submit a change to gerrit. Although I can use git pull to update the code, when I try git review I get: C:\Development\Wireshark>git review bash: /dev/tty: No such device or address error: failed to execute

Re: [Wireshark-dev] linking errors on Windows

2016-02-24 Thread João Valverde
On 24-02-2016 05:25, Edwin Groothuis wrote: Greetings, I’m in the process of upgrading an 1.10 environment into the 2.0 century and run in one last problem: The functions from a new file in epan/ don’t get recognized by the linker for VS2013. I have added it to Makefile.common, the include

Re: [Wireshark-dev] Build failing on SLES 11.2

2016-02-22 Thread João Valverde
and formatting, sent from my phone) On 22 February 2016 10:06:42 CET, "João Valverde" <joao.valve...@tecnico.ulisboa.pt> wrote: On 22-02-2016 09:02, João Valverde wrote: On 22-02-2016 08:55, Anders Broman wrote: Hi, A collegue is trying to build on SLES 11.2 but the build is fai

Re: [Wireshark-dev] [Wireshark-commits] master e282c19: autotools: Fix multiple repetitions of -L build flags

2016-02-23 Thread João Valverde
e282c19: autotools: Fix multiple repetitions of -L build flags On Mon, Feb 22, 2016 at 9:56 AM, Jeff Morriss <jeff.morriss...@gmail.com <mailto:jeff.morriss...@gmail.com>> wrote: On Mon, Feb 22, 2016 at 9:48 AM, João Valverde <joao.valve...@tecnico.ulisboa.pt <

Re: [Wireshark-dev] Build failing on SLES 11.2

2016-02-23 Thread João Valverde
On 23-02-2016 14:31, João Valverde wrote: On 23-02-2016 14:25, João Valverde wrote: Thanks. This confirms Peter's analysis. I'll start working on a fix. But, if it the message is just a diagnostic and unknown options are ignored, was by the gcc version it really just -Qunused-arguments

Re: [Wireshark-dev] Build failing on SLES 11.2

2016-02-23 Thread João Valverde
On 23-02-2016 14:25, João Valverde wrote: Thanks. This confirms Peter's analysis. I'll start working on a fix. But, if it the message is just a diagnostic and unknown options are ignored, was by the gcc version it really just -Qunused-arguments that broke the build here? On 23-02-2016

Re: [Wireshark-dev] Build failing on SLES 11.2

2016-02-23 Thread João Valverde
Thanks. This confirms Peter's analysis. I'll start working on a fix. On 23-02-2016 13:26, Anders Broman wrote: Hi, Here's the configure log: This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. It was created by

Re: [Wireshark-dev] pre-commit ImportError

2016-02-17 Thread João Valverde
On 17-02-2016 07:48, POZUELO Gloria (BCS/PSD) wrote: Hello, I’d like to ask you about a problem with the pre-commit hook. It turns out that when I try to commit my changes it shows me a message that says: “ImportError: No module named site”, but when I delete the pre-commit hook it allows me

Re: [Wireshark-dev] pre-commit ImportError

2016-02-17 Thread João Valverde
Change-Id was generated properly...I don't know what happen to the pre-commit hook, I'll keep on investigation what's going on... -Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of João Valverde Sent: Wednesday 17 February

Re: [Wireshark-dev] pre-commit ImportError

2016-02-17 Thread João Valverde
win python comes before Win32 python on your (git bash) PATH. I'm going to try the solution that it tells me... Thank you very much! -Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of João Valverde Sent: Wednesday 1

Re: [Wireshark-dev] Build failing on SLES 11.2

2016-02-22 Thread João Valverde
On 22-02-2016 08:55, Anders Broman wrote: Hi, A collegue is trying to build on SLES 11.2 but the build is failing with eth@linux-q645:~/plugin_dev/ > make /usr/bin/perl ./make-version.pl . Version configuration file version.conf

Re: [Wireshark-dev] Removing ADNS

2016-03-18 Thread João Valverde
On 18-03-2016 23:00, Pascal Quantin wrote: Le 18 mars 2016 10:02 PM, "João Valverde" <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>> a écrit : > > I pushed a change removing ADNS support. If anyone depends on this: > > htt

Re: [Wireshark-dev] ligcrypt version (Ubuntu)

2016-03-09 Thread João Valverde
On 09-03-2016 22:26, Mike Morrin wrote: I was intending to do the version check inside the dissector source file, that seems easier than putting an exceptional case into the make system. You can push a separate patch for review exporting the return value of gcry_check_version() in

Re: [Wireshark-dev] Building with CMake on Win10 and VS2013 (win64)

2016-03-30 Thread João Valverde
On 30-03-2016 16:46, Graham Bloice wrote: On 30 March 2016 at 16:02, João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>> wrote: On 30-03-2016 14:57, Graham Bloice wrote: On 30 March 2016 at 14:39, João Valverde

Re: [Wireshark-dev] compiling asn.1 dissectors in Linux

2016-04-12 Thread João Valverde
On 11-04-2016 22:37, João Valverde wrote: On 11-04-2016 21:33, Guy Harris wrote: On Apr 11, 2016, at 1:13 PM, Born In <d3c1...@yahoo.com> wrote: Thank you. Was able to get past this. Have another seemingly basic question. How do you append a suffix to the version number of

Re: [Wireshark-dev] compiling asn.1 dissectors in Linux

2016-04-12 Thread João Valverde
On 12-04-2016 18:04, João Valverde wrote: On 11-04-2016 22:37, João Valverde wrote: On 11-04-2016 21:33, Guy Harris wrote: On Apr 11, 2016, at 1:13 PM, Born In <d3c1...@yahoo.com> wrote: Thank you. Was able to get past this. Have another seemingly basic question. How do you

Re: [Wireshark-dev] compiling asn.1 dissectors in Linux

2016-04-12 Thread João Valverde
On 12-04-2016 18:13, João Valverde wrote: On 12-04-2016 18:04, João Valverde wrote: On 11-04-2016 22:37, João Valverde wrote: On 11-04-2016 21:33, Guy Harris wrote: On Apr 11, 2016, at 1:13 PM, Born In <d3c1...@yahoo.com> wrote: Thank you. Was able to get past this. Have a

Re: [Wireshark-dev] compiling asn.1 dissectors in Linux

2016-04-12 Thread João Valverde
On 12-04-2016 20:10, Guy Harris wrote: On Apr 12, 2016, at 10:48 AM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: I thought "extra" was an addition to "build", but it's not, it's a replacement, so I think it's still useful when running autogen.

Re: [Wireshark-dev] compiling asn.1 dissectors in Linux

2016-04-11 Thread João Valverde
On 11-04-2016 21:33, Guy Harris wrote: On Apr 11, 2016, at 1:13 PM, Born In wrote: Thank you. Was able to get past this. Have another seemingly basic question. How do you append a suffix to the version number of custom compiled version of wireshark? The Windows method

[Wireshark-dev] Removing ADNS

2016-03-19 Thread João Valverde
I pushed a change removing ADNS support. If anyone depends on this: https://code.wireshark.org/review/#/c/14519/ ___ Sent via:Wireshark-dev mailing list Archives:

Re: [Wireshark-dev] ./configure fails

2016-03-30 Thread João Valverde
On 30-03-2016 11:46, Juan Jose Martin Carrascosa wrote: Hi all, ./configure was working for me two weeks ago. Now it fails with: ./configure: line 19638: AX_COMPILER_VENDOR: command not found ./configure: line 19646: AX_COMPILER_VENDOR: command not found checking whether the compiler fails

Re: [Wireshark-dev] Building with CMake on Win10 and VS2013 (win64)

2016-03-30 Thread João Valverde
On 30-03-2016 14:20, João Valverde wrote: On 30-03-2016 08:48, Graham Bloice wrote: On 30 March 2016 at 03:10, João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>> wrote: On 29-03-2016 21:46, Roland Knall wrote: Sorry, la

Re: [Wireshark-dev] Building with CMake on Win10 and VS2013 (win64)

2016-03-30 Thread João Valverde
On 30-03-2016 14:25, João Valverde wrote: On 30-03-2016 14:20, João Valverde wrote: On 30-03-2016 08:48, Graham Bloice wrote: On 30 March 2016 at 03:10, João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>> wrote: On 29-03-2016 2

Re: [Wireshark-dev] Building with CMake on Win10 and VS2013 (win64)

2016-03-30 Thread João Valverde
On 30-03-2016 08:48, Graham Bloice wrote: On 30 March 2016 at 03:10, João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>> wrote: On 29-03-2016 21:46, Roland Knall wrote: Sorry, late over here. You could try with

Re: [Wireshark-dev] Building with CMake on Win10 and VS2013 (win64)

2016-03-30 Thread João Valverde
On 30-03-2016 14:57, Graham Bloice wrote: On 30 March 2016 at 14:39, João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>> wrote: No problems building the installer with NSIS 3.0b3. OK, now install on a non Windows 10 machine that

Re: [Wireshark-dev] Fwd: About building the wireshark

2016-03-28 Thread João Valverde
On 28-03-2016 04:54, LIN Qingxiang(林清祥) wrote: -- Forwarded message -- From: *LIN Qingxiang(林清祥)* > Date: 2016-03-28 11:48 GMT+08:00 Subject: About building the wireshark To: wireshark-dev

Re: [Wireshark-dev] Fwd: About building the wireshark

2016-03-28 Thread João Valverde
th "-nn" will fix your problem. 2016-03-28 14:03 GMT+08:00 João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>>: On 28-03-2016 04:54, LIN Qingxiang(林清祥) wrote: -- Forwarded message --

Re: [Wireshark-dev] Fwd: About building the wireshark

2016-03-28 Thread João Valverde
On 28-03-2016 08:59, woniu1...@gmail.com wrote: Hi, Thanks for your help. "-nn' works well now, but I got another problem as below: (I am a newbie for C) make[2]: Leaving directory `/home/lqx/bin/wireshark-2.1.0-2469-g162df25/ui/qt' Making all in ui/gtk make[2]: Entering

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64

2016-03-28 Thread João Valverde
On 28-03-2016 15:51, Joerg Mayer wrote: On Mon, Mar 28, 2016 at 02:26:41PM +, buildbot-no-re...@wireshark.org wrote: The Buildbot has detected a new failure on builder Ubuntu 14.04 x64 while building wireshark. Full details are available at:

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64

2016-03-28 Thread João Valverde
On 28-03-2016 16:30, Joerg Mayer wrote: On Mon, Mar 28, 2016 at 04:04:48PM +0100, João Valverde wrote: The variable is set but not used. Nothing strange about the warning. Pascal seems to have understood what I meant: The variable is indeed unused and the compiler should complain about

Re: [Wireshark-dev] #ifdef mess

2016-03-29 Thread João Valverde
On 29-03-2016 23:48, Joerg Mayer wrote: On Tue, Mar 29, 2016 at 03:34:38PM +0100, João Valverde wrote: On 28-03-2016 23:30, Joerg Mayer wrote: I've been meaning to write this mail for some years now but finally got around to it. Earlier today I committed

Re: [Wireshark-dev] Building with CMake on Win10 and VS2013 (win64)

2016-03-29 Thread João Valverde
On 29-03-2016 21:46, Roland Knall wrote: Sorry, late over here. You could try with cmake 3.5rc2. But beside that, I did not get WS compile correctly with VS2013 for some time now, need to use VS2015 myself. Just another data point, I tried building on Windows 10 x64 with VS2015 and the

Re: [Wireshark-dev] #ifdef mess

2016-03-29 Thread João Valverde
On 28-03-2016 23:30, Joerg Mayer wrote: Hello list, I've been meaning to write this mail for some years now but finally got around to it. Earlier today I committed 30900b443b85a7e760d703ca3d6efe61df4fe623, which I'm incredibly unproud of because of readablity: static void

Re: [Wireshark-dev] rpm-build on SuSE 11.3 fails with "new version string"

2016-04-22 Thread João Valverde
On 22-04-2016 14:21, João Valverde wrote: On 22-04-2016 14:18, João Valverde wrote: On 22-04-2016 12:41, João Valverde wrote: On 22-04-2016 12:31, Anders Broman wrote: -Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org

Re: [Wireshark-dev] rpm-build on SuSE 11.3 fails with "new version string"

2016-04-22 Thread João Valverde
On 22-04-2016 12:31, Anders Broman wrote: -Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of João Valverde Sent: den 22 april 2016 11:05 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] rpm

Re: [Wireshark-dev] rpm-build on SuSE 11.3 fails with "new version string"

2016-04-22 Thread João Valverde
The problem is also present with old version string for automated builds. How should this string be sanitized for RPM? Is there some best practice? On 22-04-2016 09:33, Anders Broman wrote: tardir=wireshark-2.1.0-git && tar --format=ustar -chf - "$tardir" | bzip2 -9 -c

Re: [Wireshark-dev] rpm-build on SuSE 11.3 fails with "new version string"

2016-04-22 Thread João Valverde
On 22-04-2016 12:41, João Valverde wrote: On 22-04-2016 12:31, Anders Broman wrote: -Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of João Valverde Sent: den 22 april 2016 11:05 To: Developer support list

Re: [Wireshark-dev] rpm-build on SuSE 11.3 fails with "new version string"

2016-04-22 Thread João Valverde
On 22-04-2016 14:18, João Valverde wrote: On 22-04-2016 12:41, João Valverde wrote: On 22-04-2016 12:31, Anders Broman wrote: -Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of João Valverde Sent: den 22 april

Re: [Wireshark-dev] reassembled PDU for lua dissector in case of a seq overrun

2016-05-14 Thread João Valverde
On 13-05-2016 16:12, Strauß, Martin wrote: Dear all, I've written a lua dissector for a company intern binary protocol. Usually it is capable to dissect everything (if no packet is missing). I considered that one tcp packet may contain multiple PDU, and also that a PDU may span over

Re: [Wireshark-dev] namake build fails fatal error U1073: don't know how to make 'ws_version_info.obj'

2016-05-01 Thread João Valverde
https://code.wireshark.org/review/#/c/15218/ On 28-04-2016 14:37, Anders Broman wrote: cd .. cd wsutil "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\BIN\amd64\nmake. exe" / -f Makefile.nmake Microsoft (R) Program Maintenance Utility

Re: [Wireshark-dev] Commit 3c1f71e: Build error "unused parameter 'ntlm_pass' [-Werror=unused-parameter]"

2016-04-19 Thread João Valverde
On 19-04-2016 20:38, Uli Heilmeier wrote: Hi list, since commit 3c1f71e my build system has failed in compiling the current master. The error is: CC packet-dcerpc-rep_proc.lo packet-dcerpc-netlogon.c: In function 'get_keytab_as_list': packet-dcerpc-netlogon.c:6561:71: error:

Re: [Wireshark-dev] Commit 3c1f71e: Build error "unused parameter 'ntlm_pass' [-Werror=unused-parameter]"

2016-04-19 Thread João Valverde
On 19-04-2016 21:02, Alexis La Goutte wrote: On Tue, Apr 19, 2016 at 9:53 PM, João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>> wrote: On 19-04-2016 20:38, Uli Heilmeier wrote: Hi list, since commit 3c1f71e my buil

Re: [Wireshark-dev] Commit 3c1f71e: Build error "unused parameter 'ntlm_pass' [-Werror=unused-parameter]"

2016-04-19 Thread João Valverde
On 19-04-2016 20:53, João Valverde wrote: On 19-04-2016 20:38, Uli Heilmeier wrote: Hi list, since commit 3c1f71e my build system has failed in compiling the current master. The error is: CC packet-dcerpc-rep_proc.lo packet-dcerpc-netlogon.c: In function 'get_keytab_as_list

Re: [Wireshark-dev] Commit 3c1f71e: Build error "unused parameter 'ntlm_pass' [-Werror=unused-parameter]"

2016-04-20 Thread João Valverde
On 20-04-2016 06:32, ze...@heilmeier.eu wrote: You don't have Kerberos enabled (HAVE_KERBEROS). By the way using an explicit --with-kerberos should throw a configure error if Kerberos isn't found, so I don't know what is going on there. There's a warning I haven't realized when running

Re: [Wireshark-dev] make dist fails if built without Qt

2016-08-01 Thread João Valverde
Should be fixed in https://code.wireshark.org/review/#/c/16826/. On 08/01/2016 01:45 PM, Anders Broman wrote: make[1]: Leaving directory wireshark/trunk/ui/gtk' (cd ui/qt && make top_distdir=../../wireshark-2.3.0 distdir=../../wireshark-2.3.0/ui/qt \ am__remove_distdir=:

Re: [Wireshark-dev] Current Lua test failures on the buildbot

2016-08-10 Thread João Valverde
On 08/07/2016 06:17 PM, Pascal Quantin wrote: 2016-08-07 18:58 GMT+02:00 João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>>: On 08/07/2016 05:23 PM, Hadriel Kaplan wrote: -- Forwarded message --

Re: [Wireshark-dev] build warnings

2016-07-13 Thread João Valverde
On 07/14/2016 02:44 AM, Michael Mann wrote: I've done some investigation into the build warnings generated by the Ubuntu and Windows buildbots. I thought I'd highlight some of the "big offenders" so that if anyone has good ideas on how to fix them, it may lead to thinning the forest out

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread João Valverde
On 08/05/2016 04:03 AM, Michael Mann wrote: I thought I'd try to cut down on some of the "noise" created by checklicenses.py and creating exceptions for files that obviously don't need a license header (COPYING/AUTHORS files in plugins for example). I thought it would simply be a matter of

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread João Valverde
On 08/05/2016 10:45 AM, Guy Harris wrote: On Aug 5, 2016, at 2:00 AM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: On 08/05/2016 08:56 AM, Alexis La Goutte wrote: I confirm ;-) (too slow...) But it is strange don't get the same warning between Ubuntu 14.04 and 16.04..

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread João Valverde
On 08/05/2016 11:50 AM, Guy Harris wrote: On Aug 5, 2016, at 3:36 AM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: On 08/05/2016 11:21 AM, Guy Harris wrote: Should we just grab some version that works and include it in the tools directory, so that we don't get myst

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread João Valverde
of checklicenses.py, should BSD + GPLv2 (only) be whitelisted? The airpcap license situation needs some attention. Cheers Le vendredi 5 août 2016, João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>> a écrit : On 08/05/2016 04:03 AM,

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread João Valverde
On 08/05/2016 11:21 AM, Guy Harris wrote: On Aug 5, 2016, at 2:52 AM, Graham Bloice wrote: I did look a bit for licensecheck and it appears to be a Perl script available as a Debian (and RPM) package devscripts as suggested by João, a package for Debian

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread João Valverde
On 08/05/2016 11:53 AM, João Valverde wrote: On 08/05/2016 11:50 AM, Guy Harris wrote: On Aug 5, 2016, at 3:36 AM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: On 08/05/2016 11:21 AM, Guy Harris wrote: Should we just grab some version that works and include it in the

[Wireshark-dev] Lua 5.3

2016-08-08 Thread João Valverde
Is moving to Lua 5.3 something we should look into? The 64 bit integer support seems really promising. ___ Sent via:Wireshark-dev mailing list Archives:

Re: [Wireshark-dev] checklicenses.py

2016-08-08 Thread João Valverde
On 08/08/2016 10:59 PM, Guy Harris wrote: On Aug 8, 2016, at 12:12 PM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: On 08/08/2016 07:38 PM, Guy Harris wrote: On Aug 8, 2016, at 11:00 AM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: There's a differ

Re: [Wireshark-dev] checklicenses.py

2016-08-08 Thread João Valverde
On 08/08/2016 11:15 PM, Guy Harris wrote: On Aug 8, 2016, at 3:10 PM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: Mainly what I was trying to say is that this dual licensing distinction can already be handled with path-specific exceptions so I guess I'm indifferent to

Re: [Wireshark-dev] checklicenses.py

2016-08-08 Thread João Valverde
On 08/08/2016 06:42 PM, Guy Harris wrote: On Aug 8, 2016, at 9:00 AM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: Is there some reason not to treat "you can license this under the BSD license or under the GPL" as an acceptable license? Please review https://co

Re: [Wireshark-dev] checklicenses.py

2016-08-08 Thread João Valverde
On 08/05/2016 10:31 PM, Guy Harris wrote: On Aug 5, 2016, at 12:17 PM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: The Debian licensecheck.pl version prior to the Smedegaard take over was standalone. I think we should import that to tools. We might still want to loo

Re: [Wireshark-dev] Lua 5.3

2016-08-08 Thread João Valverde
On 08/08/2016 05:58 PM, Pascal Quantin wrote: Hi João, 2016-08-08 18:52 GMT+02:00 João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>>: Is moving to Lua 5.3 something we should look into? The 64 bit integer support seems real

Re: [Wireshark-dev] checklicenses.py

2016-08-08 Thread João Valverde
On 08/08/2016 08:12 PM, João Valverde wrote: On 08/08/2016 07:38 PM, Guy Harris wrote: On Aug 8, 2016, at 11:00 AM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: On 08/08/2016 06:42 PM, Guy Harris wrote: On Aug 8, 2016, at 9:00 AM, João Valverde <j

Re: [Wireshark-dev] checklicenses.py

2016-08-08 Thread João Valverde
On 08/08/2016 07:38 PM, Guy Harris wrote: On Aug 8, 2016, at 11:00 AM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: On 08/08/2016 06:42 PM, Guy Harris wrote: On Aug 8, 2016, at 9:00 AM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: Is there

Re: [Wireshark-dev] Current Lua test failures on the buildbot

2016-08-06 Thread João Valverde
On 08/07/2016 03:47 AM, Guy Harris wrote: Tested on an up-to-date Ubuntu 15.10 system; the test fails. The TShark build information is: TShark (Wireshark) 2.3.0 (v2.3.0rc0-230-ge32890a from master) Copyright 1998-2016 Gerald Combs and contributors.

Re: [Wireshark-dev] checklicenses.py

2016-08-06 Thread João Valverde
et lost in the shuffle because the buildbot appears as if its "passing". The overly generous situation was the extant situation before the recent buildbot upgrades to Ubuntu 16.04. But to eliminate is a one line change -- see the diff I mailed. -Original Mess

Re: [Wireshark-dev] checklicenses.py

2016-08-06 Thread João Valverde
Let me also stress that only doc/*.pod and some airpcap files have the hacky soon-to-be-removed exception. These were grandfathered in. Everything else will still cause hard builbot failures. On 08/06/2016 11:23 PM, João Valverde wrote: On 08/06/2016 11:01 PM, Michael Mann wrote: So

Re: [Wireshark-dev] checklicenses.py

2016-08-06 Thread João Valverde
On 08/06/2016 10:07 PM, Guy Harris wrote: On Aug 6, 2016, at 1:21 PM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: Done in https://code.wireshark.org/review/#/c/16913/. Does "Removed regex to check files without an extension." mean that we are, or aren't

Re: [Wireshark-dev] checklicenses.py

2016-08-06 Thread João Valverde
On 08/05/2016 08:17 PM, João Valverde wrote: On 08/05/2016 11:53 AM, João Valverde wrote: On 08/05/2016 11:50 AM, Guy Harris wrote: On Aug 5, 2016, at 3:36 AM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: On 08/05/2016 11:21 AM, Guy Harris wrote: Should we just gra

Re: [Wireshark-dev] Current Lua test failures on the buildbot

2016-08-07 Thread João Valverde
On 08/07/2016 04:02 AM, João Valverde wrote: On 08/07/2016 03:47 AM, Guy Harris wrote: Tested on an up-to-date Ubuntu 15.10 system; the test fails. The TShark build information is: TShark (Wireshark) 2.3.0 (v2.3.0rc0-230-ge32890a from master) Copyright 1998-2016 Gerald Combs <

Re: [Wireshark-dev] Current Lua test failures on the buildbot

2016-08-07 Thread João Valverde
On 08/07/2016 05:23 PM, Hadriel Kaplan wrote: -- Forwarded message -- From: João Valverde <joao.valve...@tecnico.ulisboa.pt> Date: Sun, Aug 7, 2016 at 2:39 PM Subject: Re: [Wireshark-dev] Current Lua test failures on the buildbot To: Developer support list for Wir

Re: [Wireshark-dev] checklicenses.py

2016-08-08 Thread João Valverde
On 08/05/2016 10:31 PM, Guy Harris wrote: On Aug 5, 2016, at 12:17 PM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: The Debian licensecheck.pl version prior to the Smedegaard take over was standalone. I think we should import that to tools. We might still want to loo

Re: [Wireshark-dev] checklicenses.py

2016-08-08 Thread João Valverde
On 08/09/2016 02:52 AM, Guy Harris wrote: On Aug 8, 2016, at 6:30 PM, João Valverde <joao.valve...@tecnico.ulisboa.pt> wrote: What license, if any, should we put on our man pages? I think we can just use the standard Wireshark GPLv2+ header here, with copyright to Gerald and contri

Re: [Wireshark-dev] Cmake and RPM

2016-08-16 Thread João Valverde
runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool # Suggestion: put this in your ~/.rpmmacros (without the hash sign, of course): # -j16 -j 40 make -j16 exit 0 On Tue, Aug 16, 2016 at 8:53 PM, João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulis

Re: [Wireshark-dev] Cmake and RPM

2016-08-16 Thread João Valverde
anywhere. Should make dist create that? Thanks, Jonne. On Tue, Aug 16, 2016 at 8:42 PM, João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>> wrote: Thanks. Your rpmbuild output looks wrong, I don't know why. Your %prep script should have

Re: [Wireshark-dev] Cmake and RPM

2016-08-16 Thread João Valverde
. $ cat /etc/fedora-release Fedora release 20 (Heisenbug) On Tue, Aug 16, 2016 at 6:32 PM, João Valverde <joao.valve...@tecnico.ulisboa.pt <mailto:joao.valve...@tecnico.ulisboa.pt>> wrote: Now that all the build dependencies are present it seems like you hit two separate build

Re: [Wireshark-dev] Cmake and RPM

2016-08-17 Thread João Valverde
On 08/17/2016 10:39 AM, Jonne Zutt wrote: The "File listed twice" is a known issue I've read, and only a warning. For the Installed (but unpackaged) file, I've added the following to the %files sections of the rpm spec: %exclude %{_libdir}/pkgconfig Hurray! Package successfully built in

  1   2   3   4   >