[X2Go-Dev] [PATCH] build: resolve compile error under g++-4.7

2012-11-20 Thread Jan Engelhardt
sharetray.cpp: In member function 'void ShareTray::handleSigKeybInt()': sharetray.cpp:225:2: error: '::read' has not been declared [...] sharetray.cpp: In static member function 'static void ShareTray::keybintSignalHandler(int)': sharetray.cpp:272:2: error: '::write' has not been declared [...]

Re: [X2Go-Dev] [PATCH] build: resolve compile error under g++-4.7

2012-11-20 Thread Mike Gabriel
Hi Jan, thanks for your patch. The sharetray.cpp includes sys/unistd.h. Isn't your patch a redundancy? Mike On Di 20 Nov 2012 11:52:10 CET Jan Engelhardt wrote: sharetray.cpp: In member function 'void ShareTray::handleSigKeybInt()': sharetray.cpp:225:2: error: '::read' has not been

Re: [X2Go-Dev] [PATCH] build: resolve compile error under g++-4.7

2012-11-20 Thread Jan Engelhardt
On Tuesday 2012-11-20 21:14, Mike Gabriel wrote: Hi Jan, thanks for your patch. The sharetray.cpp includes sys/unistd.h. Isn't your patch a redundancy? It seems 6ffe45d50b3dacb1725e90a985e1876a6ed44c16 already fixed the issue (last version I was on was 3.0.1.4). However, looking at 6ffe...