[X2Go-Dev] Bug#1136: Bug#1136: Bug#1136: Multiple issues with x2gousbmount

2017-01-19 Thread Stefan Baur
Am 19.01.2017 um 10:02 schrieb Mike Gabriel:
>> Because if you *do* call x2goclient [...] --thinclient [...] for that
>> minidesktop session, then the new detection in the subroutine
>> check_x2gothinclientmode will trigger on that as well, so the "|| ..."
>> part would no longer be needed.
> 
> Not sure what you mean by that.

*sigh* ...

Old code: Checks for presence of x2gothinclientd
  (sub check_x2gothinclientd)

New code: Checks for presence of x2goclient with --thinclient option
  (sub check_x2gothinclientmode)

Old code:
if ( check_x2gothinclientd() ||  ( -d
"/usr/share/doc/x2gothinclient-minidesktop" ) )

-> "Either x2gothinclientd is running or directory
/usr/share/doc/x2gothinclient-minidesktop exists"

If, on the Minidesktop, x2goclient would be called with --thinclient,
that line could be shortened to:
if ( check_x2gothinclientmode() )


Pleas pay attention to this: Your statement

> Basically, you don't want x2gousbmount
> interfere with udisks(2) which is what the MATE session manager uses to
> manage pluggable storage devices.

contradicts what the code currently in the X2Go repo (NOT our latest,
suggested changes) is doing - in other words, the present code DOES run
x2goumount when the minidesktop is detected, so it WILL interfere with
udisks/MATE session manager - so either you are wrong, or you have an
issue there.

-Stefan

-- 
BAUR-ITCS UG (haftungsbeschränkt)
Geschäftsführer: Stefan Baur
Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364
Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
http://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1136: Bug#1136: Bug#1136: Multiple issues with x2gousbmount

2017-01-19 Thread Mike Gabriel

On  Mo 16 Jan 2017 16:39:48 CET, Stefan Baur wrote:


Am 16.01.2017 um 16:35 schrieb Mike Gabriel:


The mini desktop is a minimal MATE desktop env running on the thin
client. With that minimal desktop, x2gothinclientd is not used and the
role is taken over by MATE's session manager.

Simple as that.


Does that mean that at the very moment when an USB plug/unplug event is
detected, there is no x2goclient running that has --thinclient set?


Exactly. On the Mini-Desktop based TCE variant, X2Go Client runs in  
"normal" mode. It is launched via a desktop icon (and in the temp  
user's XDG autostart folder).



Because if you *do* call x2goclient [...] --thinclient [...] for that
minidesktop session, then the new detection in the subroutine
check_x2gothinclientmode will trigger on that as well, so the "|| ..."
part would no longer be needed.


Not sure what you mean by that. Basically, you don't want x2gousbmount  
interfere with udisks(2) which is what the MATE session manager uses  
to manage pluggable storage devices.


Mike

--

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de



pgpsJ40OztI_2.pgp
Description: Digitale PGP-Signatur
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
http://lists.x2go.org/listinfo/x2go-dev