[xmail] another batch of source comments

2009-10-14 Thread Oliver Stöneberg
Thanks for the reply on my first mail. Here's a few more notes. SMAILUtils.cpp The function USmlExtractToAddress() is not used at all. SMTPSvr.cpp In the function SMTPFilterMessage() a fflush() is performed before the fclose(). I think this is unncessary as fclose() implies a fflush()

[xmail] Multiple from inside mail headers

2009-10-14 Thread fred
Hello guys, This is not really XMail specific but I am a bit confused there and I need help from experts. Here is the problem, I am using a filter that works with SPF, everything is working fine except one thing. Sometimes forged froms pass through the filter because the filter is getting

Re: [xmail] Multiple from inside mail headers

2009-10-14 Thread CLEMENT Francis
Hello Fred As this is a filter, the choice made to use 'return-path' in place of 'from' is filter specific, not related to xmail To help you we need to know more about this filter, how it works, parameters, ... Self-written filter or found on the net ? Do you have source code for this filter (or

Re: [xmail] Multiple from inside mail headers

2009-10-14 Thread fred
Hi Francis, Thanks for your reply. This is a self-written script that get the following arguments from filter.post-data.tab !aex /mailsrv/MailRoot/filters/spfcheck/spfcheck.php @@FROM @@CRCPT @@REMOTEADDR @@FILE The @@FROM is the actual variable that is checked by this linux

Re: [xmail] Multiple from inside mail headers

2009-10-14 Thread Davide Libenzi
On Wed, 14 Oct 2009, fred wrote: Hello guys, This is not really XMail specific but I am a bit confused there and I need help from experts. Here is the problem, I am using a filter that works with SPF, everything is working fine except one thing. Sometimes forged froms pass through

Re: [xmail] another batch of source comments

2009-10-14 Thread Davide Libenzi
On Wed, 14 Oct 2009, Oliver Stöneberg wrote: Thanks for the reply on my first mail. Here's a few more notes. SMAILUtils.cpp The function USmlExtractToAddress() is not used at all. Right, by it stays. SMTPSvr.cpp In the function SMTPFilterMessage() a fflush() is performed before the

Re: [xmail] Multiple from inside mail headers

2009-10-14 Thread fred
I understand Davide, I knew this wasn't XMail fault, I only wanted to find a solution to prevent these types of forged froms. I will have to add code into my script to parse the message header and look for the From: line, compare this from with the one in the SMTP transaction, if they are

Re: [xmail] Multiple from inside mail headers

2009-10-14 Thread Davide Libenzi
On Wed, 14 Oct 2009, fred wrote: I understand Davide, I knew this wasn't XMail fault, I only wanted to find a solution to prevent these types of forged froms. I will have to add code into my script to parse the message header and look for the From: line, compare this from with the one in

Re: [xmail] another batch of source comments

2009-10-14 Thread Oliver Stöneberg
On Wed, 14 Oct 2009, Oliver Stöneberg wrote: Thanks for the reply on my first mail. Here's a few more notes. SMAILUtils.cpp The function USmlExtractToAddress() is not used at all. Right, by it stays. Like the others just FYI. SMTPSvr.cpp In the function SMTPFilterMessage() a