Re: [xmlsec] XMLSec & CMake
Thank you, Miklos and Sven. I've updated the INSTALL file: https://github.com/lsh123/xmlsec/commit/d24c9bd55a7b4eba0cf82005e2494d5f10f490d6 (first change to this file in 19 years :) :) :) ). Aleksey On 7/8/20 10:28 PM, Sven Paschukat wrote: Yes, this a good approach. Sven *Von:* xmlsec *Im Auftrag von *Miklos Vajna *Gesendet:* Mittwoch, 8. Juli 2020 19:12 *An:* Aleksey Sanin *Cc:* xmlsec@aleksey.com *Betreff:* Re: [xmlsec] XMLSec & CMake Hi, FWIW, I build libxmlsec using cmake like this in odfsig: https://github.com/vmiklos/odfsig/tree/master/extern/xmlsec This has the benefit that no changes are needed to the cmake side if the autotools files e.g. add new .c files. (This uses cng and nss, but could do the same for openssl as well.) Regards, Miklos ___ xmlsec mailing list xmlsec@aleksey.com http://www.aleksey.com/mailman/listinfo/xmlsec ___ xmlsec mailing list xmlsec@aleksey.com http://www.aleksey.com/mailman/listinfo/xmlsec
Re: [xmlsec] XMLSec & CMake
Yes, this a good approach. Sven Von: xmlsec Im Auftrag von Miklos Vajna Gesendet: Mittwoch, 8. Juli 2020 19:12 An: Aleksey Sanin Cc: xmlsec@aleksey.com Betreff: Re: [xmlsec] XMLSec & CMake Hi, FWIW, I build libxmlsec using cmake like this in odfsig: https://github.com/vmiklos/odfsig/tree/master/extern/xmlsec This has the benefit that no changes are needed to the cmake side if the autotools files e.g. add new .c files. (This uses cng and nss, but could do the same for openssl as well.) Regards, Miklos ___ xmlsec mailing list xmlsec@aleksey.com http://www.aleksey.com/mailman/listinfo/xmlsec
Re: [xmlsec] XMLSec & CMake
Feel free to link to vcpkg (https://github.com/microsoft/vcpkg). Sven > -Ursprüngliche Nachricht- > Von: Aleksey Sanin > Gesendet: Mittwoch, 8. Juli 2020 17:02 > An: Sven Paschukat ; xmlsec@aleksey.com > Betreff: Re: AW: [xmlsec] XMLSec & CMake > > Thanks! I looked at the PR: > > https://github.com/lsh123/xmlsec/pull/296/files > > And it is already complex and there are a few things that I feel have to be > added > (e.g. libxslt support). > > If it is OK with you then I would prefer to add a link to the vcpkg (can you > share > it?) to the README and website instead of adding a new build method to the > package. > > Thanks, > > Aleksey > > On 7/8/20 7:04 AM, Sven Paschukat wrote: > > Did so. > > > > Yes, this is not perfect, but for my scenario it's quite easy to build: > > - Cloning vcpkg > > - Building vcpkg > > - Command: vcpkg install xmlsec > > > > I've chosen OpenSSL because it's contained in most platforms. One have to > dive into CMakes capabilities to choose libraries platform dependent, but > that's > out of my scope at the moment. > > > > No problem if you hesitate, vcpkg already has a contribution of that script. > > > > Sven > > > >> -----Ursprüngliche Nachricht- > >> Von: Aleksey Sanin > >> Gesendet: Wednesday, 8 July 2020 01:01 > >> An: Sven Paschukat ; xmlsec@aleksey.com > >> Betreff: Re: [xmlsec] XMLSec & CMake > >> > >> Sure. Though I am hesitant about having 2 build systems :) > >> > >> Can you send a PR? I would like to understand how complex is it. > >> Also, how hard would it be to support more than just openssl? > >> E.g. on Windows I believe many people are using MS APIs. > >> > >> Aleksey > >> > >> On 7/7/20 9:27 AM, Sven Paschukat wrote: > >>> Hi, > >>> > >>> I've written a CMake configuration file (CMakeLists.txt) that is > >>> able to compile > >> XMLSec library on different platforms. It's not that configurable as > >> the original configuration script. For example, it always requires > >> OpenSSL, and it's not prepared to receive compiler options like xslt > >> or iconv. But it integrates good into a CMake build environment and > >> especially good into Microsofts vcpkg framework, in order to get rid of the > dependency management. > >>> > >>> At the moment, the CMakeLists.txt is contributed into the build > >>> process from > >> the vcpkg environment, but it would be good if we could include it > >> directly into the XMLSec sources. If I prepare a PR, do you would accept > >> it in > general? > >>> > >>> Regards, > >>> > >>> Sven > >>> > >>> ___ > >>> xmlsec mailing list > >>> xmlsec@aleksey.com > >>> http://www.aleksey.com/mailman/listinfo/xmlsec > >>> ___ xmlsec mailing list xmlsec@aleksey.com http://www.aleksey.com/mailman/listinfo/xmlsec
Re: [xmlsec] XMLSec & CMake
Hi, FWIW, I build libxmlsec using cmake like this in odfsig: https://github.com/vmiklos/odfsig/tree/master/extern/xmlsec This has the benefit that no changes are needed to the cmake side if the autotools files e.g. add new .c files. (This uses cng and nss, but could do the same for openssl as well.) Regards, Miklos ___ xmlsec mailing list xmlsec@aleksey.com http://www.aleksey.com/mailman/listinfo/xmlsec
Re: [xmlsec] XMLSec & CMake
Thanks! I looked at the PR: https://github.com/lsh123/xmlsec/pull/296/files And it is already complex and there are a few things that I feel have to be added (e.g. libxslt support). If it is OK with you then I would prefer to add a link to the vcpkg (can you share it?) to the README and website instead of adding a new build method to the package. Thanks, Aleksey On 7/8/20 7:04 AM, Sven Paschukat wrote: Did so. Yes, this is not perfect, but for my scenario it's quite easy to build: - Cloning vcpkg - Building vcpkg - Command: vcpkg install xmlsec I've chosen OpenSSL because it's contained in most platforms. One have to dive into CMakes capabilities to choose libraries platform dependent, but that's out of my scope at the moment. No problem if you hesitate, vcpkg already has a contribution of that script. Sven -Ursprüngliche Nachricht- Von: Aleksey Sanin Gesendet: Wednesday, 8 July 2020 01:01 An: Sven Paschukat ; xmlsec@aleksey.com Betreff: Re: [xmlsec] XMLSec & CMake Sure. Though I am hesitant about having 2 build systems :) Can you send a PR? I would like to understand how complex is it. Also, how hard would it be to support more than just openssl? E.g. on Windows I believe many people are using MS APIs. Aleksey On 7/7/20 9:27 AM, Sven Paschukat wrote: Hi, I've written a CMake configuration file (CMakeLists.txt) that is able to compile XMLSec library on different platforms. It's not that configurable as the original configuration script. For example, it always requires OpenSSL, and it's not prepared to receive compiler options like xslt or iconv. But it integrates good into a CMake build environment and especially good into Microsofts vcpkg framework, in order to get rid of the dependency management. At the moment, the CMakeLists.txt is contributed into the build process from the vcpkg environment, but it would be good if we could include it directly into the XMLSec sources. If I prepare a PR, do you would accept it in general? Regards, Sven ___ xmlsec mailing list xmlsec@aleksey.com http://www.aleksey.com/mailman/listinfo/xmlsec ___ xmlsec mailing list xmlsec@aleksey.com http://www.aleksey.com/mailman/listinfo/xmlsec
Re: [xmlsec] XMLSec & CMake
Sure. Though I am hesitant about having 2 build systems :) Can you send a PR? I would like to understand how complex is it. Also, how hard would it be to support more than just openssl? E.g. on Windows I believe many people are using MS APIs. Aleksey On 7/7/20 9:27 AM, Sven Paschukat wrote: Hi, I've written a CMake configuration file (CMakeLists.txt) that is able to compile XMLSec library on different platforms. It's not that configurable as the original configuration script. For example, it always requires OpenSSL, and it's not prepared to receive compiler options like xslt or iconv. But it integrates good into a CMake build environment and especially good into Microsofts vcpkg framework, in order to get rid of the dependency management. At the moment, the CMakeLists.txt is contributed into the build process from the vcpkg environment, but it would be good if we could include it directly into the XMLSec sources. If I prepare a PR, do you would accept it in general? Regards, Sven ___ xmlsec mailing list xmlsec@aleksey.com http://www.aleksey.com/mailman/listinfo/xmlsec ___ xmlsec mailing list xmlsec@aleksey.com http://www.aleksey.com/mailman/listinfo/xmlsec
