Hi Peter,
looks pretty good to me.
One tiny nit however: E.g. in eventconvert.c there are switch statements
which go like
switch(EventType){
...big list of labels for one thing...: do it; break;
}
So essentially, I guess, you're checking for some commonality, or
property. Centralizing such
Fix some of the warnings produced by recently added warnings flags
Fixes to integration with native clipboard from Colin Harrison
Update mapping table for translating native keyboard layouts to X keyboard
configurations
Colin Harrison (7):
Xming: Add Colin Harrison to copyright and authors
Fix old-style definition warnings caused by definitions with empty
parameter lists (), which should be (void) to indicate the function
takes no parameters, rather than unspecified parameters
Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk
---
hw/xwin/InitOutput.c |2 +-
Fix prototypes of winOverrideIcon(), winTaskbarIcon() and
winOverrideDefaultIcon() to return HICON
Also use HICON type in WINPREFS stucture
Remove various casts these changes make unnecessary
Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk
---
hw/xwin/winmultiwindowicons.c|6
Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk
---
hw/xwin/winconfig.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/xwin/winconfig.c b/hw/xwin/winconfig.c
index a9c4c46..3e1908c 100644
--- a/hw/xwin/winconfig.c
+++ b/hw/xwin/winconfig.c
@@ -563,8 +563,6 @@
---
exa/Makefile.am |3 ++-
exa/exa_accel.c | 44 ++--
exa/exa_priv.h |6 +-
exa/exa_render.c| 14 --
exa/exa_unaccel.c | 15 +++
fb/fbcopy_helpers.c |6 +++---
fb/fbcopy_helpers.h | 12
On Wed, Feb 4, 2009 at 8:32 AM, Michel Dänzer mic...@daenzer.net wrote:
On Wed, 2009-02-04 at 00:29 +0100, Maarten Maathuis wrote:
I hope the changes are coming to an end. I still need to know if there
are any external users of fbDoCopy that would care for a wrapper. I'm
assuming that
On Wed, 2009-02-04 at 13:38 +0100, Alexander Larsson wrote:
I found what I think is a bug in XCopyArea.
If you copy a pixmap to a window and some of the copied area is outside
the pixmap then that area in the destination window is cleared to the
background color (and possibly graphics
From: Colin Harrison colin.harri...@virgin.net
Free the memory allocated for ReturnData in FlushXEvents().
Copyright (C) Colin Harrison 2005-2008
http://www.straightrunning.com/XmingNotes/
http://sourceforge.net/projects/xming/
Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk
---
The functions are declared static in Xtransint.h but are defined
in Xtransutil.c. So when someone (xserver/os/connection.c)
incuded Xtransint.h, gcc would throw the warning.
I removed the declarations from the header and rearranged includes
in transport.c so that Xtransutil.c is included just
Em Tuesday 03 February 2009 20:16:59 Colin Guthrie escreveu:
'Twas brillig, and Ander Conselvan de Oliveira at 03/02/09 18:21 did
gyre and gimble:
Hi,
I'm having a problem with xrandr 1.2.99.4, X server from 1.6 branch and
drivers that only support RandR 1.1. The server reports it
From: Colin Harrison colin.harri...@virgin.net
An update to the keyboard layout mapping table which updates some no longer
valid keyboard layout names
(e.g. de_CH - ch -variant de) and adds a few more reported layouts
Copyright (C) Colin Harrison 2005-2008
From: Colin Harrison colin.harri...@virgin.net
Improve clipboard integration startup in XDMCP mode
Stop the Clipboard not yet started, aborting message from spamming the log.
Copyright (C) Colin Harrison 2005-2008
http://www.straightrunning.com/XmingNotes/
http://sourceforge.net/projects/xming/
Fixes warning as prototype is now in scope for the definition
Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk
---
hw/xwin/win.h |2 ++
hw/xwin/winmultiwindowwindow.c |2 --
hw/xwin/winwin32rootless.c |3 ---
3 files changed, 2 insertions(+), 5 deletions(-)
From: Colin Harrison colin.harri...@virgin.net
Function 'winProcessXEventsTimeout()' is declared 'static Bool' and
defined 'static int' (correct) in 'winclipboardwndproc.c'. This has been
wrong since dot, but luckily was of no significance
Copyright (C) Colin Harrison 2005-2008
From: Colin Harrison colin.harri...@virgin.net
The clipboard should only select PropertyChange events and do this on
the correct window, the messaging window for the clipboard not the root
window!
Copyright (C) Colin Harrison 2005-2008
http://www.straightrunning.com/XmingNotes/
From: Colin Harrison colin.harri...@virgin.net
Add Colin Harrison to copyright and authors list
Adjust license text for multiple authors
Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk
---
hw/xwin/winclipboardthread.c | 10 ++
hw/xwin/winclipboardwndproc.c | 10 ++
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
static char* __xtransname = ...;
The variable is initialized to different strings depending on
a preprocessor define. A different fix would be to make __xtransname
itself a preprocessor define. But I think the following fix does
work equally
Glynn Clements gl...@gclements.plus.com writes:
Tristan Schmelcher wrote:
Hello all. Sorry if this is not the right place to send this, but I'm
developing a plugin for Firefox on Linux and I've run up against a
roadblock. In my plugin I'm being passed a pointer to an X Display struct
(in
From: Colin Harrison colin.harri...@virgin.net
When you take ownership of a selection you should always check you got
it (X11 ICCCM gospel).
Copyright (C) Colin Harrison 2005-2008
http://www.straightrunning.com/XmingNotes/
http://sourceforge.net/projects/xming/
Signed-off-by: Jon TURNEY
Fixes warnings as they are now in scope at the definition
Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk
---
hw/xwin/win.h|5 +
hw/xwin/winwndproc.c |4
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/hw/xwin/win.h b/hw/xwin/win.h
index
I found what I think is a bug in XCopyArea.
If you copy a pixmap to a window and some of the copied area is outside
the pixmap then that area in the destination window is cleared to the
background color (and possibly graphics exposes are sent).
If the GC has a clip region set so that the
After testing with a few other options, I come back
to the old method of attaching a git format-patch
formatted file to the message, and adding some intial
comments. So that it would also make it easier to specify
in the subject what repository the patch should be applied.
Another option
I think it would be better to restore the definition of FamilyKrb5Principal
to libXau - while it may not be used by the current code, it is
defined/reserved for Kerberos5 and if a new implementation of that code
was done using current API's, we'd presumably want to use the same family
id for it.
hw/xfree86/common/xf86Helper.c:
Check the return value from setpriority() and nice() and print
a warning if either fails.
hw/xfree86/os-support/linux/lnx_init.c:
Check the return value from chown() and print a warning if it
fails.
os/utils.c:
Check the return value from write() when writing the
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
Peter, I removed the cast, it seems superfluous. But if you insist
on using a cast, please change it to (long).
dix/enterleave.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/dix/enterleave.c
By first casting to long and then to the final type. Of course
this assumes that sizeof(long) == sizeof(void *). If the Win32
folks care enough about warnings, we could make macros for this.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
Let's suppose macros would be preferred, into which
These cases should really be addressed in a different
way, as the addition of a option that is only useful to
pass distcheck is wrong.
Another cosmetic thing that should be addressed is
usage of something like:
PKG_CHECK_MODULES(XORG, xorg-server xproto $REQUIRED_MODULES)
Alan Coopersmith wrote:
I think it would be better to restore the definition of
FamilyKrb5Principal
to libXau - while it may not be used by the current code, it is
defined/reserved for Kerberos5 and if a new implementation of that code
was done using current API's, we'd presumably want to use
On Wed, Feb 04, 2009 at 08:43:43PM +0100, Tomas Carnecky wrote:
By first casting to long and then to the final type. Of course
this assumes that sizeof(long) == sizeof(void *). If the Win32
folks care enough about warnings, we could make macros for this.
Please use either uintptr_t (prefered)
On Wed, Feb 04, 2009 at 08:36:49PM +0100, Tomas Carnecky wrote:
diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c
index 732a1fd..6b9b8f0 100644
--- a/hw/xfree86/common/xf86Helper.c
+++ b/hw/xfree86/common/xf86Helper.c
@@ -2738,5 +2738,5 @@ int
On 02/04/2009 09:00 PM, Thomas Dickey wrote:
On Wed, Feb 04, 2009 at 08:36:49PM +0100, Tomas Carnecky wrote:
diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c
index 732a1fd..6b9b8f0 100644
--- a/hw/xfree86/common/xf86Helper.c
+++ b/hw/xfree86/common/xf86Helper.c
@@
The same solution proposed in xf86-input-evdev was used to
correct make distcheck. This may not be the best solution as
someone compiling from source may think the option should be
used :-)
From a98e4825b3268e3b57402dd64b5a3621159965cb Mon Sep 17 00:00:00 2001
From: Paulo Cesar Pereira de
This patch corrects most gcc/sparse warnings.
The correction for code in format:
if (a = b)
rel = a - b;
if (a = b)
rel = b - a;
rel = rel / foo;
was changed to the logical equivalent, and clear
to read, but also corrected the warning about rel
possibly being used uninitialized :-)
From
When libXfont is talking to a font server, it doesn't initialize padding
bytes.
Rgds,
---
Peter Åstrand ThinLinc Chief Developer
Cendio AB http://www.cendio.com
Wallenbergs gata 4
583 30 LinköpingPhone: +46-13-21 46 00From
The only other information I could see to query in the Composite 0.4
protocol spec is the Composite Overlay Window XID, but the request to
get that ID has the side effect of mapping the overlay window, and
xdpyinfo shouldn't have side effects like that.
Signed-off-by: Alan Coopersmith
Tomas Carnecky wrote:
It's the source of many useless warnings.
It was my suggestion to Peter to add -Wbad-function-cast
(and a few others). I am not sure if the proper solution
to the warnings is to not generate them :-)
As I understand this option, the proper solution is
of course not to
On Tue, Feb 03, 2009 at 11:54:53PM +0100, Tomas Carnecky wrote:
diff --git a/dix/events.c b/dix/events.c
index 0c8d198..2a35aa3 100644
--- a/dix/events.c
+++ b/dix/events.c
@@ -4611,7 +4611,6 @@ ProcQueryPointer(ClientPtr client)
xQueryPointerReply rep;
WindowPtr pWin, t;
On Wed, Feb 04, 2009 at 12:02:24AM +0100, Tomas Carnecky wrote:
Add parenthesis around the whole expression.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
glx/indirect_dispatch.c |2 +-
glx/indirect_dispatch_swap.c |2 +-
2 files changed, 2 insertions(+), 2
Another trivial patch.
From 9d37cb0dd0841f9135727c81c63fc4cc0b510396 Mon Sep 17 00:00:00 2001
From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br
Date: Wed, 4 Feb 2009 19:30:26 -0200
Subject: [PATCH] Janitor: make distcheck, .gitignore.
Make distcheck is corrected by requiring a newer
On Mon, 2009-02-02 at 23:02 +0100, Tomas Carnecky wrote:
--
bigreq.c:46: warning: no previous prototype for ‘BigReqExtensionInit’
sync.c:2124: warning: no previous prototype for ‘SyncExtensionInit’
xcmisc.c:59: warning: no
On Wed, Feb 04, 2009 at 05:48:01PM -0200, Paulo César Pereira de Andrade wrote:
These cases should really be addressed in a different
way, as the addition of a option that is only useful to
pass distcheck is wrong.
Another cosmetic thing that should be addressed is
usage of something
On Wed, Feb 04, 2009 at 08:18:38PM +0100, Tomas Carnecky wrote:
glx/indirect_texture_compression.c:
I assumed that CALL_GetTexLevelParameteriv() does not overwrite
compsize in case an error occurs.
The changes in this patch are not strictly necessary for correctness.
If they quiet some
On Wed, Feb 4, 2009 at 12:07 PM, Paulo César Pereira de Andrade
p...@mandriva.com.br wrote:
The toplevel .gitignore extra entries are to
match those that earlier were from subdirectories,
and to include files left by make distcheck.
Maybe I'm being dense, but you've replace CFLAGS with
This is another trivial patch, that updates
the microtouch driver to match changes to other
packages, to correct make distcheck and use
a single .gitignore file.
From 0b82c67edad92faf73506b7a7ee1d758a7599ac2 Mon Sep 17 00:00:00 2001
From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br
Date:
On Wed, Feb 04, 2009 at 09:04:05PM +0100, Joerg Sonnenberger wrote:
On Wed, Feb 04, 2009 at 08:43:43PM +0100, Tomas Carnecky wrote:
By first casting to long and then to the final type. Of course
this assumes that sizeof(long) == sizeof(void *). If the Win32
folks care enough about warnings,
On Wed, Feb 04, 2009 at 10:39:36PM +0100, Tomas Carnecky wrote:
It's the source of many useless warnings.
If it's only reporting false-positives, then this seems sensible.
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
It causes warnings for code like:
int i = (int)
On Mon, 2009-01-26 at 20:40 +, Colin Harrison wrote:
Hi,
The XKB extension is now hardwired enabled in the xserver
Shouldn't the kb options be also removed from XkbUseMsg() ?
Indeed. Done (and also nuked from man page), thanks.
- ajax
signature.asc
Description: This is a digitally
On Wed, Feb 04, 2009 at 02:10:36PM -0800, Ian Romanick wrote:
On Wed, Feb 04, 2009 at 09:04:05PM +0100, Joerg Sonnenberger wrote:
On Wed, Feb 04, 2009 at 08:43:43PM +0100, Tomas Carnecky wrote:
By first casting to long and then to the final type. Of course
this assumes that sizeof(long)
On Tue, 2009-01-27 at 00:56 +0100, mailingli...@openelec.tv wrote:
Hi, when i am build xorg server svn with uclibc-svn and kernel
2.6.28.1 i have follow error:
uclibc is insufficiently macho. Try getting a real C library. Failing
that, add the syscall to uclibc.
- ajax
signature.asc
Dan Nicholson wrote:
These cases should really be addressed in a different
way, as the addition of a option that is only useful to
pass distcheck is wrong.
For the patch, please use backticks (``) rather than $() for command
substitution since it's more portable. Also, please use the
On Wed, Feb 4, 2009 at 2:01 PM, Paulo César Pereira de Andrade
p...@mandriva.com.br wrote:
Another trivial patch.
Looking at another one of these, I see small nit.
configure.ac:
XORG_CFLAGS=$XORG_CFLAGS $CWARNFLAGS
Makefile.am:
AM_CFLAGS = $(XORG_CFLAGS)
It would be nicer if it was just
On Fri, 2009-01-30 at 17:18 -0500, Thomas Jaeger wrote:
I don't know if anyone's still using this hardware. My main motivation
here is to make sure that drivers implement the various repeat modes in
exa's composite operation correctly (that is, fall back to software if
they don't), so that
Peter Hutterer wrote:
or maybe in the same line, but not really a xorg issue,
but a pkg-config issue?
I'll merge such a patch if you have one for me.
This should be corrected (if really an issue) in pkgconfig:
% rpm -qf /usr/share/aclocal/pkg.m4
pkgconfig-0.23-4mdv2009.1
how is this
On Sat, 2009-01-31 at 13:22 -0500, Matt Turner wrote:
Hi,
xf86ReadMmio{8,16} both return a 32-bit int. Should the result be zero
or sign extended?
Zero, if I had to pick. The things you're reading are like as not to be
bitfields, so it's not like sign extension would be meaningful. But
On Wed, Feb 4, 2009 at 2:25 PM, Paulo César Pereira de Andrade
p...@mandriva.com.br wrote:
Dan Nicholson wrote:
These cases should really be addressed in a different
way, as the addition of a option that is only useful to
pass distcheck is wrong.
For the patch, please use backticks (``)
On Wed, Feb 04, 2009 at 05:07:26PM -0200, Paulo César Pereira de Andrade wrote:
After testing with a few other options, I come back
to the old method of attaching a git format-patch
formatted file to the message, and adding some intial
comments. So that it would also make it easier to
On Wed, Feb 04, 2009 at 06:25:47PM -0200, Paulo César Pereira de Andrade wrote:
The gratuitous move of the lines
DRIVER_NAME=foo
AC_SUBST([DRIVER_NAME])
is to better match the pattern used in video drivers.
But maybe it would be better to either actually
try to use a solution that
This commit causes a regression in dynamic display configuration with the
NVIDIA driver, where trying to switch to a new configuration with
nvidia-settings fails. The problem is that nvidia-settings adds the new
mode to the list, then queries the mode pool with RRGetScreenInfo. This
now fails to
On Wed, Feb 04, 2009 at 07:05:42PM -0200, Paulo César Pereira de Andrade wrote:
From 2e2ba17bbc5ef92fd52a85b53341651d79411332 Mon Sep 17 00:00:00 2001
From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br
Date: Wed, 4 Feb 2009 18:33:57 -0200
Subject: [PATCH] Janitor: change
Ian Romanick wrote:
On Wed, Feb 04, 2009 at 05:07:26PM -0200, Paulo César Pereira de Andrade
wrote:
After testing with a few other options, I come back
to the old method of attaching a git format-patch
formatted file to the message, and adding some intial
comments. So that it would also
Peter Hutterer wrote:
On Wed, Feb 04, 2009 at 07:05:42PM -0200, Paulo César Pereira de Andrade
wrote:
From 2e2ba17bbc5ef92fd52a85b53341651d79411332 Mon Sep 17 00:00:00 2001
From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br
Date: Wed, 4 Feb 2009 18:33:57 -0200
Subject: [PATCH]
On Wed, Feb 04, 2009 at 07:39:52PM -0200, Paulo César Pereira de Andrade wrote:
This is a pure janitor patch, and should be
trivial enough.
But to not leave an empty email :-) I commented
about the warnings generated due to no previous
prototype for the symbols that dlloader uses when
On Wed, Feb 04, 2009 at 07:33:37PM -0200, Paulo César Pereira de Andrade wrote:
I built and posted this patch a few days ago, after some
of the complaints about xf86-input-keyboard not compilable
in git master.
The only known missing feature is that auto repeat doesn't
work, as it is
Dan Nicholson wrote:
Another trivial patch.
Looking at another one of these, I see small nit.
configure.ac:
XORG_CFLAGS=$XORG_CFLAGS $CWARNFLAGS
Makefile.am:
AM_CFLAGS = $(XORG_CFLAGS)
It would be nicer if it was just
Makefile.am:
AM_CFLAGS = $(XORG_CFLAGS) $(CWARNFLAGS)
Then I
On Wed, Feb 04, 2009 at 08:51:59PM -0200, Paulo César Pereira de Andrade wrote:
Peter Hutterer wrote:
On Wed, Feb 04, 2009 at 07:05:42PM -0200, Paulo César Pereira de Andrade
wrote:
From 2e2ba17bbc5ef92fd52a85b53341651d79411332 Mon Sep 17 00:00:00 2001
From: Paulo Cesar Pereira de Andrade
On Wed, Feb 04, 2009 at 08:20:24PM +0100, Tomas Carnecky wrote:
Signed-off-by: Tomas Carnecky t...@dbservice.com
---
Peter, I removed the cast, it seems superfluous. But if you insist
on using a cast, please change it to (long).
That's a leftover that didn't get removed in the final
On Wed, Feb 04, 2009 at 01:56:08PM -0800, Ian Romanick wrote:
On Tue, Feb 03, 2009 at 11:54:53PM +0100, Tomas Carnecky wrote:
diff --git a/dix/events.c b/dix/events.c
index 0c8d198..2a35aa3 100644
--- a/dix/events.c
+++ b/dix/events.c
@@ -4611,7 +4611,6 @@ ProcQueryPointer(ClientPtr
On Tue, Feb 03, 2009 at 11:54:53PM +0100, Tomas Carnecky wrote:
events.c:4614: warning: unused variable ‘kbd’
xkbUtils.c:361: warning: unused variable ‘maxKeysPerMod’
xf86Events.c:409: warning: unused variable ‘ke’
generic.c:131: warning: unused variable ‘cs’
generic.c:130: warning: unused
Update .gitignore for files remaining after make and
make distcheck, as well as entry for the default tags file.
Also, from this patch on at least, start using non
bash'isms (because it is how it is done in other packages)
and use $PKG_CONFIG to better work on some build environments
(as
On Wed, Feb 4, 2009 at 2:23 PM, Adam Jackson a...@nwnk.net wrote:
uclibc is insufficiently macho. Try getting a real C library. Failing
that, add the syscall to uclibc.
If you are determined to use uClibc, you'll want to look at
TinyX/Kdrive ... which are horribly unmaintained and
On 02/05/2009 12:18 AM, Peter Hutterer wrote:
On Tue, Feb 03, 2009 at 11:54:53PM +0100, Tomas Carnecky wrote:
events.c:4614: warning: unused variable ‘kbd’
xkbUtils.c:361: warning: unused variable ‘maxKeysPerMod’
xf86Events.c:409: warning: unused variable ‘ke’
generic.c:131: warning: unused
On Wed, Feb 04, 2009 at 12:06:45PM +0100, Simon Thum wrote:
looks pretty good to me.
One tiny nit however: E.g. in eventconvert.c there are switch statements
which go like
switch(EventType){
...big list of labels for one thing...: do it; break;
}
So essentially, I guess, you're
On Wed, Feb 4, 2009 at 3:21 PM, Paulo César Pereira de Andrade
p...@mandriva.com.br wrote:
Update .gitignore for files remaining after make and
make distcheck, as well as entry for the default tags file.
Also, from this patch on at least, start using non
bash'isms (because it is how it is
On 3 Feb 2009, Dan Nicholson uttered the following:
The output isn't quite what I'd expect, but I think this is because
it's using the builtin fonts only. Try rebuilding the server with
--disable-builtin-fonts, or apply this patch that's a candidate for
augh! blasted --disable-builtin-fonts,
On Thu, Feb 05, 2009 at 03:45:51PM +1000, Peter Hutterer wrote:
If HAL isn't available when we try to connect, register a NameOwnerChanged
handler and wait until HAL is available. This allows HAL to be started in
parallel or after the server has started.
Eric pointed out that there's a time
76 matches
Mail list logo
