Re: [PATCH] Removal of a needless null statement

2008-11-08 Thread James Cloos
Fernando == Fernando Carrijo [EMAIL PROTECTED] writes: Fernando This patch removes an unnecessary null statement from xserver master. Thanks for the report. I found several others and did a general s/;;$/;/. Pushed in commit b3c7e62664457a3802ebc23785446051624a8c2f. -JimC -- James Cloos

Re: [PATCH] Removal of a needless null statement

2008-11-08 Thread James Cloos
Fernando == Fernando Carrijo [EMAIL PROTECTED] writes: Fernando ... and there are still others. XCB and libX11, to list a few! Yes, we have to look in the other repos as well. Git grep makes is relatively easy, but only works one repo at a time. I'll get the ones in app and lib, but I lack

Re: [PATCH] Removal of a needless null statement

2008-11-08 Thread Paulo César Pereira de Andrade
Fernando == Fernando Carrijo [EMAIL PROTECTED] writes: Fernando ... and there are still others. XCB and libX11, to list a few! Yes, we have to look in the other repos as well. Git grep makes is relatively easy, but only works one repo at a time. I'll get the ones in app and lib, but I

Re: [PATCH] Removal of a needless null statement

2008-11-08 Thread James Cloos
Paulo == Paulo César Pereira de Andrade [EMAIL PROTECTED] writes: Paulo I remember there were also a few cases of code like: Paulo #define macro(object) (object)-field; Paulo that would generate warnings of mixed code and declarations Indeed. There was one instance of which I was initially