xorg/driver/xf86-input-evdev: [PATCH] Correct make distchek using the same solution used in other packages.

2009-02-04 Thread Paulo César Pereira de Andrade
These cases should really be addressed in a different way, as the addition of a option that is only useful to pass distcheck is wrong. Another cosmetic thing that should be addressed is usage of something like: PKG_CHECK_MODULES(XORG, xorg-server xproto $REQUIRED_MODULES)

Re: xorg/driver/xf86-input-evdev: [PATCH] Correct make distchek using the same solution used in other packages.

2009-02-04 Thread Peter Hutterer
On Wed, Feb 04, 2009 at 05:48:01PM -0200, Paulo César Pereira de Andrade wrote: These cases should really be addressed in a different way, as the addition of a option that is only useful to pass distcheck is wrong. Another cosmetic thing that should be addressed is usage of something

Re: xorg/driver/xf86-input-evdev: [PATCH] Correct make distchek using the same solution used in other packages.

2009-02-04 Thread Paulo César Pereira de Andrade
Dan Nicholson wrote: These cases should really be addressed in a different way, as the addition of a option that is only useful to pass distcheck is wrong. For the patch, please use backticks (``) rather than $() for command substitution since it's more portable. Also, please use the

Re: xorg/driver/xf86-input-evdev: [PATCH] Correct make distchek using the same solution used in other packages.

2009-02-04 Thread Paulo César Pereira de Andrade
Peter Hutterer wrote: or maybe in the same line, but not really a xorg issue, but a pkg-config issue? I'll merge such a patch if you have one for me. This should be corrected (if really an issue) in pkgconfig: % rpm -qf /usr/share/aclocal/pkg.m4 pkgconfig-0.23-4mdv2009.1 how is this

Re: xorg/driver/xf86-input-evdev: [PATCH] Correct make distchek using the same solution used in other packages.

2009-02-04 Thread Dan Nicholson
On Wed, Feb 4, 2009 at 2:25 PM, Paulo César Pereira de Andrade p...@mandriva.com.br wrote: Dan Nicholson wrote: These cases should really be addressed in a different way, as the addition of a option that is only useful to pass distcheck is wrong. For the patch, please use backticks (``)