Re: Current tinderbox regression (libtrans)

2009-02-09 Thread Paulo César Pereira de Andrade
Alan Coopersmith wrote: I don't see any errors or problems there in my builds, but perhaps there's a difference between the Solaris Linux headers that causes this issue. I did have to move the X11/Xos_r.h to before that function to correct errors that I did hit in the Solaris builds, which

Re: [PATCH] Revert Fix XXX declared 'static' but not defined

2009-02-08 Thread Paulo César Pereira de Andrade
Benjamin Close wrote: I don't see anything wrong as it reverts to a version known to work, but from a quick test, without rebuilding everything, just libICE and libFS, it should be enough to move the definition of is_numeric and trans_mkdir to the start of Xtranssock.c (the revert in

Re: xorg/driver/xf86-video-ast: [PATCH 1/2] Janitor: make distcheck, .gitignore.

2009-02-06 Thread Paulo César Pereira de Andrade
Dan Nicholson wrote: I think I reviewed all the non-code patches and they looked fine except for a couple I replied on. Most of the warning fixes seemed fine to me, too, but I'd be lying if I said I was the master of the C specification or knowing the xserver SDK. Thanks, So, I think you

Janitor/RFC: Xorg packages

2009-02-06 Thread Paulo César Pereira de Andrade
Some points that could be made better: 1. Get rid of configure options that should not be used, and are only useful for make distcheck. I think it may be one case where AC_SUBST() can have an important role in the proper solution? 2. Replace most gratuitous AC_SUBST(VAR) by usage

driver/xf86-input-mutouch: [PATCH] Janitor: make distcheck, .gitignore.

2009-02-05 Thread Paulo César Pereira de Andrade
Use `` instead of $(). Use $PKG_CONFIG to honor user build setup. Replace ChangeLog with automatically generated version, this is also the make distcheck correction. Don't add $CWARNFLAGS to $XORG_FLAGS, as suggested by Dan Nicholson, so one could write: % make CWARNFLAGS='-Werror' or the

Re: xorg/driver/xf86-input-jamstudio: [PATCH] Janitor: make distcheck, .gitignore.

2009-02-05 Thread Paulo César Pereira de Andrade
Tiago Vignatti wrote: The gratuitous move of the lines DRIVER_NAME=foo AC_SUBST([DRIVER_NAME]) is to better match the pattern used in video drivers. But maybe it would be better to either actually try to use a solution that makes use of the pattern @driver_n...@_foo = bar and use

xorg/driver/xf86-input-palmax: [PATCH] Janitor: make distcheck, .gitignore.

2009-02-05 Thread Paulo César Pereira de Andrade
From bd89831ba1f003c9f6bdaf3c2481e11885e7a646 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br Date: Thu, 5 Feb 2009 15:03:20 -0200 Subject: [PATCH] Janitor: make distcheck, .gitignore. Use `` instead of $(). Use $PKG_CONFIG to honor user build setup.

driver/xf86-input-penmount: [PATCH] Janitor: make distcheck, compile warnings, .gitignore.

2009-02-05 Thread Paulo César Pereira de Andrade
From b4a05a860087f1aea5bc64390ea23e17654e48c3 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br Date: Thu, 5 Feb 2009 15:11:04 -0200 Subject: [PATCH] Janitor: make distcheck, compile warnings, .gitignore. Use `` instead of $(). Use $PKG_CONFIG to honor user

xorg/driver/xf86-input-spaceorb: Janitor: make distcheck, .gitignore.

2009-02-05 Thread Paulo César Pereira de Andrade
From 729b45b0a1ac4ef6a5f92549c8148b7ee7a6fa4a Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br Date: Thu, 5 Feb 2009 15:18:32 -0200 Subject: [PATCH] Janitor: make distcheck, .gitignore. Use `` instead of $(). Use $PKG_CONFIG to honor user build setup. Use

Re: [PATCH] Fix cast int-to-pointer and pointer-to-int

2009-02-05 Thread Paulo César Pereira de Andrade
Simon Thum wrote: Tomas Carnecky wrote: By first casting to long and then to the final type. Of course this assumes that sizeof(long) == sizeof(void *). If the Win32 Forgive my stupidity, but isn't it a C language rule that sizeof(long) == sizeof(void *) is always true? This of course may

xorg/driver/xf86-input-synaptics: [PATCH 1/2] Janitor: make distcheck, pkg-config, .gitignore.

2009-02-05 Thread Paulo César Pereira de Andrade
From ab4cce1b7672a67c922a4ac881fc3d60fb552345 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br Date: Thu, 5 Feb 2009 15:55:40 -0200 Subject: [PATCH 1/2] Janitor: make distcheck, pkg-config, .gitignore. Use `` instead of $(). Use $PKG_CONFIG to honor user

xorg/driver/xf86-input-synaptics: [PATCH 2/2] Janitor: compile warnings and missing symbols.

2009-02-05 Thread Paulo César Pereira de Andrade
From 1684a85f624b38856f51608976e5711462370770 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br Date: Thu, 5 Feb 2009 16:13:13 -0200 Subject: [PATCH 2/2] Janitor: compile warnings and missing symbols. The compile warnings are generated by both, gcc and sparse.

Re: [PATCH] Fix cast int-to-pointer and pointer-to-int

2009-02-05 Thread Paulo César Pereira de Andrade
Julien Cristau wrote: On Thu, 2009-02-05 at 16:16 -0200, Paulo César Pereira de Andrade wrote: Forgive my stupidity, but isn't it a C language rule that sizeof(long) == sizeof(void *) is always true? No. As said earlier in this thread there are IL32P64 systems. Thanks, I will not reply

xorg/driver/xf86-input-tek4957: [PATCH] Janitor: make distcheck, .gitignore.

2009-02-05 Thread Paulo César Pereira de Andrade
From dace9ea68b7747a4a7f614665500ea9bf3adff13 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br Date: Thu, 5 Feb 2009 16:43:22 -0200 Subject: [PATCH] Janitor: make distcheck, .gitignore. Use `` instead of $(). Use $PKG_CONFIG to honor user build setup.

xorg/driver/xf86-input-void: [PATCH 1/2] Janitor: update for ABI_XINPUT_VERSION = 5

2009-02-05 Thread Paulo César Pereira de Andrade
From fafd4f546bf75e71ce92feaa52d50699fae81a21 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br Date: Thu, 5 Feb 2009 17:30:18 -0200 Subject: [PATCH 1/2] Janitor: update for ABI_XINPUT_VERSION = 5 This driver should be seen as the simplest possible input driver,

xorg/driver/xf86-video-apm: [PATCH 2/2] Janitor: compile warning fixes.

2009-02-05 Thread Paulo César Pereira de Andrade
From fb59b563f6a586ee491f437281c7251f8a83d8f5 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br Date: Thu, 5 Feb 2009 17:56:20 -0200 Subject: [PATCH 2/2] Janitor: compile warning fixes. Correct most warnings generated by gcc and sparse. Remaining warnings are

xorg/driver/xf86-video-ark: [PATCH] Janitor: make distcheck, compile warnings, .gitignore.

2009-02-05 Thread Paulo César Pereira de Andrade
From 2d63aa335cf3cba4ea462d824019990590e8f17e Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br Date: Thu, 5 Feb 2009 18:25:05 -0200 Subject: [PATCH] Janitor: make distcheck, compile warnings, .gitignore. Use `` instead of $(). Use $PKG_CONFIG to honor user

xorg/driver/xf86-video-ast: [PATCH 2/2] Janitor: Correct compiler warnings.

2009-02-05 Thread Paulo César Pereira de Andrade
From this patch on, I will ignore the generated by default sparse warning: Using plain integer as NULL pointer that is, add -Wno-non-pointer-null to sparse (cgcc) command line. From 3f88e53d1db44b12d15f01c04a539580cb876fc0 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade

Re: extension init cleanup

2009-02-05 Thread Paulo César Pereira de Andrade
Tomas Carnecky wrote: I tried to clean up the header files that contain declarations for the various extension. Basically, in the end the header include/extinit.h contains the declarations of the extension init functions and declarations of the noXxxExtension booleans, sorted and put under

Re: extension init cleanup

2009-02-05 Thread Paulo César Pereira de Andrade
Tomas Carnecky wrote: On 02/05/2009 10:53 PM, Paulo César Pereira de Andrade wrote: Tomas Carnecky wrote: I tried to clean up the header files that contain declarations for the various extension. Basically, in the end the header include/extinit.h contains the declarations of the extension

xf86-video-ati: [PATCH] Janitor: make distcheck, .gitignore.

2009-02-05 Thread Paulo César Pereira de Andrade
I am starting to believe that, maybe -Wpointer-arith should not only be out of $CWARNFLAGS, but that $CWARNFLAGS should actually include -Wno-pointer-arith. Almost every casting is a sign of something going wrong, as the compiler should always able to do proper type conversion automatically,

Re: xorg/driver/xf86-input-jamstudio: [PATCH] Janitor: make distcheck, .gitignore.

2009-02-05 Thread Paulo César Pereira de Andrade
Peter Hutterer wrote: On Thu, Feb 05, 2009 at 03:27:34PM -0200, Paulo César Pereira de Andrade wrote: looking at the git log, jamstudio is dead and I'd rather bury it than put janitor patches in. It makes it look like the driver actually matters. we cannot simply put these dead

Re: [PATCH] Fix cast int-to-pointer and pointer-to-int

2009-02-05 Thread Paulo César Pereira de Andrade
Corbin Simpson wrote: Forgive my stupidity, but isn't it a C language rule that sizeof(long) == sizeof(void *) is always true? No. As said earlier in this thread there are IL32P64 systems. C only makes one guarantee regarding sizeof() and primitives, and that is that sizeof(char) == 1.

xorg/app/xhost: [PATCH] Remove support for old kerberos5 api.

2009-02-04 Thread Paulo César Pereira de Andrade
After testing with a few other options, I come back to the old method of attaching a git format-patch formatted file to the message, and adding some intial comments. So that it would also make it easier to specify in the subject what repository the patch should be applied. Another option

xorg/driver/xf86-input-evdev: [PATCH] Correct make distchek using the same solution used in other packages.

2009-02-04 Thread Paulo César Pereira de Andrade
These cases should really be addressed in a different way, as the addition of a option that is only useful to pass distcheck is wrong. Another cosmetic thing that should be addressed is usage of something like: PKG_CHECK_MODULES(XORG, xorg-server xproto $REQUIRED_MODULES)

Re: xorg/app/xhost: [PATCH] Remove support for old kerberos5 api.

2009-02-04 Thread Paulo César Pereira de Andrade
Alan Coopersmith wrote: I think it would be better to restore the definition of FamilyKrb5Principal to libXau - while it may not be used by the current code, it is defined/reserved for Kerberos5 and if a new implementation of that code was done using current API's, we'd presumably want to use

xorg/driver/xf86-input-joystick: [PATCH 1/2] Janitor: make distcheck, .gitignore.

2009-02-04 Thread Paulo César Pereira de Andrade
The same solution proposed in xf86-input-evdev was used to correct make distcheck. This may not be the best solution as someone compiling from source may think the option should be used :-) From a98e4825b3268e3b57402dd64b5a3621159965cb Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de

xorg/driver/xf86-input-joystick: [PATCH 2/2] Janitor: gcc 4.5 and sparse warnings.

2009-02-04 Thread Paulo César Pereira de Andrade
This patch corrects most gcc/sparse warnings. The correction for code in format: if (a = b) rel = a - b; if (a = b) rel = b - a; rel = rel / foo; was changed to the logical equivalent, and clear to read, but also corrected the warning about rel possibly being used uninitialized :-) From

Re: [PATCH] Remove -Wbad-function-cast

2009-02-04 Thread Paulo César Pereira de Andrade
Tomas Carnecky wrote: It's the source of many useless warnings. It was my suggestion to Peter to add -Wbad-function-cast (and a few others). I am not sure if the proper solution to the warnings is to not generate them :-) As I understand this option, the proper solution is of course not to

xorg/driver/xf86-input-magellan: Janitor: make distcheck, .gitignore.

2009-02-04 Thread Paulo César Pereira de Andrade
Another trivial patch. From 9d37cb0dd0841f9135727c81c63fc4cc0b510396 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br Date: Wed, 4 Feb 2009 19:30:26 -0200 Subject: [PATCH] Janitor: make distcheck, .gitignore. Make distcheck is corrected by requiring a newer

xorg/driver/xf86-input-microtouch: [PATCH] Janitor: make distcheck, .gitignore.

2009-02-04 Thread Paulo César Pereira de Andrade
This is another trivial patch, that updates the microtouch driver to match changes to other packages, to correct make distcheck and use a single .gitignore file. From 0b82c67edad92faf73506b7a7ee1d758a7599ac2 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br Date:

Re: xorg/driver/xf86-input-evdev: [PATCH] Correct make distchek using the same solution used in other packages.

2009-02-04 Thread Paulo César Pereira de Andrade
Dan Nicholson wrote: These cases should really be addressed in a different way, as the addition of a option that is only useful to pass distcheck is wrong. For the patch, please use backticks (``) rather than $() for command substitution since it's more portable. Also, please use the

Re: xorg/driver/xf86-input-evdev: [PATCH] Correct make distchek using the same solution used in other packages.

2009-02-04 Thread Paulo César Pereira de Andrade
Peter Hutterer wrote: or maybe in the same line, but not really a xorg issue, but a pkg-config issue? I'll merge such a patch if you have one for me. This should be corrected (if really an issue) in pkgconfig: % rpm -qf /usr/share/aclocal/pkg.m4 pkgconfig-0.23-4mdv2009.1 how is this

Re: xorg/app/xhost: [PATCH] Remove support for old kerberos5 api.

2009-02-04 Thread Paulo César Pereira de Andrade
Ian Romanick wrote: On Wed, Feb 04, 2009 at 05:07:26PM -0200, Paulo César Pereira de Andrade wrote: After testing with a few other options, I come back to the old method of attaching a git format-patch formatted file to the message, and adding some intial comments. So that it would also

Re: xorg/xserver: [PATCH] Janitor: change include/xkbsrv.h include guard symbol.

2009-02-04 Thread Paulo César Pereira de Andrade
Peter Hutterer wrote: On Wed, Feb 04, 2009 at 07:05:42PM -0200, Paulo César Pereira de Andrade wrote: From 2e2ba17bbc5ef92fd52a85b53341651d79411332 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade p...@mandriva.com.br Date: Wed, 4 Feb 2009 18:33:57 -0200 Subject: [PATCH] Janitor

Re: xorg/driver/xf86-input-magellan: Janitor: make distcheck, .gitignore.

2009-02-04 Thread Paulo César Pereira de Andrade
Dan Nicholson wrote: Another trivial patch. Looking at another one of these, I see small nit. configure.ac: XORG_CFLAGS=$XORG_CFLAGS $CWARNFLAGS Makefile.am: AM_CFLAGS = $(XORG_CFLAGS) It would be nicer if it was just Makefile.am: AM_CFLAGS = $(XORG_CFLAGS) $(CWARNFLAGS) Then I

xorg/driver/xf86-input-mouse: [PATCH] Janitor: use $PKG_CONFIG and update .gitignore.

2009-02-04 Thread Paulo César Pereira de Andrade
Update .gitignore for files remaining after make and make distcheck, as well as entry for the default tags file. Also, from this patch on at least, start using non bash'isms (because it is how it is done in other packages) and use $PKG_CONFIG to better work on some build environments (as

Re: [PATCH] Add a prototype for CopyGetMasterEvent()

2009-02-03 Thread Paulo César Pereira de Andrade
Peter Hutterer wrote: On Wed, Feb 04, 2009 at 12:03:12AM +0100, Tomas Carnecky wrote: This function is defined in mi/mieq.c and used in xkb/ddxDevBtn.c, hence it needs a prototype. Signed-off-by: Tomas Carnecky t...@dbservice.com --- include/input.h |8 1 files changed, 8

Re: autoreconf issue with libXfont

2009-02-02 Thread Paulo César Pereira de Andrade
Jeremy Huddleston wrote: So this is a bit odd... I'm found an issue with libXfont that is making me a bit nuts. I think it's probably related to libtool, autoconf, or automake... I wanted to see if anyone has seen something similar... When starting the server, it immediately dies because it

Re: xf86-input-evdev: Changes to 'master'

2009-02-02 Thread Paulo César Pereira de Andrade
Dan Nicholson wrote: diff --git a/configure.ac b/configure.ac index 4ba5a8a..809799f 100644 --- a/configure.ac +++ b/configure.ac @@ -72,19 +73,22 @@ XORG_DRIVER_CHECK_EXT(XINPUT, inputproto) # Checks for pkg-config packages PKG_CHECK_MODULES(XORG, xorg-server xproto $REQUIRED_MODULES)

Re: xf86-input-evdev: Changes to 'master'

2009-02-02 Thread Paulo César Pereira de Andrade
Peter Hutterer wrote: On Tue, Feb 03, 2009 at 12:35:14AM -0200, Paulo César Pereira de Andrade wrote: Dan Nicholson wrote: diff --git a/configure.ac b/configure.ac index 4ba5a8a..809799f 100644 --- a/configure.ac +++ b/configure.ac @@ -72,19 +73,22 @@ XORG_DRIVER_CHECK_EXT(XINPUT

Re: Current tinderbox regression (xhost)

2009-02-02 Thread Paulo César Pereira de Andrade
Daniel Stone wrote: On Tue, Feb 03, 2009 at 12:24:14AM -0200, Paulo César Pereira de Andrade wrote: Anyway, my freedesktop account appears to not be functional, so I will not be able to correct it now. Hopefully by tomorrow, or later tonight it is corrected... Yes, I made the decision

Re: Current tinderbox regression (libXi)

2009-01-29 Thread Paulo César Pereira de Andrade
Chris Ball wrote: http://tinderbox.x.org/builds/2009-01-29-0034/logs/libXi/#configure configure: error: Package requirements (xproto = 7.0.13 x11 = 1.1.99.1 xextproto = 7.0.3 xext = 1.0.99.1 inputproto = 1.9.99.6) were not met: Requested 'xext = 1.0.99.1' but version of Xext is 1.0.5 I

Re: Current tinderbox regression (xserver)

2009-01-29 Thread Paulo César Pereira de Andrade
Chris Ball wrote: http://tinderbox.x.org/builds/2009-01-30-0005/logs/xserver/#build In file included from ../Xext/panoramiX.h:43, from dispatch.c:134: /home/cjb/xorg-build/include/X11/extensions/panoramiXext.h:48: error: expected ')' before '*' token

Re: xserver: Branch 'master'

2009-01-27 Thread Paulo César Pereira de Andrade
Peter Hutterer wrote: Nothing agains't disabling it. But it should be building since commit 6ef46c40e62def4841a4cff4e0b443516a2ed782, and have the same problems as kdrive based servers. Since this is probably a case of nobody cares to maintain, then it should be better to just remove it. As

Re: Recent input changes

2009-01-25 Thread Paulo César Pereira de Andrade
Ben Gamari wrote: The only strange behavior I noticed so far (after waiting some days to run git master again :-)) was with the Alt key. xev says order of events is correct, but the event state field appears to be messed, and only set to the proper value after the next key press. This breaks

Re: Recent input changes

2009-01-25 Thread Paulo César Pereira de Andrade
Peter Hutterer wrote: The only strange behavior I noticed so far (after waiting some days to run git master again :-)) was with the Alt key. xev says order of events is correct, but the event state field appears to be messed, and only set to the proper value after the next key press. This

Re: [PATCH] Wait for hald during initialization when necessary

2009-01-22 Thread Paulo César Pereira de Andrade
Yan Li wrote: Attached the new version without attempting any magic fallback (and using 8 spaces instead of tabs) Tested and functional by stoping hald, running startx, and starting hald from a ssh connection, so that in no more then 8 seconds the keyboard and mouse start responding...

Re: [PATCH] Wait for hald during initialization when necessary

2009-01-21 Thread Paulo César Pereira de Andrade
Peter Hutterer wrote: +/* hald might not finish it's init yet, we'll wait for it for 2s */ +unsigned int wait_for_hal = 2 * 100; +const unsigned int wait_for_hal_sleep_time = 100 * 1000; + +/* hald might not be ready now, waiting for it for a few seconds */ +while

Re: [PATCH] Wait for hald during initialization when necessary

2009-01-21 Thread Paulo César Pereira de Andrade
Paulo César Pereira de Andrade wrote: I think it'd be better to set a timer to fire off the reinitialization rather than a simple usleep. Doing so allows us to finish the server initialization without having to wait for hal. Any opinions? I can rework my patch to remove the hal_giveup

Re: Current tinderbox regression (app/xkbcomp)

2009-01-21 Thread Paulo César Pereira de Andrade
Chris Ball wrote: http://tinderbox.x.org/builds/2009-01-21-0032/logs/xkbcomp/#build xkbparse.y:101: error: static declaration of 'parseDebug' follows non-static declaration utils.h:262: error: previous declaration of 'parseDebug' was here

Re: xorg server should wait HAL if it's not avail during init

2009-01-20 Thread Paulo César Pereira de Andrade
Tino Keitel wrote: On Tue, Jan 20, 2009 at 10:18:10 +0100, Matija Å uklje wrote: Dne torek 20. januarja 2009 je Yan Li napisal(a): I suggest we add a short (5 seconds) busy-wait if hald is not usable. Isn't that more of a (distro's) init system problem? The problem is that most of those

[PATCH] Add hal/dbus fallback when not able to talk to hal/dbus daemons.

2009-01-20 Thread Paulo César Pereira de Andrade
This is a possible solution for the problem reported in the xorg server should wait HAL if it's not avail during init thread. In my tests, it worked when running this: % sudo service haldaemon stop; startx -- -verbose 3 After waiting all the timeouts, it loaded kbd and mouse drivers, and

Re: Current tinderbox regression (xserver)

2009-01-20 Thread Paulo César Pereira de Andrade
Ian Romanick wrote: On Tue, 2009-01-20 at 14:30 -0500, Chris Ball wrote: http://tinderbox.x.org/builds/2009-01-20-0024/logs/xserver/#build ./.libs/libxorg.a(sdksyms.o):(.data.rel+0x308): undefined reference to `CreateUnclippedWinSize'

Re: [PATCH] Add hal/dbus fallback when not able to talk to hal/dbus daemons.

2009-01-20 Thread Paulo César Pereira de Andrade
Daniel Stone wrote: On Tue, Jan 20, 2009 at 08:21:45PM -0200, Paulo César Pereira de Andrade wrote: This is a possible solution for the problem reported in the xorg server should wait HAL if it's not avail during init thread. Please do not push this patch. I posted the patch more

Re: Font rendering problem in 1.6 branch (fine in 1.5 and master)

2009-01-17 Thread Paulo César Pereira de Andrade
Keith Packard wrote: On Fri, 2009-01-16 at 14:58 -0800, Dan Nicholson wrote: On Fri, Jan 16, 2009 at 2:51 PM, Jeremy Huddleston jerem...@freedesktop.org wrote: Ah... I figured it out... It has to do with --enable-builtin-fonts going from no by default in 1.5 to yes by default in 1.6 to

Re: two small patches for ico xgc (configure.ac typos)

2009-01-14 Thread Paulo César Pereira de Andrade
Dan Nicholson wrote: On Wed, Jan 14, 2009 at 5:14 AM, Jens Stroebel dr-x...@bcsoft.de wrote: Hi. Attached are two patches for app/ico and app/xgc which had small typos in their configure.ac's. Good catched. Pushed as: ico: 5ca33a50e4a643b8ed7a525e39ecec9b34f1900a

DESTDIR and pkg-config variables

2009-01-12 Thread Paulo César Pereira de Andrade
What is the proper way to correct make distcheck, when using pkg-config directory variables? Sample case is appdefaultdir for Xt/Xaw based applications. That usually, in configure.ac is: PKG_CHECK_MODULES(APPDEFS, xt) appdefaultdir=$(pkg-config --variable=appdefaultdir xt)

Re: DESTDIR and pkg-config variables

2009-01-12 Thread Paulo César Pereira de Andrade
Julien Cristau wrote: On Mon, Jan 12, 2009 at 09:50:46 -0800, Dan Nicholson wrote: I think the right way to do this is 1) Keep taking the default from pkg-config and 2) Pass in a value during distcheck with DISTCHECK_CONFIGURE_FLAGS. That'd look something like this: configure.ac:

Re: [Brainstorm] LinkKit for Xorg

2009-01-10 Thread Paulo César Pereira de Andrade
Rémi Cardona wrote: Le 10/01/2009 03:10, Paulo César Pereira de Andrade a écrit : Xorg (and to some extent XFree86) loadable modules aren't really of much use, as modules cannot be properly unloaded, there is no dependency information; a module doesn't list it's dependencies in any form

[ANNOUNCE] xf86-input-keyboard 1.3.2

2009-01-08 Thread Paulo César Pereira de Andrade
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Adam Jackson (2): Remove XFree86-Misc leftovers. Remove useless call to xf86AddModuleInfo Alan Coopersmith (2): sun_kbd.c: Don't try to repeat shutdown actions on already closed keyboard Renamed subdir .cvsignore files to

[ANNOUNCE] xf86-input-keyboard 1.3.2

2009-01-07 Thread Paulo César Pereira de Andrade
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Adam Jackson (2): Remove XFree86-Misc leftovers. Remove useless call to xf86AddModuleInfo Alan Coopersmith (2): sun_kbd.c: Don't try to repeat shutdown actions on already closed keyboard Renamed subdir .cvsignore files to

[PATCH] Default to use standard fonts and builtin fonts as a fallback

2009-01-06 Thread Paulo César Pereira de Andrade
The attached patch changes the current XServer behaviour of using built-ins font by default only. But if the default font 'fixed' is not found, it will automatically default to use built-ins fonts. I believe this is a far more reasonable default, and still addresses the most common Xorg FAQ

[no subject]

2009-01-06 Thread Paulo César Pereira de Andrade
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alan Hourihane (1): silence warning Colin Harrison (1): include for sleep() James Cloos (1): Add missing PHONY line for automatic ChangeLog generation Matthieu Herrb (1): nuke RCS Ids Paulo Cesar Pereira de Andrade (1):

Re: [should have been: ANNOUNCE: libICE 1.0.5]

2009-01-06 Thread Paulo César Pereira de Andrade
Oops, forgot a small detail :-) xorg-announce moderator(s), please correct it when allowing it to go to @xorg-announce Thanks, Paulo ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg

Re: [PATCH] Default to use standard fonts and builtin fonts as a fallback

2009-01-06 Thread Paulo César Pereira de Andrade
James Cloos wrote: +1 on concept. I know some dists are using a simple patch such as: diff --git a/dix/dixfonts.c b/dix/dixfonts.c index 416adb3..719bca4 100644 --- a/dix/dixfonts.c +++ b/dix/dixfonts.c @@ -1907,12 +1907,9 @@ InitFonts (void) { patternCache =

Re: [PATCH] Default to use standard fonts and builtin fonts as a fallback

2009-01-06 Thread Paulo César Pereira de Andrade
Paulo César Pereira de Andrade wrote: [...] A more complete patch is warranted, but perhaps just forcing built-ins as the last entry of the fontpath is sufficient? Updated, simpler and more reliable, patch attached. (patch name also change) Sorry for replying myself (twice

Re: [Cooker] x3270 fonts

2009-01-05 Thread Paulo César Pereira de Andrade
feretio wrote: Cavassin has told me that Paulo has suggested you something related to configure's options. In my research, I think that might be the case. I believe the following was referred to: configure --disable-builtin-fonts Yes, I think Colin missed my email about it. But I

Re: xserver distribution missing sdksyms.sh

2009-01-05 Thread Paulo César Pereira de Andrade
vehemens wrote: subject says it all Thanks. I feel dumb for this one :-) Last time I run make distcheck was like one month ago, when I added DISTCLEANFILES = doltcompile doltlibtool to the toplevel Makefile.am Paulo ___ xorg mailing list

Re: [PATCH] fix sdksyms for gcc3

2009-01-02 Thread Paulo César Pereira de Andrade
Matthieu Herrb wrote: gcc 3.3 (at least) doesn't support visibility attributes, so _X_EXPORT expands to nothing. This breaks the awk script embedded in hw/xfree86/loader/sdksyms.sh that expects that an extern function declaration to be in the form extern __attribute__(___something___) type

Re: xserver: Branch 'master'

2009-01-01 Thread Paulo César Pereira de Andrade
Matthieu Herrb wrote: Paulo Cesar Pereira de Andrade wrote: hw/xfree86/loader/Makefile.am |6 -- hw/xfree86/loader/sdksyms.sh | 13 + 2 files changed, 17 insertions(+), 2 deletions(-) New commits: commit 86dc660588a615baefb1799d78a501c95a931d77 Author: Paulo Cesar

[ANNOUNCE] xf86-video-siliconmotion 1.7.0

2008-12-30 Thread Paulo César Pereira de Andrade
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Xorg SiliconMotion Video Driver 1.7.0 features include support for SMI 50x chipsets, RandR 1.2, EXA acceleration Method, Dual Head, etc. Special thanks to Teddy Wang teddy.wang AT siliconmotion.com.cn for support and help in responding and/or

[ANNOUNCE] xf86-video-siliconmotion 1.7.0

2008-12-29 Thread Paulo César Pereira de Andrade
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Xorg SiliconMotion Video Driver 1.7.0 features include support for SMI 50x chipsets, RandR 1.2, EXA acceleration Method, Dual Head, etc. Special thanks to Teddy Wang teddy.wang AT siliconmotion.com.cn for support and help in responding and/or

Re: [PATCH] Include sdk header dependencies and protect agains't multiple inclusion.

2008-12-17 Thread Paulo César Pereira de Andrade
Eric Anholt wrote: Hi, The attached patch is the result of as few extra inclusions as possible, by creating a dummy file including just that header, and making it compile. This was done in the loader directory, and I added some extra -I for module headers, but including in the build

Re: X server exported symbols broken

2008-12-12 Thread Paulo César Pereira de Andrade
Peter Hutterer wrote: I just wasted quite some time to get master to actually start. Unresolved symbols all over the place, both with intel and with vesa. Vesa had xf86InterpretEDID, intel had three or four different ones (miPolyRectangle was one of them IIRC). Rebuilding with and without

Re: X server exported symbols broken

2008-12-11 Thread Paulo César Pereira de Andrade
Peter Hutterer wrote: Paulo, Hi Peter, I just wasted quite some time to get master to actually start. Unresolved symbols all over the place, both with intel and with vesa. Vesa had xf86InterpretEDID, intel had three or four different ones (miPolyRectangle was one of them IIRC). Rebuilding

[PATCH] Include sdk header dependencies and protect agains't multiple inclusion.

2008-12-10 Thread Paulo César Pereira de Andrade
Hi, The attached patch is the result of as few extra inclusions as possible, by creating a dummy file including just that header, and making it compile. This was done in the loader directory, and I added some extra -I for module headers, but including in the build tree. I would like some

Re: [PATCH] Xext: un-export all XGE functions.

2008-12-08 Thread Paulo César Pereira de Andrade
These functions are only to be used by X server extensions, so let's not expose them to the world. This will not work as expected if the X Server is compiled with hidden symbols. For the moment at least, it must be specified as both extern _X_EXPORT (what may be counter intuitive I agree).

Re: [PATCH] Xext: un-export all XGE functions.

2008-12-08 Thread Paulo César Pereira de Andrade
Peter Hutterer wrote: On Mon, Dec 08, 2008 at 07:09:13PM -0200, Paulo César Pereira de Andrade wrote: These functions are only to be used by X server extensions, so let's not expose them to the world. This will not work as expected if the X Server is compiled with hidden symbols

[RFC] Xorg symbols that should not be public

2008-12-08 Thread Paulo César Pereira de Andrade
Hi, In my Linux x86 computer, using only git master, and with X Server configured with --prefix=/usr --disable-builtin-fonts --enable-dri2 --enable-dri --enable-xephyr With all buildable modules also installed, attached is the list of symbols that are not used by any module. There are 2

Re: [RFC] Xorg symbols that should not be public

2008-12-08 Thread Paulo César Pereira de Andrade
Aaron Plattner wrote: I think some private headers, for things like libextmod, libxaa, libfb, etc, should be created, still with symbols exported at first, to guarantee binary compatibility. But some symbols that are currently exported should be made private, and not advertised in the sdk,

Re: Ansification of X.Org code: A question how to proceed

2008-12-07 Thread Paulo César Pereira de Andrade
Hi Peter, In general, I think everyone agrees conversion of the remaining bits of code that use KR/pre-ANSI-C89 style function prototypes declarations to C89 is a good thing (provided it's done correctly [1]), [1] http://invisible-island.net/ansification/index.html Hi Alan, Adam,

Re: Current tinderbox regression (xserver)

2008-12-05 Thread Paulo César Pereira de Andrade
http://tinderbox.x.org/builds/2008-12-05-0010/ http://tinderbox.x.org/builds/2008-12-05-0010/logs/xserver/#build loader.c:77:17: error: sym.h: No such file or directory loader.c: In function 'LoaderInit': loader.c:110: error: 'dixLookupTab' undeclared (first use in this function)

Re: Current tinderbox regression (xserver)

2008-12-03 Thread Paulo César Pereira de Andrade
http://tinderbox.x.org/builds/2008-12-03-0012/ http://tinderbox.x.org/builds/2008-12-03-0012/logs/xserver/#build In file included from Pci.c:130: ../../../../hw/xfree86/common/compiler.h:1041: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'volatile'

Re: xserver: Branch 'master' - 3 commits

2008-12-03 Thread Paulo César Pereira de Andrade
Hi, You appear to have taken my patch and s/fprintf(stderr, /perror(/. Generally in a situation like this one would leave original authorship intact (even my comments were preserved!). Don't know why I changed that :-) It opens space for bikeshedding on something that should never happen

Re: Symbol Visibility [was: Proposed changes to the current sdk]

2008-12-02 Thread Paulo César Pereira de Andrade
Replying myself... I changed it to export all sdk symbols to not give people a reason to compile the X Server with --disable-visibility :-) But there are plenty of symbols that shouldn't really be made available to modules. While there are others that are so widely used that now they

Re: macros: Changes to 'master'

2008-11-29 Thread Paulo César Pereira de Andrade
Paulo Cesar Pereira de Andrade wrote: Makefile.am | 12 +--- configure.ac | 23 --- xorg-macros.m4.in | 27 +++ xorgversion.m4| 14 ++ 4 files changed, 58 insertions(+), 18 deletions(-) New commits:

[ANNOUNCE] util-macros 1.2.0

2008-11-29 Thread Paulo César Pereira de Andrade
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Peter Breitenlohner (5): reorganize autoconf macro files define and use XORG_CHANGELOG macro define XORG_CWARNFLAGS macro fix XORG_PROG_RAWCPP for cygwin bump to 1.2.0 git tag: util-macros-1.2.0

Re: Ansification of X.Org code other cleanup work

2008-11-27 Thread Paulo César Pereira de Andrade
On Mon, 20 Oct 2008, Alan Coopersmith wrote: Hi Alan, in your mail starting this thread If someone wanted to organize a janitorial squad to tackle these and help new people work through them to get to the point where they were ready for commit access, we'd love you forever (or at least

Re: Current tinderbox regression (xf86-input-aiptek)

2008-11-27 Thread Paulo César Pereira de Andrade
http://tinderbox.x.org/builds/2008-11-28-0005/ http://tinderbox.x.org/builds/2008-11-28-0005/logs/xf86-input-acecad/#build acecad.c:76:28: error: sysfs/libsysfs.h: No such file or directory acecad.c: In function 'AceCadAutoDevProbe': acecad.c:250: warning: assignment makes pointer from

Re: Broken X11 After Mandriva Upgrade

2008-11-26 Thread Paulo César Pereira de Andrade
Hi, I recently upgraded to Mandriva to 2007 Free. In the process, something happened that broke X11. I have tried everything I can thing of but no joy. It has been very difficult to get any diagnostics because when I try to startx, the console goes black and neither keyboard nor mouse

Possible patch to enable hidden symbols by default

2008-11-26 Thread Paulo César Pereira de Andrade
Hi, Attached is a possible patch to enable compiling the XServer and modules with hidden symbols by default. Please comment :-) The patch allows using the --disable-visibility option, and variants to disable compilation with hidden symbols (or one could go wild and change the

Re: Is it possible to use i810 driver in Xorg7.3 without agpgart kernel module

2008-11-25 Thread Paulo César Pereira de Andrade
Hi All, Hi, Is it possible to use i810 driver in Xorg7.3 without agpgart kernel module ? I use kernel 2.4.31. And It's OK for XFree86 4.6. I think it should work with older versions of the i810 driver, as long the driver recognizes your hardware. Some months ago I worked on something

Re: xset dpms force off

2008-11-23 Thread Paulo César Pereira de Andrade
I am running a multi-head setup. I'd like to be able to turn off each head individually. I'm using the evil binary nvidia drivers to set up 4 screens as DISPLAY 0.0, 0.1, 0.2, and 0.3 I'm not using Xinerama or Twinview. xset -display :0.0 dpms force off turns off all 4 displays, as

Re: X server 1.6 release schedule

2008-11-18 Thread Paulo César Pereira de Andrade
On Sat, 2008-11-15 at 15:57 -0200, Paulo César Pereira de Andrade wrote: I volunteered to manage an X server 1.6 release, tentatively scheduled for the end of the year (yes, this year, 2008). This release will include DRI2 and RandR 1.3 support. I'd like to know how much of the new

Re: Moving xkbcomp into the server

2008-11-17 Thread Paulo César Pereira de Andrade
On Mon, Nov 17, 2008 at 11:25:25AM -0800, Dan Nicholson wrote: I decided to take a crack at moving xkbcomp into the server so it's not popen'd whenever a keymap is loaded. For the first crack, I'm trying to just leave xkbcomp pretty much unchanged except for the interface. What's causing me

Re: X server 1.6 release schedule

2008-11-15 Thread Paulo César Pereira de Andrade
I volunteered to manage an X server 1.6 release, tentatively scheduled for the end of the year (yes, this year, 2008). This release will include DRI2 and RandR 1.3 support. I'd like to know how much of the new Xinput stuff will be ready in time. Hi Keith, First, thanks for doing it. I

Re: building modular xorg

2008-11-09 Thread Paulo César Pereira de Andrade
Manoa Nosea [EMAIL PROTECTED] writes: according to: http://dri.freedesktop.org/wiki/Building http://wiki.x.org/wiki/ModularDevelopersGuide http://xorg.freedesktop.org/wiki/Development/git I more or less managed to built it, however if there is an updated location for any of these manuals

Re: [PATCH] Removal of a needless null statement

2008-11-08 Thread Paulo César Pereira de Andrade
Fernando == Fernando Carrijo [EMAIL PROTECTED] writes: Fernando ... and there are still others. XCB and libX11, to list a few! Yes, we have to look in the other repos as well. Git grep makes is relatively easy, but only works one repo at a time. I'll get the ones in app and lib, but I