Re: [PATCH] glamor: swizzle RED to 0 for alpha textures.

2016-05-13 Thread Keith Packard
Dave Airlie writes: > From: Dave Airlie > > I'm pretty sure Eric suspected this could cause a problem, and > we couldn't find a test. Well loading feedly in firefox seems > to trigger badness that this solves. And, loading a page from gfycat is broken by

Re: [PATCH xserver] glamor: Disable logic ops when doing compositing

2016-05-13 Thread Eric Anholt
Keith Packard writes: > Eric Anholt writes: > >> Keith Packard writes: >> >>> If the logic op gets left enabled, it overrides the blending >>> operation, causing incorrect contents on the display. >>> >>> Signed-off-by: Keith Packard

Re: [PATCH xserver] glamor: Disable logic ops when doing compositing

2016-05-13 Thread Keith Packard
Markus Wick writes: > Hi, > > AFAIK we disable logic ops after each usage, so this seems a bit > redundant to me. Did we miss one usages? Nope, GL_COLOR_LOGIC_OP isn't managed like other glEnable/glDisable pairs; it's left at the previous value. Someday we should figure out

Re: [PATCH xserver] glamor: Disable logic ops when doing compositing

2016-05-13 Thread Keith Packard
Eric Anholt writes: > Keith Packard writes: > >> If the logic op gets left enabled, it overrides the blending >> operation, causing incorrect contents on the display. >> >> Signed-off-by: Keith Packard > > Reviewed-by: Eric Anholt

Re: [PATCH xserver] glamor: Disable logic ops when doing compositing

2016-05-13 Thread Eric Anholt
Keith Packard writes: > If the logic op gets left enabled, it overrides the blending > operation, causing incorrect contents on the display. > > Signed-off-by: Keith Packard Reviewed-by: Eric Anholt signature.asc Description: PGP

[PATCH xserver] xrandrprovider: Do not use separate lists for unbound / source / offload slaves

2016-05-13 Thread Hans de Goede
A single provider can be both a offload and source slave at the same time, the use of seperate lists breaks in this case e.g. : xrandr --listproviders Providers: number : 2 Provider 0: id: 0x7b cap: 0xf, Source Output, Sink Output, Source Offload, Sink Offload crtcs: 3 outputs: 2 associated

Re: [PATCH xserver] glamor: Disable logic ops when doing compositing

2016-05-13 Thread Alex Deucher
On Fri, May 13, 2016 at 7:29 AM, Keith Packard wrote: > If the logic op gets left enabled, it overrides the blending > operation, causing incorrect contents on the display. > > Signed-off-by: Keith Packard Makes sense. Reviewed-by: Alex Deucher

Re: [PATCH xf86-video-ati] Explicitly set the fbcon pixmap pitch again

2016-05-13 Thread Alex Deucher
On Fri, May 13, 2016 at 5:40 AM, Michel Dänzer wrote: > From: Michel Dänzer > > The kernel driver returns 0 as the pitch of the fbcon BO via the > DRM_RADEON_GEM_GET_TILING ioctl, so we ended up using an incorrect > pitch in some cases. > > Bugzilla:

Re: [PATCH xserver] glamor: Disable logic ops when doing compositing

2016-05-13 Thread Markus Wick
Hi, AFAIK we disable logic ops after each usage, so this seems a bit redundant to me. Did we miss one usages? As logic ops aren't very common, this sounds good to me. Am 2016-05-13 13:29, schrieb Keith Packard: If the logic op gets left enabled, it overrides the blending operation, causing

[PATCH xserver] glamor: Disable logic ops when doing compositing

2016-05-13 Thread Keith Packard
If the logic op gets left enabled, it overrides the blending operation, causing incorrect contents on the display. Signed-off-by: Keith Packard --- glamor/glamor_program.c | 1 + 1 file changed, 1 insertion(+) diff --git a/glamor/glamor_program.c b/glamor/glamor_program.c

Re: [PATCH RESEND xserver v3] xfree86: Immediately handle failure to set HW cursor

2016-05-13 Thread Alexandre Courbot
On 05/13/2016 01:04 AM, Adam Jackson wrote: On Thu, 2016-05-12 at 16:04 +0900, Alexandre Courbot wrote: There is currently no reliable way to report failure to set a HW cursor. Still such failures can happen if e.g. the MODE_CURSOR DRM ioctl fails (which currently happens at least with

[PATCH xf86-video-ati] Explicitly set the fbcon pixmap pitch again

2016-05-13 Thread Michel Dänzer
From: Michel Dänzer The kernel driver returns 0 as the pitch of the fbcon BO via the DRM_RADEON_GEM_GET_TILING ioctl, so we ended up using an incorrect pitch in some cases. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94901 Signed-off-by: Michel Dänzer

[ANNOUNCE] xproto 7.0.29

2016-05-13 Thread Julien Cristau
Alan Coopersmith (1): Incorrect guard block in HPkeysym.h James Clarke (1): Don't let XFD_SETSIZE exceed FD_SETSIZE Julien Cristau (1): xproto 7.0.29 Olivier Fourdan (1): Raise the number of FD on WIN32 as well git tag: xproto-7.0.29

[ANNOUNCE] xproto 7.0.29

2016-05-13 Thread Julien Cristau
Alan Coopersmith (1): Incorrect guard block in HPkeysym.h James Clarke (1): Don't let XFD_SETSIZE exceed FD_SETSIZE Julien Cristau (1): xproto 7.0.29 Olivier Fourdan (1): Raise the number of FD on WIN32 as well git tag: xproto-7.0.29

[Bug 94901] Display corruption due to deferred fbcon pixmap pitch calculation in radeon_set_pixmap_bo

2016-05-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94901 --- Comment #5 from jpsinthe...@verizon.net --- (In reply to Michel Dänzer from comment #4) > Created attachment 123664 [details] [review] > Explicitly set the fbcon pixmap pitch again > > This should be a better fix. Please check that there are

[PATCH xserver v4 2/2] randr: Do not update ConnectionInfo if NULL

2016-05-13 Thread Olivier Fourdan
RRScreenSizeNotify() will update the connection information block, but if this occurs during initialization before ConnectionInfo is even initialized, this will lead to a crash. Simply check for ConnectionInfo prior to update it to avoid the crash. Bugzilla:

Re: [PATCH libICE] Enable visibility annotations

2016-05-13 Thread Yury Gribov
On 05/10/2016 03:00 PM, Yury Gribov wrote: On 05/06/2016 07:25 PM, Alan Coopersmith wrote: On 05/ 6/16 04:18 AM, Yury Gribov wrote: Unfortunately I don't see any good approach. We could move definitions of _X_EXPORT and friends to configure.ac but this would need to be done for all X11