Re: Fixing devPrivates

2010-04-30 Thread Keith Packard
On Thu, 29 Apr 2010 20:39:24 -0400, Eamon Walsh ewa...@tycho.nsa.gov wrote: On 04/29/2010 02:59 AM, Keith Packard wrote: I've been wanting to do this for a while, but the recent work to eliminate MAXSCREENS has pushed me to get it done sooner rather than later. What's the problem with

Re: Fixing devPrivates

2010-04-30 Thread Keith Packard
On Fri, 30 Apr 2010 04:45:43 +0200, Tomas Carnecky t...@dbservice.com wrote: Is there any other reason you chose to allocated the array only once when the object is created? For almost all of the objects, the privates are allocated along with the underlying object itself, saving an allocation

Re: Fixing devPrivates

2010-04-30 Thread Matthias Hopf
On Apr 29, 10 10:20:38 -0700, Keith Packard wrote: On Thu, 29 Apr 2010 14:06:19 +0200, Matthias Hopf mh...@suse.de wrote: I suggest that you have some sort of compile-time define available to determine the API type - in case some out-of-Xserver part (drivers?) wants to be backward

Make libdrm dependency in dri2 optional

2010-04-30 Thread Pauli Nieminen
Resending the patch series with minor fix based on review. This patch series is for drivers that are not based on drm/libdrm but are still using dri2. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

[PATCH v4 3/4] DRI2: wrap drm bits with macros and change drm_magic type

2010-04-30 Thread Pauli Nieminen
From: Tiago Vignatti tiago.vigna...@nokia.com Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com --- Changes: * Remove unnecessery include of xf86drm.h from dri2ext.c that were only required for drm_magic_t in dri2.h. * Add

[PATCH v4 4/4] DRI2: Use single error path in initialization

2010-04-30 Thread Pauli Nieminen
Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com --- hw/xfree86/dri2/dri2.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c index b20e96d..f4f34cc 100644 --- a/hw/xfree86/dri2/dri2.c +++

Re: Smooth scrolling

2010-04-30 Thread Max Schwarz
not really, all valuators sent to the clients are always absolute (with the exception of the ones in RawEvents). so even though the driver posts events as relative, they're just added to the current value and sent as absolute anyway. What's the point of relative valuators on the driver-side

Re: [PATCH v2] jhbuildrc: Make configuration and usage easier

2010-04-30 Thread Dirk Wallenstein
Ah!!! stable documentation actually means obsolete documentation. I've found the following mistakes (2.29 ist the real documentation [2]) : - You can request branch switches in git. I've taken two paragraphs (one in build_policy, and one in installprog) almost verbatim from the jhbuild manual at

Re: [PATCH v2] jhbuildrc: Make configuration and usage easier

2010-04-30 Thread Dirk Wallenstein
On Fri, Apr 30, 2010 at 03:12:07PM +0200, Dirk Wallenstein wrote: I've taken two paragraphs (one in build_policy, and one in installprog) almost verbatim from the jhbuild manual at [1]. I should probably note that somewhere. I've put my own words in there, now.

Re: [Xcb] connection issue using xcb in libX11

2010-04-30 Thread Adam Jackson
On Thu, 2010-04-29 at 13:56 -0700, Josh Triplett wrote: On Thu, Apr 29, 2010 at 01:05:48PM -0700, Jeremy Huddleston wrote: Yeah, I agree... but this fallback already exists in the wild. I find it quite dubious that real applications expect DISPLAY=:0 to connect to TCP. It certainly

Re: Fixing devPrivates

2010-04-30 Thread Keith Packard
On Fri, 30 Apr 2010 11:31:48 +0200, Matthias Hopf mh...@suse.de wrote: Hm, right, forgot about the ABI version. That would be enough, especially for rarely externally used APIs like this. Seems like adding: /* * Let drivers know how to initialize private keys */ #define

Re: [PATCH] dix: wrap variables with #ifdef when panoramix is not used

2010-04-30 Thread Keith Packard
On Fri, 30 Apr 2010 15:01:40 +0300, Tiago Vignatti tiago.vigna...@nokia.com wrote: this shut up some warnings. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/events.c |2 ++ dix/window.c |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git

Re: [PATCH v2] jhbuildrc: Make configuration and usage easier

2010-04-30 Thread Dan Nicholson
On Fri, Apr 30, 2010 at 1:13 AM, Dirk Wallenstein hals...@t-online.de wrote: This adds extensive documentation and examples for the most important configuration variables of jhbuild. Additionally this allows to specify paths with a leading tilde, and ensures that the paths are absolute

Re: [PATCH] Fix compiler issues with getifaddrs() call on OpenSolaris

2010-04-30 Thread Jamey Sharp
Reviewed-by: Jamey Sharp ja...@minilop.net I haven't tested it or anything, but the change looks correct to me. On another note, those are way more helpful warnings than GCC gives. I'm impressed. On Thu, Apr 29, 2010 at 10:39 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: OpenSolaris

Re: [PULL] misc XQuartz fixes

2010-04-30 Thread Keith Packard
On Tue, 27 Apr 2010 13:23:26 -0700, Jeremy Huddleston jerem...@apple.com wrote: This pull request includes an unreviewed patch outside of XQuartz which has been submitted to the list twice. It is small and just adds some sanity checking to miPaintWindow. These checks used to be in XQuartz'

Re: [PULL] use LRMI for real-mode calls

2010-04-30 Thread Keith Packard
On Wed, 28 Apr 2010 20:58:58 +0300, Tiago Vignatti tiago.vigna...@nokia.com wrote: Unfortunately no commits here got a review tag. Even so, I'm keeping this work openly for months already and I'd like to work on it to integrate now. So please, tell me your thoughts. Deleting this much code

Re: [PULL] misc XQuartz fixes

2010-04-30 Thread Jeremy Huddleston
On Apr 30, 2010, at 12:44, Keith Packard wrote: On Tue, 27 Apr 2010 13:23:26 -0700, Jeremy Huddleston jerem...@apple.com wrote: This pull request includes an unreviewed patch outside of XQuartz which has been submitted to the list twice. It is small and just adds some sanity checking to

Re: [PULL] use LRMI for real-mode calls

2010-04-30 Thread Adam Jackson
On Fri, 2010-04-30 at 12:50 -0700, Keith Packard wrote: On Wed, 28 Apr 2010 20:58:58 +0300, Tiago Vignatti tiago.vigna...@nokia.com wrote: Unfortunately no commits here got a review tag. Even so, I'm keeping this work openly for months already and I'd like to work on it to integrate now.

Re: [PULL] use LRMI for real-mode calls

2010-04-30 Thread Mark Kettenis
From: Adam Jackson a...@nwnk.net Date: Fri, 30 Apr 2010 17:37:32 -0400 - backend-x86emu.c looks like it loses the feature of mapping the 1M arena wherever the kernel pleases, and instead reverts to mapping it at the 0 page. This is a security bug on arches where kernel virtual addresses

Re: [PULL 1.8] Enable RECORD, linuxdoc build fixes

2010-04-30 Thread Peter Hutterer
On Fri, Apr 30, 2010 at 03:50:26PM -0500, Yaakov (Cygwin/X) wrote: Peter, Besides re-enabling RECORD, these are just build fixes. The following changes since commit 88ba993aaf3f810c6dfc1fb113d5d075eeb390b4: Keith Packard (1): Exa screen private has SavedSourceValidate, not

Re: [PULL] misc XQuartz fixes

2010-04-30 Thread Keith Packard
On Fri, 30 Apr 2010 13:13:16 -0700, Jeremy Huddleston jerem...@apple.com wrote: what about the early return if it's an UNDRAWABLE_WINDOW? pWin-drawable cannot ever be NULL unless pWin is NULL, and that 'can't happen'. -- keith.pack...@intel.com pgpGzgN6px40K.pgp Description: PGP signature

[PATCH 1/2] Fix cursor ref counting mistakes with sprites and xf86Cursor.c

2010-04-30 Thread Keith Packard
A few cursor value assignments weren't getting correctly ref counted, causing leaks of cursor objects. Signed-off-by: Keith Packard kei...@keithp.com --- dix/devices.c |2 ++ dix/events.c | 20 +++- hw/xfree86/ramdac/xf86Cursor.c |2 ++

[PATCH 2/2] Make sure XFixes invisible cursor gets freed on server reset

2010-04-30 Thread Keith Packard
This uses the same hack that dix uses for the rootCursor -- allocate a resource ID for the invisible cursor so that it gets freed at reset time. This also allows us to unconditionally create it during extension initialization; necessary as the privates layout may well be different on subsequent

Re: [PULL] misc XQuartz fixes

2010-04-30 Thread Jeremy Huddleston
On Apr 30, 2010, at 15:53, Keith Packard wrote: On Fri, 30 Apr 2010 13:13:16 -0700, Jeremy Huddleston jerem...@apple.com wrote: what about the early return if it's an UNDRAWABLE_WINDOW? pWin-drawable cannot ever be NULL unless pWin is NULL, and that 'can't happen'. I didn't ask about

Re: [PATCH 2/2] Make sure XFixes invisible cursor gets freed on server reset

2010-04-30 Thread Jamey Sharp
On Fri, Apr 30, 2010 at 4:13 PM, Keith Packard kei...@keithp.com wrote: +    if (AllocARGBCursor(psrcbits, pmaskbits, +                       NULL, cm, +                       0, 0, 0, +                       0, 0, 0, +                       pCursor, serverClient, (XID)0) != Success) +