Re: New approach to multitouch using DIDs and bitmasked events

2010-07-28 Thread Peter Hutterer
On Wed, Jul 21, 2010 at 09:27:48AM +0300, Micki Balanga wrote: Hi All, My name is Micki , I works at N-trig. I am responsible on the Linux development at N-trig. I would like to participle the discussion of adapting multi-touch protocol into Xorg server and share my knowledge regards this

Re: [Intel-gfx] xf86-video-intel: configure.ac

2010-07-28 Thread Chris Wilson
On Tue, 27 Jul 2010 09:34:01 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: and glproto is missing a dep on GL: arjan In file included from i810.h:60:0, arjan from i810_accel.c:41: arjan /usr/include/GL/glxint.h:36:19: fatal error: GL/gl.h: No such file or directory

Re: [PATCH 14/15] xkb: Use memcpy for copy

2010-07-28 Thread Mark Kettenis
Date: Wed, 28 Jul 2010 09:25:10 +1000 From: Peter Hutterer peter.hutte...@who-t.net On Tue, Jul 27, 2010 at 03:09:55PM +0300, Pauli Nieminen wrote: Source and destination have well defined size so use memcpy instead of strncpy. strncpy tryes to add NULL to end of destination but it is not

Multikey autorepetition

2010-07-28 Thread Антон Ерофеевский
sory for my english Multikey autorepetition in linux and x-win Has decided to write for this purpose - that most to understand - whether is it in linux a defect or and has been conceived The basic question in that is that if to press 2 keys - why one repeats only? Will tell I in a

Re: [PATCH 14/15] xkb: Use memcpy for copy

2010-07-28 Thread Pauli Nieminen
On 28/07/10 11:48 +0200, ext Mark Kettenis wrote: Date: Wed, 28 Jul 2010 09:25:10 +1000 From: Peter Hutterer peter.hutte...@who-t.net On Tue, Jul 27, 2010 at 03:09:55PM +0300, Pauli Nieminen wrote: Source and destination have well defined size so use memcpy instead of strncpy.

Re: [PATCH 10/15] xkb: Fix possible NULL pointer dereference

2010-07-28 Thread Pauli Nieminen
On 28/07/10 01:15 +0200, ext Peter Hutterer wrote: On Tue, Jul 27, 2010 at 03:09:51PM +0300, Pauli Nieminen wrote: If search for device failed sli is NULL. In that case we have to protect dereference to prevent server crash. Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com

Re: [PATCH 09/15] xkb: Don't check for NULL when pointer can't be NULL

2010-07-28 Thread Pauli Nieminen
On 28/07/10 01:08 +0200, ext Peter Hutterer wrote: On Tue, Jul 27, 2010 at 03:09:50PM +0300, Pauli Nieminen wrote: Caller quarantines that pAction pointer is valid. ^^ guarantees? yes. same applies here as well as for the other patch, it's not the caller guaranteeing that

Re: [PATCH 14/15] xkb: Use memcpy for copy

2010-07-28 Thread Daniel Stone
On Wed, Jul 28, 2010 at 02:11:05PM +0300, Pauli Nieminen wrote: On Tue, Jul 27, 2010 at 03:09:55PM +0300, Pauli Nieminen wrote: Source and destination have well defined size so use memcpy instead of strncpy. strncpy tryes to add NULL to end of destination but it is not

Re: [Intel-gfx] xf86-video-intel: configure.ac

2010-07-28 Thread Kristian Høgsberg
On Wed, Jul 28, 2010 at 4:42 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 27 Jul 2010 09:34:01 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: and glproto is missing a dep on GL: arjan In file included from i810.h:60:0, arjan                  from i810_accel.c:41: arjan

Re: [PATCH 2/2] Add support for per-axis valuator modes (Relative/Absolute)

2010-07-28 Thread Chase Douglas
On Wed, 2010-07-28 at 14:55 +1000, Peter Hutterer wrote: On Fri, Jul 16, 2010 at 09:21:19AM -0400, Chase Douglas wrote: @@ -309,6 +315,12 @@ countValuators(DeviceEvent *ev, int *first) for (i = 0; i sizeof(ev-valuators.mask) * 8; i++) { +/* Assume mode of 0th

Re: [PATCH 14/15] xkb: Use memcpy for copy

2010-07-28 Thread Kristian Høgsberg
On Wed, Jul 28, 2010 at 7:26 AM, Daniel Stone dan...@fooishbar.org wrote: On Wed, Jul 28, 2010 at 02:11:05PM +0300, Pauli Nieminen wrote: On Tue, Jul 27, 2010 at 03:09:55PM +0300, Pauli Nieminen wrote: Source and destination have well defined size so use memcpy instead of strncpy.

[PATCH libX11] specs: move indexterm from glossdef to glossterm

2010-07-28 Thread Gaetan Nadon
This move fixes a Java class cast exception in the glossary. The problem was introduced in commit 26f4f0d50840fe5ba4c46aae0a8e68db0059434b It may not happen on all versions of the doc toolchain. There is no reason why indexterm cannot appear in glossdef, this is a workaround to an implementation

Re: [RFC] Refactoring of dix/dixutils.c

2010-07-28 Thread Tiago Vignatti
On Wed, Jul 28, 2010 at 07:42:18AM +0200, ext Fernando Carrijo wrote: My humble attempt to put some order in dix. For lack of inspiration (or knowledge, if you prefer) I didn't touch the original copyright notices, and simply copied them verbatim to the new files; exactly like I did to

Re: [PATCH] int10: Remove the vm86 and stub backends

2010-07-28 Thread Matthew Garrett
On Tue, Jul 27, 2010 at 08:23:05PM +0200, Mark Kettenis wrote: How about fixing those bugs before killing it? Because right now there's no incentive for anyone to fix those bugs because they can use the vm86 backend instead? -- Matthew Garrett | mj...@srcf.ucam.org

Re: [PATCH] int10: Remove the vm86 and stub backends

2010-07-28 Thread Alan Coopersmith
Matthew Garrett wrote: On Tue, Jul 27, 2010 at 10:47:05PM +0200, Mark Kettenis wrote: Which makes me seriously doubt that these bugs can be found and fixed fast enough such that users won't be affected. If vm86 were an option on anything other than 32-bit x86 I'd have sympathy with

Re: [PATCH] int10: Remove the vm86 and stub backends

2010-07-28 Thread Alex Deucher
On Wed, Jul 28, 2010 at 11:29 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Matthew Garrett wrote: On Tue, Jul 27, 2010 at 10:47:05PM +0200, Mark Kettenis wrote: Which makes me seriously doubt that these bugs can be found and fixed fast enough such that users won't be affected. If

Re: [PATCH 05/15] xkb: Check for unsuported comibnation of action for XkbSetMap

2010-07-28 Thread Pauli Nieminen
On Wed, Jul 28, 2010 at 1:58 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Jul 27, 2010 at 03:09:46PM +0300, Pauli Nieminen wrote: This prevents validation code from using uninitialized values. Fixes: uninit_use_in_call: Using uninitialized element of array symsPerKey in call to

Re: [PATCH] int10: Remove the vm86 and stub backends

2010-07-28 Thread Matthew Garrett
On Wed, Jul 28, 2010 at 08:29:50AM -0700, Alan Coopersmith wrote: Isn't vm86 even further limited to just those machines running the Linux kernel, not BSD or Solaris or anything else? (Okay, maybe that doesn't take a huge chunk out of the number of machines that can run it, but it is

Re: [PATCH video-ati] The local copy of the modes code is no longer required.

2010-07-28 Thread Gaetan Nadon
On Wed, 2010-07-21 at 01:00 -0400, Alex Deucher wrote: I haven't had time to test this old stuff in ages, so unless there is anyone that still uses or needs the old compat code, I'm fine with this patch. Any distros out there still use this? Alex May I proceed with the patch? Just out

Re: [PATCH video-ati] The local copy of the modes code is no longer required.

2010-07-28 Thread Alex Deucher
On Wed, Jul 28, 2010 at 2:16 PM, Gaetan Nadon mems...@videotron.ca wrote: On Wed, 2010-07-21 at 01:00 -0400, Alex Deucher wrote: I haven't had time to test this old stuff in ages, so unless there is anyone that still uses or needs the old compat code, I'm fine with this patch.  Any distros

[ANN] libTISCH 1.1.0 (with XInput 2 support)

2010-07-28 Thread Florian Echtler
Hello everyone, I'd like to make a short announcement - I've recently published the 1.1 release of libTISCH, our multitouch development platform. Source code is available at http://sf.net/projects/tisch/ while PPA packages for Ubuntu 10.04 9.10 are at

xf86-video-xgi

2010-07-28 Thread Trevor Woerner
I needed the following code modification in order to follow the instructions here: http://xorg.freedesktop.org/wiki/ModularDevelopersGuide to build the X.Org code from git. I'm curious to know if this is a general solution, or something that is required only for my environment. diff --git

[PATCH xts 0/2] xts patches

2010-07-28 Thread Jon TURNEY
A couple of build fixes I needed, including a for building with srcdir != builddir, although I have no idea if 'make check' actually works when built like that. Jon TURNEY (2): Place libapi_s after objects which reference it in the link order, so it links successfully for linkers which

[PATCH xts 1/2] Place libapi_s after objects which reference it in the link order, so it links successfully for linkers which work -as-needed

2010-07-28 Thread Jon TURNEY
Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk --- xts5/Xlib12/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xts5/Xlib12/Makefile.am b/xts5/Xlib12/Makefile.am index 755b1a7..c7a7568 100644 --- a/xts5/Xlib12/Makefile.am +++ b/xts5/Xlib12/Makefile.am

[PATCH xts 2/2] Fixes for building srcdir != builddir

2010-07-28 Thread Jon TURNEY
Ensure $(builddir)/bin directory exists before trying to create xts-run/xts-config scripts in it Run xts-config from $(builddir) to create tetexec.cfg Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk --- xts5/Makefile.am |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff

[PATCH] configure: GLX_USE_TLS doesn't depend on AIGLX

2010-07-28 Thread Julien Cristau
From: Samuel Thibault samuel.thiba...@ens-lyon.org It is also necessary for swrast. Hurd doesn't have AIGLX (because it doesn't have DRI), but it needs the GLX_USE_TLS define if mesa is built with tls. Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org Signed-off-by: Julien Cristau

[PATCH v2 2/7] xkb: Fix possible NULL pointer dereference

2010-07-28 Thread Pauli Nieminen
changes is deferenced unconditionaly later on in function. Because XkbUpdateKeyTypesFromCore is exported function paramters should be checked for driver errors. Fixes: Variable changes tracked as NULL was dereferenced. Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com --- Added NULL

[PATCH v2 4/7] xkb: Use strdup for string copy

2010-07-28 Thread Pauli Nieminen
Code is doing opencoded string copy that can be done with strdup library call. Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com --- new patch based on Peter's review that strdup should be used to duplicating the string. xkb/XKBGAlloc.c |6 ++ 1 files changed, 2 insertions(+),

[PATCH v2 1/7] xkb: Check for unsuported comibnation of action for XkbSetMap

2010-07-28 Thread Pauli Nieminen
This prevents validation code from using unitialized values. Validation code depends on the previous step to produce lookup table for the next step. Fixes: Using uninitialized element of array symsPerKey in call to function CheckKeyActions Using uninitialized element of array mapWidths in call to

[PATCH v2 3/7] xkb: Fix allocation check to compare correct variable

2010-07-28 Thread Pauli Nieminen
prop-name is allocated in code but check is for parameter name that can't be NULL. Fixes: Cannot reach dead statement return NULL; Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com --- improved commit message xkb/XKBGAlloc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH v2 6/7] xkb: Use memcpy for copy

2010-07-28 Thread Pauli Nieminen
Source is not NULL terminated string so using memcpy instead of strncpy makes more sense. All other places doing same copy are using memcpy. memset is redurant because memcpy will write usefull values anyway. fixes: Calling strncpy with a maximum size argument of (4) on destination buffer

[PATCH v2 5/7] xkb: Use memcpy for copy

2010-07-28 Thread Pauli Nieminen
Source is not NULL terminated string so using memcpy instead of strncpy makes more sense. All other places doing same copy are using memcpy. fixes: Calling strncpy with a maximum size argument of (4) on destination buffer key-under.name of size (4) can possibly leave the destination buffer

[PULL] xkb fixes for static analiser reported bugs

2010-07-28 Thread Pauli Nieminen
The following changes since commit 9c171d4aee695ab66e6db1ab92539557bd368cfa: Alan Coopersmith (1): Add documentation of the Xserver DTrace probes are available in the git repository at: git://anongit.freedesktop.org/~suokko/xserver.git xkb_fixes_1 Pauli Nieminen (9): xkb: Use

[PATCH] dix: Better document the functions Dispatch(), WaitForSomething() and alike.

2010-07-28 Thread Fernando Carrijo
Signed-off-by: Fernando Carrijo fcarr...@yahoo.com.br --- Wrote this patch more as an exercise than anything else. And while I realize that there's a thin line between what people consider benign and pernicious commenting styles, I tend to believe that in case of intricate code such as this, we

[PATCH app-xscope] Retry _X11TransConnect on TRANS_TRY_CONNECT_AGAIN

2010-07-28 Thread Jeff Smith
Reading through Xtranssock.c reveals that when _X11TransConnect returns the value TRANS_TRY_CONNECT_AGAIN, it turns off the abstract socket flag, so that attempting _X11TransConnect might succeed the second time where it failed the first time. Now xscope will attempt the connection a second time

[PATCH xf86-video-xgi] Modify search for drm include.

2010-07-28 Thread Trevor Woerner
From: Trevor Woerner twoer...@gmail.com The build system already includes the location of the drm header file (using -I) so the source doesn't need to hard-code the relative path. Signed-off-by: Trevor Woerner twoer...@gmail.com --- src/xgi_dri.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH xf86-video-xgi] Modify search for drm include.

2010-07-28 Thread Gaetan Nadon
On Wed, 2010-07-28 at 16:34 -0400, Trevor Woerner wrote: -#include drm/drm.h +#include drm.h The xgi driver is built regularly on http://tinderbox.freedesktop.org/ so I don't see why you would need this. It also builds fine on my system where I have all current git packages. You did not

Re: [PATCH xf86-video-xgi] Modify search for drm include.

2010-07-28 Thread Trevor Woerner
On Wed, Jul 28, 2010 at 5:04 PM, Gaetan Nadon mems...@videotron.ca wrote: On Wed, 2010-07-28 at 16:34 -0400, Trevor Woerner wrote: -#include drm/drm.h +#include drm.h The xgi driver is built regularly on http://tinderbox.freedesktop.org/ so I don't see why you would need this. It also

Re: [PATCH 14/15] xkb: Use memcpy for copy

2010-07-28 Thread Peter Hutterer
On Wed, Jul 28, 2010 at 02:11:05PM +0300, Pauli Nieminen wrote: On 28/07/10 11:48 +0200, ext Mark Kettenis wrote: Date: Wed, 28 Jul 2010 09:25:10 +1000 From: Peter Hutterer peter.hutte...@who-t.net On Tue, Jul 27, 2010 at 03:09:55PM +0300, Pauli Nieminen wrote: Source and

Re: [PATCH xts 0/2] xts patches

2010-07-28 Thread Peter Hutterer
On Wed, Jul 28, 2010 at 07:28:33PM +0100, Jon TURNEY wrote: A couple of build fixes I needed, including a for building with srcdir != builddir, although I have no idea if 'make check' actually works when built like that. Jon TURNEY (2): Place libapi_s after objects which reference it in

[PULL] Fix a regression in XQuartz due to recent GLX changes

2010-07-28 Thread Jeremy Huddleston
The following changes since commit 9c171d4aee695ab66e6db1ab92539557bd368cfa: Add documentation of the Xserver DTrace probes (2010-07-23 12:41:59 -0700) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master Jeremy Huddleston (1): XQuartz: GLX:

Re: [PATCH v2 2/7] xkb: Fix possible NULL pointer dereference

2010-07-28 Thread Peter Hutterer
On Wed, Jul 28, 2010 at 10:47:02PM +0300, Pauli Nieminen wrote: changes is deferenced unconditionaly later on in function. Because XkbUpdateKeyTypesFromCore is exported function paramters should be ^ typo checked for driver errors. Fixes:

Re: [PATCH v2 1/7] xkb: Check for unsuported comibnation of action for XkbSetMap

2010-07-28 Thread Peter Hutterer
typo in the subject line btw. On Wed, Jul 28, 2010 at 10:47:01PM +0300, Pauli Nieminen wrote: This prevents validation code from using unitialized values. Validation code depends on the previous step to produce lookup table for the next step. Fixes: Using uninitialized element of array

Re: [PATCH xf86-video-xgi] Modify search for drm include.

2010-07-28 Thread Gaetan Nadon
On Wed, 2010-07-28 at 17:18 -0400, Trevor Woerner wrote: There is no drm directory, but there is a libdrm. So for my build I either have to modify the #include to say libdrm/drm.h or simply drm.h. Seeing that the radeonhd uses drm.h that's what I submitted. I think previous versions were

Re: [RFC] Refactoring of dix/dixutils.c

2010-07-28 Thread Jamey Sharp
I like this series. I haven't had a chance to confirm that the code is moved unchanged into the new source files, or to think about your copyright notices question, but splitting distinct functionality out of dixutils.c seems like an excellent idea to me. On Wed, Jul 28, 2010 at 05:55:38PM +0300,

Re: [PATCH] dix: Better document the functions Dispatch(), WaitForSomething() and alike.

2010-07-28 Thread Jamey Sharp
On Wed, Jul 28, 2010 at 05:26:34PM -0300, Fernando Carrijo wrote: Signed-off-by: Fernando Carrijo fcarr...@yahoo.com.br --- Wrote this patch more as an exercise than anything else. And while I realize that there's a thin line between what people consider benign and pernicious commenting