Re: [PATCH 0/5] glx input sanitizing

2011-01-10 Thread Julien Cristau
On Mon, Jan 3, 2011 at 21:08:05 +0100, Julien Cristau wrote: Most of this series has been sitting in bug#28823 for a while. It adds some missing checks for client-provided data in the glx code, and fixes a bug in the swapped-client path (patch 4/5). Anyone? Cheers, Julien

Re: [PATCH 0/5] glx input sanitizing

2011-01-10 Thread Kristian Høgsberg
On Mon, Jan 10, 2011 at 6:41 AM, Julien Cristau jcris...@debian.org wrote: On Mon, Jan  3, 2011 at 21:08:05 +0100, Julien Cristau wrote: Most of this series has been sitting in bug#28823 for a while.  It adds some missing checks for client-provided data in the glx code, and fixes a bug in the

Re: [PATCH 1/5] glx: make sure screen is non-negative in validGlxScreen

2011-01-10 Thread Daniel Stone
On Mon, Jan 03, 2011 at 09:08:06PM +0100, Julien Cristau wrote: Reviewed-by: Adam Jackson a...@redhat.com Signed-off-by: Julien Cristau jcris...@debian.org Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature

Re: [PATCH 2/5] glx: validate request lengths

2011-01-10 Thread Daniel Stone
On Mon, Jan 03, 2011 at 09:08:07PM +0100, Julien Cristau wrote: Reviewed-by: Adam Jackson a...@redhat.com Signed-off-by: Julien Cristau jcris...@debian.org Reviewed-by: Daniel Stone dan...@fooishbar.org Although this could probably be merged with the validate-swapped-lengths patch ... Cheers,

Re: [PATCH 3/5] glx: check request length before swapping

2011-01-10 Thread Daniel Stone
On Mon, Jan 03, 2011 at 09:08:08PM +0100, Julien Cristau wrote: Signed-off-by: Julien Cristau jcris...@debian.org Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 4/5] glx: swap the request arrays entirely, not just half of them

2011-01-10 Thread Daniel Stone
On Mon, Jan 03, 2011 at 09:08:09PM +0100, Julien Cristau wrote: Various glx request include a list of pairs of attributes. We were only swapping the first half. Signed-off-by: Julien Cristau jcris...@debian.org Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description:

Re: [PATCH 5/5] glx: validate numAttribs field before using it

2011-01-10 Thread Daniel Stone
On Mon, Jan 03, 2011 at 09:08:10PM +0100, Julien Cristau wrote: Signed-off-by: Julien Cristau jcris...@debian.org Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH] xfree86/modes: Be sure to only use new EDID for physical output dimensions

2011-01-10 Thread Adam Jackson
On Fri, 2011-01-07 at 19:10 -0800, Evan Broder wrote: The EDID processing regards physical dimensions of 0mm x 0mm as invalid. Previously the old values for height and width would be preserved if none of the physical dimension specifications in the new EDID were considered valid. This will

Re: [PATCH bitmap] Remove unused, leaky scanline.

2011-01-10 Thread Adam Jackson
On Sat, 2011-01-08 at 20:15 -0500, Trevor Woerner wrote: From: Trevor Woerner twoer...@gmail.com The pointer, scanline, doesn't appear to be used anymore, and is leaking memory. Signed-off-by: Trevor Woerner twoer...@gmail.com Reviewed-by: Adam Jackson a...@redhat.com - ajax

[git pull] glx input sanitizing

2011-01-10 Thread Julien Cristau
Hi Keith, The following changes since commit 6358a60065eef167d4e5f4afd981ff26deeba80d: EXA: Pad size of system memory copy for 1x1 pixmaps (bug #32803). (2011-01-06 08:37:27 -0800) are available in the git repository at: git://people.freedesktop.org/~jcristau/xserver for-keith Julien

Re: [PATCH 2/5] resource: s/NullResource/NULL/g

2011-01-10 Thread Daniel Stone
On Fri, Jan 07, 2011 at 02:27:26PM -0500, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 1/5] resource: Remove a useless iteration

2011-01-10 Thread Daniel Stone
Hi, On Fri, Jan 07, 2011 at 02:27:25PM -0500, Adam Jackson wrote: dix/resource.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dix/resource.c b/dix/resource.c index 6bd2403..07fcc65 100644 --- a/dix/resource.c +++ b/dix/resource.c @@ -382,7 +382,6 @@

Re: [PATCH 3/5] resource: Remove a redundant field from client resource tracking

2011-01-10 Thread Daniel Stone
On Fri, Jan 07, 2011 at 02:27:27PM -0500, Adam Jackson wrote: We only ever need log2(buckets) when rebuilding the table, which is comparatively rare. Compute it when we need it instead of tracking it by hand. Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Daniel Stone

Re: [PATCH 4/5] resource: Remove expectID hack

2011-01-10 Thread Daniel Stone
On Fri, Jan 07, 2011 at 02:27:28PM -0500, Adam Jackson wrote: This is clearly meant to short-circuit the (modestly) expensive resource lookup in LegalNewID. The problem is that long-lived clients will eventually run completely through their XID space and start asking XC-MISC for IDs to reuse.

Re: [PATCH 5/5] resource: Fix indentation

2011-01-10 Thread Daniel Stone
On Fri, Jan 07, 2011 at 02:27:29PM -0500, Adam Jackson wrote: Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Daniel Stone dan...@fooishbar.org signature.asc Description: Digital signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH xinput xi2.1] Ensure that the parent always accepts or rejects a touch

2011-01-10 Thread Daniel Stone
On Fri, Jan 07, 2011 at 01:06:04PM -0500, Chase Douglas wrote: If a touch ends before the 5 motion events have occurred, the parent window must also accept or reject the touch. Otherwise, the touch will be left dangling. I also added a printout stating whether the client accepted or rejected

Re: [PATCH] x11proto: Add #defines for Unicode Sinhala to keysymdef.h

2011-01-10 Thread Daniel Stone
Hi, On Mon, Jan 10, 2011 at 12:21:28AM +1100, Harshula Jayasuriya wrote: Add #defines for Unicode Sinhala so that they can be used in the lk XKB keyboard layout. Signed-off-by: Harshula Jayasuriya harsh...@gmail.com +#ifdef XK_SINHALA Err ... are you missing a matching #define XK_SINHALA

[Patch] Fix passive grabs

2011-01-10 Thread Philipp Reh
From 29af7ea82c6168db3c2f082bda033c143a610e8b Mon Sep 17 00:00:00 2001 From: Philipp Reh s...@s-e-f-i.de Date: Mon, 10 Jan 2011 17:35:57 +0100 Subject: [PATCH] Fix passive grabs. _XIPassiveGrabDevice, which is called by alle the passive grab functions, wrongly returns an error when it shouldn't.

Re: [PATCH] x11proto: Add #defines for Unicode Sinhala to keysymdef.h

2011-01-10 Thread Harshula
Hi Daniel, On Mon, 2011-01-10 at 15:09 +, Daniel Stone wrote: Hi, On Mon, Jan 10, 2011 at 12:21:28AM +1100, Harshula Jayasuriya wrote: Add #defines for Unicode Sinhala so that they can be used in the lk XKB keyboard layout. Signed-off-by: Harshula Jayasuriya harsh...@gmail.com

[PATCH] resource: Remove a useless iteration

2011-01-10 Thread Adam Jackson
v2: More aggressive loop rewrite pointed out by Daniel. Signed-off-by: Adam Jackson a...@redhat.com --- dix/resource.c | 28 1 files changed, 12 insertions(+), 16 deletions(-) diff --git a/dix/resource.c b/dix/resource.c index 6bd2403..ed8cc35 100644 ---

Re: [Patch] Fix passive grabs

2011-01-10 Thread Daniel Stone
On Mon, Jan 10, 2011 at 06:09:07PM +0100, Philipp Reh wrote: From 29af7ea82c6168db3c2f082bda033c143a610e8b Mon Sep 17 00:00:00 2001 From: Philipp Reh s...@s-e-f-i.de Date: Mon, 10 Jan 2011 17:35:57 +0100 Subject: [PATCH] Fix passive grabs. _XIPassiveGrabDevice, which is called by alle the

Re: [PATCH] resource: Remove a useless iteration

2011-01-10 Thread Daniel Stone
On Mon, Jan 10, 2011 at 12:44:23PM -0500, Adam Jackson wrote: v2: More aggressive loop rewrite pointed out by Daniel. Sorry, I should've mentioned this the first time -- only realised after I sent the mail -- but: +for (i = 0; i clientTable[client].buckets; i++) { + res =

Re: [PATCH xinput xi2.1] Ensure that the parent always accepts or rejects a touch

2011-01-10 Thread Chase Douglas
On 01/10/2011 09:08 AM, Daniel Stone wrote: On Fri, Jan 07, 2011 at 01:06:04PM -0500, Chase Douglas wrote: If a touch ends before the 5 motion events have occurred, the parent window must also accept or reject the touch. Otherwise, the touch will be left dangling. I also added a printout

Re: [PATCH xinput xi2.1] Ensure that the parent always accepts or rejects a touch

2011-01-10 Thread Daniel Stone
On Mon, Jan 10, 2011 at 11:51:12AM -0600, Chase Douglas wrote: On 01/10/2011 09:08 AM, Daniel Stone wrote: On Fri, Jan 07, 2011 at 01:06:04PM -0500, Chase Douglas wrote: If a touch ends before the 5 motion events have occurred, the parent window must also accept or reject the touch.

Re: [PULL] Cursor confinement ABI

2011-01-10 Thread Adam Jackson
On Thu, 2011-01-06 at 15:01 -0500, Adam Jackson wrote: Apologies for no r-b on the list, but: Also apologies for not cc'ing Keith. - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH] resource: Remove a useless iteration

2011-01-10 Thread Adam Jackson
On Mon, 2011-01-10 at 17:49 +, Daniel Stone wrote: On Mon, Jan 10, 2011 at 12:44:23PM -0500, Adam Jackson wrote: v2: More aggressive loop rewrite pointed out by Daniel. Sorry, I should've mentioned this the first time -- only realised after I sent the mail -- but: +for (i = 0; i

[PATCH] resource: Micro-tune resource hash computation

2011-01-10 Thread Adam Jackson
We do actually call Hash() on resource lookup, so let's not make it more expensive than necessary. The compiler isnmay not be smart enough to notice that we only ever have a power of two count of buckets, so flatten the log2 math so it doesn't have to know. Signed-off-by: Adam Jackson

Re: [PATCH xinput xi2.1] Ensure that the parent always accepts or rejects a touch

2011-01-10 Thread Peter Hutterer
On Mon, 10 Jan 2011 17:58:52 +, Daniel Stone dan...@fooishbar.org wrote: On Mon, Jan 10, 2011 at 11:51:12AM -0600, Chase Douglas wrote: On 01/10/2011 09:08 AM, Daniel Stone wrote: On Fri, Jan 07, 2011 at 01:06:04PM -0500, Chase Douglas wrote: If a touch ends before the 5 motion events