Re: [PATCH xserver] Xi: make XIQueryPointer return the current modifiers/group as documented.

2011-02-08 Thread Daniel Stone
On Mon, Feb 07, 2011 at 06:21:31PM +0100, carl...@gnome.org wrote: From: Carlos Garnacho carl...@gnome.org The previous XKB info was being returned instead of the current one, producing inconsistent results between the latest events and the modifiers/group returned by this call.

[PATCH 0/4] Fix some valgrind uninitialised byte errors.

2011-02-08 Thread Ander Conselvan de Oliveira
The following patches fix points to uninitialised bytes errors reported by valgrind when running Xorg. The four patches are quite similar so maybe they should be squashed into just one or two, but I made it this way so that there wouldn't be huge commit messages. Ander Conselvan de Oliveira (4):

[PATCH 1/4] ProcRRQueryVersion: fix use of uninitialised bytes valgrind error.

2011-02-08 Thread Ander Conselvan de Oliveira
==== Syscall param writev(vector[...]) points to uninitialised byte(s) ====at 0x4AB5154: writev (writev.c:51) ====by 0x7C7C3: _XSERVTransWritev (Xtrans.c:912) ====by 0x61C8B: FlushClient (io.c:924) ====by 0x62743: FlushAllOutput (io.c:668) ====by

[PATCH 2/4] ProcRRCreateMode: fix use of uninitialised bytes valgrind error.

2011-02-08 Thread Ander Conselvan de Oliveira
==543== Syscall param writev(vector[...]) points to uninitialised byte(s) ==543==at 0x4AB7154: writev (writev.c:51) ==543==by 0x8935B: _XSERVTransWritev (Xtrans.c:912) ==543==by 0x6C55F: FlushClient (io.c:924) ==543==by 0x6D013: FlushAllOutput (io.c:668) ==543==by 0x27A83:

[PATCH 4/4] XkbSendNames: fix use of uninitialised bytes valgrind error.

2011-02-08 Thread Ander Conselvan de Oliveira
==537== Syscall param writev(vector[...]) points to uninitialised byte(s) ==537==at 0x4AB7154: writev (writev.c:51) ==537==by 0x8935B: _XSERVTransWritev (Xtrans.c:912) ==537==by 0x6C55F: FlushClient (io.c:924) ==537==by 0x6CCF3: WriteToClient (io.c:846) ==537==by 0xD51D3:

[PATCH 3/4] ProcXkbGetXkbByName: fix use of uninitialised bytes valgrind error.

2011-02-08 Thread Ander Conselvan de Oliveira
==== Syscall param writev(vector[...]) points to uninitialised byte(s) ====at 0x4AB5154: writev (writev.c:51) ====by 0x7C7C3: _XSERVTransWritev (Xtrans.c:912) ====by 0x61C8B: FlushClient (io.c:924) ====by 0x62423: WriteToClient (io.c:846) ====by 0xCE39B:

Re: [PATCH synaptics] Add hysteresis-based noise reduction

2011-02-08 Thread Simon Thum
On 02/08/2011 01:23 AM, Peter Hutterer wrote: On Mon, Feb 07, 2011 at 11:32:27PM +0100, Simon Thum wrote: This introduces hysteresis into the driver's processing. It significantly reduces noise motion, i.e. now the pad does no longer generate a stream of sub-pixel events when just holding the

Porting xf86-video-v4l to use textured video

2011-02-08 Thread Mauro Carvalho Chehab
I'm currently working on make xawtv and xf86-video-v4l fully functional, in order to allow us to test the overlay part of the V4L2 API. I just sent a big patch replacing the old API to the new one, so the driver should be working now. However, only a very few set of drivers will benefit from

Re: [PATCH] Port xf86-video-v4l driver to V4L2

2011-02-08 Thread Thierry Vignaud
On 8 February 2011 10:42, Mauro Carvalho Chehab mche...@redhat.com wrote: @@ -57,16 +65,16 @@ static MODULESETUPPROTO(v4lSetup);  static XF86ModuleVersionInfo v4lVersRec =  { -        v4l, -        MODULEVENDORSTRING, -        MODINFOSTRING1, -        MODINFOSTRING2, -        

Re: [PATCH] Port xf86-video-v4l driver to V4L2

2011-02-08 Thread Mauro Carvalho Chehab
Hi Thierry, Em 08-02-2011 08:12, Thierry Vignaud escreveu: On 8 February 2011 10:42, Mauro Carvalho Chehab mche...@redhat.com wrote: @@ -57,16 +65,16 @@ static MODULESETUPPROTO(v4lSetup); static XF86ModuleVersionInfo v4lVersRec = { -v4l, -MODULEVENDORSTRING, -

Re: [PATCH] Port xf86-video-v4l driver to V4L2

2011-02-08 Thread Mauro Carvalho Chehab
Hi Thierry, Em 08-02-2011 08:12, Thierry Vignaud escreveu: On 8 February 2011 10:42, Mauro Carvalho Chehab mche...@redhat.com wrote: @@ -57,16 +65,16 @@ static MODULESETUPPROTO(v4lSetup); static XF86ModuleVersionInfo v4lVersRec = { -v4l, -MODULEVENDORSTRING, -

[PATCH] xserver: Don't crash if Xv is not initialized

2011-02-08 Thread Mauro Carvalho Chehab
The xf86-video-v4l video driver calls xf86XVQueryOffscreenImages() function in order to probe for the Xv FOURCC formats supported for PutVideo ops. However, as this support is deprecated on most of the modern drivers, a call to this method will cause a crash: X: ../../../include/privates.h:115:

Porting xf86-video-v4l to use textured video

2011-02-08 Thread Mauro Carvalho Chehab
I'm currently working on make xawtv and xf86-video-v4l fully functional, in order to allow us to test the overlay part of the V4L2 API. I just sent a big patch replacing the old API to the new one, so the driver should be working now. However, only a very few set of drivers will benefit from

Re: [PATCH evdev] Export device node as property.

2011-02-08 Thread Peter Korsgaard
Daniel == Daniel Stone dan...@fooishbar.org writes: We expose a few features of the physical device through the X driver, but other information is available only through the kernel directly. There is no way of associating an input device with the X device it spawned off short of parsing

[PATCH v6 inputproto 1/1] Multitouch updates for pointer emulation

2011-02-08 Thread Daniel Stone
Hi, Attached is the diff between the last multitouch spec posted to the list, and what I've just pushed to my p.fd.o repository. This takes in a lot of stuff I discussed with Peter during LCA, including: Pointer emulation: We'd hoped it'd be simpler, but as soon as Peter pointed out that we need

Re: [PATCH evdev] Export device node as property.

2011-02-08 Thread Peter Korsgaard
Peter == Peter Hutterer peter.hutte...@who-t.net writes: Hi, Maybe another property is needed to satisfy that. What about Device UID, which is string setup by the driver. On evdev, it uses EVIOCGPHYS, but it's up to the driver since it has the most details about the device. I still

Re: [PATCH 0/4] Fix some valgrind uninitialised byte errors.

2011-02-08 Thread Oliver McFadden
On Tue, 2011-02-08 at 11:10 +0200, ext Ander Conselvan de Oliveira wrote: The following patches fix points to uninitialised bytes errors reported by valgrind when running Xorg. The four patches are quite similar so maybe they should be squashed into just one or two, but I made it this way so

Re: documentation in GSoC

2011-02-08 Thread Donnie Berkholz
On 15:04 Thu 03 Feb , Alan Coopersmith wrote: Sure, but remember that GSoC projects are supposed to be equivalent to a full-time job for 3 months, so it would have to be a bit more than just fixing the documentation for a single library. Unfortunately, GSoC projects have to be coding, not

[PULL] Warning and build cleanups

2011-02-08 Thread ajax
The following changes since commit ea1ffd3e60bdcedbec5a6f28929f8677bf45d450: Merge remote branch 'whot/for-keith' (2011-02-02 15:19:55 -0800) are available in the git repository at: ssh://people.freedesktop.org/~ajax/xserver for-keithp Adam Jackson (8): xf86vidmode: warning fix

Re: [PATCH xserver] Xi: make XIQueryPointer return the current modifiers/group as documented.

2011-02-08 Thread Keith Packard
On Mon, 7 Feb 2011 18:21:31 +0100, carl...@gnome.org wrote: From: Carlos Garnacho carl...@gnome.org The previous XKB info was being returned instead of the current one, producing inconsistent results between the latest events and the modifiers/group returned by this call. Note that core

Re: [PATCH v6 inputproto 1/1] Multitouch updates for pointer emulation

2011-02-08 Thread Keith Packard
On Tue, 8 Feb 2011 10:53:19 +, Daniel Stone dan...@fooishbar.org wrote: This means that one touch event may be simultaneously sending touch events through to touch clients, and enqueuing emulated pointer events as the device is frozen for a grab. Fun times. Does this mean the WM cannot

Re: [PATCH v6 inputproto 1/1] Multitouch updates for pointer emulation

2011-02-08 Thread Daniel Stone
Hi, On Tue, Feb 08, 2011 at 10:12:19AM -0800, Keith Packard wrote: On Tue, 8 Feb 2011 10:53:19 +, Daniel Stone dan...@fooishbar.org wrote: This means that one touch event may be simultaneously sending touch events through to touch clients, and enqueuing emulated pointer events as the

Re: [PATCH xserver] Xi: make XIQueryPointer return the current modifiers/group as documented.

2011-02-08 Thread Daniel Stone
Hi, On Tue, Feb 08, 2011 at 10:08:36AM -0800, Keith Packard wrote: On Mon, 7 Feb 2011 18:21:31 +0100, carl...@gnome.org wrote: From: Carlos Garnacho carl...@gnome.org The previous XKB info was being returned instead of the current one, producing inconsistent results between the latest

Re: [PATCH v6 inputproto 1/1] Multitouch updates for pointer emulation

2011-02-08 Thread Daniel Stone
Hi, On Tue, Feb 08, 2011 at 06:24:47PM +, Daniel Stone wrote: If the WM consumes the event and indicates so to the server with Sync{Pointer,Both}, this is treated the same as a client calling XIAllowTouchEvents with XITouchOwnerAccept: the app gets a TouchEnd event indicating that the

Re: [PATCH v6 inputproto 1/1] Multitouch updates for pointer emulation

2011-02-08 Thread Keith Packard
On Tue, 8 Feb 2011 18:24:47 +, Daniel Stone dan...@fooishbar.org wrote: Either way, the end result is (should be?) indistinguishable from the WM having a touch grab instead of a pointer grab, to everyone else in the stack. Ok, it's crazy complicated, but sounds like what we want. Should

[PATCH 00/11] glxproxy warning fixes

2011-02-08 Thread Adam Jackson
At least with my CFLAGS, this is all I'm getting that isn't about lack of prototypes or declarations. Most of these are pretty trivial but there's a couple that would fix actual bugs. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives:

[PATCH 01/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxcmds.c: In function ‘__glXChangeDrawableAttributes’: glxcmds.c:3464:8: warning: ‘screen’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxcmds.c | 31 --- 1 files changed, 12 insertions(+), 19

[PATCH 02/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxcmds.c: In function ‘__glXGetDrawableAttributes’: glxcmds.c:3295:8: warning: ‘screen’ may be used uninitialized in this function glxcmds.c:3298:8: warning: ‘attribs_size’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxcmds.c |

[PATCH 03/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxcmds.c: In function ‘CreateContext.clone.6’: glxcmds.c:105:19: warning: ‘be_fbconfigId’ may be used uninitialized in this function glxcmds.c:104:14: warning: ‘be_vid’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxcmds.c |4

[PATCH 04/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxcmds.c: In function ‘CreateGLXPixmap’: glxcmds.c:1641:22: warning: ‘pGlxScreen’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxcmds.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[PATCH 05/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxcmds.c: In function ‘CreateGLXPixmap’: glxcmds.c:1663:20: warning: comparison between pointer and integer glxcmds.c:1663:38: warning: comparison between pointer and integer Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxcmds.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 06/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
render2swap.c:264:13: warning: ‘swapArray’ defined but not used Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/render2swap.c | 54 - 1 files changed, 0 insertions(+), 54 deletions(-) diff --git a/hw/dmx/glxProxy/render2swap.c

[PATCH 07/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxsingle.c: In function ‘__glXDisp_ReadPixels’: glxsingle.c:760:11: warning: ‘buf’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxsingle.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[PATCH 10/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxvendor.c: In function ‘__glXVForwardAllWithReply’: glxvendor.c:284:10: warning: ‘be_buf’ may be used uninitialized in this function glxvendor.c:285:10: warning: ‘be_buf_size’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com ---

[PATCH 11/11] glxproxy: warning fix

2011-02-08 Thread Adam Jackson
glxvendor.c: In function ‘__glXVForwardPipe0WithReply’: glxvendor.c:205:10: warning: ‘be_buf’ may be used uninitialized in this function Signed-off-by: Adam Jackson a...@redhat.com --- hw/dmx/glxProxy/glxvendor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: documentation in GSoC

2011-02-08 Thread Matt Dew
On 02/08/2011 09:18 AM, Donnie Berkholz wrote: On 15:04 Thu 03 Feb , Alan Coopersmith wrote: Sure, but remember that GSoC projects are supposed to be equivalent to a full-time job for 3 months, so it would have to be a bit more than just fixing the documentation for a single library.

[PATCH v2 00/10] dri2: Extent life time of DRI2Drawable and DRI2Buffer

2011-02-08 Thread Pauli
From: Pauli Nieminen ext-pauli.niemi...@nokia.com Based on previous review comments I updated the patches. Main change is the code to track the client life explicitly from Christopher. I tough that DRI2DrawableRef held same information but it can't practically used. That modification required

[PATCH v2 01/10] DRI2: Free DRI2 drawable references in DRI2DestroyDrawable

2011-02-08 Thread Pauli
From: Pauli Nieminen ext-pauli.niemi...@nokia.com If client calls DRI2CreateDrawable multiple times for same drawable DRI2 creates multiple references. Multiple references cause DRI2 send multiple invalidate events for same client. Problem is triggered because client side EGL implementation is

[PATCH v2 02/10] dri2: Refactor interface to take DRI2DrawablePtr

2011-02-08 Thread Pauli
From: Pauli Nieminen ext-pauli.niemi...@nokia.com DRI2 swaps may complete after Drawable has been destroyed. This causes memory management problems as DRI2 internal state is tighly coupled with Drawable. DRI2DrawablePtr can be used to access DRI2 functionality. This provides option that DRI2

[PATCH v2 03/10] dri2: Change driver interface to support DRI2Drawable

2011-02-08 Thread Pauli
From: Pauli Nieminen ext-pauli.niemi...@nokia.com To let DRI2Drawable exists longer than Drawable driver has to use DRI2DrawablePtr to complete swaps and MSC waits. This allows DRI2 to clean up after all operations complete without accessing the freed DrawablePtr. v2: * Refactor interface to

[PATCH v2 04/10] dri2: Add reference counting to DRI2

2011-02-08 Thread Pauli
From: Pauli Nieminen ext-pauli.niemi...@nokia.com Asynchronous request like SwapBuffers can still reference Drawable after the Drawable has been freed. DRI2Drawable cleanup should be delayed until all asynchronous operations have completed. Reference counted DRI2Drawable helps to keep

[PATCH v2 05/10] dri2: Keep DRI2Drawable resource allocated until creator frees it

2011-02-08 Thread Pauli
From: Pauli Nieminen ext-pauli.niemi...@nokia.com EGLImage requires that image siblings stay valid until all of them has been freed. Base EGLImage is only required for creating new siblings. http://www.khronos.org/registry/egl/extensions/KHR/EGL_KHR_image_base.txt To keep DRI2Drawable until all

[PATCH v2 07/10] DRI2: Track clients' outstanding swap requests.

2011-02-08 Thread Pauli
From: Christopher James Halse Rogers christopher.halse.rog...@canonical.com Clients can terminate with pending SwapBuffers requests waiting for the trigger, potentially a long way in the future. Track these requests so we don't end up delivering SwapBuffersComplete to an entirely unrelated

[PATCH v2 06/10] DRI2: Reference count buffers across SwapBuffers

2011-02-08 Thread Pauli
From: Christopher James Halse Rogers christopher.halse.rog...@canonical.com The SwapBuffers request requires that we trigger the swap at some point in the future. Sane drivers implement this by passing this request to something that will trigger a callback with the buffer pointers at the

[PATCH v2 09/10] dri2: copy front to fake front in SwapBuffers

2011-02-08 Thread Pauli
From: Pauli Nieminen ext-pauli.niemi...@nokia.com DRI2SwapComplete is too late for front to fake front copy if swap is completed asynchronously. Client could be able to use fake front already before swap completes. Moving front to fake front solves the problem but requires that driver is capable

[PATCH v2 08/10] dri2: Send events only to known clients

2011-02-08 Thread Pauli
From: Pauli Nieminen ext-pauli.niemi...@nokia.com If client disconnects and new client gets same id DRI2 events may end to wrong client. DRI2 reference list can be checked to see if the client still owns the DRI2Drawable. Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com ---

[PATCH v2 10/10] glx: Cleanup DRI2Drawable

2011-02-08 Thread Pauli
From: Pauli Nieminen ext-pauli.niemi...@nokia.com glx should cleanup DRI2Drawable when GLXDrawable is destroyed. Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com --- glx/glxdri2.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/glx/glxdri2.c

Slightly OT Question

2011-02-08 Thread Rick Stockton
I was wondering about an idea- and rather than stumble around (for weeks) on my own, I want to ask you WAY SMARTER guys about it: As you already know, I'm planning to bring some decent support for additional mouse buttons into Qt (things which GTK2 already has). For many, many years, the

Re: [PATCH 01/11] glxproxy: warning fix

2011-02-08 Thread Alan Coopersmith
For the series: Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle Solaris Platform Engineering: X Window System ___ xorg-devel@lists.x.org: X.Org development