[PATCH:setxkbmap] Use snprintf instead of trying to pre-measure sprintf result sizes.

2011-02-10 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- setxkbmap.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/setxkbmap.c b/setxkbmap.c index 868b727..9593ba4 100644 --- a/setxkbmap.c +++ b/setxkbmap.c @@ -626,14 +626,13 @@ findFileInPath(char *name,

Re: [PATCH] exa/mixed: Partially restore deferred pixmap handling for frontbuffer.

2011-02-10 Thread Michel Dänzer
On Mit, 2011-02-09 at 21:09 +0100, Maarten Maathuis wrote: - It turns out that part of the problem was actually on the driver side. I did express my suspicion about that during the review... - The performance loss is not worth the small visual improvement. - This should ensure low latency at

Re: Using XInput 2 to simulate touchevents

2011-02-10 Thread mugunthan
Hi , I m not seeing any events when I run evtest for the touch device == Input driver version is 1.0.1 Input device ID: bus 0x11 vendor 0x2 product 0x7 version 0x1b1 Input device name: SynPS/2 Synaptics TouchPad Supported events: Event type 0 (Sync) Event

[PATCH] [xserver] record: avoid crash when calling RecordFlushReplyBuffer recursively

2011-02-10 Thread Erkki Seppälä
RecordFlushReplyBuffer can call itself recursively through WriteClient-CallCallbacks-_CallCallbacks-RecordFlushAllContexts when the recording client's buffer cannot be completely emptied in one WriteClient. When a such a recursion occurs, it will not be broken out of which results in segmentation

Re: [PATCH 1/2] xkb: split out keymap compilation.

2011-02-10 Thread Dan Nicholson
On Wed, Feb 9, 2011 at 9:34 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Refacturing for simpler double-use in the next patch. No functional changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Nice work cleaning up hairy code. I was going to ask a couple questions about why

Re: [PATCH 2/2] xkb: if the keymap failed to compile, load the default keymap instead.

2011-02-10 Thread Dan Nicholson
On Wed, Feb 9, 2011 at 9:34 PM, Peter Hutterer peter.hutte...@who-t.net wrote: We really need symbols, compat and types for a sensible keymap. Try this in your xorg.conf.d snippets for all keyboards:        Option XkbLayout us        Option XkbVariant nodeadkeys us(nodeadkeys) doesn't exist

Re: [PATCH 2/2] xkb: if the keymap failed to compile, load the default keymap instead.

2011-02-10 Thread Daniel Stone
On Thu, Feb 10, 2011 at 03:34:32PM +1000, Peter Hutterer wrote: We really need symbols, compat and types for a sensible keymap. Try this in your xorg.conf.d snippets for all keyboards: Option XkbLayout us Option XkbVariant nodeadkeys us(nodeadkeys) doesn't exist so xkbcomp

Re: [PATCH v2 03/10] dri2: Change driver interface to support DRI2Drawable

2011-02-10 Thread Ville Syrjälä
On Tue, Feb 08, 2011 at 11:42:49PM +0200, ext Pauli wrote: From: Pauli Nieminen ext-pauli.niemi...@nokia.com To let DRI2Drawable exists longer than Drawable driver has to use DRI2DrawablePtr to complete swaps and MSC waits. This allows DRI2 to clean up after all operations complete without

Re: [PATCH v2 05/10] dri2: Keep DRI2Drawable resource allocated until creator frees it

2011-02-10 Thread Ville Syrjälä
On Tue, Feb 08, 2011 at 11:42:51PM +0200, ext Pauli wrote: From: Pauli Nieminen ext-pauli.niemi...@nokia.com EGLImage requires that image siblings stay valid until all of them has been freed. Base EGLImage is only required for creating new siblings.

Re: [PATCH v2 03/10] dri2: Change driver interface to support DRI2Drawable

2011-02-10 Thread Pauli Nieminen
On 10/02/11 17:40 +0200, Ville Syrjälä wrote: On Tue, Feb 08, 2011 at 11:42:49PM +0200, ext Pauli wrote: From: Pauli Nieminen ext-pauli.niemi...@nokia.com void -DRI2WaitMSCComplete(ClientPtr client, DrawablePtr pDraw, int frame, - unsigned int tv_sec, unsigned int

[PATCH] exa/mixed: Partially restore deferred pixmap handling for frontbuffer.

2011-02-10 Thread Maarten Maathuis
- It turns out that part of the problem was actually on the driver side. - The performance loss is not worth the small visual improvement. - This should ensure low latency at low throughput. - Performance loss seems less than 10% instead of the previous 33%. - It's not needed to set

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-10 Thread Keith Packard
On Thu, 10 Feb 2011 07:41:27 +0100, Michel Dänzer mic...@daenzer.net wrote: Yes, and the patch fixes it at least with the Gallium Xorg state tracker. Ok. Seems like this patch should include other visual types too; should it be using the old path for everything other than TrueColor? --

Re: [PATCH] exa/mixed: Partially restore deferred pixmap handling for frontbuffer.

2011-02-10 Thread Michel Dänzer
On Don, 2011-02-10 at 18:21 +0100, Maarten Maathuis wrote: - It's not needed to set deferred_mixed_pixmap to NULL, because exaDoMigration_mixed will handle that. True, so... @@ -721,9 +721,13 @@ ExaBlockHandler(int screenNum, pointer blockData, pointer pTimeout,

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-10 Thread Michel Dänzer
On Don, 2011-02-10 at 08:42 -0800, Keith Packard wrote: On Thu, 10 Feb 2011 07:41:27 +0100, Michel Dänzer mic...@daenzer.net wrote: Yes, and the patch fixes it at least with the Gallium Xorg state tracker. Ok. Seems like this patch should include other visual types too; should it be

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-10 Thread Michel Dänzer
On Don, 2011-02-10 at 18:46 +0100, Michel Dänzer wrote: On Don, 2011-02-10 at 08:42 -0800, Keith Packard wrote: On Thu, 10 Feb 2011 07:41:27 +0100, Michel Dänzer mic...@daenzer.net wrote: Yes, and the patch fixes it at least with the Gallium Xorg state tracker. Ok. Seems like

[PATCH] exa/mixed: Partially restore deferred pixmap handling for frontbuffer.

2011-02-10 Thread Maarten Maathuis
- It turns out that part of the problem was actually on the driver side. - The performance loss is not worth the small visual improvement. - This should ensure low latency at low throughput. - Performance loss seems about 5% instead of the previous 33%. - It's not needed to set

Re: [PATCH] exa/mixed: Partially restore deferred pixmap handling for frontbuffer.

2011-02-10 Thread Michel Dänzer
On Don, 2011-02-10 at 20:15 +0100, Maarten Maathuis wrote: - It turns out that part of the problem was actually on the driver side. - The performance loss is not worth the small visual improvement. - This should ensure low latency at low throughput. - Performance loss seems about 5% instead

Re: [PATCH] exa/mixed: Partially restore deferred pixmap handling for frontbuffer.

2011-02-10 Thread Maarten Maathuis
2011/2/10 Michel Dänzer mic...@daenzer.net: On Don, 2011-02-10 at 20:15 +0100, Maarten Maathuis wrote: - It turns out that part of the problem was actually on the driver side. - The performance loss is not worth the small visual improvement. - This should ensure low latency at low throughput.

Re: [PATCH 2/2] xkb: if the keymap failed to compile, load the default keymap instead.

2011-02-10 Thread Peter Hutterer
On Thu, Feb 10, 2011 at 02:52:26PM +, Daniel Stone wrote: On Thu, Feb 10, 2011 at 03:34:32PM +1000, Peter Hutterer wrote: We really need symbols, compat and types for a sensible keymap. Try this in your xorg.conf.d snippets for all keyboards: Option XkbLayout us

Re: [PATCH v6 inputproto 1/1] Multitouch updates for pointer emulation

2011-02-10 Thread Chase Douglas
On 02/08/2011 05:53 AM, Daniel Stone wrote: Hi, Attached is the diff between the last multitouch spec posted to the list, and what I've just pushed to my p.fd.o repository. This takes in a lot of stuff I discussed with Peter during LCA, including: Pointer emulation: We'd hoped it'd be

[PATCH xi2.1 xserver] Reallocate touches outside of signal context

2011-02-10 Thread Chase Douglas
To be squashed into xi2.1 commit BeginTouchPoint is called in signal context. Instead, check the allocation of touches whenever a touch event is handled. If the allocation is 50% used, double the allocation. This also fixes a big bug where we were reallocating the entire touch class, not just

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-10 Thread Keith Packard
On Thu, 10 Feb 2011 18:56:58 +0100, Michel Dänzer mic...@daenzer.net wrote: Though I'm afraid I don't have the time or interest for a more complete solution at this point. Can this go in for now, even if it only fixes pseudocolour? I'm taking a look at this stuff to see if I can't at least

[PATCH] Replace malloc with calloc to initialize the buffers[] as NULL in do_get_buffers function

2011-02-10 Thread Kristian Høgsberg
From: Justin Dou justin@intel.com The calling for allocate_or_reuse_buffer may fail due to some reason, e.g. out of memory. If the buffers[] were not initialized to be NULL, the following err_out may try to access an illegal memory, which will cause X crash afterward. Reviewed-by: Kristian

[PATCH] xfixes: calloc, not malloc the cursorScreenRec

2011-02-10 Thread Peter Hutterer
Debugging NULL pointers is significantly easier than random memory. Plus, if new fields (such as for pointer barriers) are added they may just be properly initialised. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- xfixes/cursor.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH] xfixes: calloc, not malloc the cursorScreenRec

2011-02-10 Thread Keith Packard
On Fri, 11 Feb 2011 14:44:48 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgppQ1FjXApC5.pgp Description: PGP signature

Re: [PATCH] exa/mixed: Partially restore deferred pixmap handling for frontbuffer.

2011-02-10 Thread Michel Dänzer
On Don, 2011-02-10 at 20:44 +0100, Maarten Maathuis wrote: 2011/2/10 Michel Dänzer mic...@daenzer.net: On Don, 2011-02-10 at 20:15 +0100, Maarten Maathuis wrote: - It turns out that part of the problem was actually on the driver side. - The performance loss is not worth the small visual

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-10 Thread Michel Dänzer
On Don, 2011-02-10 at 15:23 -0800, Keith Packard wrote: On Thu, 10 Feb 2011 18:56:58 +0100, Michel Dänzer mic...@daenzer.net wrote: Though I'm afraid I don't have the time or interest for a more complete solution at this point. Can this go in for now, even if it only fixes pseudocolour?

[PATCH v2: setxkbmap 1/3] Bug 34117: setxkbmap -I dir not accepted, despite man page

2011-02-10 Thread Alan Coopersmith
Easy enough to accept the syntax documented in the man page, so accept the -I flag with or without a space between -I and the directory argument. https://bugs.freedesktop.org/show_bug.cgi?id=34117 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- Updated to just warn ignore as

[PATCH v2: setxkbmap 2/3] Bug 34151: Potential bug and buffer overflow due to misused rules filename

2011-02-10 Thread Alan Coopersmith
https://bugs.freedesktop.org/show_bug.cgi?id=34151 Use rfName consistently, instead of sometimes reverting to svValue[RULES_NDX] Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- This patch is actually appearing for the first time in version 2 of this series. setxkbmap.c |4

[PATCH v2: setxkbmap 3/3] Use snprintf instead of trying to pre-measure sprintf result sizes.

2011-02-10 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- setxkbmap.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) Updated to apply in series after the newly inserted patch 2/3 that corrects the rfName argument to the second sprintf, and to propogate that fix to the new

setxkbmap: Refactoring for better style and maintainability?

2011-02-10 Thread Van de Bugger
Hi, I am looking into setxkbmap source. It looks like it written more than 30 years ago. I would like to refactor the code a bit. For example, I would like to combine scattered data. Let us consider existing code: /** * human-readable versions for RULES_NDX, CONFIG_NDX, etc. Used for error *

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-10 Thread Keith Packard
On Thu, 10 Feb 2011 15:23:27 -0800, Keith Packard kei...@keithp.com wrote: I'm taking a look at this stuff to see if I can't at least figure out how it's supposed to work. I don't want to ship half-a-fix when we know it's broken, just not precisely how badly. Ok, upon further review, it seems