Re: [Mesa-dev] Please mark _glapi_proc in xserver/glx/glapi.c as PUBLIC

2011-02-11 Thread Michel Dänzer
On Don, 2011-02-10 at 22:46 +0100, Peter Hjalmarsson wrote: Hello _glapi_proc was marked as PUBLIC in the following commit in the mesa tree [1], however that was never mirrored in the api for aiglx in the xserver tree. If you have linked Gallium3D drivers with -z,now (as for example

[PATCH keyboard 1/4] lnx: Fix detect CustomKeycodes for __powerpc__

2011-02-11 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- src/lnx_kbd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/lnx_kbd.c b/src/lnx_kbd.c index 63b51d9..5292f77 100644 --- a/src/lnx_kbd.c +++ b/src/lnx_kbd.c @@ -233,7 +233,7 @@

[PATCH keyboard 2/4] Cleanup set the value of CustomKeycodes

2011-02-11 Thread Alexandr Shadchin
Also, do not print values of variables CustomKeycodes twice. Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- src/bsd_kbd.c |1 - src/hurd_kbd.c |1 - src/kbd.c | 13 ++--- src/sun_kbd.c |2 -- 4 files changed, 2 insertions(+), 15 deletions(-) diff

[PATCH keyboard 3/4] Remove unused XQUEUE

2011-02-11 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- src/kbd.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/src/kbd.c b/src/kbd.c index f5cecbb..26e8e5d 100644 --- a/src/kbd.c +++ b/src/kbd.c @@ -81,11 +81,7 @@ _X_EXPORT InputDriverRec KEYBOARD = {

[PATCH keyboard 4/4] Do not print values of Protocol twice

2011-02-11 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- src/bsd_kbd.c |1 - src/lnx_kbd.c |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/bsd_kbd.c b/src/bsd_kbd.c index 1e432fd..710470a 100644 --- a/src/bsd_kbd.c +++ b/src/bsd_kbd.c @@ -357,7 +357,6 @@

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-11 Thread Maarten Maathuis
2011/2/11 Keith Packard kei...@keithp.com: On Thu, 10 Feb 2011 15:23:27 -0800, Keith Packard kei...@keithp.com wrote: I'm taking a look at this stuff to see if I can't at least figure out how it's supposed to work. I don't want to ship half-a-fix when we know it's broken, just not precisely

[PATCH 1/6] Add pixman_composite_trapezoids().

2011-02-11 Thread Søren Sandmann Pedersen
From: Søren Sandmann Pedersen s...@redhat.com This function is an implementation of the X server request Trapezoids. That request is what the X backend of cairo is using all the time; by moving it into pixman we can hopefully make it faster. --- pixman/pixman-trap.c | 87

[PATCH/RFC] Move Trapezoids and Triangles code to pixman

2011-02-11 Thread Søren Sandmann Pedersen
Hi, What follows is six patches for pixman, and three patches for the X server. Together they move the code for the Trapezoids and Triangles requests into pixman. Moving them into pixman has some advantages: - It is a performance improvement in itself since it avoids a call to

[PATCH 3/6] Add support for triangles to pixman.

2011-02-11 Thread Søren Sandmann Pedersen
From: Søren Sandmann Pedersen s...@redhat.com The Render X extension can draw triangles as well as trapezoids, but the implementation has always converted them to trapezoids. This patch moves the X server's triangle conversion code into pixman, where we can reuse the pixman_composite_trapezoid()

[PATCH 2/6] Add a test program for pixman_composite_trapezoids().

2011-02-11 Thread Søren Sandmann Pedersen
From: Søren Sandmann Pedersen s...@redhat.com A CRC32 based test program to check that pixman_composite_trapezoids() actually works. --- test/Makefile.am|5 + test/composite-traps-test.c | 253 +++ 2 files changed, 258 insertions(+), 0

[PATCH 4/6] Add a test program, tri-test

2011-02-11 Thread Søren Sandmann Pedersen
From: Søren Sandmann Pedersen s...@redhat.com This program tests whether the new triangle support works. --- test/Makefile.am |6 +- test/tri-test.c | 48 2 files changed, 53 insertions(+), 1 deletions(-) create mode 100644

[PATCH 5/6] Optimize adding opaque trapezoids onto a8 destination.

2011-02-11 Thread Søren Sandmann Pedersen
From: Søren Sandmann Pedersen s...@redhat.com When the source is opaque and the destination is alpha only, we can avoid the temporary mask and just add the trapezoids directly. --- pixman/pixman-trap.c | 133 - 1 files changed, 76 insertions(+),

[PATCH 6/6] Add new public function pixman_add_triangles()

2011-02-11 Thread Søren Sandmann Pedersen
From: Søren Sandmann Pedersen s...@redhat.com This allows some more code to be deleted from the X server. The implementation consists of converting to trapezoids, and is shared with pixman_composite_triangles(). --- pixman/pixman-trap.c | 61 -

[PATCH 1/3] Move miTrapezoids() into fb as fbTrapezoids().

2011-02-11 Thread Søren Sandmann Pedersen
From: Søren Sandmann Pedersen s...@redhat.com The main consumer of trapezoids, cairo, is using the Trapezoids request, which is currently implemented in the miTrapezoids() function. That function splits the request into smaller bits and calls lower level functions such as AddTrap. By moving the

[PATCH 2/3] Move miTriangles to fb as fbTriangles().

2011-02-11 Thread Søren Sandmann Pedersen
From: Søren Sandmann Pedersen s...@redhat.com The fb version simply calls the new pixman_composite_triangles(). This allows us to get rid of miCreateAlphaPicture(). Signed-off-by: Søren Sandmann s...@redhat.com --- fb/fbpict.c |1 + fb/fbpict.h | 10 + fb/fbtrap.c | 109

[PATCH 3/3] Implement fbAddTriangles() in terms of pixman_add_triangles().

2011-02-11 Thread Søren Sandmann Pedersen
From: Søren Sandmann Pedersen s...@redhat.com This allows the remaining triangle-to-trap conversion code to be deleted. Signed-off-by: Søren Sandmann s...@redhat.com --- fb/fbtrap.c | 91 ++- 1 files changed, 9 insertions(+), 82

Re: xkeyboard-config 2.1

2011-02-11 Thread Gaetan Nadon
On Fri, 2011-02-11 at 01:42 -0800, Jeremy Huddleston wrote: 2.0 built fine, but when I dropped 2.1 into my build system, things started to go bonkers. It looks like I'm no longer able to build xkyboard-config withoug intltool. autoreconf -fvi fails where it didn't before (because of this

[PATCH 3/8] Use the fourcc header instead of redefining it inside the code

2011-02-11 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com diff --git a/src/v4l.c b/src/v4l.c index 605454b..a51f00f 100644 --- a/src/v4l.c +++ b/src/v4l.c @@ -32,6 +32,7 @@ #include regionstr.h #include dgaproc.h #include xf86str.h +#include fourcc.h #include asm/ioctl.h /*

[PATCH 4/8] Fix Get/Set Port Attribute logic

2011-02-11 Thread Mauro Carvalho Chehab
There are several issues at GPA/SPA logic: - driver tries to limit minimum/maximum values to -1000/1000; - If yuv_format is available, all GPA/SPA are sent to the overlay encoder at the video adapter; - The most used return condition is an error. Rework the entire logic to fix the above

[PATCH 5/8] Return BadMatch if a Port Attribute is not found

2011-02-11 Thread Mauro Carvalho Chehab
Fix a small non-compliance issue: if a port attribute is not known, according with Xv specs, it should return BadMatch, and not BadValue. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com diff --git a/src/v4l.c b/src/v4l.c index 8b3d87e..fbb8bd7 100644 --- a/src/v4l.c +++ b/src/v4l.c @@

[PATCH 6/8] Provide a more consistent message if FBUF fails

2011-02-11 Thread Mauro Carvalho Chehab
Instead of providing an useless info that FBUF fails, print an error indicating what's the Fourcc format that fails. Also, on debug mode, prints a message indicating the selection of a given fourcc. This helps to verify if both the video adapter and the video capture board were set to the same

[PATCH 7/8] Fix arguments for v4l_check_yuv

2011-02-11 Thread Mauro Carvalho Chehab
The device name and the file descriptors are wrong at the cal for v4l_check_yuv(). Due to that, the driver were falling back to work with RGB formats. While here, add a code to prevent V4L driver to work if no video adapter provide Xv overlay method. Signed-off-by: Mauro Carvalho Chehab

[PATCH 8/8] Fix standard video size detection

2011-02-11 Thread Mauro Carvalho Chehab
video width/height size can vary not only as a function of the video standard but also in function of device capabilities. Due to that, the code were trying to get those info from the hardware. However, due to a driver bug, the info is not properly filled when the video standard is changed. While

[PATCH 0/8] Port xf86-video-v4l driver to V4L2 version 2

2011-02-11 Thread Mauro Carvalho Chehab
This is the second version of my backport patches. To avoid spending people's time on looking at lines that have only whitespace changes, I broke the patch I submitted two days ago into two patches: the first one with just the logical changes, and the second one with just CodingStyle (whitespace)

Re: [PATCH 0/8] Port xf86-video-v4l driver to V4L2 version 2

2011-02-11 Thread Alex Deucher
On Fri, Feb 11, 2011 at 10:54 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: This is the second version of my backport patches. To avoid spending people's time on looking at lines that have only whitespace changes, I broke the patch I submitted two days ago into two patches: the first one

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-11 Thread Keith Packard
On Fri, 11 Feb 2011 13:16:38 +0100, Maarten Maathuis madman2...@gmail.com wrote: 2011/2/11 Keith Packard kei...@keithp.com: I'll admit i wasn't thinking about odd visuals when i did this and at the time the review process of patches certainly wasn't what it is today. I think the main issue

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-11 Thread Maarten Maathuis
On Fri, Feb 11, 2011 at 7:53 PM, Keith Packard kei...@keithp.com wrote: On Fri, 11 Feb 2011 13:16:38 +0100, Maarten Maathuis madman2...@gmail.com wrote: 2011/2/11 Keith Packard kei...@keithp.com: I'll admit i wasn't thinking about odd visuals when i did this and at the time the review

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-11 Thread Keith Packard
On Fri, 11 Feb 2011 20:00:13 +0100, Maarten Maathuis madman2...@gmail.com wrote: There are dynamic colormaps? Shocking, I know. Does seem like drivers should feel free to remove non-TrueColor support at this point; it's clearly never used... -- keith.pack...@intel.com pgpgxkGJ8gh0f.pgp

Re: setxkbmap: Refactoring for better style and maintainability?

2011-02-11 Thread Alan Coopersmith
On 02/10/11 04:55 PM, Van de Bugger wrote: Hi, I am looking into setxkbmap source. It looks like it written more than 30 years ago. Only half that bad: Copyright (c) 1996 by Silicon Graphics Computer Systems, Inc. Who is the maintainer of setxkbmap? Would you accept such fix?

Re: [PATCH 0/8] Port xf86-video-v4l driver to V4L2 version 2

2011-02-11 Thread Mauro Carvalho Chehab
Hi Alex, Em 11-02-2011 15:37, Alex Deucher escreveu: On Fri, Feb 11, 2011 at 10:54 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: This is the second version of my backport patches. To avoid spending people's time on looking at lines that have only whitespace changes, I broke the patch I

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-02-11 Thread Maarten Maathuis
On Fri, Feb 11, 2011 at 8:02 PM, Keith Packard kei...@keithp.com wrote: On Fri, 11 Feb 2011 20:00:13 +0100, Maarten Maathuis madman2...@gmail.com wrote: There are dynamic colormaps? Shocking, I know. Does seem like drivers should feel free to remove non-TrueColor support at this point;

[PATCH:xorg-docs] MAINTAINERS: Update status of various libraries

2011-02-11 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- MAINTAINERS | 35 ++- 1 files changed, 30 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 49fb70b..e70e6c0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -185,6 +185,7 @@

Re: xkeyboard-config 2.1

2011-02-11 Thread Jeremy Huddleston
1) No, there is no --disable-nls option. 2) inlttool raises license concerns. 3) 2.0 built with some hackery. I'm skipping po and doing things like: if($module eq 'xkeyboard-config') { sys_print(sed -e 's/_description/description/g' -e

xorg-server 1.9.5 release schedule

2011-02-11 Thread Jeremy Huddleston
1.9.5 will likely be the last scheduled release of the 1.9 server branch. 1.9.5 is on a 8-week schedule (like 1.9.4). I've updated the calendar with the following release dates: 2011-03-04 - 1.9.5 RC1 2011-03-25 - 1.9.5 RC2 2011-04-01 - 1.9.5 Changes for 1.9.5 should continue to fit the

Re: setxkbmap: Refactoring for better style and maintainability?

2011-02-11 Thread Van de Bugger
Ok, I can prepare a patch. But I have a question: Is there any pending patches which are proposed but not yet applied to repository? My change will affect many lines of code, so I am afraid it will likely conflict with other patches. So it would be simpler to commit all the pending changes to

[PATCH:libX11] ximcp: Prevent memory leak double free if %L appears twice in string

2011-02-11 Thread Alan Coopersmith
In the highly unlikely event that TransFileName was passed a path containing multiple %L entries, for each entry it would call _XlcFileName, leaking the previous results, and then for each entry it would copy from that pointer and free it, resulting in invalid pointers possible double frees for

Re: setxkbmap: Refactoring for better style and maintainability?

2011-02-11 Thread Alan Coopersmith
On 02/11/11 02:32 PM, Van de Bugger wrote: Ok, I can prepare a patch. But I have a question: Is there any pending patches which are proposed but not yet applied to repository? Yes, there's the series I sent out last night for review which have not yet been reviewed or applied. You'd given

[PATCH:libX11] Clean up memory when first XCreateRegion succeeds and second fails

2011-02-11 Thread Alan Coopersmith
Error: Memory leak (CWE 401) Memory leak of pointer 's' allocated with XCreateRegion() at line 387 of /export/alanc/X.Org/sx86-gcc/lib/libX11/src/Region.c in function 'XShrinkRegion'. 's' allocated at line 387 with XCreateRegion(). s leaks when s != 0 at line 387.