Re: [PATCH modular 00/15] jhbuild fixes + 7.6 moduleset

2011-03-07 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:45AM -0800, Dan Nicholson wrote: A while back I was working on a moduleset for 7.6: http://lists.x.org/archives/xorg-devel/2010-November/016108.html As I worked on addressing the issues pointed out there, I uncovered a bunch more fixes for the original

Re: [PATCH:xinit] Fix minor typos in startx's comments.

2011-03-07 Thread Alan Coopersmith
On 03/ 5/11 04:59 PM, Cyril Brulebois wrote: Signed-off-by: Cyril Brulebois k...@debian.org --- startx.cpp |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/startx.cpp b/startx.cpp index f055ad9..0f4cca5 100644 --- a/startx.cpp +++ b/startx.cpp @@ -5,8 +5,8

Re: [PATCH modular 00/15] jhbuild fixes + 7.6 moduleset

2011-03-07 Thread Dirk Wallenstein
On Mon, Mar 07, 2011 at 09:15:26AM +0100, Dirk Wallenstein wrote: On Sun, Mar 06, 2011 at 09:29:45AM -0800, Dan Nicholson wrote: A while back I was working on a moduleset for 7.6: http://lists.x.org/archives/xorg-devel/2010-November/016108.html As I worked on addressing the issues

Re: [PATCH modular 10/15] jhbuild: Move font modules before drivers

2011-03-07 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:55AM -0800, Dan Nicholson wrote: The driver metamodule was separated from the module definitions by the font section. Signed-off-by: Dan Nicholson dbn.li...@gmail.com --- xorg.modules | 1000 +- 1

Re: [PATCH:libXt] Bug 34715: XtAppMainLoop doesn't work without a Display

2011-03-07 Thread walter harms
Am 06.03.2011 21:53, schrieb Alan Coopersmith: From: Jordan Hayes jor...@bitway.com https://bugs.freedesktop.org/show_bug.cgi?id=34715 XtAppNextEvent() doesn't return until there's an actual XEvent to be handled; it handles Xt-internal events (inputs, timers, signals) itself, but

Re: [PATCH 2/2] os: Work around integer overflow in TimerSet.

2011-03-07 Thread walter harms
Am 06.03.2011 21:34, schrieb Fernando Carrijo: Cyril Brulebois k...@debian.org wrote: If TimerSet gets called with a big timeout, this call can overflow: millis += now; Detect overflow and set millis to the maximal integer when that happens, to avoid falling in the “already expired”

Re: [PATCH modular 06/15] jhbuild: Build applications included in the katamari

2011-03-07 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:51AM -0800, Dan Nicholson wrote: If they're good enough to make a X.Org release, they're good enough to be build tested. Signed-off-by: Dan Nicholson dbn.li...@gmail.com --- xorg.modules | 80 +- 1

Re: [PATCH modular 05/15] jhbuild: Build openchrome driver from svn

2011-03-07 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:50AM -0800, Dan Nicholson wrote: Since the openchrome driver is being distributed in the katamari, it makes sense to build it here even if it's not under X.Org. Signed-off-by: Dan Nicholson dbn.li...@gmail.com --- xorg.modules | 11 +++ 1 files

Re: [PATCH modular 00/15] jhbuild fixes + 7.6 moduleset

2011-03-07 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:45AM -0800, Dan Nicholson wrote: A while back I was working on a moduleset for 7.6: http://lists.x.org/archives/xorg-devel/2010-November/016108.html As I worked on addressing the issues pointed out there, I uncovered a bunch more fixes for the original

Re: [PATCH modular 00/15] jhbuild fixes + 7.6 moduleset

2011-03-07 Thread Dan Nicholson
On Mon, Mar 07, 2011 at 11:56:11AM +0100, Dirk Wallenstein wrote: On Mon, Mar 07, 2011 at 09:15:26AM +0100, Dirk Wallenstein wrote: On Sun, Mar 06, 2011 at 09:29:45AM -0800, Dan Nicholson wrote: A while back I was working on a moduleset for 7.6:

Re: [PATCH modular 05/15] jhbuild: Build openchrome driver from svn

2011-03-07 Thread Dan Nicholson
On Mon, Mar 7, 2011 at 3:15 AM, Dirk Wallenstein hals...@t-online.de wrote: On Sun, Mar 06, 2011 at 09:29:50AM -0800, Dan Nicholson wrote: Since the openchrome driver is being distributed in the katamari, it makes sense to build it here even if it's not under X.Org. Signed-off-by: Dan

Re: [PATCH modular 06/15] jhbuild: Build applications included in the katamari

2011-03-07 Thread Dan Nicholson
On Mon, Mar 7, 2011 at 3:09 AM, Dirk Wallenstein hals...@t-online.de wrote: On Sun, Mar 06, 2011 at 09:29:51AM -0800, Dan Nicholson wrote: If they're good enough to make a X.Org release, they're good enough to be build tested. Signed-off-by: Dan Nicholson dbn.li...@gmail.com ---  

Re: [PATCH modular 10/15] jhbuild: Move font modules before drivers

2011-03-07 Thread Dan Nicholson
On Mon, Mar 7, 2011 at 2:56 AM, Dirk Wallenstein hals...@t-online.de wrote: On Sun, Mar 06, 2011 at 09:29:55AM -0800, Dan Nicholson wrote: The driver metamodule was separated from the module definitions by the font section. Signed-off-by: Dan Nicholson dbn.li...@gmail.com ---  xorg.modules

Re: [PATCH libXvMC 2/2] config: use Automake defaults when checking for library functions.

2011-03-07 Thread Julien Cristau
On Sat, Mar 5, 2011 at 12:01:44 -0500, Gaetan Nadon wrote: Which follows a uniform naming convention. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |2 +- src/XvMC.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Julien

Re: [PATCH libXvMC 1/2] config: move wrapper in its own directory

2011-03-07 Thread Julien Cristau
On Sat, Mar 5, 2011 at 12:01:43 -0500, Gaetan Nadon wrote: This prevents the use of per-target compiler flags. Makefiles are simpler. The -D flags for the wrapper are moved with pre-precessor flags. Fix whitespace issues. Signed-off-by: Gaetan Nadon mems...@videotron.ca ---

Re: [PATCH 1/2] os: Fix buggy integer comparison.

2011-03-07 Thread Cyril Brulebois
Keith Packard kei...@keithp.com (06/03/2011): […] We want the former result, not the latter. Unless being pointed to the appropriate stuff from 2002 by Alan (thanks!), what we want isn't exactly clear while going through the code. Might deserve some comments, maybe? That was already reported

[PATCH xlsclients] Use XCB_ATOM_* atom names rather than deprecated atom names

2011-03-07 Thread Jon TURNEY
Use XCB_ATOM_* atom names rather than deprecated atom names Those deprecated atom names were removed from xcb/util in commit 2f0334b3eb49fa3a0d6daf6b9dde10e480a5c59f Found by tinderbox, see: http://tinderbox.freedesktop.org/builds/2011-03-06-0008/logs/xlsclients/#build

Re: [PATCH modular 05/15] jhbuild: Build openchrome driver from svn

2011-03-07 Thread Dirk Wallenstein
On Mon, Mar 07, 2011 at 05:13:42AM -0800, Dan Nicholson wrote: On Mon, Mar 7, 2011 at 3:15 AM, Dirk Wallenstein hals...@t-online.de wrote: On Sun, Mar 06, 2011 at 09:29:50AM -0800, Dan Nicholson wrote: Since the openchrome driver is being distributed in the katamari, it makes sense to build

Re: [PATCH modular 00/15] jhbuild fixes + 7.6 moduleset

2011-03-07 Thread Dirk Wallenstein
On Mon, Mar 07, 2011 at 05:00:19AM -0800, Dan Nicholson wrote: On Mon, Mar 07, 2011 at 11:56:11AM +0100, Dirk Wallenstein wrote: On Mon, Mar 07, 2011 at 09:15:26AM +0100, Dirk Wallenstein wrote: On Sun, Mar 06, 2011 at 09:29:45AM -0800, Dan Nicholson wrote: A while back I was working on

Re: [PATCH 09/11] glx: Lobotomize _glapi_get_proc_address

2011-03-07 Thread Adam Jackson
On 3/3/11 4:06 PM, Julien Cristau wrote: On Thu, Mar 3, 2011 at 14:07:23 -0500, Adam Jackson wrote: -/** - * Return pointer to the named function. If the function name isn't found - * in the name of static functions, try generating a new API entrypoint on - * the fly with assembly language.

Re: [PATCH 1/3] glx: Factor out glxProbeDriver function.

2011-03-07 Thread Adam Jackson
On 3/6/11 10:11 PM, Christopher James Halse Rogers wrote: DRI, DRI2 and swrast all had near-identical driver probing logic. Pull it into glxdricommon Signed-off-by: Christopher James Halse Rogerschristopher.halse.rog...@canonical.com This always did bother me, cleanup looks good. Only thing

Re: [PATCH 2/3] glx: Use PATH_MAX as size for filename buffer

2011-03-07 Thread Adam Jackson
On 3/6/11 10:11 PM, Christopher James Halse Rogers wrote: Signed-off-by: Christopher James Halse Rogerschristopher.halse.rog...@canonical.com Any chance you can clean this up to be something we get from misc.h or similar? There's about five #ifdef MAXPATHLENs already in various files. -

Re: [PATCH xlsclients] Use XCB_ATOM_* atom names rather than deprecated atom names

2011-03-07 Thread Dan Nicholson
On Mon, Mar 7, 2011 at 5:54 AM, Jon TURNEY jon.tur...@dronecode.org.uk wrote: Use XCB_ATOM_* atom names rather than deprecated atom names Those deprecated atom names were removed from xcb/util in commit 2f0334b3eb49fa3a0d6daf6b9dde10e480a5c59f Found by tinderbox, see:

[PATCH libXvMC 1/2] Fix whitespace issues

2011-03-07 Thread Gaetan Nadon
Signed-off-by: Gaetan Nadon mems...@videotron.ca --- src/XvMCWrapper.c | 132 ++-- 1 files changed, 66 insertions(+), 66 deletions(-) diff --git a/src/XvMCWrapper.c b/src/XvMCWrapper.c index d3800e7..bff5a8b 100644 --- a/src/XvMCWrapper.c +++

[PATCH libXvMC 2/2] config: move wrapper in its own directory

2011-03-07 Thread Gaetan Nadon
This prevents the use of per-target compiler flags. Makefiles are simpler. The -D flags for the wrapper are moved with pre-precessor flags. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- Makefile.am|2 +- configure.ac |1 + src/Makefile.am

Re: [PATCH modular 14/15] jhbuild: Add script for updating moduleset tarball definitions

2011-03-07 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:59AM -0800, Dan Nicholson wrote: update-moduleset.sh takes the sha1sum and tarball and updates the module definition in a given moduleset. This should make keeping the stable moduleset easier. Signed-off-by: Dan Nicholson dbn.li...@gmail.com ---

[PATCH 1/8] dix: Remove PIXEL typedef

2011-03-07 Thread Adam Jackson
Doesn't appear to be used anywhere. Signed-off-by: Adam Jackson a...@redhat.com --- include/misc.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/include/misc.h b/include/misc.h index 62d813e..0717db6 100644 --- a/include/misc.h +++ b/include/misc.h @@ -91,10 +91,8 @@

[PATCH 0/8] LP64 ABI cleanup

2011-03-07 Thread Adam Jackson
Pretty much every use of 'long' is a bug. Atoms are only 32 bits on the wire, and though RESTYPE is not a wire type we're only using the low 32 bits of it. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives:

[PATCH 2/8] dix: Fix ATOM typedef

2011-03-07 Thread Adam Jackson
unsigned long is needlessly large on LP64. Use unsigned int instead. Signed-off-by: Adam Jackson a...@redhat.com --- include/misc.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/misc.h b/include/misc.h index 0717db6..7c97fae 100644 --- a/include/misc.h +++

[PATCH 3/8] dix: Shrink PropertyRec on LP64

2011-03-07 Thread Adam Jackson
size needn't be a long. No change on ILP32 but, combined with the previous change, 56 - 40 bytes on LP64. Signed-off-by: Adam Jackson a...@redhat.com --- include/propertyst.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/propertyst.h b/include/propertyst.h

[PATCH 4/8] xv: Use RESTYPE where appropriate

2011-03-07 Thread Adam Jackson
No functional change. Signed-off-by: Adam Jackson a...@redhat.com --- Xext/xvdix.h | 12 ++-- Xext/xvmain.c | 14 ++ 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/Xext/xvdix.h b/Xext/xvdix.h index a210615..e9c22bf 100644 --- a/Xext/xvdix.h +++

[PATCH 5/8] xinerama: Use RESTYPE consistently

2011-03-07 Thread Adam Jackson
No functional change Signed-off-by: Adam Jackson a...@redhat.com --- Xext/panoramiX.c| 10 +- Xext/panoramiXsrv.h | 12 ++-- render/render.c |2 +- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/Xext/panoramiX.c b/Xext/panoramiX.c index

[PATCH 6/8] xvmc: Use RESTYPE consistently

2011-03-07 Thread Adam Jackson
Also mark these static since they're not used externally. Signed-off-by: Adam Jackson a...@redhat.com --- Xext/xvmc.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Xext/xvmc.c b/Xext/xvmc.c index 8fbdfae..4d29941 100644 --- a/Xext/xvmc.c +++ b/Xext/xvmc.c @@ -42,9

[PATCH 7/8] xi: Use RESTYPE consistently

2011-03-07 Thread Adam Jackson
No functional change Signed-off-by: Adam Jackson a...@redhat.com --- Xi/exglobals.h |2 +- Xi/extinit.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Xi/exglobals.h b/Xi/exglobals.h index f755707..8c5a42e 100644 --- a/Xi/exglobals.h +++ b/Xi/exglobals.h @@ -76,7

[PATCH 8/8] dix: Define RESTYPE as unsigned int

2011-03-07 Thread Adam Jackson
long is needlessly long on LP64. Before: textdata bss dec hex filename 1833242 69920 49696 1952858 1dcc5a hw/vfb/Xvfb After: textdata bss dec hex filename 1832426 69920 49504 1951850 1dc86a hw/vfb/Xvfb Signed-off-by: Adam Jackson a...@redhat.com

Memory corruption with xbindkeys and xcb 1.7-2 (debian)

2011-03-07 Thread Oliver McFadden
Hi, I am not sure whether this is a known issue, but anyway, I am seeing xbindkeys crashing after a few button presses. Perhaps this should go to the xbindkeys developers, but I'm reasonably sure this is a bug in xcb. You can reproduce it as follows: 1. Start xbindkeys in non-daemon mode so you

Re: [PATCH modular 14/15] jhbuild: Add script for updating moduleset tarball definitions

2011-03-07 Thread Dan Nicholson
On Mon, Mar 7, 2011 at 8:19 AM, Dirk Wallenstein hals...@t-online.de wrote: On Sun, Mar 06, 2011 at 09:29:59AM -0800, Dan Nicholson wrote: update-moduleset.sh takes the sha1sum and tarball and updates the module definition in a given moduleset. This should make keeping the stable moduleset

Re: [PATCH modular 14/15] jhbuild: Add script for updating moduleset tarball definitions

2011-03-07 Thread Dirk Wallenstein
On Mon, Mar 07, 2011 at 08:29:49AM -0800, Dan Nicholson wrote: On Mon, Mar 7, 2011 at 8:19 AM, Dirk Wallenstein hals...@t-online.de wrote: On Sun, Mar 06, 2011 at 09:29:59AM -0800, Dan Nicholson wrote: update-moduleset.sh takes the sha1sum and tarball and updates the module definition in a

Re: [PATCH 4/4] dix: Make InputOnly window checking more consistent

2011-03-07 Thread Ville Syrjälä
On Fri, Mar 04, 2011 at 04:05:21PM -0500, ext Adam Jackson wrote: Remove the UNDRAWABLE_WINDOW macro (which was just needlessly cute) and always check -class to decide if a window is InputOnly or InputOutput. -type is now always either window or pixmap. I wonder how many places assume that

Re: [PATCH modular 00/15] jhbuild fixes + 7.6 moduleset

2011-03-07 Thread Dan Nicholson
On Mon, Mar 7, 2011 at 7:26 AM, Dirk Wallenstein hals...@t-online.de wrote: On Mon, Mar 07, 2011 at 05:00:19AM -0800, Dan Nicholson wrote: On Mon, Mar 07, 2011 at 11:56:11AM +0100, Dirk Wallenstein wrote: On Mon, Mar 07, 2011 at 09:15:26AM +0100, Dirk Wallenstein wrote: On Sun, Mar 06, 2011

Re: [PATCH 2/8] dix: Fix ATOM typedef

2011-03-07 Thread Daniel Stone
On Mon, Mar 07, 2011 at 11:28:12AM -0500, Adam Jackson wrote: unsigned long is needlessly large on LP64. Use unsigned int instead. Could we just use uint32_t? Cheers, Daniel signature.asc Description: Digital signature ___ xorg-devel@lists.x.org:

Re: [PATCH modular 14/15] jhbuild: Add script for updating moduleset tarball definitions

2011-03-07 Thread Dan Nicholson
On Mon, Mar 7, 2011 at 8:37 AM, Dirk Wallenstein hals...@t-online.de wrote: On Mon, Mar 07, 2011 at 08:29:49AM -0800, Dan Nicholson wrote: On Mon, Mar 7, 2011 at 8:19 AM, Dirk Wallenstein hals...@t-online.de wrote: On Sun, Mar 06, 2011 at 09:29:59AM -0800, Dan Nicholson wrote:

Re: Memory corruption with xbindkeys and xcb 1.7-2 (debian)

2011-03-07 Thread Peter Harris
On 2011-03-07 11:28, Oliver McFadden wrote: I am not sure whether this is a known issue, but anyway, I am seeing xbindkeys crashing after a few button presses. Perhaps this should go to the xbindkeys developers, but I'm reasonably sure this is a bug in xcb. This looks a lot like a known (not

[PATCH] libXfixes v5: Pointer barriers

2011-03-07 Thread Adam Jackson
v2: Use int * for device list, consistent with libXi. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac|2 +- include/X11/extensions/Xfixes.h | 15 ++ src/Cursor.c| 60 +++ 3 files changed, 76

Re: [PATCH modular 14/15] jhbuild: Add script for updating moduleset tarball definitions

2011-03-07 Thread Dirk Wallenstein
On Mon, Mar 07, 2011 at 09:02:20AM -0800, Dan Nicholson wrote: On Mon, Mar 7, 2011 at 8:37 AM, Dirk Wallenstein hals...@t-online.de wrote: On Mon, Mar 07, 2011 at 08:29:49AM -0800, Dan Nicholson wrote: On Mon, Mar 7, 2011 at 8:19 AM, Dirk Wallenstein hals...@t-online.de wrote: On Sun,

Re: [PATCH 2/8] dix: Fix ATOM typedef

2011-03-07 Thread Adam Jackson
On 3/7/11 11:51 AM, Daniel Stone wrote: On Mon, Mar 07, 2011 at 11:28:12AM -0500, Adam Jackson wrote: unsigned long is needlessly large on LP64. Use unsigned int instead. Could we just use uint32_t? stdint.h isn't included from misc.h. It could be, I guess, but if you have a platform

Re: [PATCH] libXfixes v5: Pointer barriers

2011-03-07 Thread Julien Cristau
On Mon, Mar 7, 2011 at 12:06:33 -0500, Adam Jackson wrote: v2: Use int * for device list, consistent with libXi. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac|2 +- include/X11/extensions/Xfixes.h | 15 ++ src/Cursor.c

Re: RandR 1.4 restart

2011-03-07 Thread James Jones
On Friday 04 March 2011 11:43:05 pm Keith Packard wrote: * PGP Signed by an unknown key On Fri, 4 Mar 2011 16:47:45 -0800, James Jones jajo...@nvidia.com wrote: On 3/1/11 6:56 PM, James Jones jajo...@nvidia.com wrote: On Tuesday 01 March 2011 08:02:24 Keith Packard wrote: *snip*

[PATCH] Xi: fix length checks for swapped clients

2011-03-07 Thread Julien Cristau
ChangeDeviceProperty and XIChangeProperty are followed by some data, so use REQUEST_AT_LEAST_SIZE instead of REQUEST_SIZE_MATCH. X.Org bug#35082 https://bugs.freedesktop.org/show_bug.cgi?id=35082 Reported-by: Markus Fleschutz markus.flesch...@x-software.com Signed-off-by: Julien Cristau

Re: [PATCH:libXt 3/3] Convert ALLOCATE_LOCAL + sprintf to XtAsprintf

2011-03-07 Thread Cyril Brulebois
Hi Alan, Alan Coopersmith alan.coopersm...@oracle.com (12/01/2011): Now that we don't need to separately strlen the format string, put it directly into the function call to clear gcc warnings of: Initialize.c:397: warning: format not a string literal, argument types not checked

[PATCH modular] xcb-util: not required to build The X C Binding (XCB) library for X

2011-03-07 Thread Gaetan Nadon
README: The xcb-util module provides a number of libraries which sit on top of libxcb, the core X protocol library, and some of the extension libraries. These experimental libraries provide convenience functions and interfaces which make the raw X protocol more usable. Some of the libraries also

Re: [PATCH modular] xcb-util: not required to build The X C Binding (XCB) library for X

2011-03-07 Thread Dan Nicholson
On Mon, Mar 7, 2011 at 11:14 AM, Gaetan Nadon mems...@videotron.ca wrote: README: The xcb-util module provides a number of libraries which sit on top of libxcb, the core X protocol library, and some of the extension libraries. These experimental libraries provide convenience functions and

Re: [PATCH modular] xcb-util: not required to build The X C Binding (XCB) library for X

2011-03-07 Thread Alan Coopersmith
On 03/ 7/11 12:29 PM, Dan Nicholson wrote: On Mon, Mar 7, 2011 at 11:14 AM, Gaetan Nadon mems...@videotron.ca wrote: README: The xcb-util module provides a number of libraries which sit on top of libxcb, the core X protocol library, and some of the extension libraries. These experimental

Re: [PATCH 1/2] os: Fix buggy integer comparison.

2011-03-07 Thread Keith Packard
On Mon, 7 Mar 2011 14:32:20 +0100, Cyril Brulebois k...@debian.org wrote: Might deserve some comments, maybe? I suppose; I guess it never seemed obscure to me (or at least, hasn't for years) Shall we proceed with tweaking that assert()? A quick testing shows that both my 1.7 and 1.10 servers

Re: [PATCH:libXt] Bug 34715: XtAppMainLoop doesn't work without a Display

2011-03-07 Thread Alan Coopersmith
On 03/ 7/11 03:00 AM, walter harms wrote: Am 06.03.2011 21:53, schrieb Alan Coopersmith: From: Jordan Hayes jor...@bitway.com https://bugs.freedesktop.org/show_bug.cgi?id=34715 XtAppNextEvent() doesn't return until there's an actual XEvent to be handled; it handles Xt-internal events

[PATCH] Xext: relax assert in SecurityAuthorizationExpired.

2011-03-07 Thread Cyril Brulebois
The following code path is considered valid: SecurityAuthorizationExpired TimerSet SecurityStartAuthorizationTimer In other words, SecurityAuthorizationExpired can be called while pAuth-timer is still NULL, so relax the assert() accordingly. That might happen when one uses big timeouts in

Re: RandR 1.4 restart

2011-03-07 Thread Keith Packard
On Mon, 7 Mar 2011 09:43:50 -0800, James Jones jajo...@nvidia.com wrote: OK, I thought you wanted to completely hide the resize from applications. I was only thinking about that from the RandR perspective so that we can separate the resizing control from the compositing manager's crtc pixmap

Re: [PATCH modular] xcb-util: not required to build The X C Binding (XCB) library for X

2011-03-07 Thread Peter Harris
On 2011-03-07 15:29, Dan Nicholson wrote: There are other components that use xcb-util, though. For instance, xlsclients needs xcb-atom.pc from xcb-util. Probably it should be included in the katamari. xlsclients was just (today) patched to remove its dependency on the deprecated xcb-atom

Re: [PATCH 2/8] dix: Fix ATOM typedef

2011-03-07 Thread Keith Packard
On Mon, 7 Mar 2011 16:51:29 +, Daniel Stone dan...@fooishbar.org wrote: On Mon, Mar 07, 2011 at 11:28:12AM -0500, Adam Jackson wrote: unsigned long is needlessly large on LP64. Use unsigned int instead. Could we just use uint32_t? Yeah, stdint types seem like a better idea everywhere.

Re: [PATCH modular 05/15] jhbuild: Build openchrome driver from svn

2011-03-07 Thread Alan Coopersmith
On Sun, Mar 06, 2011 at 09:29:50AM -0800, Dan Nicholson wrote: Since the openchrome driver is being distributed in the katamari, it makes sense to build it here even if it's not under X.Org. Though I've considered dropping it from the katamari since they're not bothering with new releases.

Re: [PATCH modular] xcb-util: not required to build The X C Binding (XCB) library for X

2011-03-07 Thread Dan Nicholson
On Mon, Mar 07, 2011 at 04:45:25PM -0500, Peter Harris wrote: On 2011-03-07 15:29, Dan Nicholson wrote: There are other components that use xcb-util, though. For instance, xlsclients needs xcb-atom.pc from xcb-util. Probably it should be included in the katamari. xlsclients was just

Re: [PATCH 1/4] dix: Remove usage_class from pixmaps, store it in -drawable.class

2011-03-07 Thread Soeren Sandmann
Adam Jackson a...@redhat.com writes: The class field was unused for pixmaps, and we don't have enough classes to justify a whole uint32 anyway. Signed-off-by: Adam Jackson a...@redhat.com You mean usage_hint in the subject line, but other than that, Reviewed-by: Soren Sandmann

Re: [PATCH modular 05/15] jhbuild: Build openchrome driver from svn

2011-03-07 Thread Dan Nicholson
On Mon, Mar 7, 2011 at 2:16 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On Sun, Mar 06, 2011 at 09:29:50AM -0800, Dan Nicholson wrote: Since the openchrome driver is being distributed in the katamari, it makes sense to build it here even if it's not under X.Org. Though I've

Re: [PATCH 2/4] dix: Remove deprecated.c

2011-03-07 Thread Soeren Sandmann
Adam Jackson a...@redhat.com writes: No more internal users, this can be dropped now. Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Soren Sandmann s...@redhat.com Soren ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-07 Thread Chase Douglas
On 03/07/2011 01:28 AM, Peter Hutterer wrote: On Wed, Mar 02, 2011 at 09:25:40AM -0500, Chase Douglas wrote: On 03/02/2011 02:29 AM, Peter Hutterer wrote: On Tue, Feb 22, 2011 at 10:06:37AM -0500, Chase Douglas wrote: Touch grabs are similar to standard input event grabs in that they take

Re: [PATCH 3/4] dix: Simplify arguments to dixLookupDrawable

2011-03-07 Thread Soeren Sandmann
Adam Jackson a...@redhat.com writes: The mask argument was almost always 0 or (equivalently) M_ANY. Are they actually equivalent? If you pass 0, then the code uses M_DRAWABLE, which actually means drawable, which is not an InputOnly window. But if you pass M_ANY, then InputOnly windows are

Re: [PATCH 0/8] LP64 ABI cleanup

2011-03-07 Thread Soeren Sandmann
Adam Jackson a...@redhat.com writes: Pretty much every use of 'long' is a bug. Atoms are only 32 bits on the wire, and though RESTYPE is not a wire type we're only using the low 32 bits of it. Apart from the uint32_t issue, Reviewed-by: Soren Sandmann s...@redhat.com for the series.

Re: [PATCH:libXt 3/3] Convert ALLOCATE_LOCAL + sprintf to XtAsprintf

2011-03-07 Thread Alan Coopersmith
On 03/ 7/11 10:57 AM, Cyril Brulebois wrote: Hi Alan, Alan Coopersmith alan.coopersm...@oracle.com (12/01/2011): Now that we don't need to separately strlen the format string, put it directly into the function call to clear gcc warnings of: Initialize.c:397: warning: format not a string

Re: [PATCH modular] xcb-util: not required to build The X C Binding (XCB) library for X

2011-03-07 Thread Gaetan Nadon
On Mon, 2011-03-07 at 14:25 -0800, Dan Nicholson wrote: On Mon, Mar 07, 2011 at 04:45:25PM -0500, Peter Harris wrote: On 2011-03-07 15:29, Dan Nicholson wrote: There are other components that use xcb-util, though. For instance, xlsclients needs xcb-atom.pc from xcb-util. Probably it

[PATCH app-twm 1/2] lex yacc: only header file needs to be in BUILT_SOURCES

2011-03-07 Thread Gaetan Nadon
http://www.gnu.org/software/automake/manual/automake.html#Yacc-and-Lex This completes reversal of commit ea03b6bcd1045dfc0d6947e4858de8994d61170b The Makefile generates a valid gram.h: gram.c rule. The Makefile already has gram.c gram.h and lex.c in the maintainer-clean-generic target.

[PATCH app-twm 2/2] deftwmrc.c is not required in MAINTAINERCLEANFILES

2011-03-07 Thread Gaetan Nadon
Automake takes care of that as it is part of BUILT_SOURCES Signed-off-by: Gaetan Nadon mems...@videotron.ca --- src/Makefile.am |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index da7ad75..74a144b 100644 --- a/src/Makefile.am +++

Re: [PATCH] libXfixes v5: Pointer barriers

2011-03-07 Thread Peter Hutterer
On Mon, Mar 07, 2011 at 12:06:33PM -0500, Adam Jackson wrote: v2: Use int * for device list, consistent with libXi. Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac|2 +- include/X11/extensions/Xfixes.h | 15 ++ src/Cursor.c

Re: [PATCH] Xi: fix length checks for swapped clients

2011-03-07 Thread Peter Hutterer
On Mon, Mar 07, 2011 at 06:55:19PM +0100, Julien Cristau wrote: ChangeDeviceProperty and XIChangeProperty are followed by some data, so use REQUEST_AT_LEAST_SIZE instead of REQUEST_SIZE_MATCH. X.Org bug#35082 https://bugs.freedesktop.org/show_bug.cgi?id=35082 Reported-by: Markus Fleschutz

Re: [PATCH v2 keyboard 3/3] Rewrote code to set initial state LEDS

2011-03-07 Thread Peter Hutterer
On Sun, Feb 20, 2011 at 08:44:06PM +0500, Alexandr Shadchin wrote: Saved only initial state CapsLock and NumLock Please write a more elaborate commit message. this code hasn't been touched for ages, if you went through the effort of understanding it and writing a patch, then a few sentences in

Re: [PATCH v2 keyboard 2/3] Removed useless leds (member structure KbdDevRec)

2011-03-07 Thread Peter Hutterer
On Sun, Feb 20, 2011 at 08:44:05PM +0500, Alexandr Shadchin wrote: Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com merged, thanks. Cheers, Peter --- src/kbd.c |8 ++-- src/xf86OSKbd.h |1 - 2 files changed, 2 insertions(+), 7 deletions(-) diff --git

Re: [PATCH v2 keyboard 1/3] Removed option XLeds

2011-03-07 Thread Peter Hutterer
On Sun, Feb 20, 2011 at 08:44:04PM +0500, Alexandr Shadchin wrote: IMHO nobody needs because it works not correctly and still not fixed Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com I've merged this one for now given that https://bugs.freedesktop.org/show_bug.cgi?id=17888 has

[PATCH] Xi: fix XI2 passive grab reply length calculation

2011-03-07 Thread Peter Hutterer
If modifiers failed, the reply length was 4 bytes too short. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Xi/xipassivegrab.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Xi/xipassivegrab.c b/Xi/xipassivegrab.c index 8663d12..3319ef9 100644 ---

[PATCH libXi] Don't discard extra data for passive grabs.

2011-03-07 Thread Peter Hutterer
Failed modifier data was discarded, causing assertions inside xcb. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/XIPassiveGrab.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/XIPassiveGrab.c b/src/XIPassiveGrab.c index ada658f..feef74b 100644 ---

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-07 Thread Peter Hutterer
On Wed, Mar 02, 2011 at 11:35:41AM -0500, Chase Douglas wrote: On 03/02/2011 05:58 AM, Daniel Stone wrote: On Tue, Feb 22, 2011 at 10:06:37AM -0500, Chase Douglas wrote: --- a/XI2.h +++ b/XI2.h @@ -32,6 +32,7 @@ #define Dont_Check 0 #endif #define