DuplicateModule [Was: PATCH Check module version each time it is loaded]

2011-10-17 Thread Michal Suchanek
On 14 October 2011 01:35, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Oct 10, 2011 at 10:10:23AM +0200, Michal Suchanek wrote: so what's the behaviour now if you remove all devices? does it reload from the disk or reload the original module? It is never reloaded according to the

[PATCH] pci: Add identifier for Cirus Logic GD-7556

2011-10-17 Thread Jeremy Huddleston
https://bugs.freedesktop.org/show_bug.cgi?id=1837 Signed-off-by: Jeremy Huddleston jerem...@apple.com --- hw/xfree86/common/xf86PciInfo.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86PciInfo.h b/hw/xfree86/common/xf86PciInfo.h index

Re: [PATCH] pci: Add identifier for Cirus Logic GD-7556

2011-10-17 Thread Jeremy Huddleston
So, what's the point of having all these in common? Why don't they just live in the drivers? It seems silly to have these defined in the server's SDK rather than the driver that will consume them, since it means the driver will need to do #ifndef PCI_CHIP_GD7556 #define PCI_CHIP_GD7556

Re: [PATCH] x11proto: add permille, ezh, and EZH to keysymdef.h

2011-10-17 Thread Marko Myllynen
Hi, There's a comment in the keysymdef.h file: * When adding new keysyms to this file, do not forget to also update the * following: * * - the mappings in src/KeyBind.c in the repo * git://anongit.freedesktop.org/xorg/lib/libX11 * * - the protocol specification in

Re: [PATCH 2/2] xfree86: Add Loongson MIPS support

2011-10-17 Thread Michel Dänzer
On Son, 2011-10-16 at 13:37 -0700, Jeremy Huddleston wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=41038 Signed-off-by: Matt Kraai kr...@ftbfs.org Reviewed-by: Jeremy Huddleston jerem...@apple.com --- Ok, so I really don't understand why ppc had its own ioBase in

Re: DuplicateModule [Was: PATCH Check module version each time it is loaded]

2011-10-17 Thread Peter Hutterer
On Mon, Oct 17, 2011 at 08:35:44AM +0200, Michal Suchanek wrote: On 14 October 2011 01:35, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Oct 10, 2011 at 10:10:23AM +0200, Michal Suchanek wrote: so what's the behaviour now if you remove all devices? does it reload from the disk or

[PATCH evdev] type-safe inline functions for bitmask manipulation

2011-10-17 Thread Max Schwarz
We can't use BitIsSet/SetBit from the server (inputstr.h) since they operate on byte arrays. EvdevSetBit is added in preparation for the smooth-scrolling on wheel emulation patch. Signed-off-by: Max Schwarz m...@x-quadraht.de --- src/evdev.c | 76

Re: [PATCH] Export include/input.h:GetMaster() function

2011-10-17 Thread Adam Tkac
On 10/13/2011 07:29 AM, Peter Hutterer wrote: On Wed, Oct 12, 2011 at 12:44:00PM +0200, Adam Tkac wrote: On 10/12/2011 06:27 AM, Peter Hutterer wrote: On Tue, Oct 11, 2011 at 03:12:56PM +0200, Adam Tkac wrote: attached patch exports the GetMaster() function, it is needed by TigerVNC's

Re: [PATCH] xfree86: Add Loongson MIPS support

2011-10-17 Thread Alex Deucher
On Sun, Oct 16, 2011 at 9:25 PM, Michael macal...@netbsd.org wrote: Hello, On Sun, 16 Oct 2011 21:08:36 -0400 Alex Deucher alexdeuc...@gmail.com wrote: On Sun, Oct 16, 2011 at 9:06 PM, Michael macal...@netbsd.org wrote: Hello, On Sun, 16 Oct 2011 11:37:16 -0400 Matt Turner

Re: PATCH v5 Document -background none option

2011-10-17 Thread Michal Suchanek
Hello, yet another update ;-) v2: place the option in Xserver man page rather than Xorg man page v3: reword based in input from Alan Coopersmith v4: remove extra space causing formatting error v5: remove superfluous 'as', make 'none' the same style as '-background' Thanks Michal

Re: [PATCH 2/4] xserver: limit the kernel subsystems we look for devices in

2011-10-17 Thread Jochen Friedrich
Am Mon, 18 Jul 2011 schrieb Lennart Poettering: Don't enumerate/monitor all devices of the system (since that can be quite a few), but limit our search to devices from the input subsystem, as well as the tty subsystem (to cover Wacom tablets). This should make X start up a bit faster and

Re: [PATCH libX11] include: Add GetReqSized() for request buffers of specific size

2011-10-17 Thread Jamey Sharp
On Mon, Oct 17, 2011 at 09:19:02AM +1000, Peter Hutterer wrote: On Fri, Oct 14, 2011 at 06:42:02PM +0200, Jamey Sharp wrote: The GetReq family of macros is so evil. I'm not going to go so far as to NAK this patch or anything, but please consider whether you can implement this as a proper

[PATCH RESEND xserver 2/2] XWinrc.man: fix warning: tab character in unquoted macro argument #35054

2011-10-17 Thread Gaetan Nadon
Spaces or tabs do not affect the text output layout. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- hw/xwin/man/XWinrc.man | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/xwin/man/XWinrc.man b/hw/xwin/man/XWinrc.man index e4c454f..71d8dad 100644 ---

Re: [PATCH V4] xserver: check for elevated privileges not uid=0

2011-10-17 Thread Jamey Sharp
Reviewed-by: Jamey Sharp ja...@minilop.net Since this has gone through so many changes I tried to carefully re-review the whole thing, and it still looks good to me. Thanks, Antoine! We don't actually put xserver: in the commit message for a server patch, though. It wouldn't be wrong to tag this

Re: [PATCH evdev] type-safe inline functions for bitmask manipulation

2011-10-17 Thread Chase Douglas
On 10/17/2011 03:12 AM, Max Schwarz wrote: We can't use BitIsSet/SetBit from the server (inputstr.h) since they operate on byte arrays. EvdevSetBit is added in preparation for the smooth-scrolling on wheel emulation patch. Signed-off-by: Max Schwarz m...@x-quadraht.de Have you looked into

Syntax enhancements for Match statements

2011-10-17 Thread Oleh Nykyforchyn
Hi colleagues, It has been written a long time ago about my patches, which introduced negation, |+ and regexes to Match statements: On Thu, 23 Jun 2011 12:06:46 +1000 Peter Hutterer peter.hutte...@who-t.net wrote: sorry if you've already done this in another thread but do you have an

Re: Re: [PATCH evdev] type-safe inline functions for bitmask manipulation

2011-10-17 Thread Max Schwarz
Have you looked into switching the evdev bit arrays from longs to bytes so we can standardize on one type of bit array? That would be possible. Longs are used because the linux evdev layer uses longs and we can let ioctl() write directly into our bitmask arrays. I can change the occurences of

[PATCH evdev v2] type-safe inline functions for bitmask manipulation

2011-10-17 Thread Max Schwarz
We can't use BitIsSet/SetBit from the server (inputstr.h) since they operate on byte arrays. EvdevSetBit is added in preparation for the smooth-scrolling on wheel emulation patch. Signed-off-by: Max Schwarz m...@x-quadraht.de --- sorry, forgot to actually make EvdevBitIsSet/EvdevSetBit inline...

[PATCH] configure.ac: Add -fno-strict-aliasing to CFLAGS

2011-10-17 Thread Jeremy Huddleston
This should force the server to have -fno-strict-aliasing even once it is removed from the warning flags. See: https://bugs.freedesktop.org/show_bug.cgi?id=31238 Signed-off-by: Jeremy Huddleston jerem...@apple.com --- configure.ac |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-)

Re: [PATCH RESEND xserver 2/2] XWinrc.man: fix warning: tab character in unquoted macro argument #35054

2011-10-17 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston jerem...@apple.com On Oct 17, 2011, at 10:00 AM, Gaetan Nadon wrote: Spaces or tabs do not affect the text output layout. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- hw/xwin/man/XWinrc.man | 10 +- 1 files changed, 5 insertions(+), 5

Re: [PATCH evdev v2] type-safe inline functions for bitmask manipulation

2011-10-17 Thread Jeremy Huddleston
Looks to me like you want those to be declared 'static inline' Why not have EvdevBitIsSet and EvdevSetBit use BitIsSet/SetBit with endianness-fu? On Oct 17, 2011, at 11:34 AM, Max Schwarz wrote: We can't use BitIsSet/SetBit from the server (inputstr.h) since they operate on byte arrays.

[PATCH evdev v3] type-safe inline functions for bitmask manipulation

2011-10-17 Thread Max Schwarz
We can't use BitIsSet/SetBit from the server (inputstr.h) since they operate on byte arrays. EvdevSetBit is added in preparation for the smooth-scrolling on wheel emulation patch. Signed-off-by: Max Schwarz m...@x-quadraht.de --- make that static inline -.- src/evdev.c | 76

Re: [PATCH evdev v2] type-safe inline functions for bitmask manipulation

2011-10-17 Thread Max Schwarz
Why not have EvdevBitIsSet and EvdevSetBit use BitIsSet/SetBit with endianness-fu? What would you gain from that? I think my implementation is simple and straight, endianness-fu isn't going to make it nicer... Max ___ xorg-devel@lists.x.org: X.Org

[PATCH xserver 1/2] xorg.conf.man: fix 382: warning: missing `)' (got `R') #35054

2011-10-17 Thread Gaetan Nadon
http://www.gnu.org/software/groff/manual/html_node/Man-usage.html Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com Signed-off-by: Gaetan Nadon mems...@videotron.ca --- hw/xfree86/man/xorg.conf.man |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

[PATCH xserver 2/2] XWinrc.man: fix warning: tab character in unquoted macro argument #35054

2011-10-17 Thread Gaetan Nadon
Spaces or tabs do not affect the text output layout. Reviewed-by: Jeremy Huddleston jerem...@apple.com Signed-off-by: Gaetan Nadon mems...@videotron.ca --- hw/xwin/man/XWinrc.man | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/xwin/man/XWinrc.man

Re: [PULL RESEND] more prep work for screen crossing fixes, inverted button emulation fix

2011-10-17 Thread Keith Packard
On Tue, 11 Oct 2011 16:32:24 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Max Schwarz (1): dix: fix inverted handling of legacy scroll button events Peter Hutterer (15): dix: fill out root_x/y for keyboard events dix: warn about keyboard events with valuator

Re: [PULL] build fix, GC clipping cleanup

2011-10-17 Thread Keith Packard
On Wed, 5 Oct 2011 08:30:56 -0700, Jamey Sharp ja...@minilop.net wrote: Alright, the pixmap hooks have weird undocumented constraints, and maybe we'll figure out something clever someday. Meanwhile, would you please merge the other three commits? For other ABI changes like this, we've

Re: [PATCH xserver] composite: Update borderClip in compAllocPixmap()

2011-10-17 Thread Keith Packard
On Sun, 9 Oct 2011 01:11:04 +0300, Ville Syrjala syrj...@sci.fi wrote: Previously the parent constrained borderClip was copied over when compRedirectWindow() is called. That is insufficient eg. in case the window was already redirected, but not yet realized. So copy the borderClip over in

Re: [PULL] build fix, GC clipping cleanup

2011-10-17 Thread Jamey Sharp
On Mon, Oct 17, 2011 at 02:06:55PM -0700, Keith Packard wrote: On Wed, 5 Oct 2011 08:30:56 -0700, Jamey Sharp ja...@minilop.net wrote: Alright, the pixmap hooks have weird undocumented constraints, and maybe we'll figure out something clever someday. Meanwhile, would you please merge the

Re: [PULL] build fix, GC clipping cleanup

2011-10-17 Thread Keith Packard
On Mon, 17 Oct 2011 23:49:19 +0200, Jamey Sharp ja...@minilop.net wrote: Do you care if drivers still work in between the two patches? No. What I think would be nice is if making the changes in the drivers is relatively straight forward, either using a new #define, or just an ABI bump. I'll

Re: [PATCH] configure.ac: Add -fno-strict-aliasing to CFLAGS

2011-10-17 Thread Gaetan Nadon
On Mon, 2011-10-17 at 11:37 -0700, Jeremy Huddleston wrote: This should force the server to have -fno-strict-aliasing even once it is removed from the warning flags. See: https://bugs.freedesktop.org/show_bug.cgi?id=31238 Signed-off-by: Jeremy Huddleston jerem...@apple.com ---

Re: [PATCH 1/2 v5] mieq: Provide better adaptability and diagnostics during mieq overflow

2011-10-17 Thread Peter Hutterer
On Sun, Oct 16, 2011 at 10:14:31PM -0700, Jeremy Huddleston wrote: This patch changes from a static length event queue (512) to one that starts at 128 and grows to 4096 as it overflows, logging each time it grows. This change also allows for multiple backtraces to be printed when the server

Re: [PATCH 2/2 v4] mieq: Reserve some space in EQ for release and other special events

2011-10-17 Thread Peter Hutterer
On Sun, Oct 16, 2011 at 09:16:13PM -0700, Jeremy Huddleston wrote: The last 64 events in the event queue will be reserved for release events in order to help return the system to a cleaner state when it comes back from a soft wedge. Signed-off-by: Jeremy Huddleston jerem...@apple.com ---

Re: [PATCH 1/2 v5] mieq: Provide better adaptability and diagnostics during mieq overflow

2011-10-17 Thread Jeremy Huddleston
On Oct 17, 2011, at 4:58 PM, Peter Hutterer wrote: +if (new_nevents = eventQueue-nevents) +return FALSE; + +if (!eventQueue) { +ErrorF([mi] mieqGrowQueue called with a NULL eventQueue\n); +return FALSE; +} this condition needs to be swapped with the