Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function.

2012-06-19 Thread Kristian Høgsberg
On Mon, Jun 18, 2012 at 12:58 PM, Keith Packard kei...@keithp.com wrote: Christopher James Halse Rogers christopher.halse.rog...@canonical.com writes: +typedef int (*DRI2AuthMagic2ProcPtr) (ScreenPtr pScreen, int fd, uint32_t magic); Bikeshed -- seems like the 'fd' parameter is not needed

[PATCH] Add APIs for selecting on write fds.

2012-06-19 Thread Keith Packard
This adds API support for waking the server when an fd becomes writable. void AddWriteSocket(int fd); Add an FD to the select write mask; the server will wake when this fd is writable. void RemoveWriteSocket(int fd); Remove the FD from the select write mask.

[PATCH] Test WaitForSomething select return in new Check* functions

2012-06-19 Thread Keith Packard
The bitmask from select is only valid if it returned a positive value, so record it for use by CheckWriteSocket and CheckReadSocket Signed-off-by: Keith Packard kei...@keithp.com --- os/WaitFor.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/os/WaitFor.c

Re: [PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function.

2012-06-19 Thread Christopher James Halse Rogers
On Tue, 2012-06-19 at 14:38 -0400, Kristian Høgsberg wrote: On Mon, Jun 18, 2012 at 12:58 PM, Keith Packard kei...@keithp.com wrote: Christopher James Halse Rogers christopher.halse.rog...@canonical.com writes: +typedef int (*DRI2AuthMagic2ProcPtr) (ScreenPtr pScreen, int fd, uint32_t

[PATCH] dri2: Pass a ScreenPtr through to the driver's AuthMagic function. (v3)

2012-06-19 Thread Christopher James Halse Rogers
xwayland drivers need access to their screen private data to authenticate. Now that drivers no longer have direct access to the global screen arrays, this needs to be passed in as function context. v2: Don't break ABI v3: Paint the bikeshed blue; drop fd from AuthMagic2ProcPtr prototype

Re: [PATCH] Add APIs for selecting on write fds.

2012-06-19 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: On Tue, Jun 19, 2012 at 12:00:12PM -0700, Keith Packard wrote: shouldn't the documentatin for the calls be in the code? looking up git commits to understand functions doesn't scale too well. Yeah, I started by copying the text from the function