Hi Matt,
Thank you for your review. We really appreciate that you've pick out so many
issues we need to improve. It seems that we still have a lot of work to do to
match the quality which can be accepted by X.Org. We will fix the issue you've
reported before next submission.
One more question:
On Mon, Jul 09, 2012 at 05:13:15PM -0700, Chase Douglas wrote:
When a touch begin is pointer emulated, the initial motion and button
press events should not have the first button set in the button mask.
The button mask represents the state of the buttons *before* the event.
Signed-off-by:
On Mon, Jul 09, 2012 at 05:12:44PM -0700, Chase Douglas wrote:
When a touch begin is pointer emulated, do not include touch state when
calculating the button state for the initial motion and button press
events. This change ensures the logical state of the buttons prior to the
events is set
when robustness is enabled, this is required.
Cc: Ian Romanick i...@freedesktop.org
Signed-off-by: Dave Airlie airl...@redhat.com
---
glx/glxdri2.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/glx/glxdri2.c b/glx/glxdri2.c
index 909de70..608cc17 100644
---
Cc: Ian Romanick i...@freedesktop.org
Signed-off-by: Dave Airlie airl...@redhat.com
---
glx/glxdri2.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/glx/glxdri2.c b/glx/glxdri2.c
index 608cc17..6b389ab 100644
--- a/glx/glxdri2.c
+++ b/glx/glxdri2.c
@@ -535,7 +535,7 @@
glxdri2.c:486: warning: statement with no effect
Signed-off-by: Dave Airlie airl...@redhat.com
Cc: Ian Romanick i...@freedesktop.org
---
glx/glxdri2.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/glx/glxdri2.c b/glx/glxdri2.c
index 6b389ab..a35e39c 100644
---
Looks like idr renamed this and pushed the wrong one.
Signed-off-by: Dave Airlie airl...@redhat.com
Cc: Ian Romanick i...@freedesktop.org
---
glx/glxdri2.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/glx/glxdri2.c b/glx/glxdri2.c
index a35e39c..ddbcf69 100644
---
Reported by gcc.
Signed-off-by: Dave Airlie airl...@redhat.com
Cc: Ian Romanick i...@freedesktop.org
---
glx/glxdri2.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/glx/glxdri2.c b/glx/glxdri2.c
index ddbcf69..b8261d4 100644
--- a/glx/glxdri2.c
+++ b/glx/glxdri2.c
@@
On 07/12/2012 05:17 AM, Aaron.Chen 陈俊杰 wrote:
Hi Matt,
Thank you for your review. We really appreciate that you've pick out so many
issues we need to improve. It seems that we still have a lot of work to do to
match the quality which can be accepted by X.Org. We will fix the issue you've
From: Michel Dänzer michel.daen...@amd.com
Otherwise the reference can lead to use after free in
__glXDRIinvalidateBuffers().
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50019
Signed-off-by: Michel Dänzer michel.daen...@amd.com
---
glx/glxdri2.c |8 ++--
1 file changed, 6
As suggested by Kristian Høgsberg, explicitly call FreeResource for the DRI2
drawable reference.
[PATCH 1/2] dri2: Add DRI2CreateDrawable2.
[PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX
___
xorg-devel@lists.x.org: X.Org development
From: Michel Dänzer michel.daen...@amd.com
Same as DRI2CreateDrawable, except it can return the DRI2 specific XID of the
DRI2 drawable reference to the base drawable.
Signed-off-by: Michel Dänzer michel.daen...@amd.com
---
hw/xfree86/dri2/dri2.c | 15 +--
hw/xfree86/dri2/dri2.h |
Hi!
While looking at NetBSD xsrc patches I found one for xinit.
Index: xinit/dist/xinitrc.cpp
===
RCS file: /cvsroot/xsrc/external/mit/xinit/dist/xinitrc.cpp,v
retrieving revision 1.1.1.3
retrieving revision 1.2
diff -u -r1.1.1.3
Another patch to NetBSD xsrc adds Colemak data to xkbdata.
The files are marked:
2006-01-01 Shai Coleman, http://colemak.com/ . Public domain.
so they should be safe to include.
I didn't find an anongit repository for xkbdata, so the two files are
added as attachment with corresponding
Jon TURNEY (3):
Revert bogus GlxPushProvider() in commit a1d41e3
Restore extern to the declaration of __glXDRISWRastProvider
Restore GLX extension to XWin
glx/glxext.c |3 ---
glx/glxserver.h |2 +-
hw/xwin/InitOutput.c | 23 ---
3 files changed,
a1d41e3 Move extension initialisation prototypes into extinit.h
also includes a change to GlxExtensionInit to install the swrast GLX
provider.
Since b86aa74 GLX: Insert swrast provider from GlxExtensionInit
already does this (correctly, by installing the swrast provider
at the end of the chain,
b86aa74 dropped the 'extern' from the declaration of __glXDRISWRastProvider
This turns out to be important to me, as without it, the final link only gets
the tentative definition of __glXDRISWRastProvider implied by the declaration,
and not the proper one from glxdriswrast.c, presumably because
- Add an XwinExtensionInit(), similar in spirit to QuartzExtensionInit()
and xf86ExtensionInit()
- Load the GLX extension (I'm guessing XQuartz needs this adding somewhere
as well)
- Also, since we now have an proper place to install the native GL provider
where it will take priority over the the
Another simple fix, this time for libFS -- a broken prototype.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Per NetBSD PR 41899 from Henning Petersen.
Signed-off-by: Thomas Klausner w...@netbsd.org
---
src/FSlibInt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/FSlibInt.c b/src/FSlibInt.c
index db9cc47..a04d3cd 100644
--- a/src/FSlibInt.c
+++ b/src/FSlibInt.c
@@ -1194,7
Hi,
On 12 July 2012 13:30, Jon TURNEY jon.tur...@dronecode.org.uk wrote:
#ifdef XWIN_GLX_WINDOWS
-if (g_fNativeGl) {
+if ((g_fNativeGl) (serverGeneration == 1)) {
/* install the native GL provider */
glxWinPushNativeProvider();
}
#endif
You might instead
Lots of compiler setting recommendations include -DPIC -fPIC
for compiling position-independent code. This patch avoids a
problem with that in xman.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info:
Signed-off-by: Thomas Klausner w...@netbsd.org
---
misc.c | 2 +-
vendor.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/misc.c b/misc.c
index 8818aa8..7592996 100644
--- a/misc.c
+++ b/misc.c
@@ -764,7 +764,7 @@ ConstructCommand(cmdbuf, path, filename, tempfile)
Hi. I have got the following error:
Making all in glx
make[1]: Enter to folder `/usr/src/xorg-server-git/src/xserver/glx'
CC glxdri2.lo
glxdri2.c: In function '__glXDRIscreenDestroy':
glxdri2.c:385:18: warning: cast discards '__attribute__((const))'
qualifier from pointer target type
On Thu, Jul 12, 2012 at 6:54 PM, son_of_the_osi...@interia.pl wrote:
Hi. I have got the following error:
Making all in glx
make[1]: Enter to folder `/usr/src/xorg-server-git/src/xserver/glx'
CC glxdri2.lo
glxdri2.c: In function '__glXDRIscreenDestroy':
glxdri2.c:385:18: warning:
On 07/12/12 05:25 AM, Thomas Klausner wrote:
Another patch to NetBSD xsrc adds Colemak data to xkbdata.
The files are marked:
2006-01-01 Shai Coleman, http://colemak.com/ . Public domain.
so they should be safe to include.
I didn't find an anongit repository for xkbdata, so the two files
This fixes an implicit declaration,
xf86AutoConfig.c:202:5: error: implicit declaration of function
'xf86PlatformMatchDriver' [-Werror=implicit-function-declaration]
xf86AutoConfig.c:202:5: warning: nested extern declaration of
'xf86PlatformMatchDriver' [-Wnested-externs]
Signed-off-by: Dave
On Thu, Jul 12, 2012 at 06:51:04AM -0700, Alan Coopersmith wrote:
xkbdata is long dead - xkeyboard-config replaced it shortly after the
X11R7.0 release.
Thanks for the info. Upon checking further, NetBSD has already
switched to xkeyboard-config (in 2009 or so) but just didn't remove
xkbdata
This adds the decl for SyncExtenionInit.
Signed-off-by: Dave Airlie airl...@redhat.com
---
test/xtest.c |1 +
1 file changed, 1 insertion(+)
diff --git a/test/xtest.c b/test/xtest.c
index 402d9ce..e5e5241 100644
--- a/test/xtest.c
+++ b/test/xtest.c
@@ -30,6 +30,7 @@
#include inputstr.h
On Thu, Jul 12, 2012 at 7:16 AM, Michel Dänzer mic...@daenzer.net wrote:
As suggested by Kristian Høgsberg, explicitly call FreeResource for the DRI2
drawable reference.
[PATCH 1/2] dri2: Add DRI2CreateDrawable2.
[PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX
Thanks, Michel.
Hi,
All Jon's series works OK for me:
Reviewed-by: Colin Harrison colin.harrison at virgin.net
Tested-by: Colin Harrison colin.harrison at virgin.net
Thanks,
Colin Harrison
___
xorg-devel@lists.x.org: X.Org development
Archives:
On Wed, Jul 11, 2012 at 05:56:45PM -0700, Alan Coopersmith wrote:
Works for me. Applied pushed to git master:
To ssh://git.freedesktop.org/git/xorg/app/xedit
33dacad..ce36f7b master - master
Thank you!
As Matt noted, please include the module name in the [PATCH module] header
for
Daniel Stone dan...@fooishbar.org writes:
I hate this [redacted] script.
Signed-off-by: Daniel Stone dan...@fooishbar.org
Merged.
deb0865..8b820f2 master - master
--
keith.pack...@intel.com
pgpq3JJDF6hRx.pgp
Description: PGP signature
___
Jeremy Huddleston Sequoia jerem...@apple.com writes:
Jeremy Huddleston (3):
XQuartz: Silence an unused-variable warning
XQuartz: Fix build failure due to incorrect PseudoramiXExtensionInit
prototype
XQuartz: Re-add prototype for DRIExtensionInit
8b820f2..656e5fe
Michel Dänzer mic...@daenzer.net writes:
From: Michel Dänzer michel.daen...@amd.com
Same as DRI2CreateDrawable, except it can return the DRI2 specific XID of the
DRI2 drawable reference to the base drawable.
Any reason to keep the old function around? It doesn't appear to be used
outside of
Am 12.07.2012 14:55, schrieb Thomas Klausner:
Signed-off-by: Thomas Klausner w...@netbsd.org
---
misc.c | 2 +-
vendor.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/misc.c b/misc.c
index 8818aa8..7592996 100644
--- a/misc.c
+++ b/misc.c
@@ -764,7 +764,7
Hi Keith,
Please consider pulling into master.
Thanks.
The following changes since commit deb08658e2a6b1647a7213a316c6f3019bcdce48:
xfree86: Strip dangling pointers from desiredMode (2012-07-11 15:55:22 -0700)
are available in the git repository at:
On Thu, Jul 12, 2012 at 2:12 AM, Dave Airlie airl...@gmail.com wrote:
Cc: Ian Romanick i...@freedesktop.org
Signed-off-by: Dave Airlie airl...@redhat.com
---
Patches 2-5 are R-b me. No idea about patch 1.
___
xorg-devel@lists.x.org: X.Org development
On Don, 2012-07-12 at 09:30 -0700, Keith Packard wrote:
Michel Dänzer mic...@daenzer.net writes:
From: Michel Dänzer michel.daen...@amd.com
Same as DRI2CreateDrawable, except it can return the DRI2 specific XID of
the
DRI2 drawable reference to the base drawable.
Any reason to
On 07/11/2012 10:37 PM, Matt Turner wrote:
On Wed, Jul 4, 2012 at 3:21 PM, Ian Romanick i...@freedesktop.org wrote:
From: Ian Romanick ian.d.roman...@intel.com
If the driver supports __DRI2_ROBUSTNESS, then enable
GLX_ARB_create_cotnext_robustness as well. If robustness values are
passed to
On Thu, Jul 12, 2012 at 10:33 AM, Ian Romanick i...@freedesktop.org wrote:
No, it should have been __DRI_CTX_ATTRIB_RESET_STRATEGY. :( I making
changes across multiple repos across multiple sets of review comments. I'll
change the name in Mesa back to __DRI_CTX_ATTRIB_RESET_NOTIFICATION.
On 07/12/2012 02:12 AM, Dave Airlie wrote:
glxdri2.c:486: warning: statement with no effect
Signed-off-by: Dave Airlie airl...@redhat.com
Cc: Ian Romanick i...@freedesktop.org
This also needs the 'glx: Fix checking GL version' posted by Bartosz
Brachaczek back on 7/5.
---
glx/glxdri2.c
On 07/12/2012 02:12 AM, Dave Airlie wrote:
when robustness is enabled, this is required.
Cc: Ian Romanick i...@freedesktop.org
Signed-off-by: Dave Airlie airl...@redhat.com
Series is
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
---
glx/glxdri2.c |5 +++--
1 file changed, 3
The same patch as before, but with s/XMAN/ROFF/ -- pick either version :)
[PATCH] Rename PIC to ROFF_PIC to avoid problems with -DPIC
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info:
Signed-off-by: Thomas Klausner w...@netbsd.org
---
misc.c | 2 +-
vendor.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/misc.c b/misc.c
index 8818aa8..abe410e 100644
--- a/misc.c
+++ b/misc.c
@@ -764,7 +764,7 @@ ConstructCommand(cmdbuf, path, filename, tempfile)
On Thu, Jul 12, 2012 at 07:00:52PM +0200, walter harms wrote:
I see, to be fair i do not know the code but the names are roff/nroff
precompiler therefore i would
expect a name like roff_pic.
Fine with me, I've just resent the patch with the change as suggested.
Pick either, I don't really
Michel Dänzer mic...@daenzer.net writes:
On Don, 2012-07-12 at 09:30 -0700, Keith Packard wrote:
Michel Dänzer mic...@daenzer.net writes:
From: Michel Dänzer michel.daen...@amd.com
Same as DRI2CreateDrawable, except it can return the DRI2 specific XID of
the
DRI2 drawable
On Thu, Jul 12, 2012 at 14:39:26 +0200, Thomas Klausner wrote:
Per NetBSD PR 41899 from Henning Petersen.
Signed-off-by: Thomas Klausner w...@netbsd.org
---
src/FSlibInt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/FSlibInt.c b/src/FSlibInt.c
index
Hi!
On 16.02.2012 02:45, Mario Kleiner wrote:
If a swaplimit 1 is set on a server which
supports the swaplimit api (XOrg 1.12.0+),
the following can happen:
1. Client calls glXSwapBuffersMscOML() with a
swap target 1 vblank in the future, or a
client calls glXSwapbuffers() while the
On 07/11/2012 11:26 PM, Peter Hutterer wrote:
On Mon, Jul 09, 2012 at 05:13:15PM -0700, Chase Douglas wrote:
When a touch begin is pointer emulated, the initial motion and button
press events should not have the first button set in the button mask.
The button mask represents the state of the
On 07/11/2012 11:34 PM, Peter Hutterer wrote:
On Mon, Jul 09, 2012 at 05:12:44PM -0700, Chase Douglas wrote:
When a touch begin is pointer emulated, do not include touch state when
calculating the button state for the initial motion and button press
events. This change ensures the logical state
On 11/07/12 08:13 AM, Michel Dänzer wrote:
On Mon, 2012-07-09 at 16:44 -0700, Connor Behan wrote:
On 06/07/12 03:52 AM, Michel Dänzer wrote:
On Don, 2012-07-05 at 17:51 -0700, Connor Behan wrote:
For real this time. This allows the r128 driver to continue having 2D
That this patch is for the
Construct a unique filename based on the display name and the RMLVO
values. If that file contains valid contents, use it. Otherwise,
compile the keymap to that file and don't unlink it so that it will be
re-used the next time the server runs.
Signed-off-by: Keith Packard kei...@keithp.com
---
Michel Dänzer mic...@daenzer.net writes:
[PATCH 1/2] dri2: Add DRI2CreateDrawable2.
[PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX
Merged.
656e5fe..a2d0829 master - master
--
keith.pack...@intel.com
pgpvdimyUbuFg.pgp
Description: PGP signature
Jon TURNEY jon.tur...@dronecode.org.uk writes:
Jon TURNEY (3):
Revert bogus GlxPushProvider() in commit a1d41e3
Restore extern to the declaration of __glXDRISWRastProvider
Restore GLX extension to XWin
Merged.
a2d0829..746193a master - master
--
Hi,
On 12 July 2012 23:07, Keith Packard kei...@keithp.com wrote:
Construct a unique filename based on the display name and the RMLVO
values. If that file contains valid contents, use it. Otherwise,
compile the keymap to that file and don't unlink it so that it will be
re-used the next time
Dave Airlie airl...@gmail.com writes:
This adds the decl for SyncExtenionInit.
Tested-by: Keith Packard kei...@keithp.com
Merged.
746193a..ea74e38 master - master
--
keith.pack...@intel.com
pgp0zVBO6KWGU.pgp
Description: PGP signature
___
Daniel Stone dan...@fooishbar.org writes:
You need to do at least some rudimentary stat() work so that you'll
rebuild the keymap if the files it uses changes.
My plan is to simply put that work on the package installer loading new
files into the xkb directories. A simple post-install hook that
Daniel Stone dan...@fooishbar.org writes:
Ugh, please don't do that. I already get people (validly) complaining
that XKB is unintuitive enough ...
Yeah, but I don't want to stat 324 files and 26 directories. That seems
like a worse plan.
You could just do everything under the data root
Hi Keith,
the GLX fixes are all for building against mesa master, the platform
bus fix is unreviewed, but please smash an r-b on it, its trivial, but
Fedora won't build the server with implicit declarations.
Dave.
The following changes since commit ea74e381ae91f45ec195a5505262e2e5a3c0e1c9:
Dave Airlie airl...@gmail.com writes:
Bartosz Brachaczek (1):
glx: Fix checking GL version
Dave Airlie (6):
glx: pass screen into the convert function
glx/dri2: fix typo in the notification reset for robustness.
glx/dri2: fix incorrect == vs =
glx/dri2: use
On Thu, 2012-07-12 at 15:27 -0700, Keith Packard wrote:
My plan is to simply put that work on the package installer loading new
files into the xkb directories. A simple post-install hook that removed
all of the files in the server's cache directory should make that work
It'd be nicer if X
On Thu, Jul 12, 2012 at 01:17:33PM -0700, Chase Douglas wrote:
On 07/11/2012 11:26 PM, Peter Hutterer wrote:
On Mon, Jul 09, 2012 at 05:13:15PM -0700, Chase Douglas wrote:
When a touch begin is pointer emulated, the initial motion and button
press events should not have the first button set in
Colin Walters walt...@verbum.org writes:
It'd be nicer if X shipped a binary to run which did whatever is
necessary to ensure the cache is valid, and update it. That keeps the
implementation details of the caching contained where it should be, and
not duplicated around in the various
64 matches
Mail list logo
