Re: [PATCH:xscope] Print correct event names for events sent via SendEvent requests

2013-12-02 Thread walter harms
Am 01.12.2013 20:44, schrieb Alan Coopersmith: The high bit of an X11 event id is set to 0 for events generated by the server, 1 for events sent from another client via SendEvent requests. Previously xscope printed: ..EVENT: **INVALID** (150) Now it

Re: [PATCH 1/1] glxstubs: Don't mix availability types on non-ELF

2013-12-02 Thread Jon TURNEY
On 29/11/2013 19:36, Jeremy Huddleston Sequoia wrote: Signed-off-by: Jeremy Huddleston Sequoia jeremyhu-2kanfrk1nckavxtiumw...@public.gmane.org --- glx/glxstubs.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/glx/glxstubs.c b/glx/glxstubs.c index

Re: [PATCH] configure.ac: enable systemd socket activation in libxtrans

2013-12-02 Thread Łukasz Stelmach
It was 2013-11-30 sob 01:42, when Peter Hutterer wrote: On 29/11/2013 19:36 , Łukasz Stelmach wrote: It was 2013-11-29 pią 06:00, when Peter Hutterer wrote: On Thu, Nov 28, 2013 at 04:23:07PM +0100, Hans de Goede wrote: From: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Łukasz

Re: [PATCH] configure.ac: enable systemd socket activation in libxtrans

2013-12-02 Thread Hans de Goede
Hi, On 12/02/2013 02:33 PM, Łukasz Stelmach wrote: It was 2013-11-30 sob 01:42, when Peter Hutterer wrote: On 29/11/2013 19:36 , Łukasz Stelmach wrote: It was 2013-11-29 pią 06:00, when Peter Hutterer wrote: On Thu, Nov 28, 2013 at 04:23:07PM +0100, Hans de Goede wrote: From: Łukasz

Re: [RFC] GLX dispatch rewrite

2013-12-02 Thread Jon TURNEY
On 30/11/2013 00:07, Keith Packard wrote: Jeremy Huddleston Sequoia writes: We can't guarantee what symbols (ie OpenGL extensions) will be available in libGL at link time and runtime which is why I wrote _glapi_create_table_from_handle. This fills out the dispatch table with entry points

[PATCH 0/5] hw/xwin fixes and more

2013-12-02 Thread Jon TURNEY
Sorry for being a bit late in the release cycle for looking at these issues. [5/5] is just here for discussion. Jon TURNEY (4): configure.ac: Don't fail with an error about requiring libpciaccess with --disable-int10-module --disable-pciaccess configure.ac: Link XWin with present

[PATCH 1/5] configure.ac: Don't fail with an error about requiring libpciaccess with --disable-int10-module --disable-pciaccess

2013-12-02 Thread Jon TURNEY
Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com Tested-by: Jeremy Huddleston Sequoia jerem...@apple.com --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index

[PATCH 3/5] ephyr: Fix compilation when ./configure'd with --enable-debug

2013-12-02 Thread Jon TURNEY
/jhbuild/checkout/xorg/xserver/hw/kdrive/ephyr/ephyr.c: In function ‘ephyrProcessMouseMotion’: /jhbuild/checkout/xorg/xserver/hw/kdrive/ephyr/ephyr.c:946:188: error: ‘ephyrCurScreen’ undeclared (first use in this function) /jhbuild/checkout/xorg/xserver/hw/kdrive/ephyr/ephyr.c: In function

[PATCH 5/5] hw/xwin: Rewrite WGL wrapper function generation script

2013-12-02 Thread Jon TURNEY
From: Marc Haesen ma...@users.sourceforge.net Rewrite WGL wrapper function generation script to use Khronos group XML v2: Remove -dispatchheader option, since dispatch.h doesn't exist anymore, use the private glapi interface to construct the GL dispatch table for the native WGL thunks.

[PATCH 4/5] hw/xwin/glx: Fix compilation of hw/xwin/glx/indirect.c

2013-12-02 Thread Jon TURNEY
/jhbuild/checkout/xorg/xserver/hw/xwin/glx/indirect.c: In function 'fbConfigsDump': /jhbuild/checkout/xorg/xserver/hw/xwin/glx/indirect.c:390:34: error: 'GLX_RGBA_FLOAT_BIT_ARB' undeclared (first use in this function) /jhbuild/checkout/xorg/xserver/hw/xwin/glx/indirect.c:391:20: error:

[PATCH 2/5] configure.ac: Link XWin with present extension if we are building with it enabled

2013-12-02 Thread Jon TURNEY
Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index dfd4c78..6e4784a 100644 --- a/configure.ac +++ b/configure.ac @@ -2065,7 +2065,7 @@ if test x$XWIN = xyes; then

[PATCH libXft] Use FT_*_H macros instead of including freetype/*.h

2013-12-02 Thread Julien Cristau
The latter doesn't seem to work with recent freetype. Signed-off-by: Julien Cristau jcris...@debian.org --- src/xftglyphs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/xftglyphs.c b/src/xftglyphs.c index 2f3dc5a..4b5fb82 100644 --- a/src/xftglyphs.c +++

[PATCH][libXft] xftglyphs: use recommend freetype inclusion

2013-12-02 Thread Ross Burton
FreeType recommends to use their special macros to include the headers, because it gives them the ability to move headers around. They did this in 2.5.1 (yes, a point release) and this direct inclusion doesn't work anymore. Signed-off-by: Ross Burton ross.bur...@intel.com --- src/xftglyphs.c |

Re: [RFC] GLX dispatch rewrite

2013-12-02 Thread Adam Jackson
On Fri, 2013-11-29 at 15:20 -0800, Jeremy Huddleston Sequoia wrote: On Nov 29, 2013, at 12:13, Keith Packard kei...@keithp.com wrote: Jeremy Huddleston Sequoia jerem...@freedesktop.org writes: So what's the story on this? How should we solve this for xquartz and xwin? Should we pull

Re: [PATCH 1/1] glxstubs: Don't mix availability types on non-ELF

2013-12-02 Thread Jeremy Huddleston Sequoia
On Dec 2, 2013, at 04:37, Jon TURNEY jon.tur...@dronecode.org.uk wrote: On 29/11/2013 19:36, Jeremy Huddleston Sequoia wrote: Signed-off-by: Jeremy Huddleston Sequoia jeremyhu-2kanfrk1nckavxtiumw...@public.gmane.org --- glx/glxstubs.c | 8 +++- 1 file changed, 7 insertions(+), 1

Re: [PATCH] configure.ac: enable systemd socket activation in libxtrans

2013-12-02 Thread Hans de Goede
Hi, On 11/28/2013 07:34 PM, Gaetan Nadon wrote: On 13-11-28 10:23 AM, Hans de Goede wrote: +AC_ARG_WITH([systemd], + AS_HELP_STRING([--with-systemd], [support systemd socket activation]), + [], [with_systemd=check]) +have_systemd=check Can I trouble you to replace check with auto?

[PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation (v5)

2013-12-02 Thread Hans de Goede
Hi All, Here is v5 (I'm starting the numbering where Łukasz stopped) of the systemd socket activation patch-set. This version addresses all review comments made in response to my previous posting of this set. Testing can still be done like this: 1) Create a file named

[PATCH libxtrans 1/2] Define TRANS_RECEIVED flag for transports

2013-12-02 Thread Hans de Goede
From: Łukasz Stelmach l.stelm...@samsung.com The flag is to be used to mark transports related to sockets received from systemd. Signed-off-by: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- Xtrans.c

Re: [PATCH 2/2] Enable systemd socket activation

2013-12-02 Thread Hans de Goede
Hi, On 11/29/2013 05:37 AM, Peter Hutterer wrote: On Thu, Nov 28, 2013 at 04:21:14PM +0100, Hans de Goede wrote: From: Łukasz Stelmach l.stelm...@samsung.com Receive file descriptors of open sockets from systemd instead of creating them. --- Xtrans.c | 82

Re: [PATCH] configure.ac: enable systemd socket activation in libxtrans

2013-12-02 Thread Hans de Goede
Hi, On 11/29/2013 06:00 AM, Peter Hutterer wrote: On Thu, Nov 28, 2013 at 04:23:07PM +0100, Hans de Goede wrote: From: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Hans de Goede hdego...@redhat.com --- configure.ac | 28

[PATCH] configure.ac: enable systemd socket activation in libxtrans

2013-12-02 Thread Hans de Goede
From: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Łukasz Stelmach l.stelm...@samsung.com Signed-off-by: Hans de Goede hdego...@redhat.com --- configure.ac | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index

[PATCH libxtrans 2/2] Enable systemd socket activation

2013-12-02 Thread Hans de Goede
From: Łukasz Stelmach l.stelm...@samsung.com Receive file descriptors of open sockets from systemd instead of creating them. Signed-off-by: Łukasz Stelmach l.stelm...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: MyungJoo Ham myungjoo@samsung.com Cc: Piort Bereza

Re: [PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation

2013-12-02 Thread Hans de Goede
Hi, On 11/29/2013 05:38 AM, Peter Hutterer wrote: On Thu, Nov 28, 2013 at 04:21:12PM +0100, Hans de Goede wrote: Hi All, As I already mentioned in my self-introduction mail I'm a new member of Red Hat's graphics team. One of the first things I'll be working on is systemd integration,

Re: [PATCH 06/14] composite: Automatically enable backing store support on the screen

2013-12-02 Thread Julien Cristau
On Thu, Nov 21, 2013 at 17:43:19 -0500, Adam Jackson wrote: ... unless you explicitly disabled it with -bs on the command line, or with the corresponding thing in xorg.conf. v2: Drop a bogus hunk from compChangeWindowAttributes [vsyrjala] Signed-off-by: Adam Jackson a...@redhat.com ---

Re: [PATCH] configure.ac: enable systemd socket activation in libxtrans

2013-12-02 Thread Gaetan Nadon
On 13-12-02 01:48 PM, Hans de Goede wrote: Thanks for the feedback, both have been fixed in my local tree, I'll send a new version soon. Thanks, Gaetan ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: [PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation

2013-12-02 Thread Julien Cristau
On Mon, Dec 2, 2013 at 20:50:33 +0100, Hans de Goede wrote: Given that this is mostly for more embedded setups and it does not work with xdm/gdm, I'm not sure shipping these as example is a good idea. They won't be usable ootb in anyway, integration work will need to be done by distros who

Re: [RFC] GLX dispatch rewrite

2013-12-02 Thread Keith Packard
Adam Jackson a...@nwnk.net writes: Right, but that lack-of-guarantee is true of Linux too. glxstubs.c is incomplete evidence of this. I ought to just flesh that out the rest of the way. On Windows, the desire is to be able to switch (at run-time) between the native GL and swrast in mesa,

Re: [PATCH 07/14] composite: Don't double-redirect if someone asks for backing store twice

2013-12-02 Thread Keith Packard
Adam Jackson a...@redhat.com writes: v2: Belt-and-suspenders the unredirection path [vsyrjala] Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpoLfhOR1qWj.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation (v5)

2013-12-02 Thread Kristian Høgsberg
On Mon, Dec 2, 2013 at 11:44 AM, Hans de Goede hdego...@redhat.com wrote: Hi All, Hi, I didn't follow all this in detail, but I'm not sure that we need Xtrans patches at all. The server already has ListenOnOpenFD() in os/connection.c. It was added for launchd under OSX, but we use it for

[PATCH:libXmu] ShapeEllipseOrRoundedRectangle: Check height AND width, not width twice

2013-12-02 Thread Alan Coopersmith
Fixed to match check in ShapeOval() https://bugs.freedesktop.org/show_bug.cgi?id=72245 Fixes cppcheck warning: [ShapeWidg.c:204]: (style) Same expression on both sides of '||'. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/ShapeWidg.c |2 +- 1 file changed, 1

[PATCH util-macros] XORG_WITH_DOXYGEN: check for the dot graphics utility

2013-12-02 Thread Gaetan Nadon
It is part of the graphviz package and it may be used by doxygen if the HAVE_DOT is set to yes in the doxygen configuration file. The calling module handles if the tool is mandatory or not. Doxygen will work fine without it, but no fancy graphics. Signed-off-by: Gaetan Nadon mems...@videotron.ca

[PATCH 2/4] Xext: Use SHMDIR and O_TMPFILE when creating mapping files

2013-12-02 Thread Keith Packard
ShmCreateSegment asks for a file descriptor for a memory mapped file created by the X server. This patch uses O_TMPFILE where available, and also uses the SHMDIR directory to store the files, both for the O_TMPFILE and mkstemp cases. Signed-off-by: Keith Packard kei...@keithp.com Reviewed-by:

[PATCH 0/4] Fixes for X shared memory fence stuff

2013-12-02 Thread Keith Packard
Make sure the fences are allocated on the right file system: [PATCH 1/4] Select directory for MIT-SHM temp files at configure time [PATCH 2/4] Xext: Use SHMDIR and O_TMPFILE when creating mapping Avoid consuming low file descriptors with shared memory fence FDs: [PATCH 3/4] miext: Move

[PATCH 4/4] miext/sync: Handle libxshmfence API change

2013-12-02 Thread Keith Packard
libxshmfence had an unfortunate 'int32_t' type for the mapped fence. That changed to exposing a 'struct shmfence' instead, which is nice and opaque and offers fine type checking across the API. This patch requires the newer version of the library and uses the new interface type. Signed-off-by:

[PATCH 3/4] miext: Move SyncShm FDs out of the way of clients

2013-12-02 Thread Keith Packard
Applications may end up allocating a bunch of shmfence objects, each of which uses a file descriptor, which must be kept open lest some other client ask for a copy of it later on. Lacking an API that can turn a memory mapping back into a file descriptor, about the best we can do is push the file

[PATCH 1/4] Select directory for MIT-SHM temp files at configure time

2013-12-02 Thread Keith Packard
By default, this looks through a list of directories to find one which exists, but can be overridden with --with-shared-memory-dir=PATH This patch doesn't actually do anything with this directory, just makes it available in the configuration Signed-off-by: Keith Packard kei...@keithp.com

Re: [PATCH 0/4] Fixes for X shared memory fence stuff

2013-12-02 Thread Keith Packard
Keith Packard kei...@keithp.com writes: Make sure the fences are allocated on the right file system: [PATCH 1/4] Select directory for MIT-SHM temp files at configure time [PATCH 2/4] Xext: Use SHMDIR and O_TMPFILE when creating mapping Avoid consuming low file descriptors with shared

Re: [PATCH 09/14] xinerama: Export the screen region

2013-12-02 Thread Keith Packard
Adam Jackson a...@redhat.com writes: damageext wants this so it can intersect subtract requests against the root window geometry. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpQ0u4HGBmtE.pgp Description: PGP signature

[PATCH] Xi: ungrab device when releasing a passive grab without ButtonReleaseMask (#71878)

2013-12-02 Thread Peter Hutterer
If a touch triggers an async button grab and that grab does not have the ButtonReleaseMask set, the TouchEnd is never delivered, deliveries is 0 and the grab is never deactivated. If the grab is pointer async and keyboard sync, the keyboard events are stuck in EnqueueEvent until some other

[PATCH util-macros] XORG_TESTSET_CFLAG: add -fd which is the SUNCC -Wold-style-definition

2013-12-02 Thread Gaetan Nadon
Seen in the XCB configuration and found missing in xorg. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- xorg-macros.m4.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in index 20a0bd0..0a547c7 100644 --- a/xorg-macros.m4.in +++

Re: [PATCH 11/14] damageext: Xineramify (v6)

2013-12-02 Thread Keith Packard
Adam Jackson a...@redhat.com writes: I've been reading code this afternoon, and I think your approach is subtly broken. PanoramiXDamageQueue traps the damage additions to screen 0, creates a Dispatch callback and then waits until the request completes before merging damage. Other screens call

Re: [PATCH 10/14] dix: Add PostDispatchCallback

2013-12-02 Thread Keith Packard
Adam Jackson a...@redhat.com writes: This is required to Xineramify the Damage extension, since we need to collect regions across screens. You can't quite use FlushCallback for this since WriteEventsToClient can itself trigger FlushCallback and you recurse. There are probably other cases

Re: [PATCH 13/14] fixes: Fix PanoramiXSetPictureClipRegion for root windows (v2)

2013-12-02 Thread Keith Packard
Adam Jackson a...@redhat.com writes: Root windows in Xinerama are in the coordinate space of their root window pixmap, not in protocol space. This fixes 'xcompmgr -n' when Xinerama is active. v2: Only translate for root windows, since the clip origin is drawable-relative. Reviewed-by:

Re: [PATCH 14/14] fixes: Fix PanoramiXSetWindowShapeRegion for root windows (v2)

2013-12-02 Thread Keith Packard
Adam Jackson a...@redhat.com writes: Root windows in Xinerama are in the coordinate space of their root window pixmap, not in protocol space. v2: Only translate for root windows, sice the window shape is drawable-relative. This looks so familiar... Reviewed-by: Keith Packard

Re: [PATCH util-macros] XORG_TESTSET_CFLAG: add -fd which is the SUNCC -Wold-style-definition

2013-12-02 Thread Alan Coopersmith
On 12/ 2/13 03:37 PM, Gaetan Nadon wrote: Seen in the XCB configuration and found missing in xorg. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- xorg-macros.m4.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in index

[PATCH:luit] Remove nearly empty locale.c file

2013-12-02 Thread Alan Coopersmith
Simply included a bunch of .h files and had no code of its own. Flagged by Solaris ld -z guidance: ld: guidance: removal of unused file recommended: locale.o Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- Makefile.am |1 - locale.c|5 - 2 files changed, 6

Re: [PATCH 12/14] composite: Fix COW creation for Xinerama

2013-12-02 Thread Keith Packard
Adam Jackson a...@redhat.com writes: Say you have two 800x600 screens left/right of each other. A window that's 200x200 at +700+0 in protocol coordinate space will appear to be at -100+0 in the coordinate space of the right hand screen. Put another way: windows are in the coordinate space

Re: [PATCH 2/2] dix: Use XINotifyPassiveGrab/Ungrab on button passive grab crossings

2013-12-02 Thread Peter Hutterer
On Tue, Nov 26, 2013 at 02:07:06PM +1000, Peter Hutterer wrote: On Mon, Nov 25, 2013 at 06:14:38PM +0100, carl...@gnome.org wrote: From: Carlos Garnacho carl...@gnome.org XI2 clients were getting crossing events with XINotifyGrab/Ungrab modes whenever a passive button grab was triggered,

[PATCH] dix: fix check for grab type

2013-12-02 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dix/events.c b/dix/events.c index 4632bb7..4aaa54c 100644 --- a/dix/events.c +++ b/dix/events.c @@ -4696,7 +4696,7 @@ DeviceEnterLeaveEvent(DeviceIntPtr

Re: [PATCH libxtrans 2/2] Enable systemd socket activation

2013-12-02 Thread Alan Coopersmith
On 12/ 2/13 11:44 AM, Hans de Goede wrote: Cc: Alan Coopersmith alan.coopersm...@oracle.com You can stop cc'ing me on every patch, since that just adds to the patches getting caught in moderation for having too large a cc list. I'm already on xorg-devel, and have no interest in support for

Re: [PATCH 0/5] A couple more present fixes

2013-12-02 Thread Michel Dänzer
On Don, 2013-11-21 at 10:16 -0500, Alex Deucher wrote: On Thu, Nov 21, 2013 at 1:12 AM, Keith Packard kei...@keithp.com wrote: Alex Deucher alexdeuc...@gmail.com writes: For anyone interested in fixing this for pre-present xserver, Ilija fixed it similarly in the ddx for radeon:

Re: [PATCH 0/5] A couple more present fixes

2013-12-02 Thread Keith Packard
Michel Dänzer mic...@daenzer.net writes: IIRC changing the MSC frequency would e.g. break some piglit tests if DPMS happened to be active when they were running. There could be similar issues with real apps. I'm open to suggestions, but given that DRI2 is already broken in one direction