Re: [PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation

2013-12-03 Thread Hans de Goede
Hi, On 12/02/2013 09:36 PM, Julien Cristau wrote: On Mon, Dec 2, 2013 at 20:50:33 +0100, Hans de Goede wrote: Given that this is mostly for more embedded setups and it does not work with xdm/gdm, I'm not sure shipping these as example is a good idea. They won't be usable ootb in anyway,

Re: [PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation (v5)

2013-12-03 Thread Hans de Goede
Hi, On 12/02/2013 09:54 PM, Kristian Høgsberg wrote: On Mon, Dec 2, 2013 at 11:44 AM, Hans de Goede hdego...@redhat.com wrote: Hi All, Hi, I didn't follow all this in detail, but I'm not sure that we need Xtrans patches at all. The server already has ListenOnOpenFD() in os/connection.c.

[PATCH RESEND] xfree86: Keep a non-seat0 X server from touching VTs (#71258)

2013-12-03 Thread Laércio de Sousa
This is my first atempt to block VT access to non-seat0 X servers. If -seat option is passed with a value different from seat0, X server won't call xf86OpenConsole(). This is needed to avoid any race condition between seat0 and non-seat0 X servers. If a non-seat0 X server opens a given VT before

Re: [PATCH 11/14] damageext: Xineramify (v6)

2013-12-03 Thread Adam Jackson
On Mon, 2013-12-02 at 15:38 -0800, Keith Packard wrote: Adam Jackson a...@redhat.com writes: I've been reading code this afternoon, and I think your approach is subtly broken. PanoramiXDamageQueue traps the damage additions to screen 0, creates a Dispatch callback and then waits until the

[libxshmfence PATCH] Check return value from ftruncate

2013-12-03 Thread Julien Cristau
Silences compiler warning: xshmfence_alloc.c: In function 'xshmfence_alloc_shm': xshmfence_alloc.c:54:11: warning: ignoring return value of 'ftruncate', declared with attribute warn_unused_result [-Wunused-result] ftruncate(fd, sizeof (struct xshmfence)); ^ Signed-off-by: Julien

Re: [PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation (v5)

2013-12-03 Thread Kristian Høgsberg
On Tue, Dec 3, 2013 at 1:48 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 12/02/2013 09:54 PM, Kristian Høgsberg wrote: On Mon, Dec 2, 2013 at 11:44 AM, Hans de Goede hdego...@redhat.com wrote: Hi All, Hi, I didn't follow all this in detail, but I'm not sure that we need

[PATCH 8/8] xquartz/glx: Convert to non-glapi dispatch

2013-12-03 Thread Adam Jackson
CGL doesn't have anything like glXGetProcAddress, and the old code just called down to dlsym in any case. It's a little mind-warping since dlopening a framework actually loads multiple dylibs, but that's just how OSX rolls. Signed-off-by: Adam Jackson a...@redhat.com ---

[PATCH 1/8] glx: Refresh generated code

2013-12-03 Thread Adam Jackson
This just brings the code into sync with current Mesa master. Signed-off-by: Adam Jackson a...@redhat.com --- glx/indirect_dispatch.c | 12 glx/indirect_dispatch.h | 8 ++-- glx/indirect_dispatch_swap.c | 14 ++ glx/indirect_size_get.c | 9 +

[PATCH 0/8] Attempt to fix GLX for OSX

2013-12-03 Thread Adam Jackson
This fixes up the indirect glx code to only call-by-name those symbols present in the Linux OpenGL ABI, which corresponds to OpenGL 1.2.1. Since that was available even on OSX 10.0 this should be sufficient for xquartz as well. Merely proven correct, not tested. The xwin code assuredly needs

[PATCH 4/8] glx: Remove function stubs

2013-12-03 Thread Adam Jackson
Now that we're calling non-1.2 ABI things by function pointer this is no longer needed. Signed-off-by: Adam Jackson a...@redhat.com --- glx/Makefile.am | 1 - glx/glxstubs.c | 50 -- 2 files changed, 51 deletions(-) delete mode 100644

[PATCH 6/8] dri2: wire up GetProcAddress

2013-12-03 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- glx/glxdri2.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index fbbd1fd..632768c 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -55,7 +55,6 @@ typedef struct __GLXDRIscreen

[PATCH 3/8] glx: Convert non-generated function pointer thunking

2013-12-03 Thread Adam Jackson
Same concept as the generated code conversion. Signed-off-by: Adam Jackson a...@redhat.com --- glx/indirect_program.c | 34 -- glx/render2.c | 12 ++-- glx/render2swap.c | 12 ++-- 3 files changed, 44 insertions(+), 14 deletions(-)

[PATCH 7/8] drisw: Wire up GetProcAddress

2013-12-03 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- glx/glxdriswrast.c | 5 + 1 file changed, 5 insertions(+) diff --git a/glx/glxdriswrast.c b/glx/glxdriswrast.c index c9962dc..d41967f 100644 --- a/glx/glxdriswrast.c +++ b/glx/glxdriswrast.c @@ -425,6 +425,9 @@

[PATCH 5/8] glx: Untangle the prototypes around the GetProcAddress thunk

2013-12-03 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- glx/glxext.c| 4 ++-- glx/glxserver.h | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/glx/glxext.c b/glx/glxext.c index 3a7de28..3f5758e 100644 --- a/glx/glxext.c +++ b/glx/glxext.c @@ -541,10 +541,10 @@

[PATCH:macros] XORG_COMPILER_FLAGS: Add -Wlogical-op to default warning set

2013-12-03 Thread Alan Coopersmith
We've fixed several bugs it uncovered already, only one warning left that it adds in a default build. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- xorg-macros.m4.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in

Re: [PATCH:macros] XORG_COMPILER_FLAGS: Add -Wlogical-op to default warning set

2013-12-03 Thread Gaetan Nadon
On 13-12-03 04:09 PM, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- xorg-macros.m4.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in index 0a547c7..200a36b 100644 Reviewed-by: Gaetan

Re: [RFC] GLX dispatch rewrite

2013-12-03 Thread Adam Jackson
On Mon, 2013-12-02 at 12:37 -0800, Keith Packard wrote: Adam Jackson a...@nwnk.net writes: Right, but that lack-of-guarantee is true of Linux too. glxstubs.c is incomplete evidence of this. I ought to just flesh that out the rest of the way. On Windows, the desire is to be able to

[PATCH synaptics] eventcomm: ungrab the device on DeviceOff

2013-12-03 Thread Peter Hutterer
For symmetry, the kernel should ungrab when we close the fd. Reported-by: Kristian Høgsberg k...@bitplanet.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/eventcomm.c | 4 1 file changed, 4 insertions(+) diff --git a/src/eventcomm.c b/src/eventcomm.c index

Re: [PATCH 0/8] Attempt to fix GLX for OSX

2013-12-03 Thread Jon TURNEY
On 03/12/2013 20:14, Adam Jackson wrote: This fixes up the indirect glx code to only call-by-name those symbols present in the Linux OpenGL ABI, which corresponds to OpenGL 1.2.1. Since that was available even on OSX 10.0 this should be sufficient for xquartz as well. Thanks very much for

Re: [RFC] GLX dispatch rewrite

2013-12-03 Thread Keith Packard
Adam Jackson a...@nwnk.net writes: That's insane. It *is* Windows, after all, so a certain level of insanity is to be expected? In any case, as Jon explained it to me, it's done on a per-window basis -- for top-level windows, it's easy to directly use the Windows GL. For sub-windows, that's

Re: [PATCH 11/14] damageext: Xineramify (v6)

2013-12-03 Thread Keith Packard
Adam Jackson a...@redhat.com writes: No. Accumulate - DamageReportDamage on screen 0 - Queue. Even if clipping means there's no damage to screen 0's logical aperture, screen 0's DamageExtPtr tracks the whole protocol screen, and its callback always gets invoked. Oh, right, it's calling

Re: [RFC] GLX dispatch rewrite

2013-12-03 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/02/2013 12:37 PM, Keith Packard wrote: Adam Jackson a...@nwnk.net writes: Right, but that lack-of-guarantee is true of Linux too. glxstubs.c is incomplete evidence of this. I ought to just flesh that out the rest of the way. On

[PATCH xgc] Remove include of Version 7 sys/timeb.h header

2013-12-03 Thread Matthieu Herrb
From: Christian Weisgerber na...@mips.inka.de I don't know if there are any extant operating systems that still require sys/timeb.h for getrusage(). Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr --- tests.c | 1 - 1 file changed, 1 deletion(-) diff --git tests.c tests.c index

Re: [PATCH 0/8] Attempt to fix GLX for OSX

2013-12-03 Thread Jeremy Huddleston Sequoia
I haven't tested the series yet, but I will hopefully tomorrow. My main concern is with error handling when __glGetProcAddress() returns NULL. == 1,4,5 == Ok Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com == 2 == I didn't check line by line, but the pattern looks reasonable if one

Re: xfree86: Keep a non-seat0 X server from touching VTs

2013-12-03 Thread Connor Behan
On 03/12/13 12:00 PM, lbsous...@gmail.com wrote: This is my first atempt to block VT access to non-seat0 X servers. If -seat option is passed with a value different from seat0, X server won't call xf86OpenConsole(). This is needed to avoid any race condition between seat0 and non-seat0 X