Re: [PATCH 05/27] glamor: Do glyph private init at screeninit time, and other stuff at CSR.

2014-03-13 Thread Michel Dänzer
On Mit, 2014-03-12 at 17:37 -0700, Eric Anholt wrote: Markus Wick mar...@selfnet.de writes: Am 2014-03-11 22:30, schrieb Eric Anholt: diff --git a/glamor/glamor.h b/glamor/glamor.h index e25dc73..9cda46d 100644 --- a/glamor/glamor.h +++ b/glamor/glamor.h @@ -131,14 +131,6 @@ extern

glamor performance regression

2014-03-13 Thread Michel Dänzer
On Mon, 2014-03-10 at 14:10 -0700, Keith Packard wrote: commit 25be6b384298a7769fedb6d9b5bdc370398c9c95 Author: Eric Anholt e...@anholt.net Date: Sun Jan 12 07:18:50 2014 +0800 glamor: Fix a mismatched glamor_get/put_context(). We don't call GL in this function any more,

[PATCH xf86-input-joystick 2/3] Add a generic jstkCloseDevice helper function

2014-03-13 Thread Hans de Goede
This is a preparation patch for adding support for server managed fds. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/backend_bsd.c | 5 + src/backend_evdev.c| 5 + src/backend_joystick.c | 30 +- src/jstk.c | 18

[PATCH xf86-input-joystick 3/3] Add support for server managed fds

2014-03-13 Thread Hans de Goede
Keep things simple by handling server managed fds in the common parts of the open and close paths. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/backend_bsd.c | 10 ++ src/backend_evdev.c| 10 ++ src/backend_joystick.c | 10 ++ src/jstk.c |

Re: [PATCH 21/27] glamor: Improve the performance of PushPixels by, well, pushing pixels.

2014-03-13 Thread Eric Anholt
Markus Wick mar...@selfnet.de writes: I didn't find any issues in this patch, but I don't see the point: Do we really want to convert a pixmap with 1 bit per pixel into a list of enabled pixels on cpu? Isn't it as easy to upload this pixmap as texture and do everything else in the pixel

Re: [PATCH 05/27] glamor: Do glyph private init at screeninit time, and other stuff at CSR.

2014-03-13 Thread Eric Anholt
Michel Dänzer mic...@daenzer.net writes: On Mit, 2014-03-12 at 17:37 -0700, Eric Anholt wrote: Markus Wick mar...@selfnet.de writes: Am 2014-03-11 22:30, schrieb Eric Anholt: diff --git a/glamor/glamor.h b/glamor/glamor.h index e25dc73..9cda46d 100644 --- a/glamor/glamor.h +++

Re: glamor performance regression

2014-03-13 Thread Eric Anholt
Michel Dänzer mic...@daenzer.net writes: On Mon, 2014-03-10 at 14:10 -0700, Keith Packard wrote: commit 25be6b384298a7769fedb6d9b5bdc370398c9c95 Author: Eric Anholt e...@anholt.net Date: Sun Jan 12 07:18:50 2014 +0800 glamor: Fix a mismatched glamor_get/put_context(). We

Re: [PATCH 16/27] glamor: Replace some goofy enum-likes with a real enum.

2014-03-13 Thread Eric Anholt
Markus Wick mar...@selfnet.de writes: Am 2014-03-11 22:30, schrieb Eric Anholt: This unpacks the bitfield into an int size, but my experience has been that packing bitfields doesn't matter for performance. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_fbo.c | 2 +-

Re: [PATCH v2 0/5] xwayland: Refactor bits of XKB functionality

2014-03-13 Thread Kristian Høgsberg
On Wed, Mar 12, 2014 at 7:56 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Refactored series. I really disliked the XkbCompContext patches, something just didn't sit right with it. I wish we could use fmemopen() but short of that or a bigger refactoring this should do. Replaces the

Re: [PATCH 1/2] glamor_*gl_has_extension: Move strlen after check for NULL string

2014-03-13 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: Alan Coopersmith alan.coopersm...@oracle.com writes: Flagged by cppcheck 1.64: [glamor/glamor_core.c:536] - [glamor/glamor_core.c:540]: (warning) Possible null pointer dereference: extension - otherwise it is redundant to check it

Re: [PATCH 18/27] glamor: Allow nested mapping of pixmaps.

2014-03-13 Thread Eric Anholt
Markus Wick mar...@selfnet.de writes: Am 2014-03-11 22:30, schrieb Eric Anholt: The common pattern is to do nested if statements making calls to prepare_access() and then pop those mappings back off in each set of braces. Some cases checked for src == dst to avoid leaking mappings, but

Re: [PATCH 1/2] glamor_*gl_has_extension: Move strlen after check for NULL string

2014-03-13 Thread Alan Coopersmith
On 03/13/14 11:40 AM, Eric Anholt wrote: Keith Packard kei...@keithp.com writes: Alan Coopersmith alan.coopersm...@oracle.com writes: Flagged by cppcheck 1.64: [glamor/glamor_core.c:536] - [glamor/glamor_core.c:540]: (warning) Possible null pointer dereference: extension - otherwise

[PATCH] Xge: remove warning messages about missing Xge extension event translations

2014-03-13 Thread Keith Packard
When mixing Xlib and xcb, it's quite possible for some events to be received for xcb-only extensions, which will subsequently not be translatable by the Xge WireToEvent/EventToWire hooks Signed-off-by: Keith Packard kei...@keithp.com --- src/Xge.c | 7 --- 1 file changed, 7 deletions(-)

[PATCH] a lockup in the mga driver

2014-03-13 Thread Mikulas Patocka
Hi David Are you maintaining the Xorg mga driver? (you anounced the last update 1.6.3) Or is someone else maintaining it? I've had a Xserver lockup in the mga driver, examining it with gdb showed this obviously broken loop: count = INREG(MGAREG_VCOUNT) + 2;

Re: [PATCH] a lockup in the mga driver

2014-03-13 Thread Dave Airlie
On Fri, Mar 14, 2014 at 8:25 AM, Mikulas Patocka mpato...@redhat.com wrote: Hi David Are you maintaining the Xorg mga driver? (you anounced the last update 1.6.3) Or is someone else maintaining it? Nobody maintains it really, the usermode driver is mostly ignored at this point, I try to look

[PATCH] ephyr: Deal with non-root visual for window

2014-03-13 Thread Keith Packard
glx will sometimes select a non-root visual, deal with that by creating a suitable colormap and using that instead of attempting to use the default colormap. Signed-off-by: Keith Packard kei...@keithp.com --- hw/kdrive/ephyr/hostx.c | 31 +-- 1 file changed, 21

Re: glamor performance regression

2014-03-13 Thread Michel Dänzer
On Don, 2014-03-13 at 10:43 -0700, Eric Anholt wrote: Michel Dänzer mic...@daenzer.net writes: On Mon, 2014-03-10 at 14:10 -0700, Keith Packard wrote: commit 25be6b384298a7769fedb6d9b5bdc370398c9c95 Author: Eric Anholt e...@anholt.net Date: Sun Jan 12 07:18:50 2014 +0800