Re: [PATCH 13/20] glamor: Add glamor_program based copy acceleration

2014-03-25 Thread Markus Wick
Am 2014-03-19 06:09, schrieb Keith Packard: +glamor_pixmap_loop(src_priv, src_box_x, src_box_y) { +glamor_pixmap_loop(dst_priv, dst_box_x, dst_box_y) { +for (b = 0; b nbox; b++) { Are you sure that this loop order is safe? Eg what happens, when we copy the

[PATCH xinit 2/3] startx: Under Linux start X on the current VT

2014-03-25 Thread Hans de Goede
When we let X allocate a new VT, systemd-logind will not recognize any processes running on this VT as belonging to a valid session (since there was no pam session opened on that tty). This causes problems like PolicyKit denials for these processes. ConsoleKit under Linux has been deprecated for

[PATCH xinit 1/3] Drop $RAWCPPFLAGS when generating startx

2014-03-25 Thread Hans de Goede
startx.cpp contains things like #if defined(__SCO__), and $RAWCPPFLAGS contains -undef causing these to not get set. Signed-off-by: Hans de Goede hdego...@redhat.com --- cpprules.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpprules.in b/cpprules.in index

[PATCH xinit 0/3] Various fixes from the Fedora packages

2014-03-25 Thread Hans de Goede
Hi All, Fedora has been carrying various xinit fixes which I believe would be good to have upstream. Hence this patch-set. Once these are merged I'll do a new 1.3.3 xinit release. Do we have any other open xinit issues which should get resolved before then ? Regards, Hans

Re: [PATCH xinit 2/3] startx: Under Linux start X on the current VT

2014-03-25 Thread Julien Cristau
On Tue, Mar 25, 2014 at 12:56:35 +0100, Hans de Goede wrote: When we let X allocate a new VT, systemd-logind will not recognize any processes running on this VT as belonging to a valid session (since there was no pam session opened on that tty). This causes problems like PolicyKit denials

Re: [PATCH xinit 3/3] Makefile.am: Give XINITDIR a default value

2014-03-25 Thread Julien Cristau
On Tue, Mar 25, 2014 at 12:56:36 +0100, Hans de Goede wrote: We are using XINITDIR, but never setting it. Lets give it a sane default. Signed-off-by: Hans de Goede hdego...@redhat.com --- Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile.am b/Makefile.am index

[PATCH] Set a flag property on the root window to say if the X server VT is active

2014-03-25 Thread Michael Thayer
An X11 client may need to know whether the X server virtual terminal is currently the active one. This change adds a root window property which provides that information. Intended interface user: the VirtualBox Guest Additions. Signed-off-by: Michael Thayer michael.tha...@oracle.com --- This is

[PATCH libxtrans v2] configure: Also add -D_DEFAULT_SOURCE to .pc cflags to shut up glibc warnings

2014-03-25 Thread Hans de Goede
The latest glibc considers _BSD_SOURCE deprecated, leading to the following warning being issued for pretty much every C-file in the xserver: In file included from /usr/include/stdint.h:25:0, from /usr/lib/gcc/x86_64-redhat-linux/4.8.2/include/stdint.h:9, from

[PATCH v2] fb: fix fast-path detection

2014-03-25 Thread Daniel Kurtz
The width parameter is used to disable the blit fast-path (memcpy) when source and destination rows overlap in memory. This check was added in [0]. Unfortunately, the calculation to determine if source and destination lines overlapped was incorrect: (1) it converts width from pixels to bytes,

Re: [PATCH 13/20] glamor: Add glamor_program based copy acceleration

2014-03-25 Thread Keith Packard
Markus Wick mar...@selfnet.de writes: Am 2014-03-19 06:09, schrieb Keith Packard: +glamor_pixmap_loop(src_priv, src_box_x, src_box_y) { +glamor_pixmap_loop(dst_priv, dst_box_x, dst_box_y) { +for (b = 0; b nbox; b++) { Are you sure that this loop order is

Re: [PATCH v2] fb: fix fast-path detection

2014-03-25 Thread Keith Packard
Daniel Kurtz djku...@chromium.org writes: Fix both of these by converting width from bits to FbBits, and let the pointer arithmetic convert to byte addresses. Ok, I'm doing a bit more careful review this morning, and I think the width parameter isn't quite right. (Note that we can ignore bpp

[PATCH xserver] suid: adding Xorg.sh.in to EXTRA_DIST is redundant

2014-03-25 Thread Gaetan Nadon
All files specified in AC_CONFIG_FILES get distributed automatically. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- hw/xfree86/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am index 18fa99b..ceb4c6a 100644

[PATCH xorg-docs] Fix typo in Release Notes.

2014-03-25 Thread Gaetan Nadon
Signed-off-by: Gaetan Nadon mems...@videotron.ca --- general/ReleaseNotes.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/general/ReleaseNotes.xml b/general/ReleaseNotes.xml index 8fd43ba..72fb644 100644 --- a/general/ReleaseNotes.xml +++ b/general/ReleaseNotes.xml @@

Re: [PATCH libxtrans v2] configure: Also add -D_DEFAULT_SOURCE to .pc cflags to shut up glibc warnings

2014-03-25 Thread Kristian Høgsberg
On Tue, Mar 25, 2014 at 7:16 AM, Hans de Goede hdego...@redhat.com wrote: The latest glibc considers _BSD_SOURCE deprecated, leading to the following warning being issued for pretty much every C-file in the xserver: In file included from /usr/include/stdint.h:25:0, from

Re: [PATCH] Handle -displayfd and an explicit display number sensibly

2014-03-25 Thread Kristian Høgsberg
On Tue, Mar 25, 2014 at 9:39 AM, Jon TURNEY jon.tur...@dronecode.org.uk wrote: On 24/03/2014 19:56, Kristian Høgsberg wrote: On Wed, Mar 19, 2014 at 7:26 AM, Jon TURNEY wrote: Handle -displayfd and an explicit display number sensibly, e.g. use the explicitly specified display number, and write

Re: [PATCH xorg-docs] Fix typo in Release Notes.

2014-03-25 Thread Alan Coopersmith
On 03/25/14 11:17 AM, Gaetan Nadon wrote: Signed-off-by: Gaetan Nadon mems...@videotron.ca --- general/ReleaseNotes.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/general/ReleaseNotes.xml b/general/ReleaseNotes.xml index 8fd43ba..72fb644 100644 ---

Re: Switching between a software and a hardware mouse cursor

2014-03-25 Thread Michael Thayer
On 18/03/14 11:17, Michael Thayer wrote: On 05/03/14 19:45, Adam Jackson wrote: On Thu, 2014-02-27 at 15:46 +0100, Michael Thayer wrote: Another would be to add a return value to the DDX CRTC functions load_cursor_argb, so that if the KMS driver failed to set the cursor, modesetting could

[PATCH 2/6] os: Always compile ListenOnOpenFD() and export it

2014-03-25 Thread Kristian Høgsberg
This function was written to allow the X server to inherit the listen socket from launchd on OS X. The code is not specific to OS X though and will be useful for on-demand launched Xwayland servers. Signed-off-by: Kristian Høgsberg k...@bitplanet.net Reviewed-by: Daniel Stone

[PATCH 4/6] os: Add AddClientOnOpenFD() to create a new client for an file descriptor

2014-03-25 Thread Kristian Høgsberg
When the Xwayland server is socket-activated, we need to connect and initialize the window manager before the activating client gets to proceed with connecting. We do this by passing a socket file descriptor for the window manager connection to the Xwayland server, which then uses this new

[PATCH 3/6] os: Add a mechanism to prevent creating any listen sockets

2014-03-25 Thread Kristian Høgsberg
A socket-activated server will receive its listening sockets from the parent process and should not create its own sockets. This patch introduces a NoListen flag that can be set by a DDX to prevent the server from creating the sockets. Signed-off-by: Kristian Høgsberg k...@bitplanet.net

[PATCH 1/6] .gitignore: Add new autotools file 'test-driver'

2014-03-25 Thread Kristian Høgsberg
Automake 1.12 introduces a new parallel test framework that uses a shell script helper and generates *.log and *.trs files. Add to .gitignore. Signed-off-by: Kristian Høgsberg k...@bitplanet.net Reviewed-by: Gaetan Nadon mems...@videotron.ca --- .gitignore | 1 + test/.gitignore | 2 ++ 2

Re: [PATCH libxtrans v2] configure: Also add -D_DEFAULT_SOURCE to .pc cflags to shut up glibc warnings

2014-03-25 Thread Mark Kettenis
From: Hans de Goede hdego...@redhat.com Date: Tue, 25 Mar 2014 15:16:57 +0100 I've discussed this with the glibc developers and the prefered way of fixing this is by also defining _DEFAULT_SOURCE which is the new way of stating _BSD_SOURCE / _SVID_SOURCE . Sounds like a reasonable

Re: [PULLv2] LoadExtension clean-up series

2014-03-25 Thread Keith Packard
Emil Velikov emil.l.veli...@gmail.com writes: Emil Velikov (5): miinitext: move AddStaticExtensions() to LoadExtension() miinitext: drop sentinel detection during LoadExtension miinitext: constify staticExtensions miinitext: avoid allocating a sentinel ExtensionModule

Re: [PULL] more xwayland prep work, restore XkbCopyDeviceKeymap

2014-03-25 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: Adam Jackson (1): xkb: Restore XkbCopyDeviceKeymap Kristian Høgsberg (4): test: Don't add TEST_LDADD to list test os: Always compile ListenOnOpenFD() and export it os: Add a mechanism to prevent creating any listen

Re: [PATCH xserver] suid: adding Xorg.sh.in to EXTRA_DIST is redundant

2014-03-25 Thread Peter Hutterer
On Tue, Mar 25, 2014 at 02:00:13PM -0400, Gaetan Nadon wrote: All files specified in AC_CONFIG_FILES get distributed automatically. Signed-off-by: Gaetan Nadon mems...@videotron.ca Merged all three, thanks. Cheers, Peter --- hw/xfree86/Makefile.am |2 +- 1 file changed, 1

Re: [PATCH 2/3] xf86LogInit: log to XDG_DATA_HOME when not running as root

2014-03-25 Thread Peter Hutterer
On Mon, Mar 24, 2014 at 04:32:00PM +0100, Hans de Goede wrote: When no logfile was specified (xf86LogFileFrom == X_DEFAULT) and we're not running as root log to $XDG_DATA_HOME/xorg/Xorg.#.log as Xorg won't be able to log to the default /var/log/... when it is not running as root.

Re: [PATCH 3/3] systemd-logind: Monitor systemd-logind going away

2014-03-25 Thread Peter Hutterer
On Mon, Mar 24, 2014 at 04:32:01PM +0100, Hans de Goede wrote: When we're using server managed-fds through systemd-logind, systemd-logind *must* keep running while we are using it, as it does things like drmSetMaster and drmDropMaster for us on vt-switch. On a systemd-logind restart, we

Re: [PATCH:xf86-input-mouse 1/4] Enable MSE_MISC on NetBSD as well.

2014-03-25 Thread Alan Coopersmith
On 08/19/13 02:14 AM, Thomas Klausner wrote: Otherwise we can't find WSMouse. From Matthew R. Green m...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org --- src/bsd_mouse.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/bsd_mouse.c b/src/bsd_mouse.c

Re: [PATCH:xf86-input-mouse 4/4] For wsmouse, keep 3-button emulation status.

2014-03-25 Thread Alan Coopersmith
On 08/19/13 02:14 AM, Thomas Klausner wrote: With a multiplexed device like wsmouse it does not make sense to kill emulate3buttons on the first button-3-pressed event. The button-3 pressed may belong to a mouse long gone and leave the internal (two button only) mousepad useless. From Martin