Re: [PATCH xserver 3/3] present: Call present_restore_screen_pixmap from present_set_abort_flip

Michel Dänzer writes: > From: Michel Dänzer > > After present_set_abort_flip, the screen pixmap will be used for all > screen drawing, so we need to restore the current flip pixmap contents > to the screen pixmap here as well. > > Improves flashing /

Re: [PATCH xserver 2/3] present: Factor code for restoring screen pixmap out of present_unflip

Michel Dänzer writes: > From: Michel Dänzer > > The following fix will use the refactored function. This isn't a simple refactor; the semantics of the new function are different from the replaced code. I'd love to see a separate patch which changed

Re: [PATCH xserver 1/3] present: Only update screen pixmap from flip pixmap once per unflip

Michel Dänzer writes: > From: Michel Dänzer > > present_unflip may be called several times from present_check_flip_window > during the same unflip. We can only copy to the screen pixmap the first > time, otherwise we may scribble over other windows.

Re: [PATCH xserver 2/3] present: Factor code for restoring screen pixmap out of present_unflip

Michel Dänzer writes: Here's another review, now that I've more carefully looked at the other two patches. > +if (!flip_window || !flip_pixmap) > +return; In the original code, this didn't abort the operation entirely... This operation would have been skipped:

Unplugging the main graphics device

Hello, I have been experimenting a bit with plugging and unplugging of graphics devices (using a dummy KMS driver which is udl stripped of the actual hardware poking) and how the X server copes with that. It seems to cope well with a secondary device being removed, but not with the only

Re: Which version x.org xserver got rid of ClockRanges?

On Tue, 16 Feb 2016 23:12:27 +0100 "Kevin Brace" wrote: > Hi Pekka, > > Can I include your name in the commit I will put into OpenChrome shortly? > It will look like this. > > Suggested-by: Pekka Paalanen <"Your e-mail"> > Signed-off-by: Kevin Brace >

Re: [PATCH xserver 3/3] present: Call present_restore_screen_pixmap from present_set_abort_flip

On Fri, Feb 19, 2016 at 11:39:12AM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > After present_set_abort_flip, the screen pixmap will be used for all > screen drawing, so we need to restore the current flip pixmap contents > to the screen pixmap here as well. > >

Re: [PATCH xserver 2/3] present: Factor code for restoring screen pixmap out of present_unflip

On Fri, Feb 19, 2016 at 11:39:11AM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > The following fix will use the refactored function. > > Signed-off-by: Michel Dänzer Reviewed-by: Chris Wilson -Chris -- Chris

Re: [PATCH xserver 1/3] present: Only update screen pixmap from flip pixmap once per unflip

On Fri, Feb 19, 2016 at 11:39:10AM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > present_unflip may be called several times from present_check_flip_window > during the same unflip. We can only copy to the screen pixmap the first > time, otherwise we may scribble

Re: [PATCH 1/2] xfree86: add pci id matching to OutputClass

On 18 February 2016 at 11:28, Aaron Plattner wrote: > On 02/08/2016 07:24 PM, Dave Airlie wrote: >> This will be used by drivers to denote PCI ids in the future >> instead of hardcoding them in the server. > > What benefit does this provide over MatchDriver? Is this to just

Re: [PATCH v3 0/9] PRIME Synchronization

On 12 February 2016 at 14:39, Alex Goins wrote: > Pinging in case this got buried. Is there any reason this only addresses one direction in the -modesetting driver. In theory shouldn't we able to expose both source and sink bits in -modesetting? (esp when glamor is enabled).

Re: [PATCH xserver 2/2] xwayland: Correctly detect whether posix_fallocate exists

On Fri, Feb 19, 2016 at 15:08:13 +0800, Jonas Ådahl wrote: > We had HAVE_POSIX_FALLOCATE checks, but no such macros were ever > defined anywhere. This commit makes it so that this macro is defined if > the posix_fallocate is detected during configure. > > Signed-off-by: Jonas Ådahl

Re: [PATCH] present: Cancel the copy on unflip when aborting a pending flip

On 19.11.2015 18:23, Michel Dänzer wrote: > On 16.02.2015 20:51, Chris Wilson wrote: >> If we handle a vblank notification and perform a copy whilst a flip is >> still pending, we mark the pending flip for abort. After marking the >> next flip completion for abortion, we then proceed to copy the