Re: [PATCH libX11 3/5] fix: warning: pointer targets in passing argument 2 of '_XSend' differ in signedness [-Wpointer-sign]

2016-04-26 Thread Alan Coopersmith
On 04/26/16 07:31 AM, walter harms wrote: fix signess warning by casting Signed-off-by: walter harms --- src/ModMap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ModMap.c b/src/ModMap.c index a809aa2..4263a8b 100644 --- a/src/ModMap.c +++

[PATCH synaptics] eventcomm: fix typo checking for two-finger scrolling

2016-04-26 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/eventcomm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/eventcomm.c b/src/eventcomm.c index 5f55141..9c9a036 100644 --- a/src/eventcomm.c +++ b/src/eventcomm.c @@ -710,7 +710,7 @@

[PATCH evdev] Prevent buffer overrun accessing btn_labels

2016-04-26 Thread Peter Hutterer
We go up to BTN_JOYSTICK, hence group can have a value of up to including 15. The actual btn_labels only has 6 elements though. Found by coverity. Signed-off-by: Peter Hutterer --- src/evdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/evdev.c

[PATCH xserver] xfree86: add support for MatchIsTabletPad

2016-04-26 Thread Peter Hutterer
The tablet pads have been separate kernel devices for a while now and libwacom has labelled them with the udev ID_INPUT_TABLET_PAD for over a year now. Add a new MatchIsTabletPad directive to apply configuration options specifically to the Pad part of a tablet. Signed-off-by: Peter Hutterer

[PATCH xf86-input-libinput] conf: rename to 60-libinput.conf

2016-04-26 Thread Peter Hutterer
60 sorts higher than the other drivers (evdev has 10, synaptics, wacom and others have 50) so we keep the same order. This is part of a two-step solution, the other half is renaming the xf86-input-wacom's config snippet to sort higher than libinput's. Currently libinput picks up devices that are

[PATCH libX11 4/5 V2] fix memleak in error path

2016-04-26 Thread walter harms
V2: remove unneeded NULL (reported by eric.engest...@imgtec.com) fix mem leak in error path Signed-off-by: walter harms --- src/xlibi18n/lcPublic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/xlibi18n/lcPublic.c b/src/xlibi18n/lcPublic.c index 98a7435..f35f17a

Re: [PATCH libX11 4/5] fix memleak in error path

2016-04-26 Thread walter harms
Am 26.04.2016 16:47, schrieb Eric Engestrom: > On Tue, Apr 26, 2016 at 04:29:41PM +0200, walter harms wrote: >> >> >> free all memory on error >> >> Signed-off-by: walter harms >> >> >> --- >> src/xlibi18n/lcPublic.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >>

Re: [xserver-xorg][PATCH 1/1] xwayland: ftruncate if posix_fallocate fails

2016-04-26 Thread Pekka Paalanen
On Tue, 26 Apr 2016 16:46:03 +0200 (CEST) Mark Kettenis wrote: > > Date: Tue, 26 Apr 2016 15:58:47 +0300 > > From: Ian Ray > > > > On Mon, Apr 25, 2016 at 04:49:07PM +0300, Pekka Paalanen wrote: > > > On Mon, 25 Apr 2016 15:47:09 +0300 > > > Ian Ray

Re: [xserver-xorg][PATCH 1/1] xwayland: ftruncate if posix_fallocate fails

2016-04-26 Thread Mark Kettenis
> Date: Tue, 26 Apr 2016 15:58:47 +0300 > From: Ian Ray > > On Mon, Apr 25, 2016 at 04:49:07PM +0300, Pekka Paalanen wrote: > > On Mon, 25 Apr 2016 15:47:09 +0300 > > Ian Ray wrote: > > > > > On a slow system that is configured with SMART_SCHEDULE_POSSIBLE,

Re: [PATCH] fix typo in supported sample sizes and maximum bit rate

2016-04-26 Thread Eric Engestrom
On Tue, Apr 26, 2016 at 09:00:42AM +0200, reinhard.zitzm...@gmail.com wrote: > From: Reinhard Zitzmann > > Signed-off-by: Reinhard Zitzmann > --- > edid-decode.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff

Re: [PATCH libX11 4/5] fix memleak in error path

2016-04-26 Thread Eric Engestrom
On Tue, Apr 26, 2016 at 04:29:41PM +0200, walter harms wrote: > > > free all memory on error > > Signed-off-by: walter harms > > > --- > src/xlibi18n/lcPublic.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/xlibi18n/lcPublic.c

[PATCH libX11 4/5] fix memleak in error path

2016-04-26 Thread walter harms
free all memory on error Signed-off-by: walter harms --- src/xlibi18n/lcPublic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/xlibi18n/lcPublic.c b/src/xlibi18n/lcPublic.c index 98a7435..08122b9 100644 --- a/src/xlibi18n/lcPublic.c +++

Re: [PATCH] Avoid 10x7 heuristic, handled by server

2016-04-26 Thread Stefan Dirsch
On Tue, Apr 26, 2016 at 03:49:12PM +0200, Julien Cristau wrote: > On Tue, Apr 26, 2016 at 14:09:24 +0200, Stefan Dirsch wrote: > > > On Tue, Apr 26, 2016 at 12:58:55PM +0200, Julien Cristau wrote: > > > On Tue, Apr 26, 2016 at 11:45:15 +0200, Stefan Dirsch wrote: > > > > > > > From: Frederic

[PATCH libX11 2/5] no need to check args for Xfree()

2016-04-26 Thread walter harms
simplify code Signed-off-by: walter harms --- src/xlibi18n/lcGeneric.c | 74 +--- 1 file changed, 33 insertions(+), 41 deletions(-) diff --git a/src/xlibi18n/lcGeneric.c b/src/xlibi18n/lcGeneric.c index 69090f7..9a599c5 100644 ---

[PATCH] Disable "acceleration" under qemu

2016-04-26 Thread Stefan Dirsch
Disable "acceleration" under qemu, since taking the hypercall trap is really quite expensive and you're better off doing noaccel. Patch is based on the one by "Adam Jackson"

[PATCH libX11 5/5] fix memleak in error path

2016-04-26 Thread walter harms
free all mem on error Signed-off-by: walter harms --- src/xlibi18n/lcGeneric.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/xlibi18n/lcGeneric.c b/src/xlibi18n/lcGeneric.c index 1c78a95..69090f7 100644 --- a/src/xlibi18n/lcGeneric.c +++ b/src/xlibi18n/lcGeneric.c @@

[PATCH libX11 3/5] fix: warning: pointer targets in passing argument 2 of '_XSend' differ in signedness [-Wpointer-sign]

2016-04-26 Thread walter harms
fix signess warning by casting Signed-off-by: walter harms --- src/ModMap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ModMap.c b/src/ModMap.c index a809aa2..4263a8b 100644 --- a/src/ModMap.c +++ b/src/ModMap.c @@ -39,7 +39,7 @@

[PATCH libX11 1/5] remove stray extern

2016-04-26 Thread walter harms
remove stray extern Signed-off-by: walter harms --- src/xkb/XKBExtDev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xkb/XKBExtDev.c b/src/xkb/XKBExtDev.c index b9710f8..d45460e 100644 --- a/src/xkb/XKBExtDev.c +++ b/src/xkb/XKBExtDev.c @@ -36,7 +36,7

Re: [PATCH] uxa: fix missing includes for fstat

2016-04-26 Thread Stefan Dirsch
On Tue, Apr 26, 2016 at 01:51:39PM +0100, Chris Wilson wrote: > On Tue, Apr 26, 2016 at 02:42:52PM +0200, Stefan Dirsch wrote: > > From: Dominique Leuenberger > > > > Without these headers, we can run into build errors like: > > sys/stat.h is already included. Curious. >

Re: [PATCH] Avoid 10x7 heuristic, handled by server

2016-04-26 Thread Julien Cristau
On Tue, Apr 26, 2016 at 14:09:24 +0200, Stefan Dirsch wrote: > On Tue, Apr 26, 2016 at 12:58:55PM +0200, Julien Cristau wrote: > > On Tue, Apr 26, 2016 at 11:45:15 +0200, Stefan Dirsch wrote: > > > > > From: Frederic Crozat > > > > > > Remove the 10x7 heuristic, since the

[PATCH] fix typo in supported sample sizes and maximum bit rate

2016-04-26 Thread reinhard . zitzmann
From: Reinhard Zitzmann Signed-off-by: Reinhard Zitzmann --- edid-decode.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/edid-decode.c b/edid-decode.c index 0b94ad5..62c732d 100644 --- a/edid-decode.c +++

Re: [xserver-xorg][PATCH 1/1] xwayland: ftruncate if posix_fallocate fails

2016-04-26 Thread Pekka Paalanen
On Tue, 26 Apr 2016 15:58:47 +0300 Ian Ray wrote: > On Mon, Apr 25, 2016 at 04:49:07PM +0300, Pekka Paalanen wrote: > > On Mon, 25 Apr 2016 15:47:09 +0300 > > Ian Ray wrote: > > > > > On a slow system that is configured with SMART_SCHEDULE_POSSIBLE, large > >

Re: [xserver-xorg][PATCH 1/1] xwayland: ftruncate if posix_fallocate fails

2016-04-26 Thread Ian Ray
On Mon, Apr 25, 2016 at 04:49:07PM +0300, Pekka Paalanen wrote: > On Mon, 25 Apr 2016 15:47:09 +0300 > Ian Ray wrote: > > > On a slow system that is configured with SMART_SCHEDULE_POSSIBLE, large > > posix_fallocate() requests may be interrupted by the SmartScheduleTimer > >

Re: [PATCH] uxa: fix missing includes for fstat

2016-04-26 Thread Chris Wilson
On Tue, Apr 26, 2016 at 02:42:52PM +0200, Stefan Dirsch wrote: > From: Dominique Leuenberger > > Without these headers, we can run into build errors like: sys/stat.h is already included. Curious. -Chris -- Chris Wilson, Intel Open Source Technology Centre

[PATCH] sna: fix missing includes for fstat

2016-04-26 Thread Stefan Dirsch
From: Dominique Leuenberger In order for fstat to be usable, sys/stat.h needs to be included or we might end up in a build failure like: sna_driver.c: In function 'sna_handle_uevents': sna_driver.c:799:6: error: implicit declaration of function 'fstat'

[PATCH] uxa: fix missing includes for fstat

2016-04-26 Thread Stefan Dirsch
From: Dominique Leuenberger Without these headers, we can run into build errors like: intel_driver.c: In function 'I830HandleUEvents': intel_driver.c:745:14: error: storage size of 's' isn't known intel_video.c:104:39: warning: initialization discards 'const' qualifier

Re: [xserver-xorg][PATCH 1/1] xwayland: ftruncate if posix_fallocate fails

2016-04-26 Thread Yuriy M. Kaminskiy
Ian Ray writes: > On a slow system that is configured with SMART_SCHEDULE_POSSIBLE, large > posix_fallocate() requests may be interrupted by the SmartScheduleTimer > (SIGALRM) continuously. Fallback to ftruncate if posix_fallocate fails. > > Signed-off-by: Ian Ray

Re: [PATCH] Avoid 10x7 heuristic, handled by server

2016-04-26 Thread Stefan Dirsch
On Tue, Apr 26, 2016 at 11:57:27AM +0200, Mark Kettenis wrote: > > From: Stefan Dirsch > > Date: Tue, 26 Apr 2016 11:45:15 +0200 > > > > From: Frederic Crozat > > > > Remove the 10x7 heuristic, since the server has equivalent code now. > > Instead, disable

Re: [PATCH libICE] Enable visibility annotations

2016-04-26 Thread Emil Velikov
On 26 April 2016 at 07:54, Yury Gribov wrote: > On 04/20/2016 10:03 AM, Yury Gribov wrote: >> >> On 04/19/2016 06:35 PM, Yury Gribov wrote: >>> >>> On 04/18/2016 06:21 PM, Adam Jackson wrote: On Mon, 2016-04-18 at 09:23 +0300, Yury Gribov wrote: > Does

Re: [PATCH] Avoid 10x7 heuristic, handled by server

2016-04-26 Thread Julien Cristau
On Tue, Apr 26, 2016 at 11:45:15 +0200, Stefan Dirsch wrote: > From: Frederic Crozat > > Remove the 10x7 heuristic, since the server has equivalent code now. > Instead, disable "acceleration" under qemu, since taking the hypercall > trap is really quite expensive and you're

Re: [PATCH] Avoid 10x7 heuristic, handled by server

2016-04-26 Thread Mark Kettenis
> From: Stefan Dirsch > Date: Tue, 26 Apr 2016 11:45:15 +0200 > > From: Frederic Crozat > > Remove the 10x7 heuristic, since the server has equivalent code now. > Instead, disable "acceleration" under qemu, since taking the hypercall > trap is really quite

Re: [PATCH] Use 16bpp when running in virt and on XenSource gfx

2016-04-26 Thread Mark Kettenis
> From: Stefan Dirsch > Date: Tue, 26 Apr 2016 11:45:38 +0200 > > From: Frederic Crozat > > Due to graphics corruption default to 16bpp in virt instead of 24 (Fedora). > Do the same on XenSource gfx, which suffers from the same issue. I think using magic

[PATCH] Use 16bpp when running in virt and on XenSource gfx

2016-04-26 Thread Stefan Dirsch
From: Frederic Crozat Due to graphics corruption default to 16bpp in virt instead of 24 (Fedora). Do the same on XenSource gfx, which suffers from the same issue. --- src/alp_driver.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

[PATCH] Avoid 10x7 heuristic, handled by server

2016-04-26 Thread Stefan Dirsch
From: Frederic Crozat Remove the 10x7 heuristic, since the server has equivalent code now. Instead, disable "acceleration" under qemu, since taking the hypercall trap is really quite expensive and you're better off doing noaccel. (Fedora) --- src/alp_driver.c | 7 +++ 1

Re: [PATCH libICE] Enable visibility annotations

2016-04-26 Thread Yury Gribov
On 04/20/2016 10:03 AM, Yury Gribov wrote: On 04/19/2016 06:35 PM, Yury Gribov wrote: On 04/18/2016 06:21 PM, Adam Jackson wrote: On Mon, 2016-04-18 at 09:23 +0300, Yury Gribov wrote: Does below look like a sane approach? 1) get all deps via $ apt-cache rdepends libice6 libice-dev 2)