Re: [PATCH xserver 5/9] Create a threaded mechanism for input [v5]

2016-05-12 Thread Keith Packard
Emil Velikov writes: > The commit summary does not mention anything, just the revision log > suggests "linux only". Worth adding a couple of words to clarify > things ? good point, I reworded the 'v2' comment to say: v2: Fix non-Xorg link. Enable where supported by

XDC 2016 : Call for paper

2016-05-12 Thread Martin Peres
Hello, I have the pleasure to announce that the X.org Developer Conference 2016 will be held in Helsinki from September 21 to September 23. The venue is located at Haaga-Helia university[0], next to the Pasila station. The official page for the event is http://www.x.org/wiki/Events/XDC2016

Re: [PATCH libICE] Bump the major version

2016-05-12 Thread Emil Velikov
On 12 May 2016 at 17:19, Julien Cristau wrote: > On Thu, May 12, 2016 at 14:27:48 +0100, Emil Velikov wrote: > >> With previous commits we've hidden a selection of internal symbols from >> the DSO. Neither of them has been part of the API, although let's do the >> sane thing

Re: [PATCH xserver 5/9] Create a threaded mechanism for input [v5]

2016-05-12 Thread Emil Velikov
On 12 May 2016 at 18:47, Keith Packard wrote: > Emil Velikov writes: > >> This will enable it on more platforms than just Linux. > > Right, the goal is to use it where available. > The commit summary does not mention anything, just the revision log

Re: [PATCH xserver] Use separate name for --with-bundle-version help variable

2016-05-12 Thread Keith Packard
Jeremy Huddleston Sequoia writes: > I actually already had a patch for that on my branch and just hadn't gotten > around to sending it, sorry: > > > https://github.com/XQuartz/xorg-server/commit/eb7c1e7fb16338d8fc03a0bb0f9bb53eb99ee139 > > I ended up just getting rid of

Re: [PATCH xserver] Use separate name for --with-bundle-version help variable

2016-05-12 Thread Jeremy Huddleston Sequoia
I actually already had a patch for that on my branch and just hadn't gotten around to sending it, sorry: https://github.com/XQuartz/xorg-server/commit/eb7c1e7fb16338d8fc03a0bb0f9bb53eb99ee139 I ended up just getting rid of the shell variable and only using the m4 variable. I don't think

[PATCH xserver v3 2/2] ranrd: Do not update ConnectionInfo if NULL

2016-05-12 Thread Olivier Fourdan
RRScreenSizeNotify() will update the connection information block, but if this occurs during initialization before ConnectionInfo is even initialized, this will lead to a crash. Simply check for ConnectionInfo prior to update it to avoid the crash. Bugzilla:

Re: [PATCH RESEND xserver v3] xfree86: Immediately handle failure to set HW cursor

2016-05-12 Thread Keith Packard
Alexandre Courbot writes: > Signed-off-by: Alexandre Courbot > Cc: Michael Thayer Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP signature

Re: [PATCH xserver 5/9] Create a threaded mechanism for input [v5]

2016-05-12 Thread Alan Coopersmith
On 05/12/16 10:47 AM, Keith Packard wrote: Emil Velikov writes: Then again I'm wondering if linking with pthread, won't lead to some noticeable perf degradation, as a fair few POSIX functions will now pthread_mutex_lock/unlock as opposed using the Glibc stub. The

Re: [PATCH v2 xserver 2/2] ranrd: Do not update ConnectionInfo if NULL

2016-05-12 Thread Adam Jackson
On Thu, 2016-05-12 at 19:05 +0200, Olivier Fourdan wrote: > diff --git a/randr/rrscreen.c b/randr/rrscreen.c > index d0ca91e..66efef5 100644 > --- a/randr/rrscreen.c > +++ b/randr/rrscreen.c > @@ -41,6 +41,9 @@ RREditConnectionInfo(ScreenPtr pScreen) >  int screen = 0; >  int d; >   > +   

Re: [PATCH xserver 5/9] Create a threaded mechanism for input [v5]

2016-05-12 Thread Keith Packard
Emil Velikov writes: > This will enable it on more platforms than just Linux. Right, the goal is to use it where available. > You can use AX_PTHREAD here, instead of open-coding it. Thanks. I've updated the series to do this; it's on my input-thread branch in

[PATCH xserver] Use separate name for --with-bundle-version help variable

2016-05-12 Thread Keith Packard
The help string for --with-bundle-version can't have any shell variable expansion, so it uses an m4 variable instead. Using the same name as the shell variable causes the configure script to end up with the expanded string (1.18.99\n) instead of the variable name (DEFAULT_BUNDLE_VERSION). Using

[PATCH v2 xserver 2/2] ranrd: Do not update ConnectionInfo if NULL

2016-05-12 Thread Olivier Fourdan
RRScreenSizeNotify() will update the connection information block, but if this occurs during initialization before ConnectionInfo is even initialized, this will lead to a crash. Simply check for ConnectionInfo prior to update it to avoid the crash. Bugzilla:

Re: [PATCH libICE] Bump the major version

2016-05-12 Thread Julien Cristau
On Thu, May 12, 2016 at 14:27:48 +0100, Emil Velikov wrote: > With previous commits we've hidden a selection of internal symbols from > the DSO. Neither of them has been part of the API, although let's do the > sane thing and bump the major, as we might have changed things in a > backward

Re: [PATCH xserver 2/2] ranrd: Do not update ConnectionInfo if NULL

2016-05-12 Thread Adam Jackson
On Thu, 2016-05-12 at 14:51 +0200, Olivier Fourdan wrote: > @@ -148,7 +148,8 @@ RRScreenSizeNotify(ScreenPtr pScreen) >   >  RRTellChanged(pScreen); >  RRSendConfigNotify(pScreen); > -RREditConnectionInfo(pScreen); > +if (ConnectionInfo) > +RREditConnectionInfo(pScreen); >

Re: [PATCH libICE] Bump the major version

2016-05-12 Thread Emil Velikov
On 12 May 2016 at 16:22, Adam Jackson wrote: > On Thu, 2016-05-12 at 14:27 +0100, Emil Velikov wrote: >> With previous commits we've hidden a selection of internal symbols from >> the DSO. Neither of them has been part of the API, although let's do the >> sane thing and bump the

Re: [PATCH RESEND xserver v3] xfree86: Immediately handle failure to set HW cursor

2016-05-12 Thread Adam Jackson
On Thu, 2016-05-12 at 16:04 +0900, Alexandre Courbot wrote: > There is currently no reliable way to report failure to set a HW > cursor. Still such failures can happen if e.g. the MODE_CURSOR DRM > ioctl fails (which currently happens at least with modesetting on Tegra > for format incompatibility

Re: [PATCH libICE] Bump the major version

2016-05-12 Thread Adam Jackson
On Thu, 2016-05-12 at 14:27 +0100, Emil Velikov wrote: > With previous commits we've hidden a selection of internal symbols from > the DSO. Neither of them has been part of the API, although let's do the > sane thing and bump the major, as we might have changed things in a > backward incompatible

[PATCH libICE] Bump the major version

2016-05-12 Thread Emil Velikov
With previous commits we've hidden a selection of internal symbols from the DSO. Neither of them has been part of the API, although let's do the sane thing and bump the major, as we might have changed things in a backward incompatible way. I.e. we might have unintentionally broken some

Re: [PATCH xserver 5/9] Create a threaded mechanism for input [v5]

2016-05-12 Thread Emil Velikov
On 11 May 2016 at 21:54, Keith Packard wrote: > The current SIGIO signal handler method, used at generation of input events, > has a bunch of oddities. This patch introduces an alternative way using a > thread, which is used to select() all input device file descriptors. > > A

Re: [PATCH xserver] dix: Remove pointless client-state callbacks

2016-05-12 Thread Emil Velikov
Hi Adam, On 18 April 2016 at 17:56, Adam Jackson wrote: > /* Reset extension. Called on server shutdown. */ > static void > GEResetProc(ExtensionEntry * extEntry) > { > -DeleteCallback(, GEClientCallback, 0); > EventSwapVector[GenericEvent] = NotImplemented; Can

Re: [PATCH libICE 1/7] Added visibility annotations.

2016-05-12 Thread Emil Velikov
On 9 May 2016 at 17:52, Adam Jackson wrote: > On Sun, 2016-05-08 at 09:19 +0100, Emil Velikov wrote: >> From: Yury Gribov >> >> This allow us to be good citizen by hiding the private symbols and >> reducing the overall size of the binary. >> >> Note:

Re: [PATCH libICE] Enable visibility annotations

2016-05-12 Thread Emil Velikov
On 10 May 2016 at 13:00, Yury Gribov wrote: > On 05/06/2016 07:25 PM, Alan Coopersmith wrote: >> >> On 05/ 6/16 04:18 AM, Yury Gribov wrote: >>> >>> Unfortunately I don't see any good approach. We could move definitions of >>> _X_EXPORT and friends to configure.ac but this

[PATCH xserver 1/2] xwayland: Restore wl_display_roundtrip() in InitInput

2016-05-12 Thread Olivier Fourdan
This partially revert commit 984be78 The rountrip in Xwayland's InitInput() is unlikely the culprit for the crash reported in bug 95337, even though it's triggered from InitInput(). Startup goes like this: xwl_screen_init() xwl_output_create() wl_display_roundtrip() InitInput()

[PATCH RFC xserver 0/2] Rework for for bug 95337

2016-05-12 Thread Olivier Fourdan
The patch I posted yesterday to fix bug 95337 which was pushed as commit 984be78 is probably incomplete or invalid, my bad, really sorry. I thought it was a somehow generic issue of calling wl_display_roundtrip() too early, but it really is not. It's actually RR code trying to modify the

[PATCH RESEND xserver v3] xfree86: Immediately handle failure to set HW cursor

2016-05-12 Thread Alexandre Courbot
There is currently no reliable way to report failure to set a HW cursor. Still such failures can happen if e.g. the MODE_CURSOR DRM ioctl fails (which currently happens at least with modesetting on Tegra for format incompatibility reasons). As failures are currently handled by setting the HW