Re: [PATCH xf86-input-mouse] Support input ABI version 23 and 24

Peter Hutterer writes: > yeah, but until the server bits are merged there is still a chance that the > patches change and I'd rather not have to worry about that. Sure, two patches sent to the list. I'd love to get review on the proposed server API changes for version

[PATCH xf86-input-mouse 1/2] Support ABI_XINPUT_VERSION 23 (use input_lock/input_unlock)

This makes using input_lock/input_unlock conditional on the ABI version so that we don't get compiler warnings when compiling with the newer server bits. Signed-off-by: Keith Packard --- src/mouse.c | 24 1 file changed, 24 insertions(+) diff --git

[PATCH xf86-input-mouse 2/2] Support ABI_XINPUT_VERSION 24 (remove LastSelectMask from block/wakeup)

The block and wakeup handler API is changing so that the FD_SET type isn't visible outside the OS layer anymore. The mouse driver didn't need that argument anyways, so the change is just to adjust the APIs to avoid compiler warnings. Signed-off-by: Keith Packard ---

Re: [PATCH xf86-input-mouse] Support input ABI version 23 and 24

On Mon, May 30, 2016 at 10:08:34PM -0700, Keith Packard wrote: > Peter Hutterer writes: > > > On Mon, May 30, 2016 at 01:42:20AM -0700, Keith Packard wrote: > >> Version 23 has threaded input, so locking uses input_lock/input_unlock > >> instead of

Re: [PATCH xf86-input-mouse] Support input ABI version 23 and 24

Peter Hutterer writes: > On Mon, May 30, 2016 at 01:42:20AM -0700, Keith Packard wrote: >> Version 23 has threaded input, so locking uses input_lock/input_unlock >> instead of xf86BlockSIGIO/xf86UnblockSIGIO. >> >> Version 24 removes the FD_SET arguments from block and

Re: [PATCH xserver v3] xwayland: Use the CLOCK_MONOTONIC clock

On Tue, May 24, 2016 at 06:46:42PM +0800, Jonas Ådahl wrote: > By default the X server will try CLOCK_MONOTONIC_COARSE before > CLOCK_MONOTONIC, while A Wayland compositor may only support getting > their timestamps from the CLOCK_MONOTONIC clock. This causes various > issues since it may happen

Re: [PATCH xf86-input-keyboard] Use xf86AddEnabledDevice with threaded input

On Mon, May 30, 2016 at 01:27:49AM -0700, Keith Packard wrote: > We couldn't use SIGIO input for keyboard processing, but we can use > threaded input. s/couldn't/didn't/ > > Signed-off-by: Keith Packard > --- > src/kbd.c | 16 +++- > 1 file changed, 15

Re: [PATCH xf86-input-mouse] Support input ABI version 23 and 24

On Mon, May 30, 2016 at 01:42:20AM -0700, Keith Packard wrote: > Version 23 has threaded input, so locking uses input_lock/input_unlock > instead of xf86BlockSIGIO/xf86UnblockSIGIO. > > Version 24 removes the FD_SET arguments from block and wakeup handlers this one isn't merged yet, please send

Re: [PATCH xserver 17/23] os: Add ospoll interface

Emil Velikov writes: > Amazing. On behalf of anyone who has to deal with the Windows side of > things - thank you. I'd love to see this working on Windows -- I think it could use either WSAPoll or select; neither of those depend on FD values at all. > Side note:

Re: [PATCH xserver 17/23] os: Add ospoll interface

On 30 May 2016 at 08:47, Keith Packard wrote: > Julien Cristau writes: > >>> #define X_NOTIFY_READ POLLIN >>> #define X_NOTIFY_WRITE POLLOUT >>> #define X_NOTIFY_OTHER (!(POLLIN|POLLOUT)) >>> >> I guess you mean ~(POLLIN|POLLOUT). > > Yes, thanks. I've

Re: [PATCH xf86-input-libinput] Switch to xf86AddEnabledDevice if we have the input thread

On Mon, May 30, 2016 at 12:09:34PM +0200, Julien Cristau wrote: > On Mon, May 30, 2016 at 18:12:36 +1000, Peter Hutterer wrote: > > > Pre input-thread xf86AddEnabledDevice was hooked up to the signal handler. > > libinput never was capable of running inside a signal handler, so we had to > > use

Re: [PATCH xserver 1/2] xwayland: Move sprite invalidation logic into mipointer

On 29 May 2016 at 19:45, Keith Packard wrote: > Emil Velikov writes: > >> - Seems like the exports from mi/ are remnants from the separate >> (non-builtin) extmod days. >> >> Not 100% sure though. Can anyone please shed some light ? > > _X_EXPORT is

Re: [PATCH xf86-input-libinput] Switch to xf86AddEnabledDevice if we have the input thread

On Mon, May 30, 2016 at 18:12:36 +1000, Peter Hutterer wrote: > Pre input-thread xf86AddEnabledDevice was hooked up to the signal handler. > libinput never was capable of running inside a signal handler, so we had to > use AddEnabledDevice() instead which merely hooks to the server's select loop.

Re: [PATCH app/sessreg] Use off_t instead of long to make largefile support work

Hi Egbert you defintely have my Reviewed-by: Stefan Dirsch But could you still fix the typo in the changelog (relace -> replace) and mention the bugreport https://bugzilla.opensuse.org/show_bug.cgi?id=981522 as reference? And also add that the issue has been reproduced

[PULL xserver] Reviewed fixes and xf86_reload_cursors removal

Hi Keith / Adam, The following changes since commit 28b2c880a9dbfd91e82397a0f22482d258a8b670: xfree86: Provide xf86BlockSIGIO and xf86ReleaseSIGIO as wrappers for input mutex (2016-05-30 00:17:34 -0700) are available in the git repository at:

Re: [PATCH xserver] dix: Don't update current time in the middle of input event processing

Michel Dänzer writes: > Tested-by: Michel Dänzer > > Thank you for restoring sanity to my GNOME session! Just don't ask how long it took to discover where the problem was... -- -keith signature.asc Description: PGP signature

Re: [PATCH libXfont 4/4] fstrans: Remove unused foo() function

Jeremy Huddleston Sequoia writes: > The point of it seems to have been to silence an unused function warning, but > there's no point if we're just transitioning that to another unused function > warning. Sigh. It worked once for me. Reviewed-by: Keith Packard

Re: [PATCH xf86-input-libinput] Switch to xf86AddEnabledDevice if we have the input thread

Peter Hutterer writes: > Pre input-thread xf86AddEnabledDevice was hooked up to the signal handler. > libinput never was capable of running inside a signal handler, so we had to > use AddEnabledDevice() instead which merely hooks to the server's select loop. > > Now

[PATCH xf86-input-mouse] Support input ABI version 23 and 24

Version 23 has threaded input, so locking uses input_lock/input_unlock instead of xf86BlockSIGIO/xf86UnblockSIGIO. Version 24 removes the FD_SET arguments from block and wakeup handlers Signed-off-by: Keith Packard --- src/mouse.c | 45

Re: [PATCH xf86-input-libinput] Use xf86AddEnabledDevice instead of AddEnabledDevice when threaded [v3]

On Mon, May 30, 2016 at 01:13:41AM -0700, Keith Packard wrote: > libinput can't run at SIGIO time, so it has been using > AddEnabledDevice to run in non-signal context. > > Threaded input runs all input in non-signal context, so we want to use > xf86AddEnabledDevice at last. > > v2: use XINPUT

Re: [PATCH xserver] dix: Don't update current time in the middle of input event processing

On 28.05.2016 09:49, Keith Packard wrote: > In patch 137ac094e7ab8c871f3b36e40ad826ac797f0e26, Adam moved an > expensive call to UpdateCurrentTime out of the main dispatch > loop. That's a good change as the original fix from Chase was a bit > expensive. However, it breaks grab processing and so a

[PATCH xf86-input-keyboard] Use xf86AddEnabledDevice with threaded input

We couldn't use SIGIO input for keyboard processing, but we can use threaded input. Signed-off-by: Keith Packard --- src/kbd.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/kbd.c b/src/kbd.c index e378dcc..3063d27 100644 ---

[PATCH xf86-input-libinput] Use xf86AddEnabledDevice instead of AddEnabledDevice when threaded [v3]

libinput can't run at SIGIO time, so it has been using AddEnabledDevice to run in non-signal context. Threaded input runs all input in non-signal context, so we want to use xf86AddEnabledDevice at last. v2: use XINPUT ABI version check instead of testing for presence of AddEnabledDevice,

[PATCH xf86-input-libinput] Switch to xf86AddEnabledDevice if we have the input thread

Pre input-thread xf86AddEnabledDevice was hooked up to the signal handler. libinput never was capable of running inside a signal handler, so we had to use AddEnabledDevice() instead which merely hooks to the server's select loop. Now with the input thread we can use xf86AddEnabledDevice and let

[PATCH libXfont 3/4] fserve: Silence a -Wformat warning

src/fc/fserve.c:653:32: warning: format specifies type 'int' but the argument has type 'CARD32' (aka 'unsigned long') [-Wformat] " from font server\n", rep->length); ^~~ 1 warning generated. Signed-off-by: Jeremy Huddleston Sequoia

[PATCH libXfont 4/4] fstrans: Remove unused foo() function

The point of it seems to have been to silence an unused function warning, but there's no point if we're just transitioning that to another unused function warning. src/fc/fstrans.c:32:20: warning: unused function 'foo' [-Wunused-function] static inline void foo(void) { (void) is_numeric("a"); }

[PATCH libXfont 2/4] bitmap: Bail out on invalid input to FontFileMakeDir instead of calling calloc for 0 bytes

Found by clang static analysis: Call to 'calloc' has an allocation size of 0 bytes Signed-off-by: Jeremy Huddleston Sequoia --- src/bitmap/bitscale.c | 4 1 file changed, 4 insertions(+) diff --git a/src/bitmap/bitscale.c b/src/bitmap/bitscale.c index

[PATCH libXfont 1/4] FreeType: Correct an allocation size

Found by clang static analysis: Result of 'calloc' is converted to a pointer of type 'int', which is incompatible with sizeof operand type 'int *' This is likely benign because the old size was larger on any platform where sizeof(int) <= sizeof(void *), which is everywhere.

[PATCH libXfont 1/1] fserve: Fix a buffer read overrun in _fs_client_access

https://bugs.freedesktop.org/show_bug.cgi?id=83224 Found by clang's Address Sanitizer crac.num_auths = set_font_authorizations(, , client); /* Work around bug in xfs versions up through modular release 1.0.8 which

[PATCH xf86-input-libinput] Use xf86AddEnabledDevice instead of AddEnabledDevice when threaded [v2]

libinput can't run at SIGIO time, so it has been using AddEnabledDevice to run in non-signal context. Threaded input runs all input in non-signal context, so we want to use xf86AddEnabledDevice at last. v2: use XINPUT ABI version check instead of testing for presence of AddEnabledDevice,

Re: [PATCH xserver 1/2] xwayland: use the lowercase xnf.*alloc API

Hi Emil, On 29 May 2016 at 12:16, Emil Velikov wrote: > Can anyone ack/nack this and patch 2/2 ? While at it, could you please also add the XNFreallocarray() I added in the meantime in xwayland-glamor-xv.c to your patch for xwayland? Meanwhile for 1/2 and 2/2 in

Re: [PATCH xserver 17/23] os: Add ospoll interface

Julien Cristau writes: >> #define X_NOTIFY_READ POLLIN >> #define X_NOTIFY_WRITE POLLOUT >> #define X_NOTIFY_OTHER (!(POLLIN|POLLOUT)) >> > I guess you mean ~(POLLIN|POLLOUT). Yes, thanks. I've actually reconsidered and decided to make an interface which doesn't use

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

Michel Dänzer writes: > [ Unknown signature status ] > On 30.05.2016 12:29, Keith Packard wrote: >> Michel Dänzer writes: >> >>> Let's take things one step at a time, get my patch in as is (which >>> brings us back to where we were before using copies

Re: [PATCH xserver] dix: Remove bogus input_mutex and input_mutex_count definitions from globals.c

Peter Hutterer writes: > did you need the __thread for the one in os/inputthread.c? Nope, it's only modified under the lock. > Reviewed-by: Peter Hutterer otherwise Thanks. -- -keith signature.asc Description: PGP signature

Re: [PATCH xserver 17/23] os: Add ospoll interface

On Sun, May 29, 2016 at 11:35:16 -0700, Keith Packard wrote: > Emil Velikov writes: > > > There's two things which I should have mentioned: > > - How does one have poll.h when poll() is missing - Cygwin may have > > the header, although I'm not sure about other