Re: [PATCH 0/3 all repositories] autogen.sh: sync with server

2017-01-24 Thread Emil Velikov
On 25 January 2017 at 02:26, Michel Dänzer wrote: > On 24/01/17 11:32 PM, Adam Jackson wrote: >> On Tue, 2017-01-24 at 10:40 +1000, Peter Hutterer wrote: >>> Heads up: I'll be pushing the following three patches into all xorg >>> repositories that need it in the next few days.

Re: [PATCH 0/3 all repositories] autogen.sh: sync with server

2017-01-24 Thread Michel Dänzer
On 24/01/17 11:32 PM, Adam Jackson wrote: > On Tue, 2017-01-24 at 10:40 +1000, Peter Hutterer wrote: >> Heads up: I'll be pushing the following three patches into all xorg >> repositories that need it in the next few days. Speak up now or be >> forever silent, etc. etc. > > Convention so far has

Re: [PATCH xserver 00/19] Module loader cleanup

2017-01-24 Thread Emil Velikov
On 23 January 2017 at 19:32, Adam Jackson wrote: > I'd like to move the module loader up to dix. In preparation for that, here's > a bunch of cleanup patches. The first three aren't mine, I just think they're > neat. > s/three/four/ and thank you. I'll try to re-spin my

Re: [PATCH xserver 11/19] xfree86: Remove DriverRec1 compat struct

2017-01-24 Thread Emil Velikov
On 23 January 2017 at 19:32, Adam Jackson wrote: > The idea here is that the driver might have once been old enough to not > have the driverFunc slot in DriverRec, with the module ABI not having > changed when it was added. That was ages ago, and drivers always declare >

Re: [PATCH xserver 10/19] loader: Remove silly "unspecified" version handling

2017-01-24 Thread Emil Velikov
On 23 January 2017 at 19:32, Adam Jackson wrote: > Nobody who is using this functionality is ever not specifying a major > version, which makes sense. If you don't care about a minor version, > that's equivalent to saying you require minor >= 0, so just say so; > likewise patch

Re: [PATCH v2 xserver] glamor: Two pass won't work on memory pixmaps

2017-01-24 Thread Eric Anholt
Olivier Fourdan writes: > When selecting "CA_TWO_PASS" in glamor_composite_clipped_region() when > the hardware does not support "GL_ARB_blend_func_extended", we call > glamor_composite_choose_shader() twice in a row, which in turn calls > glamor_pixmap_ensure_fbo(). > > On

Re: [PATCH xserver 4/4] glx: Move Composite's synthetic visuals to a different select group

2017-01-24 Thread Eric Anholt
Adam Jackson writes: > Should you find yourself using a 16bpp display while also using a > compositor, you poor soul, you may find that your GLX applications > behave strangely; in particular, glxgears will be transparent. This is > because it clears to (0,0,0,0) which is

[PATCH v2 xserver] glamor: Two pass won't work on memory pixmaps

2017-01-24 Thread Olivier Fourdan
When selecting "CA_TWO_PASS" in glamor_composite_clipped_region() when the hardware does not support "GL_ARB_blend_func_extended", we call glamor_composite_choose_shader() twice in a row, which in turn calls glamor_pixmap_ensure_fbo(). On memory pixmaps, the first call will set the FBO and the

Re: [PATCH xserver] glamor: keep gl_fbo and fbo consistent

2017-01-24 Thread Olivier Fourdan
> There is a fundamental logical problem with this patch though, because > glamor_upload_picture_to_texture() does: > > assert(glamor_pixmap_is_memory(pixmap)); > > which is basically priv->type == GLAMOR_MEMORY; > > So glamor_upload_picture_to_texture() clearly expects a pixmap of type >

Re: [PATCH] libXinerama: Set number to 0 on error.

2017-01-24 Thread Adam Jackson
On Mon, 2017-01-23 at 19:00 +0100, Tobias Stoeckmann wrote: > On Mon, Jan 23, 2017 at 11:52:13AM -0500, Adam Jackson wrote: > > Not that any caller has likely made this mistake, but you want an > > if > > (number) before this, otherwise you turn a protocol error into a > > segfault. > > If a

Re: [PATCH 0/3 all repositories] autogen.sh: sync with server

2017-01-24 Thread Adam Jackson
On Tue, 2017-01-24 at 10:40 +1000, Peter Hutterer wrote: > Heads up: I'll be pushing the following three patches into all xorg > repositories that need it in the next few days. Speak up now or be > forever silent, etc. etc. Convention so far has been to strip xf86-{video,input}- from the driver

Re: libx11: Issues with Data32/_XData32

2017-01-24 Thread walter harms
Am 24.01.2017 09:18, schrieb Julien Cristau: > On Tue, Jan 24, 2017 at 01:12:23 +, James Clarke wrote: > >> Hi, >> I've been debugging an issue in gtk2-perl causing it to SIGBUS on >> sparc64, and traced it back to what seems to be dodgy code inside >> libx11. One of the tests calls

Re: [PATCH xserver] glamor: keep gl_fbo and fbo consistent

2017-01-24 Thread Olivier Fourdan
Hi > If the pixmap type is neither GLAMOR_TEXTURE_ONLY nor GLAMOR_TEXTURE_DRM > we might have the fbo field set but the gl_fbo still set to the default > GLAMOR_FBO_UNATTACHED, which later may fail an assert in > glamor_upload_picture_to_texture(). > > Bugzilla:

Re: libx11: Issues with Data32/_XData32

2017-01-24 Thread Julien Cristau
On Tue, Jan 24, 2017 at 01:12:23 +, James Clarke wrote: > Hi, > I've been debugging an issue in gtk2-perl causing it to SIGBUS on > sparc64, and traced it back to what seems to be dodgy code inside > libx11. One of the tests calls gdk_window_set_opacity, which calls > XChangeProperty with a