[PATCH xserver] ramdac: Check ScreenPriv != NULL in xf86ScreenSetCursor()

2017-10-24 Thread Alex Goins
Similar to change cba5a10f, xf86ScreenSetCursor() would dereference ScreenPriv without NULL checking it. If Option "SWCursor" is specified, ScreenPriv == NULL. Without this fix, it is observed that setting Option "SWCursor" "on" on the modesetting driver in a PRIME configuration will segfault the

Re: [PATCH xserver] meson: Use [ true, false, auto ] for tristate values

2017-10-24 Thread Peter Hutterer
On Tue, Oct 24, 2017 at 01:03:09PM -0400, Adam Jackson wrote: > For symmetry with the boolean options. I really do not want to care > whether an option is a tristate if I'm trying to set it explicitly. > > Signed-off-by: Adam Jackson Reviewed-by: Peter Hutterer

Re: [PATCH app/bdftopcf] Import libXfont's BDF-to-PCF code

2017-10-24 Thread Adam Jackson
On Tue, 2017-10-24 at 20:45 +0200, Julien Cristau wrote: > On Tue, Oct 24, 2017 at 13:54:47 -0400, Adam Jackson wrote: > > > bdftopcf is the only consumer of libXfont 1.x's read/write support, and > > we'd like 1.x to go away entirely. Copy in the BDF read and PCF write > > support so there's one

Re: [PATCH xserver 1/2] dix: Don't vary the ClientRec ABI at build time

2017-10-24 Thread Julien Cristau
On Tue, Oct 24, 2017 at 14:38:12 -0400, Adam Jackson wrote: > Just no. > > Signed-off-by: Adam Jackson > --- > include/dixstruct.h | 2 -- > 1 file changed, 2 deletions(-) > for the series: Reviewed-by: Julien Cristau Cheers, Julien

Re: [PATCH app/bdftopcf] Import libXfont's BDF-to-PCF code

2017-10-24 Thread Julien Cristau
On Tue, Oct 24, 2017 at 13:54:47 -0400, Adam Jackson wrote: > bdftopcf is the only consumer of libXfont 1.x's read/write support, and > we'd like 1.x to go away entirely. Copy in the BDF read and PCF write > support so there's one fewer consumer of 1.x. > > Signed-off-by: Adam Jackson

[PATCH xserver 1/2] dix: Don't vary the ClientRec ABI at build time

2017-10-24 Thread Adam Jackson
Just no. Signed-off-by: Adam Jackson --- include/dixstruct.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/dixstruct.h b/include/dixstruct.h index 70f87959e..28bff66f8 100644 --- a/include/dixstruct.h +++ b/include/dixstruct.h @@ -111,9 +111,7 @@ typedef struct

[PATCH xserver 2/2] dix: Don't track the XKB client versions in the ClientRec

2017-10-24 Thread Adam Jackson
XKB stores some stuff in the ClientRec that, style-wise, should probably be in a client private. vMinor tracks the client's idea of the XKB minor version, but is never read, we can just nuke it. vMajor is only used for a bug-compat workaround for X11R6.0-vintage clients. We're only using though

[PATCH xserver] xres: Return the atom naming the type, not its internal type number

2017-10-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- Xext/xres.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/Xext/xres.c b/Xext/xres.c index 02421588a..7a7aabc9b 100644 --- a/Xext/xres.c +++ b/Xext/xres.c @@ -274,6 +274,24 @@

[PATCH xserver 2/3] glamor: Unconditionalize GLAMOR_PIXMAP_DYNAMIC_UPLOAD

2017-10-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- glamor/glamor_priv.h | 8 glamor/glamor_render.c | 14 +- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/glamor/glamor_priv.h b/glamor/glamor_priv.h index b828350cd..5da400a37 100644 ---

[PATCH xserver 3/3] glamor: Unconditionalize GLAMOR_TEXTURED_LARGE_PIXMAP

2017-10-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- glamor/glamor.c | 4 +--- glamor/glamor_priv.h | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/glamor/glamor.c b/glamor/glamor.c index c55ba249e..b70759b65 100644 --- a/glamor/glamor.c +++ b/glamor/glamor.c @@ -183,9

[PATCH app/bdftopcf] Import libXfont's BDF-to-PCF code

2017-10-24 Thread Adam Jackson
bdftopcf is the only consumer of libXfont 1.x's read/write support, and we'd like 1.x to go away entirely. Copy in the BDF read and PCF write support so there's one fewer consumer of 1.x. Signed-off-by: Adam Jackson --- Makefile.am | 21 +- atom.c | 250 +++

Re: [PATCH xserver] configure.ac: unconditionally enable kdrive

2017-10-24 Thread Matt Turner
Reviewed-by: Matt Turner ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver] meson: Use [ true, false, auto ] for tristate values

2017-10-24 Thread Adam Jackson
For symmetry with the boolean options. I really do not want to care whether an option is a tristate if I'm trying to set it explicitly. Signed-off-by: Adam Jackson --- meson.build | 42 +- meson_options.txt | 28

Re: [Mesa-dev] XDC 2017 feedback

2017-10-24 Thread Andres Gomez
Hi, Just chipping in to leave a couple of additional notes. As other have said before me, I also think the organization was very good. Things mentioned before: * Tables layout: kind of agree it was not great for following the talks but they were also making it easier to talk with other

Re: [PATCH xserver] meson: Don't use '' in link_with, ever

2017-10-24 Thread Adam Jackson
On Tue, 2017-10-24 at 12:19 +0100, Jon Turney wrote: > On 23/10/2017 21:21, Lyude Paul wrote: > > > Signed-off-by: Lyude Paul > > Reviewed-by: Jon Turney remote: I: patch #184369 updated using rev 4d53e30651c0fe5f7be38ae8529fa49846d39549.

Re: [PATCH xserver] travis: Fix OSX build

2017-10-24 Thread Adam Jackson
On Tue, 2017-10-24 at 12:07 +0100, Jon Turney wrote: > Turn off homebrew autoupdating before installing ccache, to avoid: > > /usr/local/Homebrew/Library/Homebrew/brew.rb:12:in `': Homebrew must > be run under Ruby 2.3! You're running 2.0.0. (RuntimeError) > > Signed-off-by: Jon Turney

Re: [PATCH xserver] meson: Don't use '' in link_with, ever

2017-10-24 Thread Jon Turney
On 23/10/2017 21:21, Lyude Paul wrote: String arguments as elements in the array passed to the link_with argument in meson's executable() functions are not valid and will end up causing the build file generation to file. This actually ended up exposing a bug in meson that caused it not to report

[PATCH xserver] travis: Fix OSX build

2017-10-24 Thread Jon Turney
Turn off homebrew autoupdating before installing ccache, to avoid: /usr/local/Homebrew/Library/Homebrew/brew.rb:12:in `': Homebrew must be run under Ruby 2.3! You're running 2.0.0. (RuntimeError) Signed-off-by: Jon Turney --- .travis.yml | 2 +- 1 file changed, 1

Re: [PATCH] modesetting: fail PreInit() if the device has zero connectors

2017-10-24 Thread Tobias Jakobi
Hello Hans, Hans de Goede wrote: > Hi, > > On 20-10-17 19:08, tobias.jako...@uni-bielefeld.de wrote: >> On laptop systems with a dedicated (powerful) GPU A, you usually >> have all connectors routed to another (less-powerful) GPU B. >> >> With my setup (GPU A = Nvidia, GPU B = Intel) I keep GPU