Re: [PATCH xserver v2] xfree86: Refine drm modes on continuous freq panel

2020-04-14 Thread Dave Airlie
Any chance we could get this in a gitlab merge request? Dave. On Tue, 14 Apr 2020 at 19:28, Aaron Ma wrote: > > EDID1.4 replaced GTF Bit with Continuous or Non-Continuous Frequency Display. > > Check the "Display Range Limits Descriptor" for GTF support. > If panel doesn't support GTF, then add

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-29 Thread Dave Airlie
On Sat, 29 Feb 2020 at 05:34, Eric Anholt wrote: > > On Fri, Feb 28, 2020 at 12:48 AM Dave Airlie wrote: > > > > On Fri, 28 Feb 2020 at 18:18, Daniel Stone wrote: > > > > > > On Fri, 28 Feb 2020 at 03:38, Dave Airlie wrote: > > > > b)

Re: [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Dave Airlie
On Fri, 28 Feb 2020 at 18:18, Daniel Stone wrote: > > On Fri, 28 Feb 2020 at 03:38, Dave Airlie wrote: > > b) we probably need to take a large step back here. > > > > Look at this from a sponsor POV, why would I give X.org/fd.o > > sponsorship money that they are

Re: [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Dave Airlie
On Fri, 28 Feb 2020 at 07:27, Daniel Vetter wrote: > > Hi all, > > You might have read the short take in the X.org board meeting minutes > already, here's the long version. > > The good news: gitlab.fd.o has become very popular with our > communities, and is used extensively. This especially

Re: [PATCH] result parameter for ScreenWakeupHandlerProcPtr should be unsigned long

2019-01-03 Thread Dave Airlie
On Fri, 14 Dec 2018 at 06:47, Kevin Brace wrote: > > The result parameter defined inside scrnintstr.h for > ScreenWakeupHandlerProcPtr should be unsigned long type not int type. > This led to wrong pointer type compilation warnings when compiling S3 > Savage DDX Version 2.3.9 for

Re: [PATCH xf86-video-v4l 1/4] Remove unused variable osname

2018-10-07 Thread Dave Airlie
yay, for all 4. Reviewed-by: Dave Airlie On Mon, 8 Oct 2018 at 13:20, Peter Hutterer wrote: > > Coverity is unhappy and there's enough unhappiness in this world already, so > let's go for the low-hanging fruit. > > Signed-off-by: Peter Hutterer > --- > src/v4l.c | 1 -

Re: [PATCH] devices: break after finding and removing device from lists

2018-09-12 Thread Dave Airlie
On Wed, 12 Sep 2018 at 23:39, Walter Harms wrote: > > > > > Dave Airlie hat am 12. September 2018 um 03:40 > > geschrieben: > > > > > > From: Dave Airlie > > > > Coverity complains about a use after free in here after the > > freeing,

[PATCH] devices: break after finding and removing device from lists

2018-09-11 Thread Dave Airlie
From: Dave Airlie Coverity complains about a use after free in here after the freeing, I can't follow the linked list so well, but whot says the device can only be on one list once, so break should fix it. Signed-off-by: Dave Airlie --- dix/devices.c | 2 ++ 1 file changed, 2 insertions

Re: [PATCH xserver v8 05/14] modesetting: Use atomic modesetting API for pageflip if available

2018-09-11 Thread Dave Airlie
On Wed, 28 Feb 2018 at 11:21, Daniel Stone wrote: > > From: Louis-Francis Ratté-Boulianne > > In order to flip between compressed and uncompressed buffers - > something drmModePageFlip explicitly bans us from doing - we need > to port use the atomic modesetting API. It's only 'fake' atomic >

Re: [PATCH xserver v2 2/2] randr: Scream when creating a shared pixmap fails

2018-06-20 Thread Dave Airlie
On 21 June 2018 at 09:12, Lyude Paul wrote: > This seems like a problem worth screaming about. > > Signed-off-by: Lyude Paul For the series: Reviewed-by: Dave Airlie > --- > randr/rrcrtc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/randr/rrcrtc.c

Re: [PATCH xserver] modesetting: Also disable CRTC in drmmode_output_disable()

2018-06-14 Thread Dave Airlie
plays connected to it > - Remove the hub > - Now there should be CRTCs stuck on the orphaned MST connectors, and X > won't be able to reclaim them. > > Signed-off-by: Lyude Paul > Cc: Louis-Francis Ratté-Boulianne Reviewed-by: Dave Airlie > --- > hw/xfree86/drivers

[PATCH] xwayland: fix typo in non-modifier fallback path

2018-05-28 Thread Dave Airlie
From: Dave Airlie Pointed out on irc by q66. --- hw/xwayland/xwayland-glamor-gbm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xwayland/xwayland-glamor-gbm.c b/hw/xwayland/xwayland-glamor-gbm.c index 29325adac..68c2cc32e 100644 --- a/hw/xwayland/xwayland-glamor-gbm.c

Re: glamor_init: clamp GLSL to 120 if platform doesn't have instanced arrays

2018-05-15 Thread Dave Airlie
On 16 May 2018 at 05:51, Lukas F. Hartmann wrote: > Hi, > > I upgraded Xwayland and the assorted libraries from git masters today, > and noticed that glamor wouldn't work anymore on i.MX6/etnaviv. The > error was: > > No provider of glVertexAttribDivisor found. Requires one of:

Re: [PATCH xf86-video-vesa 2/4] Fall back to VGA if the palette API isn't supported

2018-01-31 Thread Dave Airlie
l > will be NULL, so use that as the hint to fall back to VGA banging. > > Signed-off-by: Adam Jackson <a...@redhat.com> I can confirm I dug in seabios as well. Reviewed-by: Dave Airlie <airl...@redhat.com> > --- > src/vesa.c | 21 + > 1 file changed

Re: [PATCH xserver 0/6] Signal handling cleanups

2017-12-06 Thread Dave Airlie
t; do: These look like a good idea, Reviewed-by: Dave Airlie <airl...@redhat.com> > > hw/kdrive/src/kdrive.c | 14 > hw/xfree86/common/xf86.h | 4 --- > hw/xfree86/common/xf86Events.c | 38 &g

Re: [PATCH] modesetting: fail PreInit() if the device has zero connectors

2017-11-01 Thread Dave Airlie
On 24 October 2017 at 02:42, Tobias Jakobi wrote: > Hello Hans, > > > Hans de Goede wrote: >> Hi, >> >> On 20-10-17 19:08, tobias.jako...@uni-bielefeld.de wrote: >>> On laptop systems with a dedicated (powerful) GPU A, you usually >>> have all connectors routed to

Re: [PATCH] modesetting: fail PreInit() if the device has zero connectors

2017-11-01 Thread Dave Airlie
On 21 October 2017 at 03:08, wrote: > On laptop systems with a dedicated (powerful) GPU A, you usually > have all connectors routed to another (less-powerful) GPU B. > > With my setup (GPU A = Nvidia, GPU B = Intel) I keep GPU A switched > off by not loading the

Re: [PATCH xserver] ramdac: Check ScreenPriv != NULL in xf86ScreenSetCursor()

2017-10-25 Thread Dave Airlie
Reviewed-by: Dave Airlie <airl...@redhat.com> On 25 October 2017 at 11:39, Alex Goins <ago...@nvidia.com> wrote: > Similar to change cba5a10f, xf86ScreenSetCursor() would dereference ScreenPriv > without NULL checking it. If Option "SWCursor" is specified, Screen

Re: VK_EXT_aquire_xlib_display and kernel security concerns

2017-10-16 Thread Dave Airlie
On 17 October 2017 at 06:01, James Jones wrote: > On 10/16/2017 12:28 PM, Keith Packard wrote: >> >> James Jones writes: >> >>> I think at a lower level, we have different views of how >>> vkGetPhysicalDeviceDisplayPropertiesKHR/VK_KHR_display works. >>>

[PATCH] modesetting: handle NULL cursor in drmmode_set_cursor.

2017-06-22 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> We had a bug reported with a touchscreen where we could end up in here with a NULL cursor, so let's not crash the X server. Signed-off-by: Dave Airlie <airl...@redhat.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 3 +++ 1 fil

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-05-09 Thread Dave Airlie
> > Just please make sure that one (user configurable/opt-in if necessary) > policy from the beginning is to allow leasing out any output to > applications, not just HMDs. My type of scientific/medical applications > would benefit as soon as it has the option to get a drm lease for a given >

Re: [PATCH mga] xf86-video-mga: Add support for a new G200eH3 device

2017-02-12 Thread Dave Airlie
> > Signed-off-by: Mathieu Larouche <mathieu.larou...@matrox.com> Reviewed-by: Dave Airlie <airl...@redhat.com> > --- > src/mga.h| 4 +++- > src/mga_dacG.c | 56 > +++- > src/mga_driver.c | 36 +++

Re: [PATCH xserver] present: disable page flip only when a slave crtc is active

2017-01-31 Thread Dave Airlie
On 1 February 2017 at 11:21, Michel Dänzer wrote: > On 01/02/17 04:05 AM, David Airlie wrote: >>> From: "Michel Dänzer" >>> On 26/01/17 07:13 PM, Qiang Yu wrote: @@ -145,7 +157,7 @@ present_check_flip(RRCrtcPtrcrtc, return

Re: [PATCH xserver 2/2] modesetting: Fix reverse prime update lagging on secondary GPU outputs

2016-09-15 Thread Dave Airlie
if any shared pixmaps were updated by the primary GPU, > forcing an immediate re-run of all blockhandlers. Nice idea, Reviewed-by: Dave Airlie <airl...@redhat.com> > > Signed-off-by: Hans de Goede <hdego...@redhat.com> > --- > hw/xfree86/drivers/modesetting/driver

Re: [PATCH xserver 1/2] modesetting: Fix reverse prime partial update issues on secondary GPU outputs

2016-09-15 Thread Dave Airlie
for an example of > what this looks like see: Reviewed-by: Dave Airlie <airl...@redhat.com> ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 4/4] xfree86: promote one GPU screen if (NumScreens == 0 && NumGPUScreens > 0)

2016-09-05 Thread Dave Airlie
On 5 September 2016 at 22:39, Laszlo Ersek wrote: > On 09/04/16 11:01, Hans de Goede wrote: >> HI, >> >> On 04-09-16 03:11, Laszlo Ersek wrote: >>> Aarch64/KVM virtual machines cannot use emulated graphics cards with >>> linear framebuffers, due to architectural cache coherency

Re: Hints for debugging a weird sw-cursor issue ?

2016-08-31 Thread Dave Airlie
On 1 September 2016 at 11:28, Michel Dänzer <mic...@daenzer.net> wrote: > On 01/09/16 10:24 AM, Michel Dänzer wrote: >> On 01/09/16 08:33 AM, Carsten Haitzler (The Rasterman) wrote: >>> On Thu, 1 Sep 2016 06:36:32 +1000 Dave Airlie <airl...@gmail.com> said: >>&g

Re: Hints for debugging a weird sw-cursor issue ?

2016-08-31 Thread Dave Airlie
On 31 August 2016 at 22:10, Hans de Goede wrote: > Hi All, > > I've noticed a weird sw-cursor issue when a slave-output is active > (I believe this is a sw-cursor issue because show_cursor never > gets called when a slave-output is active at server start). > > I'm seeing

[PATCH 2/2] glamor: use write only for putimage in some cases (v2)

2016-08-23 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> Ilia pointed out that xlock -mode wator is slow, this speeds it up by avoiding the ReadPixels on every frame. The current criteria for putimage is a) ALU copy operation b) planemask all set c) region is contained inside pCompositeClip v2: check for

[PATCH 1/2] glamor: Add GLAMOR_ACCESS_WO

2016-08-22 Thread Dave Airlie
From: Michel Dänzer <michel.daen...@amd.com> [airlied: rebased onto master - I left WO alone as it's more like the GL interface review suggested changing it to bits.] Reviewed-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Signed-o

[PATCH] modesetting: prefer primary crtc when picking over nothing

2016-08-02 Thread Dave Airlie
be throttling things. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85064 Signed-off-by: Dave Airlie <airl...@redhat.com> --- hw/xfree86/drivers/modesetting/vblank.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/hw/xfree86/drivers/modes

Re: [PATCH video-mga 2/2] xf86-video-mga: Add support for the new G200e chipset

2016-07-13 Thread Dave Airlie
> + if (pMga->is_G200SE) { > + outMGAdac( 0x1a, 0x09); > + usleep(500); > + outMGAdac( 0x1a, 0x01); > + } > + So this piece stands out here as a change to not just this chip, has this been tested on all G200SE? What does it do? Dave.

Re: modesetting driver does not support being an offload source, should not advertise cap ?

2016-07-07 Thread Dave Airlie
On 7 July 2016 at 02:08, Hans de Goede wrote: > Hi all, > > Currently the modesetting driver sets a cap flag claiming that it can > be an offload source, yet using DRI_PRIME=1 with the modesetting driver > being the driver for slave nvidia gpu, does not work unless the master

Re: [PATCH] modesetting: NULL assignment for drmmode_set_target_scanout_target_cpu

2016-07-07 Thread Dave Airlie
gnment causes a ton of problems with dereferencing > uninitialized memory. > > Signed-off-by: Alex Goins <ago...@nvidia.com> Reviewed-by: Dave Airlie <airl...@redhat.com> > --- > hw/xfree86/drivers/modesetting/drmmode_display.c | 1 + > 1 file changed, 1 insertion(+) > > di

Re: [PATCH v7 00/11] PRIME Synchronization

2016-06-20 Thread Dave Airlie
eamed a > couple of patches to the i915 DRM driver that mesh with these, and have > implemented double buffered PRIME source support in the NVIDIA proprietary > driver (pending release.) This series is better off in at this point I think, I've looked over it a few time

Re: [PATCH xserver 2/2] modesetting: Only add main fb if necessary

2016-06-13 Thread Dave Airlie
These two are Reviewed-by: Dave Airlie <airl...@redhat.com> Can you take a look at Lyude's patch just posted? not sure if it'll conflict with these. Dave. On 2 June 2016 at 05:04, Hans de Goede <hdego...@redhat.com> wrote: > If we're doing reverse-prime; or doing rotat

Re: [PATCH xserver] modesetting: Set ppix->fb_id to 0 after removing the fb

2016-06-13 Thread Dave Airlie
Reviewed-by: Dave Airlie <airl...@redhat.com> On 2 June 2016 at 21:48, Hans de Goede <hdego...@redhat.com> wrote: > This ensures the fb gets re-added when a shared pixmap is re-used for > a second drmmode_set_scanout_pixmap_cpu call. > > Note currently the xserver never

Re: [PATCH xserver] modesetting: Properly cleanup fb for reverse-prime-offload

2016-06-13 Thread Dave Airlie
Reviewed-by: Dave Airlie <airl...@redhat.com> On 2 June 2016 at 05:04, Hans de Goede <hdego...@redhat.com> wrote: > drmmode_set_scanout_pixmap_gpu(pix) adds drmmod->fb_id through a call > to drmmode_xf86crtc_resize(), but on a subsequent > drmmode_set_scanout_pixmap_gpu(N

Re: [PATCH xserver v2] xrandrprovider: Do not use separate lists for unbound / source / offload slaves

2016-06-13 Thread Dave Airlie
s by unifying all 3 lists into a single slaves list. > > Note that this does change the struct _Screen definition, so this is an ABI > break. I do not expect any of the drivers to actually use the removed / > changed > fields so a recompile should suffice. > > Signed-off-by:

Re: [PATCH v6 10/11] modesetting: Disable Reverse PRIME for i915

2016-06-13 Thread Dave Airlie
On 14 June 2016 at 10:39, Alex Goins wrote: >> > >> IMHO the proposed patch does not sound like a reasonable long-term >> > >> solution. Ideally the driver will expose a flag, based on which Xorg >> > >> will enable/disable reverse prime. That said, as a short-term fix this >>

Re: [PATCH v5 00/13] PRIME Synchronization

2016-05-26 Thread Dave Airlie
On 20 May 2016 at 08:36, Alex Goins wrote: > Hi Dave, > > Any update on this? Anything I can do to help? Hey, can you take a look at prime: clean up slave bo properly. (v3) I think with this rebased onto that, we should be pretty much good to merge. Dave.

[PATCH xserver] prime: clean up slave bo properly. (v3)

2016-05-05 Thread Dave Airlie
. v2: use a new toplevel API, though it still passes NULL to something that wasn't expecting it. v3: pass -1 instead of 0. Signed-off-by: Dave Airlie <airl...@redhat.com> --- dix/pixmap.c | 7 +++ hw/xfree86/dri2/dri2.c | 1

[PATCH] modesetting: fix build with glamor disabled.

2016-05-05 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> Fix build without --enable-glamor. Caught by the arm tinderbox. Signed-off-by: Dave Airlie <airl...@redhat.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/xfree86/drivers

Re: [PATCH v5 00/13] PRIME Synchronization

2016-05-03 Thread Dave Airlie
On 3 May 2016 at 12:19, Alex Goins wrote: > Sorry for all of the self-replies. > > I spent more time looking into what might be causing this (despite not being > able to reproduce it), and found that in the Present extension's > present_check_flip(), it doesn't use flipping if

[PATCH 1/2] modesetting: add support for background none.

2016-05-02 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This adds support using glamor for background None. loosely based off the amdgpu code. relies on the glamor_finish code. Acked-by: Eric Anholt <e...@anholt.net> Signed-off-by: Dave Airlie <airl...@redhat.com> --- hw/xfree86/drivers/mo

[PATCH 2/2] modesetting: port clean start code from amdgpu. (v2)

2016-05-02 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> Both radeon and amdgpu don't set the mode until the first blockhandler, this means everything should be rendered on the screen correctly by then. This ports this code, it also removes the tail call of EnterVT from ScreenInit, it really isn't nec

[PATCH] edid-decode: parse displayid blocks

2016-05-01 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> --- edid-decode.c | 174 ++ 1 file changed, 174 insertions(+) diff --git a/edid-decode.c b/edid-decode.c index 62c732d..631b223 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -1072,6 +10

Re: [PATCH xserver] prime: clean up slave bo properly. (v2)

2016-04-29 Thread Dave Airlie
On 29 April 2016 at 17:56, Julien Cristau <jcris...@debian.org> wrote: > On Fri, Apr 29, 2016 at 15:54:28 +1000, Dave Airlie wrote: > >> This is an ABI break, in that we now pass NULL to a function >> that hasn't accepted it before. >> >> Alex Goins had a di

Re: [PATCH v5 01/13] xf86: Add PRIME flipping functions to Screen

2016-04-29 Thread Dave Airlie
On 13 April 2016 at 14:17, Alex Goins wrote: > Adds typedefs for (*RRStartFlippingPixmapTrackingProcPtr), > (*RREnableSharedPixmapFlippingProcPtr), > and (*RRDisableSharedPixmapFlippingProcPtr) in randrstr.h. > > Adds typedefs for (*PresentSharedPixmapProcPtr), >

[PATCH xserver] prime: clean up slave bo properly. (v2)

2016-04-28 Thread Dave Airlie
. v2: use a new toplevel API, though it still passes NULL to something that wasn't expecting it. Signed-off-by: Dave Airlie <airl...@redhat.com> --- dix/pixmap.c | 6 ++ hw/xfree86/dri2/dri2.c | 1 + hw/xfree86/drivers/modes

Re: [PATCH v5 00/13] PRIME Synchronization

2016-04-28 Thread Dave Airlie
On 13 April 2016 at 14:17, Alex Goins wrote: > Hello all, > > These patches change the xserver to support setting up PRIME with double > buffering, and implement double buffered PRIME sink and source support in > the modesetting driver. In addition to these changes, I've

Re: [PATCH 6/6] prime: clean up slave bo properly.

2016-04-28 Thread Dave Airlie
> This is an ABI break, in that we now pass NULL to a function > that hasn't accepted it before. > > Alex Goins had a different patch for this but it wasn't symmetrical, > it freed something in a very different place than it allocated it, > this attempts to retain symmetry in the releasing of the

[PATCH 5/6] modesetting: set capabilities up after glamor and enable offload caps.

2016-04-28 Thread Dave Airlie
This moves the capabilites setting to after glamor is initialised, and enables the offload caps in cases where they work. This enables DRI2 PRIME support with modesetting. Signed-off-by: Dave Airlie <airl...@redhat.com> --- hw/xfree86/drivers/modesetting/driver.

[PATCH 1/6] modesetting: Consistent whitespace in driver.c

2016-04-28 Thread Dave Airlie
N/A v4: Initial commit Signed-off-by: Alex Goins <ago...@nvidia.com> Reviewed-by: Dave Airlie <airl...@redhat.com> --- hw/xfree86/drivers/modesetting/driver.c | 36 - 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/hw/xfree86/drivers/modesett

[PATCH 6/6] prime: clean up slave bo properly.

2016-04-28 Thread Dave Airlie
. Signed-off-by: Dave Airlie <airl...@redhat.com> --- dix/pixmap.c | 5 + hw/xfree86/dri2/dri2.c | 1 + hw/xfree86/drivers/modesetting/driver.c | 4 hw/xfree86/drivers/modesetting/drmmode_display.c | 6 ++

[PATCH 2/6] randr/provider: only allow slave gpu to be offload sources.

2016-04-28 Thread Dave Airlie
The other way around makes no sense. Signed-off-by: Dave Airlie <airl...@redhat.com> --- randr/rrprovider.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/randr/rrprovider.c b/randr/rrprovider.c index bbb8e51..5329f41 100644 --- a/randr/rrprovider.c +++ b/randr/rrprovider.c @@

[PATCH 4/6] xf86Crtc: don't set the root window property on slave GPUs.

2016-04-28 Thread Dave Airlie
Slave GPUs don't have a root window to set this on, so don't. This fixes some crashes I saw just playing around. Signed-off-by: Dave Airlie <airl...@redhat.com> --- hw/xfree86/modes/xf86Crtc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/modes/xf86Crtc.

[PATCH 3/6] modesetting: set driverPrivate to NULL after closing fd.

2016-04-28 Thread Dave Airlie
Otherwise ms_ent_priv will return NULL and things will fall apart. Signed-off-by: Dave Airlie <airl...@redhat.com> --- hw/xfree86/drivers/modesetting/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/drivers/modesetting/driver.c b/hw/xfree86/d

Re: [PATCH] glamor: add glamor_finish API

2016-04-28 Thread Dave Airlie
On 12 March 2016 at 09:59, Eric Anholt <e...@anholt.net> wrote: > Dave Airlie <airl...@gmail.com> writes: > >> From: Dave Airlie <airl...@redhat.com> >> >> Some drivers are calling glFinish, they really should be doing this. >> >> This also is

[PATCH] glamor: swizzle RED to 0 for alpha textures.

2016-03-15 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> I'm pretty sure Eric suspected this could cause a problem, and we couldn't find a test. Well loading feedly in firefox seems to trigger badness that this solves. bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94554 Signed-off-by: Dave Airlie

Re: [PATCH xserver] glamor: Make context current in glamor_pixmap_fbo_cache_put

2016-03-10 Thread Dave Airlie
gt; > (EE) glamor256: GL error: GL_INVALID_OPERATION in glBindTexture(non-gen name) > > spew since 0b4c0c75 ('glamor: Replace "finish access" shader with texture > swizzling'). > > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Reviewed-by: Dave Airlie <airl...@redhat.com&

[PATCH 2/2] glamor: use write only for putimage in some cases

2016-03-10 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> Ilia pointed out that xlock -mode wator is slow, this speeds it up by avoiding the ReadPixels on every frame. The current criteria for putimage is a) ALU copy operation b) planemask all set c) region is contained inside pCompositeClip Signed-off-by

[PATCH 1/2] glamor: Add GLAMOR_ACCESS_WO

2016-03-10 Thread Dave Airlie
From: Michel Dänzer <michel.daen...@amd.com> [airlied: rebased onto master - I left WO alone as it's more like the GL interface review suggested changing it to bits.] Reviewed-by: Dave Airlie <airl...@redhat.com> Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Signed-o

[PATCH] glamor: add glamor_finish API

2016-03-10 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> Some drivers are calling glFinish, they really should be doing this. This also is needed for some reverse prime scenarios. Signed-off-by: Dave Airlie <airl...@redhat.com> --- glamor/glamor.c | 9 + glamor/glamor.h | 1 + 2 files

[PATCH] [RFC] glamor: implement write-only prepares

2016-03-09 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> For some putimages we know we won't ever care about the data we readback, we are going to trash it with the putimage contents. So implement GLAMOR_ACCESS_WO mode. This will avoid doing the readbacks. Use it for putimages that are copy with a solid pla

Re: Unplugging the main graphics device

2016-02-22 Thread Dave Airlie
On 22 February 2016 at 22:20, Michael Thayer wrote: > On 19.02.2016 16:16, Michael Thayer wrote: >> >> I have been experimenting a bit with plugging and unplugging of graphics >> devices (using a dummy KMS driver which is udl stripped of the actual >> hardware poking)

Re: [PATCH 1/2] xfree86: add pci id matching to OutputClass

2016-02-19 Thread Dave Airlie
On 18 February 2016 at 11:28, Aaron Plattner <aplatt...@nvidia.com> wrote: > On 02/08/2016 07:24 PM, Dave Airlie wrote: >> This will be used by drivers to denote PCI ids in the future >> instead of hardcoding them in the server. > > What benefit does this provide over Ma

Re: [PATCH v3 0/9] PRIME Synchronization

2016-02-19 Thread Dave Airlie
On 12 February 2016 at 14:39, Alex Goins wrote: > Pinging in case this got buried. Is there any reason this only addresses one direction in the -modesetting driver. In theory shouldn't we able to expose both source and sink bits in -modesetting? (esp when glamor is enabled).

Re: [PATCH] dri2: add virtio-gpu pci ids

2016-02-15 Thread Dave Airlie
On 13 February 2016 at 07:52, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > Add virtio-gpu legacy + 1.0 pci ids, allowing them to use > modesetting + glamor with dri2. Reviewed-by: Dave Airlie <airl...@redhat.com> > > Signed-off-by: Marc-André Lureau <

[PATCH] modesetting: add support for background none.

2016-02-09 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This adds support using glamor for background None. loosely based off the amdgpu code. relies on the glamor_finish code. Signed-off-by: Dave Airlie <airl...@redhat.com> --- hw/xfree86/drivers/modesetting/driver.c | 21 + hw/xfr

[PATCH] modesetting: port clean start code from amdgpu.

2016-02-09 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> Both radeon and amdgpu don't set the mode until the first blockhandler, this means everything should be rendered on the screen correctly by then. This ports this code, it also removes the tail call of EnterVT from ScreenInit, it really isn't nec

[PATCH 1/2] xfree86: add pci id matching to OutputClass

2016-02-08 Thread Dave Airlie
This will be used by drivers to denote PCI ids in the future instead of hardcoding them in the server. Signed-off-by: Dave Airlie <airl...@redhat.com> --- hw/xfree86/common/xf86platformBus.c | 14 ++ hw/xfree86/parser/OutputClass.c | 21 + hw/xfree86/

[PATCH 2/2] xfree86/linux: disable using built-in pci id list on Linux.

2016-02-08 Thread Dave Airlie
This disables the built-in pciid lists on Linux, as we want to start using OutputClass only to pick which drivers to load. Signed-off-by: Dave Airlie <airl...@redhat.com> --- hw/xfree86/common/xf86pciBus.c | 3 ++- hw/xfree86/common/xf86platformBus.c | 3 ++- 2 files changed, 4 inse

[RFC] use OutputClass PCI ID matching for driver selection.

2016-02-08 Thread Dave Airlie
This series is a replacement for my previous attempt at glamor forcing different drivers to load. First it adds the ability to match on PCI ID strings to the OutputClass stuff. The sections are of the form: ection "OutputClass" Identifier "nouveau" Driver "nouveau"

[PATCH 2/2] pixmap: add wait shared pixmap

2016-02-08 Thread Dave Airlie
to the shared pixmap before the second driver does things to its side of the shared pixmap. This fixes a wierd lag, if you run X across two GPUs, and then run xsetroot -solid and various values, the slave screens end up a slot behind. Signed-off-by: Dave Airlie <airl...@redhat.com> --- dix/pi

[PATCH 1/2] present: fail flipping if we have any slave outputs.

2016-02-08 Thread Dave Airlie
(something we shouldn't be doing), so the slave driver can never get it's own screen ptr back. For now to fix the problem just block flips if we have any slaves configured. We can fix the ABI up later, but this fix can be backported to stable. Signed-off-by: Dave Airlie <airl...@redhat.

Re: [PATCH] Fix XineramaQueryScreens for reverse prime

2016-02-07 Thread Dave Airlie
On 4 February 2016 at 23:06, Jan Burgmeier <jan.burgme...@unicon-software.com> wrote: > Bugzilla: https://bugs.freedesktop.org/92313 Reviewed-by: Dave Airlie <airl...@redhat.com> though it might be nice to have some more info from the bug in the commit message. > --- > r

Re: [PATCH xserver 00/19] glamor: Cleanups all over

2016-01-28 Thread Dave Airlie
On 28 January 2016 at 18:21, Dave Airlie <airl...@gmail.com> wrote: > On 28 January 2016 at 11:56, Eric Anholt <e...@anholt.net> wrote: >> I've been working on vc4 X performance again, particularly looking at >> dragging windows with xcompmgr -c running. I'll be

Re: [PATCH xserver 00/19] glamor: Cleanups all over

2016-01-28 Thread Dave Airlie
ware (I see fewer texture sampler requests on vc4). No > performance change on i965, but I hope that vc4 is in better shape > after it. (I'm away from the hardware at the moment, but should test > later today). 1-3 look good to me, Reviewed-by: Dave Airlie <airl...@redhat.com> I'l

Re: [PATCH 6/8] ephyr: Create 3.3 core profile context if possible (v3)

2016-01-22 Thread Dave Airlie
On 23 January 2016 at 02:53, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi Dave, > > On 19 January 2016 at 09:02, Dave Airlie <airl...@gmail.com> wrote: >> From: Keith Packard <kei...@keithp.com> >> >> On desktop GL, Ask for a 3.3 core profile con

Re: [PATCH xserver 1/2] glamor: Fix copy-like Render operations between 15 and 16 depth.

2016-01-21 Thread Dave Airlie
nterpretation matches on both sides. > > Fixes rendercheck/blend/over and renderhceck/blend/src in piglit. > > Signed-off-by: Eric Anholt <e...@anholt.net> makes sense, Reviewed-by: Dave Airlie <airl...@redhat.com> > --- > glamor/glamor_render.c | 8 > 1

Re: [PATCH xserver 2/2] glamor: Drop the composite_with_copy path entirely.

2016-01-21 Thread Dave Airlie
hat it doesn't, we should fix composite. For EXA I could see us caring, for glamor not so much. Though I suppose in theory we could have a blitfb based copy that is faster, but we don't. Reviewed-by: Dave Airlie <airl...@redhat.com> > > Signed-off-by: Eric Anholt <e...@anholt.net>

Re: [PATCH] glamor: don't do copy if we have 0 boxes to copy.

2016-01-19 Thread Dave Airlie
On 20 January 2016 at 03:56, Eric Anholt <e...@anholt.net> wrote: > Dave Airlie <airl...@gmail.com> writes: > >> From: Dave Airlie <airl...@redhat.com> >> >> This happens if you run twm + mplayer + xclock and drag >> the clock over the mplayer. I

[PATCH 2/8] glamor/xv: add vbo support

2016-01-18 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This converts the Xv code to using VBOs instead of client ptrs. This is necessary to move towards using the core profile later. Signed-off-by: Dave Airlie <airl...@redhat.com> --- glamor/glamor_xv.c | 31 +-- 1 file

[PATCH 6/8] ephyr: Create 3.3 core profile context if possible (v2)

2016-01-18 Thread Dave Airlie
From: Keith Packard <kei...@keithp.com> On desktop GL, Ask for a 3.3 core profile context if that's available, otherwise create a generic context. v2: tell glamor the profile is a core one. Signed-off-by: Keith Packard <kei...@keithp.com> Signed-off-by: Dave Airlie <airl...@redh

[PATCH 5/8] glamor: add core profile support.

2016-01-18 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This adds a new flag to glamor_init to denote the context is core profile. This flag is used to disable quads for rendering. Signed-off-by: Dave Airlie <airl...@redhat.com> --- glamor/glamor.c | 3 ++- glamor/glamor.h | 3 ++- 2 file

[PATCH 8/8] xwayland: add support for use core profile for glamor.

2016-01-18 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This adds support to Xwayland to try and use OpenGL core profile for glamor first. Signed-off-by: Dave Airlie <airl...@redhat.com> --- hw/xwayland/xwayland-glamor.c | 22 +- hw/xwayland/xwayland.h| 1 + 2 files

[PATCH 1/8] glamor: use vbos in gradient/picture code.

2016-01-18 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This converts two client arrays users to using vbos, this is necessary to move to using core profile later. Signed-off-by: Dave Airlie <airl...@redhat.com> --- glamor/glamor_gradient.c | 33 - glamor/glamor_pic

[PATCH 7/8] glamor: add core profile support to EGL glamor.

2016-01-18 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This breaks ABI unfortunately as we have to pass the core profile info from the egl part of glamor to the glamor part of glamor. Signed-off-by: Dave Airlie <airl...@redhat.com> --- glamor/glamor.h | 2 +- glamor/

[PATCH 4/8] glamor: Use GL_RED instead of GL_ALPHA if we have texture_swizzle

2016-01-18 Thread Dave Airlie
paths] Signed-off-by: Keith Packard <kei...@keithp.com> Signed-off-by: Dave Airlie <airl...@redhat.com> --- glamor/glamor.c | 4 glamor/glamor_composite_glyphs.c | 5 + glamor/glamor_fbo.c | 2 ++ glamor/glamor_picture.c | 22

glamor core profile support

2016-01-18 Thread Dave Airlie
This series implements support for glamor in ephyr/EGL/Xwayland to use GL core profile when it can. This required 4 main changes: a) stop using client ptrs everywhere, I found 3 places left, gradient, picture and xv where we use these. b) start using VAOs c) use GL_RED instead of GL_ALPHA d) stop

[PATCH 3/8] glamor: Use vertex arrays

2016-01-18 Thread Dave Airlie
From: Keith Packard <kei...@keithp.com> Core contexts require the use of vertex arrays, so switch both glamor and ephyr/glamor over. Signed-off-by: Keith Packard <kei...@keithp.com> Signed-off-by: Dave Airlie <airl...@redhat.com> --- glamor/glamor.c

[PATCH] glamor: don't do copy if we have 0 boxes to copy.

2016-01-18 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This happens if you run twm + mplayer + xclock and drag the clock over the mplayer. If we don't catch it, we cause an illegal draw elements command to be passed to GL. Signed-off-by: Dave Airlie <airl...@redhat.com> --- glamor/glamor_copy.c | 3

Re: [PATCH 2/8] glamor/xv: add vbo support

2016-01-18 Thread Dave Airlie
On 19 January 2016 at 11:15, Eric Anholt <e...@anholt.net> wrote: > Dave Airlie <airl...@gmail.com> writes: > >> From: Dave Airlie <airl...@redhat.com> >> >> This converts the Xv code to using VBOs instead of >> client ptrs. This is necessary

[PATCH] glamor/xv: add vbo support (v2)

2016-01-18 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This converts the Xv code to using VBOs instead of client ptrs. This is necessary to move towards using the core profile later. v2: put all boxes into single vbo, use draw arrays to offset things. (Eric) Signed-off-by: Dave Airlie <airl...@r

[PATCH] glamor/xv: add vbo support (v2.1)

2016-01-18 Thread Dave Airlie
From: Dave Airlie <airl...@redhat.com> This converts the Xv code to using VBOs instead of client ptrs. This is necessary to move towards using the core profile later. v2: put all boxes into single vbo, use draw arrays to offset things. (Eric) v2.1: brown paper bag with releasing vbo. Sign

Re: [PATCH 7/8] glamor: add core profile support to EGL glamor.

2016-01-18 Thread Dave Airlie
On 19 January 2016 at 12:09, Michel Dänzer <mic...@daenzer.net> wrote: > On 19.01.2016 09:56, Dave Airlie wrote: >> From: Dave Airlie <airl...@redhat.com> >> >> This breaks ABI unfortunately as we have to pass the core profile >> info from the egl part

Re: glamor core profile support

2016-01-18 Thread Dave Airlie
On 19 January 2016 at 12:39, Dave Airlie <airl...@gmail.com> wrote: > On 19 January 2016 at 10:56, Dave Airlie <airl...@gmail.com> wrote: >> This series implements support for glamor in ephyr/EGL/Xwayland >> to use GL core profile when it can. >> >> This re

Re: [PATCH 7/8] glamor: add core profile support to EGL glamor.

2016-01-18 Thread Dave Airlie
On 19 January 2016 at 12:38, Michel Dänzer <mic...@daenzer.net> wrote: > On 19.01.2016 11:20, Dave Airlie wrote: >> On 19 January 2016 at 12:09, Michel Dänzer <mic...@daenzer.net> wrote: >>> On 19.01.2016 09:56, Dave Airlie wrote: >>>> From: Dave Airlie

Re: glamor core profile support

2016-01-18 Thread Dave Airlie
On 19 January 2016 at 10:56, Dave Airlie <airl...@gmail.com> wrote: > This series implements support for glamor in ephyr/EGL/Xwayland > to use GL core profile when it can. > > This required 4 main changes: > a) stop using client ptrs everywhere, I found 3 places left, >

  1   2   3   4   5   6   7   8   9   10   >