to me and it fixes the autoloading problem.
Tested-by: Kristian Høgsberg k...@bitplanet.net
Please apply.
Kristian
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
Cc: Tiago Vignatti tiago.vigna...@nokia.com
Cc: Alex Deucher alexdeuc...@gmail.com
Reviewed-by: Julien Cristau jcris
On Mon, May 31, 2010 at 6:22 PM, Owain Ainsworth zer...@googlemail.com wrote:
On Mon, May 31, 2010 at 12:52:06PM +0300, Pauli Nieminen wrote:
From: Tiago Vignatti tiago.vigna...@nokia.com
With this new hook drmAuthMagic becomes useless and should be deprecated.
You might want to implement
.
The entire v6 version of the series looks good, except for the comment
above about ABI break, since we're only extending, not breaking the
ABI. If you remove that comment, you can add
Reviewed-by: Kristian Høgsberg k...@bitplanet.net
to the series and send a pull request to Keith.
Kristian
On Fri, May 28, 2010 at 12:13 PM, Pauli Nieminen
ext-pauli.niemi...@nokia.com wrote:
These patches make it possible to use dri2 without libdrm. Dropping
libdrm support is done as optional compile time option to keep ABI/API
compability with older libdrm based drivers.
In future libdrm could
On Wed, May 19, 2010 at 1:31 AM, Keith Packard kei...@keithp.com wrote:
On Tue, 18 May 2010 16:20:14 -0700, Jamey Sharp ja...@minilop.net wrote:
On Tue, May 18, 2010 at 3:38 PM, Keith Packard kei...@keithp.com wrote:
On Sat, 15 May 2010 14:37:22 -0700, Keith Packard kei...@keithp.com
wrote:
1461b31e40a3e44f6327199d23cf2ab70d8f5176 tests to see if the allocation
of buffer[i] failed after i has been incremented, causing it to look
at the wrong pointer.
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
---
hw/xfree86/dri2/dri2.c |8 +---
1 files changed, 5 insertions(+), 3
-pauli.niemi...@nokia.com
Looks good,
Reviewed-by: Kristian Høgsberg k...@bitplanet.net
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
2010/5/11 Adam Jackson a...@nwnk.net:
On Tue, 2010-05-11 at 12:15 -0400, Kristian Høgsberg wrote:
2010/5/11 Adam Jackson a...@nwnk.net:
Is ConfigNotify sufficient for this? I think it'll miss subwindows.
The ConfigNotify chain looks like it only fires from ConfigureWindow(),
which
On Wed, May 12, 2010 at 5:45 PM, Keith Packard kei...@keithp.com wrote:
Signed-off-by: Keith Packard kei...@keithp.com
---
config/udev.c | 6 +++---
hw/dmx/dmxgc.c | 2 ++
hw/dmx/glxProxy/glxcmds.c | 2 +-
3 files changed, 6 insertions(+), 4 deletions(-)
this process.
Kristian
2010/5/10 Kristian Høgsberg k...@bitplanet.net:
If we don't have a fake front, nothing will happen. The fix was extracted
from a bigger patch from Francisco Jerez.
https://bugs.freedesktop.org/show_bug.cgi?id=27305
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
On Sat, May 8, 2010 at 6:57 AM, Julien Cristau jcris...@debian.org wrote:
On Fri, May 7, 2010 at 23:19:18 -0700, Keith Packard wrote:
Signed-off-by: Keith Packard kei...@keithp.com
---
config/udev.c | 6 +++---
hw/dmx/dmxgc.c | 2 ++
hw/dmx/glxProxy/glxcmds.c
I'm resending the patch series to fix the XID confusion in DRI2. Patches
2, 3 and 4 have already been review and/or tested, but the first patch
needs review again. Patch 1 is the one that fixes the resource count
in dix/resource.c. Keith pointed out that the other recent resource
functions also
deleted a resource and may end up following an invalid
next pointer if the resource system is called into recursively.
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
---
dix/resource.c | 17 +++--
1 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/dix/resource.c b/dix
hard-code the version we need instead of
using the #defines.
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
Reviewed-by: Adam Jackson a...@redhat.com
---
glx/glxdri2.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
Reviewed-by: Adam Jackson a...@redhat.com
---
include/list.h |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/list.h b/include/list.h
index a126a65..89dc29d 100644
--- a/include/list.h
+++ b/include/list.h
...@fishsoup.net
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
---
glx/glxcmds.c | 23 ---
glx/glxdri.c |8 ++-
glx/glxdri2.c | 10 ++-
glx/glxdriswrast.c|8 ++-
glx/glxscreens.h |6 +-
hw/xfree86/dri2/dri2.c| 150
On Fri, May 7, 2010 at 3:13 PM, Keith Packard kei...@keithp.com wrote:
On Fri, 7 May 2010 14:58:05 -0400, Kristian Høgsberg k...@bitplanet.net
wrote:
resources = clientTable[client-index].resources;
+ eltptr = clientTable[client-index].elements;
for (i = 0; i clientTable
2010/5/1 Kristian Høgsberg k...@bitplanet.net:
Some pixmaps (window pixmaps and scratch pixmaps) don't have the
drawable-id set and thus DRI2 gets confused when using that field
for looking up the DRI2 drawable. Go back to using privates for getting
at the DRI2 drawable from a DrawablePtr
On Sun, May 2, 2010 at 5:02 PM, Keith Packard kei...@keithp.com wrote:
On Sat, 1 May 2010 13:31:57 -0400, Kristian Høgsberg k...@bitplanet.net
wrote:
All resource functions keep clientTable[cid].elements up to date with the
number of resources allocated to the client. Except
-resource-fixes
Kristian Høgsberg (4):
dix: Update element count in FreeResource*()
glxdri2: Hard-code the extension version we need
list.h: Add list_for_each_entry_safe()
dri2: Take an XID for tracking the DRI2 drawable
dix/resource.c| 17 +-
glx/glxcmds.c
and we end up following an invalid next pointer.
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
---
dix/resource.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/dix/resource.c b/dix/resource.c
index 91d0cfb..aec2a5b 100644
--- a/dix/resource.c
+++ b/dix/resource.c
hard-code the version we need instead of
using the #defines.
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
---
glx/glxdri2.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/glx/glxdri2.c b/glx/glxdri2.c
index 74d6ebc..c34e29a 100644
--- a/glx/glxdri2.c
+++ b
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
---
include/list.h |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/list.h b/include/list.h
index a126a65..89dc29d 100644
--- a/include/list.h
+++ b/include/list.h
@@ -94,4 +94,10 @@ list_is_empty(struct list
can remove the DRI2 drawable when the X resource
it was created for goes away. Additionally, we also now track the DRI2
drawable using a client XID so we can reclaim the DRI2 drawable even if
the client goes before the drawable and doesn't destroy the DRI2 drawable.
Signed-off-by: Kristian
This ensures that the DrawableGone callback gets called as necessary
when the X drawable goes away. Otherwise, using a GLX drawable
(say, glXSwapBuffers) in indirect mode after the X drawable has been
destroyed will crash the server.
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
Reviewed
On Fri, Apr 16, 2010 at 11:24 AM, Jon TURNEY
jon.tur...@dronecode.org.uk wrote:
This way other DDX which don't have DRI can use them
I don't think this can generate ABI problems with the DRI1 loader,
but what do I know...
Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk
This looks ok.
2010/4/15 Michel Dänzer mic...@daenzer.net:
On Wed, 2010-04-14 at 15:13 -0400, Kristian Høgsberg wrote:
The real fix is the patch from attachment 25038, not the DestroyWindow
hook. If the context is destroyed first, it will remove itself from
the glxAllContexts list so the DrawableGone
2010/4/15 Michel Dänzer mic...@daenzer.net:
On Thu, 2010-04-15 at 07:58 -0400, Kristian Høgsberg wrote:
2010/4/15 Michel Dänzer mic...@daenzer.net:
On Wed, 2010-04-14 at 15:13 -0400, Kristian Høgsberg wrote:
The real fix is the patch from attachment 25038, not the DestroyWindow
hook
On Thu, 15 Apr 2010 15:48:00 +0200, Michel Dänzer mic...@daenzer.net wrote:
On Thu, 2010-04-15 at 08:26 -0400, Kristian Høgsberg wrote:
2010/4/15 Kristian Høgsberg k...@bitplanet.net:
2010/4/15 Michel Dänzer mic...@daenzer.net:
On Thu, 2010-04-15 at 07:58 -0400, Kristian Høgsberg wrote
2010/4/15 Keith Packard kei...@keithp.com:
On Wed, 14 Apr 2010 20:30:55 -0400, Kristian Høgsberg k...@bitplanet.net
wrote:
Oh, I was thinking I could just allocate the ID, but not actually add
the Pixmap as a resource. Is that bad form?
It wouldn't help -- you need FreeResource
2010/4/15 Keith Packard kei...@keithp.com:
On Thu, 15 Apr 2010 14:15:05 -0400, Kristian Høgsberg k...@bitplanet.net
wrote:
2010/4/15 Keith Packard kei...@keithp.com:
On Wed, 14 Apr 2010 20:30:55 -0400, Kristian Høgsberg k...@bitplanet.net
wrote:
Oh, I was thinking I could just
2010/4/15 Keith Packard kei...@keithp.com:
On Thu, 15 Apr 2010 14:47:51 -0400, Kristian Høgsberg k...@bitplanet.net
wrote:
Right, it would linger until the client exits. So I guess I'll have
to actually AddResource the pixmap with the FakeClientID and then use
FreeResource to destroy
Keith, have you had time to look at this respun fix for 26394?
2010/4/9 Kristian Høgsberg k...@bitplanet.net:
The main motivation here is to have the resource system clean up the
DRI2 drawable automatically so glx doesn't have to. Right now, the
glx drawable resource must be destroyed before
2010/4/10 Michel Dänzer mic...@daenzer.net:
On Fri, 2010-04-09 at 14:18 -0400, Kristian Høgsberg wrote:
Now that glx doesn't call DRI2DestroyDrawable anymore, we don't need to
force a specific resource destruction order in the DestroyWindow hook.
I don't think DRI2DestroyDrawable was the only
2010/3/30 Francisco Jerez curroje...@riseup.net:
It wasn't a problem before the invalidate changes (fa5103a02
specifically) because the SwapBuffers request was unconditionally
followed by a GetBuffers request (and GetBuffers updated the fake
front). On DRI2.3 the client is only required to
On Wed, Apr 14, 2010 at 1:18 PM, Keith Packard kei...@keithp.com wrote:
On Wed, 14 Apr 2010 10:25:49 -0400, Kristian Høgsberg k...@bitplanet.net
wrote:
Keith, have you had time to look at this respun fix for 26394?
Oh. I just had a bad thought -- pixmaps don't follow the same rule
2010/4/14 Michel Dänzer mic...@daenzer.net:
On Wed, 2010-04-14 at 10:43 -0400, Kristian Høgsberg wrote:
2010/4/10 Michel Dänzer mic...@daenzer.net:
On Fri, 2010-04-09 at 14:18 -0400, Kristian Høgsberg wrote:
Now that glx doesn't call DRI2DestroyDrawable anymore, we don't need to
force
doesn't have to worry about that and the
resource destruction order becomes irrelevant.
https://bugs.freedesktop.org/show_bug.cgi?id=26394
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
---
Here's a different approach to fixing 26394. It's more invasive and there's
a little piece of uglyness
Now that glx doesn't call DRI2DestroyDrawable anymore, we don't need to
force a specific resource destruction order in the DestroyWindow hook.
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
---
glx/glxscreens.c | 28
glx/glxscreens.h |1 -
2 files changed
for the indirect
case.
Signed-off-by: Francisco Jerez curroje...@riseup.net
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
---
glx/glxcmds.c | 24 +++-
glx/glxserver.h |1 +
2 files changed, 24 insertions(+), 1 deletions(-)
diff --git a/glx/glxcmds.c b/glx/glxcmds.c
index
and pass the GLX XID to FreeResource instead.
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
---
glx/glxscreens.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/glx/glxscreens.c b/glx/glxscreens.c
index 58d8ee0..b3dad33 100644
--- a/glx/glxscreens.c
+++ b/glx
2010/4/8 Kristian Høgsberg k...@bitplanet.net:
The DestroyWindow hook only works when the GLX drawable XID is the same
as the X window XID. This is only the case for drawables created
through the pre-GLX-1.3 compatibility mechanism. GLX Drawables created
using glXCreateWindow get a different
On Thu, Apr 8, 2010 at 9:02 PM, Keith Packard kei...@keithp.com wrote:
On Thu, 8 Apr 2010 20:06:40 -0400, Kristian Høgsberg k...@bitplanet.net
wrote:
+static int glxWindowPrivateKeyIndex;
+static DevPrivateKey glxWindowPrivateKey = glxWindowPrivateKeyIndex;
Because there doesn't appear
2010/3/22 Michel Dänzer mic...@daenzer.net:
From: Michel Dänzer daen...@vmware.com
Seems to work as well...
Signed-off-by: Michel Dänzer daen...@vmware.com
---
configure.ac | 2 +-
glx/glxdri2.c | 9 +
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git
On Sun, Mar 21, 2010 at 8:10 PM, Keith Packard kei...@keithp.com wrote:
On Tue, 16 Mar 2010 10:26:54 -0400, Kristian Høgsberg k...@bitplanet.net
wrote:
Yes, the series look good and I've updated my branch:
I don't like this code. It adds an unnecessary layer between
DRI2TrackClient
2010/3/22 Ian Romanick i...@freedesktop.org:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Kristian Høgsberg wrote:
2010/2/8 Francisco Jerez curroje...@riseup.net:
The spec says (regarding glXCreateWindow): If there is already a
GLXFBConfig associated with win (as a result of a previous
2010/3/16 Francisco Jerez curroje...@riseup.net:
Keith Packard kei...@keithp.com writes:
I want to get this patch sequence merged, can someone point me at a
repository that I can pull it in from?
Kristian, are you OK with v10? If so, could you gather the whole patch
series in your personal
the license on list.h). Or grab them from the list and add my
Reviewed-by: Kristian Høgsberg k...@bitplanet.net
Signed-off-by: Kristian Høgsberg k...@bitplanet.net
___
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel
2010/2/17 Francisco Jerez curroje...@riseup.net:
Bumps the supported DRI2 protocol version.
---
v5: Restructuring as proposed by Kristian: Don't duplicate the
invalidation policy in the GLX code, keep it in dri2.c and hide the
actual invalidation mechanism behind an opaque callback.
That's
On Mon, Feb 8, 2010 at 1:25 PM, Francisco Jerez curroje...@riseup.net wrote:
The spec says (regarding glXCreateWindow): If there is already a
GLXFBConfig associated with win (as a result of a previous
glXCreateWindow call), then a BadAlloc error is generated.. It will
also come useful to
On Mon, Feb 8, 2010 at 1:25 PM, Francisco Jerez curroje...@riseup.net wrote:
The spec says (regarding glXCreateWindow): If there is already a
GLXFBConfig associated with win (as a result of a previous
glXCreateWindow call), then a BadAlloc error is generated.. It will
also come useful to
On Fri, Jan 22, 2010 at 12:04 PM, Tiago Vignatti
tiago.vigna...@nokia.com wrote:
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
hw/xfree86/dri2/dri2.c | 7 +--
hw/xfree86/dri2/dri2.h | 2 +-
hw/xfree86/dri2/dri2ext.c | 2 ++
3 files changed, 8 insertions(+), 3
On Tue, Jan 19, 2010 at 2:18 PM, Tiago Vignatti
tiago.vigna...@nokia.com wrote:
Some drivers use DRI2 protocol but implement their own kernel rendering
mananger. For these drivers, libdrm becomes useless.
Yeah, I think this could be ok. The drm usage in DRI2 does stick out
a bit, and should
, then I'll
merge it in.
Kristian, any comments?
Reviewed-by: Keith Packard kei...@keithp.com
Looks good, thanks.
Reviewed-by: Kristian Høgsberg k...@bitplanet.net
___
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo
On Mon, Jan 11, 2010 at 9:35 AM, Gaetan Nadon mems...@videotron.ca wrote:
On Sun, 2010-01-10 at 14:06 -0800, Keith Packard wrote:
On Sun, 10 Jan 2010 16:06:51 -0500, Gaetan Nadon mems...@videotron.ca wrote:
The dmx and scaled text files are generated from sgml files.
The linuxdoc program
On Wed, Nov 18, 2009 at 2:28 PM, Adam Jackson a...@redhat.com wrote:
Signed-off-by: Adam Jackson a...@redhat.com
---
include/pciaccess.h | 14
src/Makefile.am | 1 +
src/common_io.c | 95
src/linux_sysfs.c | 184
2009/11/3 Aaron Plattner aplatt...@nvidia.com:
The following changes since commit 412c56ef3332d09efbd861e41c3e985f44729729:
Maarten Maathuis (1):
exa: remove some outdated comment
are available in the git repository at:
git://people.freedesktop.org/~aplattner/xserver dri2-vdpau
Hi
On Fri, Oct 30, 2009 at 1:42 PM, Eric Anholt e...@anholt.net wrote:
On Fri, 2009-10-30 at 10:59 -0700, Jesse Barnes wrote:
I've put up some trees (after learning my lesson about working in the
main tree) with the latest DRI2 sync/swap bits:
git://git.freedesktop.org/home/jbarnes/xserver
On Thu, Oct 29, 2009 at 5:52 PM, Adam Jackson a...@nwnk.net wrote:
On Thu, 2009-10-29 at 14:01 -0700, keithp wrote:
Excerpts from Adam Jackson's message of Thu Oct 29 11:01:29 -0700 2009:
+ screen-base.GLXmajor = 1;
+ screen-base.GLXminor = 4;
Should this define be in a header
2009/10/26 Aaron Plattner aplatt...@nvidia.com:
On Sat, Oct 24, 2009 at 08:56:11AM -0700, Kristian Høgsberg wrote:
On Fri, Oct 23, 2009 at 8:13 PM, Aaron Plattner aplatt...@nvidia.com wrote:
Hi Keith,
These changes add VDPAU driver name registration support to the X server.
I extended
2009/10/26 Aaron Plattner aplatt...@nvidia.com:
On Mon, Oct 26, 2009 at 10:45:31AM -0700, Kristian Høgsberg wrote:
2009/10/26 Aaron Plattner aplatt...@nvidia.com:
On Sat, Oct 24, 2009 at 08:56:11AM -0700, Kristian Høgsberg wrote:
On Fri, Oct 23, 2009 at 8:13 PM, Aaron Plattner aplatt
Hi Michel,
I spent a good deal of time avoiding using resources in dri2.c since
we should be able to just use pointers directly from aiglx clients.
There should be a simpler way to fix this that doesn't use resources
or clients in dri2.c. Keeping drawable resource tracking out of
dri2.c was a
101 - 162 of 162 matches
Mail list logo
