Hi Keith!
Just saw this patch while I glossed over the input threading patches.
Glad to see them land after all these years! But anyway:
On 05/18/2016 11:03 PM, Keith Packard wrote:
-/* X is very likely to have the wrong idea of what the actual cursor
- * sprite is, so in order to
Well, if they're all whitespace-only like those you linked you're
welcome to make them
Reviewed-by: Simon Thum <simon.t...@gmx.de>
Cheers
Simon
On 04/11/2016 06:42 PM, Peter Harris wrote:
On 2016-04-11 12:32, Simon Thum wrote:
Does anyone know what is the "correct" fix? Ol
Hi all,
my gentoo box is giving me this:
/usr/bin/python3.4
/var/tmp/portage/x11-libs/libxcb-/work/libxcb-/src/c_client.py
-c "libxcb 1.11.90" -l "X Version 11" \
-s "3" -p /dev/null \
\
/usr/share/xcb/xc_misc.xml
File
@@
+Copyright © 2006-2009 Simon Thum
Copyright © 2008-2012 Kristian Høgsberg
Copyright © 2010-2012 Intel Corporation
Copyright © 2010-2011 Benjamin Franzke
diff --git a/src/filter.c b/src/filter.c
index b953bee..626cb0a 100644
--- a/src/filter.c
+++ b/src/filter.c
@@ -1,4 +1,5 @@
/*
+ * Copyright
Hi Peter,
This:
+Bool
+valuator_mask_has_accelerated(const ValuatorMask *mask)
+{
+return mask-has_unacel;
+}
looks quite quirky, in semantics and spelling.
But I have a much larger issue that irritates me. The whole ptraccel
shebang was moved to libinput:
Hi Peter,
finally some time for this ;)
In general I'm fine but I think this duplicates the affine transform
matrix already present. The old limit was chosen to avoid difficulties
that are no longer present with Daniel's double valuators, so it is not
a problem in itself, just a duplication.
Hi all,
I would like to tell another story, perhaps you follow me.
I work on a project with a quite sharp gradient of competence in the
development team. We do use gerrit and a build server which verifies our
patches.
The effect of gerrit - in our case! - is to encourage the less
, 1, SYNAPTICS_PROP_AREA,
32, 3},
+{HorizHysteresis, PT_INT,0, 1,
SYNAPTICS_PROP_NOISE_CANCELLATION, 32,0},
+{VertHysteresis,PT_INT,0, 1,
SYNAPTICS_PROP_NOISE_CANCELLATION, 32,1},
{ NULL, 0, 0, 0, 0 }
};
Reviewed-by: Simon Thum
);
-
scale_to_desktop(pDev,mask,devx,devy,screenx,screeny);
scr = positionSprite(pDev, (flags POINTER_ABSOLUTE) ? Absolute :
Relative,
mask,devx,devy,screenx,screeny);
Reviewed-by: Simon Thum simon.t...@gmx.de
Cheers,
Simon
to be static
...which is exactly what it is (or was).
Reviewed-by: Simon Thum simon.t...@gmx.de
Signed-off-by: Jon TURNEYjon.tur...@dronecode.org.uk
---
dix/ptrveloc.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/dix/ptrveloc.c b/dix/ptrveloc.c
index 7b6f560..977eed6
Hi Peter(s),
the story behind the default noise cancellation is that I chose what
worked well on my system (25) and figured out a reasonable fraction of
the diagonal that approximately gave me that number (0.5%; see
set_default_parameters).
My system refers to an old HW I no longer have in
fix. I just ignored it after figuring the amount of #ifdef's
supposedly required.
Reviewed-by: Simon Thum simon.t...@gmx.de
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/ptrveloc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dix/ptrveloc.c
-off-by: Peter Hutterer peter.hutte...@who-t.net
If only because that initialization path is put to use,
Reviewed-by: Simon Thum simon.t...@gmx.de
---
hw/xfree86/common/xf86Xinput.c | 29 +
hw/xfree86/man/xorg.conf.man | 11 +++
2 files changed, 40
Hi Peter,
I like this patch, but I'd add a check for absolute devices. It's
neither currently possible nor feasible with relative devices.
In any case, it's
Reviewed-by: Simon Thum simon.t...@gmx.de
On 07/06/2011 12:54 AM, Peter Hutterer wrote:
xinput map-to-crtc device name VGA0 will map
Hi Daniel,
there's still mention of pointer or unqualified acceleration in there.
E.g. Synaptics Max Accel is likely to be confused with core
acceleration, esp. as it has this meaning by default : The core
acceleration specifies the maximum pointer acceleration to be applied.
So, more finger
);
-dev-last.remainder[0] = tmpf - (float)tmpi;
+dev-last.remainder[0] = tmpf - (double)tmpi;
}
if (dy) {
I think this really should be if (dx != 0.0). If only to be explicit.
(There are 4 instances of that.)
Otherwise,
Reviewed-by: Simon Thum simon.t
On 06/09/2011 02:14 AM, Peter Hutterer wrote:
On Wed, Jun 08, 2011 at 07:30:52PM +0200, Simon Thum wrote:
(I removed some text)
I think my wiki page has a scenario for high-resolution mice, plus
some users asked for that. Perhaps the man page can be improved.
the problem with pointer
...@collabora.co.uk
Reviewed-by: Daniel Stone dan...@fooishbar.org
Thanks git someone improved that pile'o'junk!
Reviewed-by: Simon Thum simon.t...@gmx.de
(I have a few comments though.)
---
src/synaptics.c | 76
+--
1 files changed, 68
On 06/09/2011 09:57 PM, Daniel Stone wrote:
From: Derek Foreman derek.fore...@collabora.co.uk
Attempt to decrease the possibility of errant motion as much as possible
by adding three new configurable filters, disabled by default:
- Synaptics Max Jerk: maximum change in acceleration
On 06/09/2011 07:17 PM, Daniel Stone wrote:
Switch the ValuatorMask struct to using doubles instead of ints for the
actual values. Preserve the old int API, and (attempt to) round towards
zero for values we return.
It's nice to keep the API, but what about the ABI? AFAIK this changes
the size
(I removed some text)
I think my wiki page has a scenario for high-resolution mice, plus
some users asked for that. Perhaps the man page can be improved.
the problem with pointer acceleration is that the UI to tweak it is is
suboptimal. yes, there's xinput but we don't have a ubiquitous GUI
On 06/03/2011 03:27 AM, Peter Hutterer wrote:
On Thu, Jun 02, 2011 at 03:44:15PM +0200, Simon Thum wrote:
On 05/31/2011 05:57 AM, Peter Hutterer wrote:
The transformation matrix we previously stored was a scaled matrix based on
the axis ranges of the device. For relative movements, the scaling
seems to belong to another patch.
Otherwise, consider this
Reviewed-by: Simon Thum simon.t...@gmx.de
@@ -1185,16 +1188,22 @@ GetPointerEvents(InternalEvent *events, DeviceIntPtr
pDev, int type, int buttons
/* x and y are only set, but not used, by moveAbsolute
On 06/03/2011 04:59 PM, Daniel Stone wrote:
This widens most of ptrveloc.[ch] to double from float: I would have
loved to have done it in smaller chunks, but the code's fairly
intractable, so.
Signed-off-by: Daniel Stone dan...@fooishbar.org
While I don't oppose it, I would like to mention
On 06/03/2011 05:00 PM, Daniel Stone wrote:
For scroll wheel support, we used to send buttons 4/5 and 6/7 for
horizontal/vertical positive/negative scroll events. For touchpads, we
really want more fine-grained scroll values. GetPointerEvents now
accepts both old-school scroll button
On 06/05/2011 01:32 PM, Simon Thum wrote:
First off, you're discarding sub-pixel information that doesn't make it
into the (integer) output. That's wrong by itself, e.g. scaling down
cancels slow motion, you can't really rotate by small angles, etc.
So having seen daniel's patches, this point
On 05/31/2011 05:57 AM, Peter Hutterer wrote:
We passed in the mask, but didn't do anything with it. Move the logic to
take the axes out of the valuator masks into transformAbsolute.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Simon Thum simon.t...@gmx.de
---
dix
)
valuator_mask_set(mask, 1, y);
}
Reviewed-by: Simon Thum simon.t...@gmx.de
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
On 05/31/2011 05:57 AM, Peter Hutterer wrote:
The transformation matrix we previously stored was a scaled matrix based on
the axis ranges of the device. For relative movements, the scaling is not
required (or desired).
Well, also any non-zero translating component will kill the mouse. That
also
On 05/26/2011 03:33 AM, Peter Hutterer wrote:
On Wed, May 25, 2011 at 04:29:15PM +0200, Diego Elio Pettenò wrote:
Il giorno mer, 25/05/2011 alle 16.20 +0200, Cyril Brulebois ha scritto:
just curious; do you have numbers? ./configure is usually insanely
long, so I'm not sure a few
On 05/26/2011 03:41 AM, Diego Elio Pettenò wrote:
Il giorno gio, 26/05/2011 alle 11.36 +1000, Peter Hutterer ha scritto:
merged thanks. please reply to this patch with your Signed-off-by though
http://wiki.x.org/wiki/Development/Documentation/SubmittingPatches
Sorry I always forget that :/
On 05/27/2011 07:13 AM, Peter Hutterer wrote:
To avoid confusion with a future patch and it better describes what this
does anyway - delivering events to all clients that have the event mask on
the window.
I find the name a tiny bit off - the window mask doesn't get anything
delivered, does it?
On 05/12/2011 01:57 AM, Peter Hutterer wrote:
On Wed, May 11, 2011 at 09:16:15PM +0200, Simon Thum wrote:
On 05/11/2011 06:59 AM, Peter Hutterer wrote:
The current raw event behaviour is pretty useless. RawEvents are sent to all
root windows but only if the device is not grabbed. Clients
On 05/11/2011 06:59 AM, Peter Hutterer wrote:
The current raw event behaviour is pretty useless. RawEvents are sent to all
root windows but only if the device is not grabbed. Clients that need to
monitor devices can only do so by grabbing the device - rendering it
unusable to other clients.
On 05/05/2011 01:14 AM, Peter Hutterer wrote:
Static analysis claims that ptr += size may assign garbage. But since the
protocol requires format to be 8, 16 or 32, size should always have a valid
value. Initialize to 0 to shut up clang.
Perhaps it would be preferable to have something like:
On 05/03/2011 03:00 AM, Peter Hutterer wrote:
Some more documentation would have helped, I found it hard to get the big
picture in my head even with the wiki page. There are too many details that
weren't clear immediately and having what's in your brain about the accel
methods backed up
Hi Ian,
you seem not to be used to mailing lists. You should cc all the people
you want to read this mail, i.e. normally everyone already in to or cc
[0]. People read their email, but not the list archive. I did that as I
was interested in the progress on this issue.
I'm just stepping in since
On 04/20/2011 10:21 AM, Daniel Stone wrote:
Hi,
On Wed, Apr 20, 2011 at 04:28:29PM +1000, Peter Hutterer wrote:
index 0741604..4901d6a 100644
--- a/dix/ptrveloc.c
+++ b/dix/ptrveloc.c
@@ -1122,7 +1122,6 @@ acceleratePointerPredictable(
ValuatorMask* val,
CARD32 evtime)
{
-
4+8+16;
Reviewed-by: Simon Thum simon.t...@gmx.de
Cheers,
Simon
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
,
vel-velocity, threshold, acc);
DebugAccelF((dix ptracc) profile sample [%.2f] is %.3f\n,
vel-velocity, res);
- return res;
}
+
+return res;
}
Reviewed-by: Simon Thum simon.t...@gmx.de
Cheers,
Simon
*/
float iveloc = 0, res = 0, tmp, vdiff;
float vfac = vel-corr_mul * vel-const_acceleration; /* premultiply */
Reviewed-by: Simon Thum simon.t...@gmx.de
That's a big improvement in readability.
Cheers,
Simon
___
xorg-devel@lists.x.org: X.Org
On 04/20/2011 08:28 AM, Peter Hutterer wrote:
The two directions returned by this calculation are always the two boundary
conditions. Since we don't do quadrants but octants, the flagged ones are
45°, not 90°. e.g. an angle of 35° flags E and NE.
Yes, so 2 flagged directions cover an angle of
-by: Simon Thum simon.t...@gmx.de
You seem to have recovered the reasoning quite nicely, there's nothing I
could add.
Cheers,
Simon
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman
];
Reviewed-by: Simon Thum simon.t...@gmx.de
Since high-precision (i.e. high-dx/dy) devices become more common, you
might want to increase the range to avoid those atan2()s, or shift back
into range. Precision isn't paramount here.
Cheers,
Simon
___
xorg
;
}
#define DIRECTION_CACHE_RANGE 5
Reviewed-by: Simon Thum simon.t...@gmx.de
Although I don't see any specific improvement.
Cheers,
Simon
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org
;
if ((iveloc == 0 || offset = vel-initial_range) tmp != 0) {
/* set initial velocity and result */
Much better.
Reviewed-by: Simon Thum simon.t...@gmx.de
Cheers,
Simon
___
xorg-devel@lists.x.org: X.Org development
Archives: http
, tracker-dy, cur_t -
tracker-time);
#endif
}
-return res;
+return result;
}
#undef TRACKER_INDEX
Reviewed-by: Simon Thum simon.t...@gmx.de
Cheers,
Simon
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org
];
/* Since it may not be apparent: lrintf() does not offer
Other than that,
Reviewed-by: Simon Thum simon.t...@gmx.de
Cheers,
Simon
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman
) profile sample [%.2f] is %.3f\n,
vel-velocity, res);
}
-return res;
+return result;
}
Hey, this was saving 27 bytes...!
Reviewed-by: Simon Thum simon.t...@gmx.de
Cheers,
Simon
___
xorg-devel@lists.x.org: X.Org
] = tmp - (float)tmpi;
}
if (dy) {
+float tmp;
tmp = mult * fdy + dev-last.remainder[1];
tmpi = lrintf(tmp);
valuator_mask_set(val, 1, tmpi);
Reviewed-by: Simon Thum simon.t
) soften);
+ApplyConstantDeceleration(velocitydata, fdx, fdy);
/* Calculate the new delta (with accel) and drop it back
* into the valuator masks */
Reviewed-by: Simon Thum simon.t...@gmx.de
for the rest of the series [16-18] as well.
Cheers
Hi Orhan,
please answer to all, makes life easier for everyone. I just saw that
mail by incident.
On 03/29/2011 04:41 PM, Orhan Kavrakoglu wrote:
On 03/29/2011 02:56 PM, Simon Thum wrote:
It's technically correct, and I welcome people to patch it into distros,
but for master I'd prefer
On 04/04/2011 07:54 PM, Tiago Vignatti wrote:
It will fix two possible cases of use after free in RemoveDevice.
Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com
---
dix/devices.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/dix/devices.c b/dix/devices.c
On 04/05/2011 01:27 PM, Tiago Vignatti wrote:
On 04/05/2011 03:14 PM, ext Simon Thum wrote:
On 04/04/2011 07:54 PM, Tiago Vignatti wrote:
It will fix two possible cases of use after free in RemoveDevice.
Signed-off-by: Tiago Vignattitiago.vigna...@nokia.com
---
dix/devices.c |1 +
1
event system.
Yeah, X isn't there yet. Note however that the approach could be scaled
up to what you describe. Does your research or implementation focus X?
Cheers,
Simon
--
Timothy Meade
tmzt on freenode
On Apr 5, 2011 7:08 AM, Simon Thum simon.t...@gmx.de wrote:
Hi Orhan,
please answer
On 04/05/2011 02:46 PM, Tiago Vignatti wrote:
On 04/05/2011 03:54 PM, ext Simon Thum wrote:
On 04/05/2011 01:27 PM, Tiago Vignatti wrote:
On 04/05/2011 03:14 PM, ext Simon Thum wrote:
On 04/04/2011 07:54 PM, Tiago Vignatti wrote:
It will fix two possible cases of use after free
On 04/05/2011 02:41 PM, Daniel Stone wrote:
Hi,
On Tue, Apr 05, 2011 at 02:07:33PM +0200, Simon Thum wrote:
Well, it's an RFC by Peter at the moment, AFAIK not much to read. I'll
add a bit to my idea FYC. The concept would probably use pixman and
list.h-lists and look something like:
So
==
Absolute)
valuators[j] = dev-valuator-axisVal[xv-first_valuator +
j];
+else
+valuators[j] = 0;
}
if (i + 6 num_valuators)
Seems sane.
Reviewed-by: Simon Thum simon.t...@gmx.de
Cheers,
Simon
On 03/29/2011 03:39 AM, Peter Hutterer wrote:
On Mon, Mar 28, 2011 at 04:04:48PM -0400, Chase Douglas wrote:
This allows for masked valuators to be handled properly in XI 1.x
events. Any unset valuators in the device event are set to the last
known value when transmitted on the wire through XI
Hi Orhan,
I don't have much problems with the patch as-is, except that a
corresponding xorg.conf man page entry should be added.
The bigger problem is that I don't even like to have
ConstantDeceleration within the accel code, so adding scaling as a flat
profile is making the mess worse.
What
On 03/23/2011 06:13 AM, Peter Hutterer wrote:
Having rotation support has been a feature requested for a while
now. Now we've had two independent implementations happen within quite a
short timeframe, one in synaptics, one in evdev (and wacom has had it's own
implementation for a while). So
Hi Aapo,
On 03/21/2011 12:51 PM, Aapo Rantalainen wrote:
What is then common for wacom/synaptics/others? Is there a point to
tune this synaptics-patch or is this doable on server level? (Or some
other better way?)
definitively. You could implement matrix rotation for relative devices.
The
The function names refer to different device classes which, in fact, are all
implmented using the
same device class.
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info:
Since the mode of valuators (no longer?) bears a relation to the device class
actually initialized, this naming was quite misleading.
Signed-off-by: Simon Thum simon.t...@gmx.de
---
src/evdev.c | 28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git
I made an attempt to remove the absolute device class from the server. It was,
to the best of my knowledge,
unused and quite misleading since all is there except for real useage. The
actual removal (patch 5+6)
is split up so the API is kept (more or less) for the benefit of out-of-tree
drivers.
Signed-off-by: Simon Thum simon.t...@gmx.de
---
hw/xquartz/darwinXinput.c | 12 +---
1 files changed, 1 insertions(+), 11 deletions(-)
diff --git a/hw/xquartz/darwinXinput.c b/hw/xquartz/darwinXinput.c
index 8bb83ca..3ef34fe 100644
--- a/hw/xquartz/darwinXinput.c
+++ b/hw/xquartz
] simplify ChangeDeviceControl in stubs
[PATCH 5/6] xserver: remove AbsoluteClassRec keeping the ABI
[PATCH 6/6] xserver: remove AbsoluteClass, breaking the A(P|B)I
From 47b0698fe40d283bc2a97b25d8ce2cdbd4d8d27d Mon Sep 17 00:00:00 2001
From: Simon Thum simon.t...@gmx.de
Date: Sat, 5 Mar 2011 04:58:30
On 03/15/2011 04:43 PM, Keith Packard wrote:
On Tue, 15 Mar 2011 11:05:07 -0400, Adam Jackson a...@redhat.com wrote:
xf86RandR12.c: In function 'xf86RandR12EnterVT':
xf86RandR12.c:1769:5: warning: ISO C90 forbids mixed declarations and
code
True, but I was using the construct as well, based
On 03/01/2011 03:12 AM, Peter Hutterer wrote:
On Tue, Mar 01, 2011 at 09:40:38AM +0800, Daniel Kurtz wrote:
Honestly, the purpose of this timer baffles me a bit. AFAICT, it should
never fire.
note that this timer has been present for years now while large parts of the
driver evolved around
On 02/28/2011 06:32 PM, Adam Jackson wrote:
Nobody can have been using this, it's never called from extension init.
XI2 device properties should now be a functional replacement.
While at it, there's also the AbsoluteClassRec, complete with device
controls and all, sitting around doing nothing
On 02/28/2011 01:56 PM, Daniel Kurtz wrote:
Some Synaptics image sensors report samples at less than 80 Samples/sec.
Thus, the inter-sample gap is longer than 13 ms (more like 17-25 ms).
With a 13ms timeout, every sample was processed twice:
1) Once when ReadHwState() returned valid data.
On 02/15/2011 12:27 PM, Daniel Stone wrote:
When delivering an event to a device grabbed with SyncBoth,
DeliverGrabbedEvent walks the device tree looking for associated devices
to freeze them. Unfortunately, it froze all devices instead of just the
paired device, and the previous fix in
2001
From: Simon Thum simon.t...@gmx.de
Date: Sun, 6 Feb 2011 17:57:17 +0100
Subject: [PATCH] Add hysteresis-based noise reduction
This introduces hysteresis into the driver's processing. It significantly
reduces noise motion, i.e. now the pad does no longer generate a stream of
sub-pixel events
not marking as used. This lets drivers
check option syntax more flexibly without scaring users.
Cheers,
Simon
From a0261fb459f9715c075bc479ba841968ef199450 Mon Sep 17 00:00:00 2001
From: Simon Thum simon.t...@gmx.de
Date: Sun, 6 Feb 2011 19:07:19 +0100
Subject: [PATCH 1/2] fix percent options parsing
On 02/08/2011 01:23 AM, Peter Hutterer wrote:
On Mon, Feb 07, 2011 at 11:32:27PM +0100, Simon Thum wrote:
This introduces hysteresis into the driver's processing. It significantly
reduces noise motion, i.e. now the pad does no longer generate a stream of
sub-pixel events when just holding
This allows to specify e.g. 0.5% without rounding to zero.
Signed-off-by: Simon Thum simon.t...@gmx.de
---
All other percent-related functions return double already.
hw/xfree86/common/xf86Option.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xfree86/common
This allows set_percent_option() in synaptics to work as described, i.e.
without an irritating warning.
Signed-off-by: Simon Thum simon.t...@gmx.de
---
Possibly, the other cases should be aligned as well?
hw/xfree86/common/xf86Option.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions
becomes flicker-free etc.
Signed-off-by: Simon Thum simon.t...@gmx.de
---
What's missing is a complementing property, if the patch is acceptable
otherwiese I'm willing to add it.
man/synaptics.man |9 +++
src/synaptics.c| 62
++-
src
moving the handler registration upwards should fix it.
Cheers,
Simon
From b1fe1b9b727f2018ced6e90f7f6e492c20069703 Mon Sep 17 00:00:00 2001
From: Simon Thum simon.t...@gmx.de
Date: Sat, 4 Sep 2010 16:31:24 +0200
Subject: [PATCH 1/4] dix: refactor scheme init
Signed-off-by: Simon Thum simon.t...@gmx.de
On 01/07/2011 12:53 AM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Xi/xiwarppointer.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Xi/xiwarppointer.c b/Xi/xiwarppointer.c
index 7276e6f..c01b115 100644
---
On 12/20/2010 08:28 AM, Peter Hutterer wrote:
On Sun, Dec 19, 2010 at 05:04:51PM +0100, Alberto Milone wrote:
@@ -1754,7 +1754,8 @@ ComputeDeltas(SynapticsPrivate *priv, const struct
SynapticsHwState *hw,
if (inside_area moving_state !priv-palm
!priv-vert_scroll_edge_on
On 12/17/2010 07:32 AM, Alan Coopersmith wrote:
https://bugs.freedesktop.org/show_bug.cgi?id=32436
Fix typo introduced in 2416255f7e3fd9190a9 that breaks builds when
configured --enable-install-libxf86config
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Tested-by: Simon Thum
On 12/15/2010 08:15 PM, Aaron Plattner wrote:
$ gcc test.c
test.c: In function ‘main’:
test.c:11: warning: initialization from incompatible pointer type
$ ./a.out
x
$ gcc -O2 test.c
test.c: In function ‘main’:
test.c:11: warning: initialization from incompatible pointer type
$ ./a.out
a
On 12/16/2010 10:09 PM, Alan Coopersmith wrote:
Simon Thum wrote:
Hi List,
on my gentoo box I have a server build which fails (using the live xorg
ebuilds). The ebuild invokes:
./configure (lots) --enable-install-libxf86config (lots more)
My (separate) dev builds didn't fail. So I applied
On 12/16/2010 10:49 PM, Alan Coopersmith wrote:
Simon Thum wrote:
On 12/16/2010 10:09 PM, Alan Coopersmith wrote:
Simon Thum wrote:
Hi List,
on my gentoo box I have a server build which fails (using the live xorg
ebuilds). The ebuild invokes:
./configure (lots) --enable-install
On 12/14/2010 02:22 AM, Alan Coopersmith wrote:
Callers who had successfully built without issues with the existing
libX11 headers were suddenly either given warnings or errors (-Werror)
with the new headers.
I've stumbled into this and I'd really appreciate if someone could clarify.
AFAIK
On 12/14/2010 10:01 PM, Alan Coopersmith wrote:
Unfortunately, this was a surprise to me, since I was expecting it to
behave as const char * does when passed char * pointers, as apparently
did everyone on xorg-devel when the patch went by.
Another myth debunked: applying const gets you
On 12/13/2010 03:24 PM, Dan Nicholson wrote:
On Sun, Dec 12, 2010 at 7:20 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
After collecting the driver's default options, report the list of options
set for the device before calling PreInit(). This helps with debugging those
cases where
such as XkbLayout in the
case of evdev.
I guess you got it, but I can't test it due to build problems. However,
consider this
Revieved-by: Simon Thum simon.t...@gmx.de
Cheers,
Simon
Reported-by: Sebastian Glita gls...@yahoo.com
Reported-by: Simon Thum simon.t...@gmx.de
Signed-off-by: Peter Hutterer
On 12/05/2010 11:22 PM, Keith Packard wrote:
This provides a driver hook which can either completely replace, or
just validate the parameters for, the RRSetCrtcConfigs request.
It makes a lot of sense and contains an equal lot of whitespace changes ;)
Otherwise, feel free to assume my r-b.
On 12/04/2010 10:41 AM, Alan Coopersmith wrote:
+++ b/COPYING
@@ -19,7 +19,7 @@ Copyright © 1999 Keith Packard
Copyright © 2007-2009 Red Hat, Inc.
Copyright © 2005-2008 Daniel Stone
Copyright © 2006-2009 Simon Thum
-Copyright © 1987, 2003-2006, 2008-2009 Sun Microsystems, Inc.
+Copyright
Hi Peter,
the patch makes sense and should probably be applied. It just doesn't
work for me, i.e. acceleration is off. I'm unsure why, perhaps it's an
unrelated problem. So if it doesn't break your stuff, please apply.
On 11/19/2010 02:09 AM, Peter Hutterer wrote:
From: Simon Thum simon.t
On 11/17/10 22:26, Max Schwarz wrote:
I would propose specific methods for changing the resolution, axes ranges,
etc., and one final call to send out events.
Sounds fine.
Simon
___
xorg-devel@lists.x.org: X.Org development
Archives:
On 11/14/10 22:52, Peter Hutterer wrote:
On Sun, Nov 14, 2010 at 06:51:43PM +0100, Max Schwarz wrote:
Are the drivers allowed to access the valuator structure
(e.g. dev-valuator-axis[0].resolution = XY) or should I implement
wrapper functions in the server to do that?
It depends on whether
On 11/09/10 06:07, Peter Hutterer wrote:
I don't understand the no_integration stuff. aside from it being a bit of a
misnomer, I'm missing the point of what is supposed to do. if the axis is in
relative mode, you can go past the axis ranges anyway. In absolute mode,
well, are wheels ever in
On 11/08/10 22:55, Max Schwarz wrote:
Hi Simon,
That sounds fine. But how are button events being generated which match
a potential only-smooth-scrolling input?
I'm not sure I understand your question. I didn't change the generation of
button events in any way. They are just emitted in
On 11/07/10 18:03, Max Schwarz wrote:
Hi Simon,
A thing I'm
missing is how you're establishing the relationship of smooth and button
scrolling? It might just be me since I'm only looking at the diffs.
It's certainly subtle ;-)
Look at EvdevProcessRelativeMotionEvent().
In case of a change
On 11/06/10 23:03, Manuel Reimer wrote:
What I'm not happy about is the fact, that there are two configuration
options (CURSOR and MODE). They IMHO do nearly the same.
CURSOR on stylus -- absolute
CURSOR on puck -- relative
MODE on absolute -- absolute
MODE on relative -- relative
One
On 11/02/10 08:45, Peter Hutterer wrote:
On 2/11/10 17:41 , Peter Korsgaard wrote:
PH == Peter Huttererpeter.hutte...@who-t.net writes:
Hi,
PH right, that's the easy part. right now the property isn't hooked
up for
PH relative devices, so afaict that needs to be the first step. A
quick
On 11/07/10 14:56, Max Schwarz wrote:
Hi,
I finally found some time for smooth scrolling.
Great news, thanks for your efforts!
I've got rebased patches against git versions for
xserver, xf86-input-evdev, xf86-input-synaptics
in my github repo at https://github.com/x-quadraht/pscroll.
1 - 100 of 187 matches
Mail list logo
