Re: [PATCH 1/2] list.h: Fix list_for_each_entry_safe()

2010-06-20 Thread Kristian Høgsberg
On Fri, Jun 18, 2010 at 5:43 PM, Dan Nicholson dbn.li...@gmail.com wrote: On Fri, Jun 18, 2010 at 2:34 PM, Keith Packard kei...@keithp.com wrote: On Mon, 14 Jun 2010 09:25:22 -0400, Kristian Høgsberg k...@bitplanet.net wrote: -      pos = next, next = __container_of(next-member.next, next,

Re: [PATCH 1/2] list.h: Fix list_for_each_entry_safe()

2010-06-18 Thread Keith Packard
On Mon, 14 Jun 2010 09:25:22 -0400, Kristian Høgsberg k...@bitplanet.net wrote: - pos = next, next = __container_of(next-member.next, next, member)) + pos = tmp, tmp = __container_of(pos-member.next, tmp, member)) Any reason this uses a ',' instead of a ';'? Otherwise,

Re: [PATCH 1/2] list.h: Fix list_for_each_entry_safe()

2010-06-18 Thread Dan Nicholson
On Fri, Jun 18, 2010 at 2:34 PM, Keith Packard kei...@keithp.com wrote: On Mon, 14 Jun 2010 09:25:22 -0400, Kristian Høgsberg k...@bitplanet.net wrote: -      pos = next, next = __container_of(next-member.next, next, member)) +      pos = tmp, tmp = __container_of(pos-member.next, tmp,

[PATCH 1/2] list.h: Fix list_for_each_entry_safe()

2010-06-14 Thread Kristian Høgsberg
Can't use next as a macro argument since we're accessing the .next field of struct list. --- include/list.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/list.h b/include/list.h index 89dc29d..4ce20a8 100644 --- a/include/list.h +++ b/include/list.h @@

Re: [PATCH 1/2] list.h: Fix list_for_each_entry_safe()

2010-06-14 Thread Tiago Vignatti
On Mon, Jun 14, 2010 at 03:25:22PM +0200, ext Kristian H�gsberg wrote: Can't use next as a macro argument since we're accessing the .next field of struct list. --- include/list.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/list.h b/include/list.h

Re: [PATCH 1/2] list.h: Fix list_for_each_entry_safe()

2010-06-14 Thread Kristian Høgsberg
On Mon, Jun 14, 2010 at 10:52 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: On Mon, Jun 14, 2010 at 03:25:22PM +0200, ext Kristian H�gsberg wrote: Can't use next as a macro argument since we're accessing the .next field of struct list. ---  include/list.h |    6 +++---  1 files changed,