Re: [PATCH 14/15] xkb: Use memcpy for copy

2010-07-28 Thread Mark Kettenis
Date: Wed, 28 Jul 2010 09:25:10 +1000 From: Peter Hutterer peter.hutte...@who-t.net On Tue, Jul 27, 2010 at 03:09:55PM +0300, Pauli Nieminen wrote: Source and destination have well defined size so use memcpy instead of strncpy. strncpy tryes to add NULL to end of destination but it is not

Re: [PATCH 14/15] xkb: Use memcpy for copy

2010-07-28 Thread Pauli Nieminen
On 28/07/10 11:48 +0200, ext Mark Kettenis wrote: Date: Wed, 28 Jul 2010 09:25:10 +1000 From: Peter Hutterer peter.hutte...@who-t.net On Tue, Jul 27, 2010 at 03:09:55PM +0300, Pauli Nieminen wrote: Source and destination have well defined size so use memcpy instead of strncpy.

Re: [PATCH 14/15] xkb: Use memcpy for copy

2010-07-28 Thread Daniel Stone
On Wed, Jul 28, 2010 at 02:11:05PM +0300, Pauli Nieminen wrote: On Tue, Jul 27, 2010 at 03:09:55PM +0300, Pauli Nieminen wrote: Source and destination have well defined size so use memcpy instead of strncpy. strncpy tryes to add NULL to end of destination but it is not

Re: [PATCH 14/15] xkb: Use memcpy for copy

2010-07-28 Thread Kristian Høgsberg
On Wed, Jul 28, 2010 at 7:26 AM, Daniel Stone dan...@fooishbar.org wrote: On Wed, Jul 28, 2010 at 02:11:05PM +0300, Pauli Nieminen wrote: On Tue, Jul 27, 2010 at 03:09:55PM +0300, Pauli Nieminen wrote: Source and destination have well defined size so use memcpy instead of strncpy.

Re: [PATCH 14/15] xkb: Use memcpy for copy

2010-07-28 Thread Peter Hutterer
On Wed, Jul 28, 2010 at 02:11:05PM +0300, Pauli Nieminen wrote: On 28/07/10 11:48 +0200, ext Mark Kettenis wrote: Date: Wed, 28 Jul 2010 09:25:10 +1000 From: Peter Hutterer peter.hutte...@who-t.net On Tue, Jul 27, 2010 at 03:09:55PM +0300, Pauli Nieminen wrote: Source and

[PATCH 14/15] xkb: Use memcpy for copy

2010-07-27 Thread Pauli Nieminen
Source and destination have well defined size so use memcpy instead of strncpy. strncpy tryes to add NULL to end of destination but it is not possible if source doesn't have NULL. Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com --- xkb/XKBGAlloc.c |4 ++-- 1 files changed, 2