[PATCH 2/2] xfixes: Use list.h macros in tracking hide count

2010-06-14 Thread Kristian Høgsberg
--- This is not a patch to be applied. Recently, the utility of list.h was questioned and as I came a across the cursor hide count code today I figured it would make a good example of how list.h can make the code significantly simpler. In particular, it's easy to prepend and iterate though a

Re: [PATCH 2/2] xfixes: Use list.h macros in tracking hide count

2010-06-14 Thread Tiago Vignatti
On Mon, Jun 14, 2010 at 03:25:23PM +0200, ext Kristian H�gsberg wrote: This is not a patch to be applied. why not?! :) Tiago ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: [PATCH 2/2] xfixes: Use list.h macros in tracking hide count

2010-06-14 Thread Kristian Høgsberg
On Mon, Jun 14, 2010 at 10:56 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: On Mon, Jun 14, 2010 at 03:25:23PM +0200, ext Kristian H�gsberg wrote: This is not a patch to be applied. why not?! :) Oh, I mentioned this in my first attempt to send out these patches (which git send-mail

Re: [PATCH 2/2] xfixes: Use list.h macros in tracking hide count

2010-06-14 Thread Kristian Høgsberg
2010/6/14 Vignatti Tiago (Nokia-D/Helsinki) tiago.vigna...@nokia.com: On Mon, Jun 14, 2010 at 05:24:16PM +0200, ext Kristian Høgsberg wrote:  I don't think it makes sense to go through the server and replace existing linked list code.  That code is already written and tested, and replacing it

Re: [PATCH 2/2] xfixes: Use list.h macros in tracking hide count

2010-06-14 Thread Vignatti Tiago (Nokia-D/Helsinki)
On Mon, Jun 14, 2010 at 05:48:54PM +0200, ext Kristian Høgsberg wrote: 2010/6/14 Vignatti Tiago (Nokia-D/Helsinki) tiago.vigna...@nokia.com: I think open coded list implementation everywhere is more error prone than just have one single set of basic macros. Isn't it? All the open coded

Re: [PATCH 2/2] xfixes: Use list.h macros in tracking hide count

2010-06-14 Thread Mikhail Gusarov
Twas brillig at 19:16:46 14.06.2010 UTC+03 when tiago.vigna...@nokia.com did gyre and gimble: All the open coded lists in ther server are there now, and they're working. If it's not broken, don't mess with it. If you come across an error in an open coded list implementation, that would