[PATCH evdev v2] type-safe inline functions for bitmask manipulation

2011-10-17 Thread Max Schwarz
We can't use BitIsSet/SetBit from the server (inputstr.h) since they operate on byte arrays. EvdevSetBit is added in preparation for the smooth-scrolling on wheel emulation patch. Signed-off-by: Max Schwarz m...@x-quadraht.de --- sorry, forgot to actually make EvdevBitIsSet/EvdevSetBit inline...

Re: [PATCH evdev v2] type-safe inline functions for bitmask manipulation

2011-10-17 Thread Jeremy Huddleston
Looks to me like you want those to be declared 'static inline' Why not have EvdevBitIsSet and EvdevSetBit use BitIsSet/SetBit with endianness-fu? On Oct 17, 2011, at 11:34 AM, Max Schwarz wrote: We can't use BitIsSet/SetBit from the server (inputstr.h) since they operate on byte arrays.

Re: [PATCH evdev v2] type-safe inline functions for bitmask manipulation

2011-10-17 Thread Max Schwarz
Why not have EvdevBitIsSet and EvdevSetBit use BitIsSet/SetBit with endianness-fu? What would you gain from that? I think my implementation is simple and straight, endianness-fu isn't going to make it nicer... Max ___ xorg-devel@lists.x.org: X.Org