Re: [PATCH libXrandr] Avoid out of boundary accesses on illegal responses

2017-01-28 Thread Julien Cristau
On Sat, Jan 7, 2017 at 19:15:42 +0100, Tobias Stoeckmann wrote: > Hi Julien, > > On Sat, Jan 07, 2017 at 07:03:17PM +0100, Julien Cristau wrote: > > It looks like we're leaking 'attr' on these error paths? > > confirmed. That is what I get for copying the error handling of the > attr == NULL

Re: [PATCH libXrandr] Avoid out of boundary accesses on illegal responses

2017-01-07 Thread Tobias Stoeckmann
Hi Julien, On Sat, Jan 07, 2017 at 07:03:17PM +0100, Julien Cristau wrote: > It looks like we're leaking 'attr' on these error paths? confirmed. That is what I get for copying the error handling of the attr == NULL case... diff --git a/src/XrrCrtc.c b/src/XrrCrtc.c index 6665092..8316b78

Re: [PATCH libXrandr] Avoid out of boundary accesses on illegal responses

2017-01-07 Thread Julien Cristau
[resending with xorg-devel cc added which I forgot the first time around] On Sun, Sep 25, 2016 at 22:50:44 +0200, Matthieu Herrb wrote: > diff --git a/src/XrrCrtc.c b/src/XrrCrtc.c > index 5ae35c5..6665092 100644 > --- a/src/XrrCrtc.c > +++ b/src/XrrCrtc.c [...] > @@ -357,7 +378,7 @@