On Wed, 2018-03-21 at 09:02 -0600, Keith Packard wrote:
> Julien Cristau writes:
>
> > Doesn't this break when e.g. client supports 2.2 and server supports
> > 1.4, where we'll return 2.2 instead of 1.4? i.e. it seems to me this
> > should be
> >
> > if (rep.majorVersion >
On 21 March 2018 at 08:02, Julien Cristau wrote:
> On Mon, Mar 19, 2018 at 16:04:43 +, Emil Velikov wrote:
>
>> From: Emil Velikov
>>
>> As per the protocol, the server should not return version greater than
>> the one supported by the client.
Julien Cristau writes:
> Doesn't this break when e.g. client supports 2.2 and server supports
> 1.4, where we'll return 2.2 instead of 1.4? i.e. it seems to me this
> should be
>
> if (rep.majorVersion > stuff->majorVersion ||
> (rep.majorVersion == stuff->majorVersion
On Mon, Mar 19, 2018 at 16:04:43 +, Emil Velikov wrote:
> From: Emil Velikov
>
> As per the protocol, the server should not return version greater than
> the one supported by the client.
>
> Add a spec quote and tweak the numbers accordingly.
>
> Fixes:
On Mon, 2018-03-19 at 16:04 +, Emil Velikov wrote:
> From: Emil Velikov
>
> As per the protocol, the server should not return version greater than
> the one supported by the client.
>
> Add a spec quote and tweak the numbers accordingly.
>
> Fixes: 5c5c1b77982
> Emil Velikov hat am 19. März 2018 um 17:04
> geschrieben:
>
>
> From: Emil Velikov
>
> As per the protocol, the server should not return version greater than
> the one supported by the client.
>
> Add a spec quote and tweak the
From: Emil Velikov
As per the protocol, the server should not return version greater than
the one supported by the client.
Add a spec quote and tweak the numbers accordingly.
Fixes: 5c5c1b77982 ("present: Add Present extension")
Cc: Thierry Reding