Re: [PATCH xserver] xkb: add a cause to the xkb indicator update after a keymap change

2016-06-29 Thread Daniel Stone
On 28 June 2016 at 11:48, Peter Hutterer wrote: > Regression introduce by ac164e58870d which calls > XkbUpdateAllDeviceIndicators() with two NULL arguments. A few layers down into > the stack and we triggered a NULL-pointer dereference. In theory a NULL cause > is

Re: [PATCH xserver] xkb: add a cause to the xkb indicator update after a keymap change

2016-06-28 Thread Julien Cristau
On Tue, Jun 28, 2016 at 11:48:58 +1000, Peter Hutterer wrote: > Regression introduce by ac164e58870d which calls > XkbUpdateAllDeviceIndicators() with two NULL arguments. A few layers down into > the stack and we triggered a NULL-pointer dereference. In theory a NULL cause > is acceptable since

[PATCH xserver] xkb: add a cause to the xkb indicator update after a keymap change

2016-06-27 Thread Peter Hutterer
Regression introduce by ac164e58870d which calls XkbUpdateAllDeviceIndicators() with two NULL arguments. A few layers down into the stack and we triggered a NULL-pointer dereference. In theory a NULL cause is acceptable since we don't actually change modifier state here. Instead of updating all