Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-30 Thread Michel Dänzer
On Sam, 2012-07-28 at 10:28 -0700, Jeremy Huddleston Sequoia wrote: On Jul 28, 2012, at 10:05, Julien Cristau jcris...@debian.org wrote: On Sat, Jul 28, 2012 at 09:58:46 -0700, Jeremy Huddleston Sequoia wrote: Ok, so then what do we do about this? Is it really important enough to

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-30 Thread Jeremy Huddleston Sequoia
On Jul 30, 2012, at 07:03, Michel Dänzer mic...@daenzer.net wrote: I agree that it's very unlikely that anyone would mix libglx.so and libdri2.so between versions, and yes of course making the symbol not exported would cause libglx.so to not be able to use it. And you do realize the fix

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-30 Thread Michel Dänzer
On Mon, 2012-07-30 at 09:04 -0700, Jeremy Huddleston Sequoia wrote: On Jul 30, 2012, at 07:03, Michel Dänzer mic...@daenzer.net wrote: That will get us into a situation where some servers advertising the same ABI version have DRI2CreateDrawable2 and some don't. You could bump the ABI

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-30 Thread Jeremy Huddleston Sequoia
On Jul 30, 2012, at 09:15, Michel Dänzer mic...@daenzer.net wrote: On Mon, 2012-07-30 at 09:04 -0700, Jeremy Huddleston Sequoia wrote: Ok. I think that letting DRI destroy the GLX drawable is just all kinds of ugly from the layering perspective. That's not happening. The fix makes GLX

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-30 Thread Michel Dänzer
On Mon, 2012-07-30 at 09:36 -0700, Jeremy Huddleston Sequoia wrote: On Jul 30, 2012, at 09:15, Michel Dänzer mic...@daenzer.net wrote: I think an ABI minor bump would be the safest solution. Would you mind sending me a [PULL]? Sorry, I don't have time for this right now. Ok,

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-28 Thread Julien Cristau
Hi Jeremy, On Mon, Jul 23, 2012 at 21:36:29 -0700, Jeremy Huddleston Sequoia wrote: Sorry, been swamped, but I'll be going through the past 2 months worth of commits to see if anything else is worth bringing in. Any update here? Would it help if I tried to get you a list? (Debian's going

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-28 Thread Jeremy Huddleston Sequoia
On Jul 28, 2012, at 07:50, Julien Cristau jcris...@debian.org wrote: Hi Jeremy, On Mon, Jul 23, 2012 at 21:36:29 -0700, Jeremy Huddleston Sequoia wrote: Sorry, been swamped, but I'll be going through the past 2 months worth of commits to see if anything else is worth bringing in. Any

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-28 Thread Julien Cristau
On Sat, Jul 28, 2012 at 09:58:46 -0700, Jeremy Huddleston Sequoia wrote: Ok, so then what do we do about this? Is it really important enough to break ABI, even considering that 1.13 is just around the corner? I'd think not, but I'm willing to listen to arguments. I'm not sure why you say

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-28 Thread Jeremy Huddleston Sequoia
On Jul 28, 2012, at 10:05, Julien Cristau jcris...@debian.org wrote: On Sat, Jul 28, 2012 at 09:58:46 -0700, Jeremy Huddleston Sequoia wrote: Ok, so then what do we do about this? Is it really important enough to break ABI, even considering that 1.13 is just around the corner? I'd think

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-13 Thread Michel Dänzer
On Don, 2012-07-12 at 15:09 -0700, Keith Packard wrote: Michel Dänzer mic...@daenzer.net writes: [PATCH 1/2] dri2: Add DRI2CreateDrawable2. [PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX Merged. 656e5fe..a2d0829 master - master Thanks! Peter, can you cherry-pick

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-13 Thread Peter Hutterer
On 13/07/12 17:31 , Michel Dänzer wrote: On Don, 2012-07-12 at 15:09 -0700, Keith Packard wrote: Michel Dänzer mic...@daenzer.net writes: [PATCH 1/2] dri2: Add DRI2CreateDrawable2. [PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX Merged. 656e5fe..a2d0829 master - master

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-13 Thread Peter Hutterer
On 13/07/12 17:31 , Michel Dänzer wrote: On Don, 2012-07-12 at 15:09 -0700, Keith Packard wrote: Michel Dänzer mic...@daenzer.net writes: [PATCH 1/2] dri2: Add DRI2CreateDrawable2. [PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX Merged. 656e5fe..a2d0829 master - master

[PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-12 Thread Michel Dänzer
As suggested by Kristian Høgsberg, explicitly call FreeResource for the DRI2 drawable reference. [PATCH 1/2] dri2: Add DRI2CreateDrawable2. [PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-12 Thread Kristian Høgsberg
On Thu, Jul 12, 2012 at 7:16 AM, Michel Dänzer mic...@daenzer.net wrote: As suggested by Kristian Høgsberg, explicitly call FreeResource for the DRI2 drawable reference. [PATCH 1/2] dri2: Add DRI2CreateDrawable2. [PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX Thanks, Michel.

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-12 Thread Keith Packard
Michel Dänzer mic...@daenzer.net writes: [PATCH 1/2] dri2: Add DRI2CreateDrawable2. [PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX Merged. 656e5fe..a2d0829 master - master -- keith.pack...@intel.com pgpvdimyUbuFg.pgp Description: PGP signature