Re: [PATCH xserver 0/9] double frees in AddResource failure paths

2016-03-08 Thread Adam Jackson
On Tue, 2016-03-08 at 00:30 +0100, Rémi Cardona wrote: > Le 07/03/2016 23:20, Julien Cristau a écrit : > > Hi, > > > > prompted by Adam's recent fixes for unchecked AddResource, I've been > > looking at the failure paths, and found a number of places where it > > looks like we're freeing things

Re: [PATCH xserver 0/9] double frees in AddResource failure paths

2016-03-07 Thread Rémi Cardona
Le 07/03/2016 23:20, Julien Cristau a écrit : > Hi, > > prompted by Adam's recent fixes for unchecked AddResource, I've been > looking at the failure paths, and found a number of places where it > looks like we're freeing things twice (once as part of AddResource > itself calling the destroy

[PATCH xserver 0/9] double frees in AddResource failure paths

2016-03-07 Thread Julien Cristau
Hi, prompted by Adam's recent fixes for unchecked AddResource, I've been looking at the failure paths, and found a number of places where it looks like we're freeing things twice (once as part of AddResource itself calling the destroy function for the resource, and once in the caller). Plus more