Re: [PATCH xserver 05/10] test: Add a little xinit-like program for starting servers for testing.

2016-09-24 Thread Eric Anholt
Ray Strode writes: > Hey cool, > > On Friday, September 23, 2016, Eric Anholt wrote: >> >> The normal xinit is racy because it doesn't use -displayfd.  This >> implements the bare minimum for testing purposes, using -displayfd to >> sequence starting the

Re: [PATCH xserver 05/10] test: Add a little xinit-like program for starting servers for testing.

2016-09-23 Thread Ray Strode
Hey cool, On Friday, September 23, 2016, Eric Anholt wrote: > > The normal xinit is racy because it doesn't use -displayfd.  This > implements the bare minimum for testing purposes, using -displayfd to > sequence starting the client, and avoids adding yet another dependency > to

Re: [PATCH xserver 05/10] test: Add a little xinit-like program for starting servers for testing.

2016-09-22 Thread Julien Cristau
On Thu, Sep 22, 2016 at 11:45:06 +0300, Eric Anholt wrote: > +asprintf(_string, "%d", displayfd); > +if (!displayfd_string) > +exit(1); I think you need to check the return value from asprintf, not displayfd_string: When successful, these functions return the number of

[PATCH xserver 05/10] test: Add a little xinit-like program for starting servers for testing.

2016-09-22 Thread Eric Anholt
The normal xinit is racy because it doesn't use -displayfd. This implements the bare minimum for testing purposes, using -displayfd to sequence starting the client, and avoids adding yet another dependency to the server. Signed-off-by: Eric Anholt --- test/.gitignore | 1