Re: [PATCH xserver 1/4] glx: Macroize building the attribute list in DoGetDrawableAttributes

On Thu, 2016-03-10 at 11:45 -0800, Eric Anholt wrote: > > I think some compilers/static checkers will whine unless this is a do { > ... } while (0) macro, becauuse of the "stray" semicolons we end up with > otherwise.  With that changed, > > Reviewed-by: Eric Anholt Did this

Re: [PATCH xserver 1/4] glx: Macroize building the attribute list in DoGetDrawableAttributes

On Thu, Mar 10, 2016 at 13:25:03 -0500, Adam Jackson wrote: > No functional change, just a little easier to read and harder to get > wrong. > > Signed-off-by: Adam Jackson > --- > glx/glxcmds.c | 38 +++--- > 1 file changed, 15 insertions(+), 23

[PATCH xserver 1/4] glx: Macroize building the attribute list in DoGetDrawableAttributes

No functional change, just a little easier to read and harder to get wrong. Signed-off-by: Adam Jackson --- glx/glxcmds.c | 38 +++--- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index